From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Daniel Scally <djrscally@gmail.com>
Cc: yong.zhi@intel.com, sakari.ailus@linux.intel.com,
bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org,
gregkh@linuxfoundation.org, davem@davemloft.net, robh@kernel.org,
devel@driverdev.osuosl.org, jorhand@linux.microsoft.com,
kieran.bingham@ideasonboard.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, kitakar@gmail.com
Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms
Date: Thu, 17 Sep 2020 03:19:21 -0700 [thread overview]
Message-ID: <8274e9166ad6f7c95f0885403b9584081672a3ff.camel@perches.com> (raw)
In-Reply-To: <20200917093407.GK4282@kadam>
On Thu, 2020-09-17 at 12:34 +0300, Dan Carpenter wrote:
> On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote:
> > diff --git a/drivers/staging/media/ipu3/cio2-bridge.c b/drivers/staging/media/ipu3/cio2-bridge.c
[]
> > + if (!dev->driver_data) {
> > + pr_info("ACPI match for %s, but it has no driver\n",
> > + supported_devices[i]);
>
> put_device(dev);
>
> > + continue;
> > + } else {
No need for an else either.
> > + pr_info("Found supported device %s\n",
> > + supported_devices[i]);
so this can be unindented too.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Daniel Scally <djrscally@gmail.com>
Cc: devel@driverdev.osuosl.org, robh@kernel.org,
jorhand@linux.microsoft.com, linux-media@vger.kernel.org,
gregkh@linuxfoundation.org, kieran.bingham@ideasonboard.com,
linux-kernel@vger.kernel.org, kitakar@gmail.com,
sakari.ailus@linux.intel.com, bingbu.cao@intel.com,
mchehab@kernel.org, davem@davemloft.net, tian.shu.qiu@intel.com,
yong.zhi@intel.com
Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms
Date: Thu, 17 Sep 2020 03:19:21 -0700 [thread overview]
Message-ID: <8274e9166ad6f7c95f0885403b9584081672a3ff.camel@perches.com> (raw)
In-Reply-To: <20200917093407.GK4282@kadam>
On Thu, 2020-09-17 at 12:34 +0300, Dan Carpenter wrote:
> On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote:
> > diff --git a/drivers/staging/media/ipu3/cio2-bridge.c b/drivers/staging/media/ipu3/cio2-bridge.c
[]
> > + if (!dev->driver_data) {
> > + pr_info("ACPI match for %s, but it has no driver\n",
> > + supported_devices[i]);
>
> put_device(dev);
>
> > + continue;
> > + } else {
No need for an else either.
> > + pr_info("Found supported device %s\n",
> > + supported_devices[i]);
so this can be unindented too.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-09-17 10:23 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 21:36 [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms Daniel Scally
2020-09-16 21:36 ` Daniel Scally
2020-09-17 0:17 ` kernel test robot
2020-09-17 3:02 ` kernel test robot
2020-09-17 7:53 ` Greg KH
2020-09-17 7:53 ` Greg KH
2020-09-17 9:47 ` Dan Scally
2020-09-17 9:47 ` Dan Scally
2020-09-17 10:15 ` Dan Carpenter
2020-09-17 10:15 ` Dan Carpenter
2020-09-17 10:24 ` Dan Scally
2020-09-17 10:24 ` Dan Scally
2020-09-17 13:28 ` Kieran Bingham
2020-09-17 13:28 ` Kieran Bingham
2020-09-17 14:08 ` Andy Shevchenko
2020-09-17 14:08 ` Andy Shevchenko
2020-09-17 14:19 ` Kieran Bingham
2020-09-17 14:19 ` Kieran Bingham
2020-09-17 14:36 ` Andy Shevchenko
2020-09-17 14:36 ` Andy Shevchenko
2020-09-17 9:34 ` Dan Carpenter
2020-09-17 9:34 ` Dan Carpenter
2020-09-17 10:19 ` Joe Perches [this message]
2020-09-17 10:19 ` Joe Perches
2020-09-18 22:50 ` Dan Scally
2020-09-18 22:50 ` Dan Scally
2020-09-17 10:33 ` Sakari Ailus
2020-09-17 10:33 ` Sakari Ailus
2020-09-17 10:49 ` Dan Carpenter
2020-09-17 10:49 ` Dan Carpenter
2020-09-17 12:25 ` Andy Shevchenko
2020-09-17 12:25 ` Andy Shevchenko
2020-09-17 13:15 ` Dan Carpenter
2020-09-17 13:15 ` Dan Carpenter
2020-09-18 6:40 ` Sakari Ailus
2020-09-18 6:40 ` Sakari Ailus
2020-09-18 8:16 ` Dan Carpenter
2020-09-18 8:16 ` Dan Carpenter
2020-09-17 10:52 ` Dan Scally
2020-09-17 10:52 ` Dan Scally
2020-09-17 12:45 ` Andy Shevchenko
2020-09-17 12:45 ` Andy Shevchenko
2020-09-17 13:36 ` Dan Scally
2020-09-17 13:36 ` Dan Scally
2020-09-17 14:14 ` Andy Shevchenko
2020-09-17 14:14 ` Andy Shevchenko
2020-09-17 21:25 ` Daniel Scally
2020-09-17 21:25 ` Daniel Scally
2020-09-17 14:44 ` Andy Shevchenko
2020-09-17 14:44 ` Andy Shevchenko
2020-09-18 7:51 ` Sakari Ailus
2020-09-18 7:51 ` Sakari Ailus
2020-09-18 13:07 ` Andy Shevchenko
2020-09-18 13:07 ` Andy Shevchenko
2020-09-21 13:33 ` Dan Scally
2020-09-21 13:33 ` Dan Scally
2020-09-21 14:33 ` Andy Shevchenko
2020-09-21 14:33 ` Andy Shevchenko
2020-09-23 9:39 ` Dan Scally
2020-09-23 9:39 ` Dan Scally
2020-09-28 11:37 ` Dan Scally
2020-09-28 11:37 ` Dan Scally
2020-09-18 8:03 ` Dan Carpenter
2020-09-18 8:03 ` Dan Carpenter
2020-09-18 8:09 ` Dan Scally
2020-09-18 8:09 ` Dan Scally
2020-09-20 21:34 ` kernel test robot
2020-09-20 21:34 ` [RFC PATCH] cio2_sync_state() can be static kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8274e9166ad6f7c95f0885403b9584081672a3ff.camel@perches.com \
--to=joe@perches.com \
--cc=bingbu.cao@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.