* [PATCH] Add new recipe for squashfs-tools-ng
@ 2020-10-21 15:58 Luca Bocassi
2020-10-21 19:02 ` [OE-core] " Richard Purdie
` (2 more replies)
0 siblings, 3 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-21 15:58 UTC (permalink / raw)
To: openembedded-core
From: Luca Boccassi <luca.boccassi@microsoft.com>
The main difference with squashfs-tools is the availability
of a shared library and a programmatic interface, rather
than just command-line tools.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
.../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
new file mode 100644
index 0000000000..bbc5f86ae9
--- /dev/null
+++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+ file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+ file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+ file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+ file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+ file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+ file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+ file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+ file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+ file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+PV = "1.0.2"
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH] Add new recipe for squashfs-tools-ng
2020-10-21 15:58 [PATCH] Add new recipe for squashfs-tools-ng Luca Bocassi
@ 2020-10-21 19:02 ` Richard Purdie
2020-10-22 2:21 ` Khem Raj
2020-10-21 19:08 ` Konrad Weihmann
2020-10-22 9:20 ` [PATCH v2] " Luca Bocassi
2 siblings, 1 reply; 21+ messages in thread
From: Richard Purdie @ 2020-10-21 19:02 UTC (permalink / raw)
To: Luca Bocassi, openembedded-core
On Wed, 2020-10-21 at 16:58 +0100, Luca Bocassi wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> The main difference with squashfs-tools is the availability
> of a shared library and a programmatic interface, rather
> than just command-line tools.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> .../squashfs-tools-ng_git.bb | 37
> +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-
> tools-ng_git.bb
Should we be switching over to squashfs-tools-ng and removing squashfs-
tools? I'm not sure we want to support both versions?
Cheers,
Richard
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH] Add new recipe for squashfs-tools-ng
2020-10-21 15:58 [PATCH] Add new recipe for squashfs-tools-ng Luca Bocassi
2020-10-21 19:02 ` [OE-core] " Richard Purdie
@ 2020-10-21 19:08 ` Konrad Weihmann
2020-10-22 9:21 ` Luca Bocassi
2020-10-22 9:20 ` [PATCH v2] " Luca Bocassi
2 siblings, 1 reply; 21+ messages in thread
From: Konrad Weihmann @ 2020-10-21 19:08 UTC (permalink / raw)
To: openembedded-core, luca.boccassi
On 21.10.20 17:58, Luca Bocassi wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> The main difference with squashfs-tools is the availability
> of a shared library and a programmatic interface, rather
> than just command-line tools.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> .../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
>
> diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> new file mode 100644
> index 0000000000..bbc5f86ae9
> --- /dev/null
> +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> @@ -0,0 +1,37 @@
> +SUMMARY = "New set of tools for working with SquashFS images"
> +SECTION = "base"
> +LICENSE = "GPLv3+ & LGPL-3.0+"
A bit of nitpick, but with all the license files mentioned below the
LICENSE setting looks wrong to me.
I would at least expect some BSD and zLib SPDX identifiers here.
To be super exact one would have to take the PACKAGECONFIG into account
to get the correct value
> +LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
> + file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> + file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
> + file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
> + file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
> + file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
> + file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
> + file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
> + file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
> + file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
> +
> +PV = "1.0.2"
> +SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
> +SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
> +"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig
> +
> +PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
> +PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
> +PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
> +PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
> +PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
> +PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
> +PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
> +
> +PACKAGES =+ "libsquashfs"
> +FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +CVE_PRODUCT = "squashfs"
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH] Add new recipe for squashfs-tools-ng
2020-10-21 19:02 ` [OE-core] " Richard Purdie
@ 2020-10-22 2:21 ` Khem Raj
2020-10-22 9:13 ` Luca Bocassi
0 siblings, 1 reply; 21+ messages in thread
From: Khem Raj @ 2020-10-22 2:21 UTC (permalink / raw)
To: Richard Purdie
Cc: Luca Bocassi, Patches and discussions about the oe-core layer
On Wed, Oct 21, 2020 at 12:02 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2020-10-21 at 16:58 +0100, Luca Bocassi wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > .../squashfs-tools-ng_git.bb | 37
> > +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-
> > tools-ng_git.bb
>
> Should we be switching over to squashfs-tools-ng and removing squashfs-
> tools? I'm not sure we want to support both versions?
I am not sure if we want to switch to ng yet as on option its good to
have. Perhaps in meta-oe or some other place.
>
> Cheers,
>
> Richard
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH] Add new recipe for squashfs-tools-ng
2020-10-22 2:21 ` Khem Raj
@ 2020-10-22 9:13 ` Luca Bocassi
0 siblings, 0 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-22 9:13 UTC (permalink / raw)
To: Khem Raj, Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Wed, 2020-10-21 at 19:21 -0700, Khem Raj wrote:
> On Wed, Oct 21, 2020 at 12:02 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Wed, 2020-10-21 at 16:58 +0100, Luca Bocassi wrote:
> > > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > >
> > > The main difference with squashfs-tools is the availability
> > > of a shared library and a programmatic interface, rather
> > > than just command-line tools.
> > >
> > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > > ---
> > > .../squashfs-tools-ng_git.bb | 37
> > > +++++++++++++++++++
> > > 1 file changed, 37 insertions(+)
> > > create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-
> > > tools-ng_git.bb
> >
> > Should we be switching over to squashfs-tools-ng and removing squashfs-
> > tools? I'm not sure we want to support both versions?
>
> I am not sure if we want to switch to ng yet as on option its good to
> have. Perhaps in meta-oe or some other place.
Yeah the command line interface is not a one-to-one mapping, so
probably best to keep both around.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] Add new recipe for squashfs-tools-ng
2020-10-21 15:58 [PATCH] Add new recipe for squashfs-tools-ng Luca Bocassi
2020-10-21 19:02 ` [OE-core] " Richard Purdie
2020-10-21 19:08 ` Konrad Weihmann
@ 2020-10-22 9:20 ` Luca Bocassi
2020-10-22 11:10 ` [OE-core] " Peter Kjellerstedt
2020-10-22 11:30 ` [PATCH v3] " Luca Bocassi
2 siblings, 2 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-22 9:20 UTC (permalink / raw)
To: openembedded-core; +Cc: kweihmann
From: Luca Boccassi <luca.boccassi@microsoft.com>
The main difference with squashfs-tools is the availability
of a shared library and a programmatic interface, rather
than just command-line tools.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
.../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
new file mode 100644
index 0000000000..6479017ddb
--- /dev/null
+++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
@@ -0,0 +1,37 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPLv3+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+ file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
+ file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+ file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+ file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+ file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+ file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+ file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+ file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+ file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+PV = "1.0.2"
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
+"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH] Add new recipe for squashfs-tools-ng
2020-10-21 19:08 ` Konrad Weihmann
@ 2020-10-22 9:21 ` Luca Bocassi
0 siblings, 0 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-22 9:21 UTC (permalink / raw)
To: Konrad Weihmann, openembedded-core
On Wed, 2020-10-21 at 21:08 +0200, Konrad Weihmann wrote:
> On 21.10.20 17:58, Luca Bocassi wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > .../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> >
> > diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > new file mode 100644
> > index 0000000000..bbc5f86ae9
> > --- /dev/null
> > +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > @@ -0,0 +1,37 @@
> > +SUMMARY = "New set of tools for working with SquashFS images"
> > +SECTION = "base"
> > +LICENSE = "GPLv3+ & LGPL-3.0+"
>
> A bit of nitpick, but with all the license files mentioned below the
> LICENSE setting looks wrong to me.
> I would at least expect some BSD and zLib SPDX identifiers here.
Added MIT, Zlib and BSD-2-Clause in v2.
> To be super exact one would have to take the PACKAGECONFIG into account
> to get the correct value
The binary is distributed under the terms of GPL3 regardless, so not
sure it's worth the complications? Is it required/commonly done in
other recipes?
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH v2] Add new recipe for squashfs-tools-ng
2020-10-22 9:20 ` [PATCH v2] " Luca Bocassi
@ 2020-10-22 11:10 ` Peter Kjellerstedt
2020-10-22 11:30 ` Luca Bocassi
2020-10-22 11:30 ` [PATCH v3] " Luca Bocassi
1 sibling, 1 reply; 21+ messages in thread
From: Peter Kjellerstedt @ 2020-10-22 11:10 UTC (permalink / raw)
To: Luca Bocassi, openembedded-core; +Cc: kweihmann
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Luca Bocassi
> Sent: den 22 oktober 2020 11:20
> To: openembedded-core@lists.openembedded.org
> Cc: kweihmann@outlook.com
> Subject: [OE-core] [PATCH v2] Add new recipe for squashfs-tools-ng
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> The main difference with squashfs-tools is the availability
> of a shared library and a programmatic interface, rather
> than just command-line tools.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2: added MIT, Zlib and BSD-2-Clause to LICENSE
>
> .../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-
> tools-ng_git.bb
>
> diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> new file mode 100644
> index 0000000000..6479017ddb
> --- /dev/null
> +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> @@ -0,0 +1,37 @@
> +SUMMARY = "New set of tools for working with SquashFS images"
> +SECTION = "base"
> +LICENSE = "GPLv3+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
Change "GPLv3+" to "GPL-3.0+" for consistency.
You have GPL-2.0 listed below too so it should probably be added
above as well.
> +LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
> + file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> + file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
> + file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
> + file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
> + file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
> + file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
> + file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
> + file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
> + file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
> +
> +PV = "1.0.2"
Move the version to the file name.
> +SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
> +SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
> +"
I'd remove that backslash and keep it as one line.
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig
> +
> +PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
Change to:
PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
> +PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
> +PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
> +PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
> +PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
> +PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
> +PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
> +
> +PACKAGES =+ "libsquashfs"
> +FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +CVE_PRODUCT = "squashfs"
> --
> 2.20.1
//Peter
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3] Add new recipe for squashfs-tools-ng
2020-10-22 9:20 ` [PATCH v2] " Luca Bocassi
2020-10-22 11:10 ` [OE-core] " Peter Kjellerstedt
@ 2020-10-22 11:30 ` Luca Bocassi
2020-10-22 19:10 ` [OE-core] " Khem Raj
` (2 more replies)
1 sibling, 3 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-22 11:30 UTC (permalink / raw)
To: openembedded-core; +Cc: peter.kjellerstedt
From: Luca Boccassi <luca.boccassi@microsoft.com>
The main difference with squashfs-tools is the availability
of a shared library and a programmatic interface, rather
than just command-line tools.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
.../squashfs-tools-ng_1.0.2.bb | 34 +++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
new file mode 100644
index 0000000000..293b31cd92
--- /dev/null
+++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
@@ -0,0 +1,34 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+ file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+ file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+ file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+ file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+ file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+ file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+ file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+ file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH v2] Add new recipe for squashfs-tools-ng
2020-10-22 11:10 ` [OE-core] " Peter Kjellerstedt
@ 2020-10-22 11:30 ` Luca Bocassi
0 siblings, 0 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-22 11:30 UTC (permalink / raw)
To: Peter Kjellerstedt, openembedded-core; +Cc: kweihmann
On Thu, 2020-10-22 at 11:10 +0000, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-
> > core@lists.openembedded.org> On Behalf Of Luca Bocassi
> > Sent: den 22 oktober 2020 11:20
> > To: openembedded-core@lists.openembedded.org
> > Cc: kweihmann@outlook.com
> > Subject: [OE-core] [PATCH v2] Add new recipe for squashfs-tools-ng
> >
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> >
> > .../squashfs-tools-ng_git.bb | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-
> > tools-ng_git.bb
> >
> > diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > new file mode 100644
> > index 0000000000..6479017ddb
> > --- /dev/null
> > +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_git.bb
> > @@ -0,0 +1,37 @@
> > +SUMMARY = "New set of tools for working with SquashFS images"
> > +SECTION = "base"
> > +LICENSE = "GPLv3+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
>
> Change "GPLv3+" to "GPL-3.0+" for consistency.
Done.
> You have GPL-2.0 listed below too so it should probably be added
> above as well.
The COPYING.md file specifies that it is mentioned only because some of
the dependencies use it and can be linked against. As far as I can see
no code included in this repository uses that license. So I've removed
it from the checksum list.
> > +LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
> > + file://licenses/GPLv2.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> > + file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
> > + file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
> > + file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
> > + file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
> > + file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
> > + file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
> > + file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
> > + file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
> > +
> > +PV = "1.0.2"
>
> Move the version to the file name.
Done.
> > +SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
> > +SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https \
> > +"
>
> I'd remove that backslash and keep it as one line.
Done.
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +inherit autotools pkgconfig
> > +
> > +PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
>
> Change to:
>
> PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
Done.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH v3] Add new recipe for squashfs-tools-ng
2020-10-22 11:30 ` [PATCH v3] " Luca Bocassi
@ 2020-10-22 19:10 ` Khem Raj
2020-10-23 8:57 ` Luca Bocassi
2020-10-24 12:58 ` Richard Purdie
2020-10-26 10:05 ` [PATCH v4] " Luca Bocassi
2 siblings, 1 reply; 21+ messages in thread
From: Khem Raj @ 2020-10-22 19:10 UTC (permalink / raw)
To: Luca Bocassi, openembedded-core; +Cc: peter.kjellerstedt
On 10/22/20 4:30 AM, Luca Bocassi wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> The main difference with squashfs-tools is the availability
> of a shared library and a programmatic interface, rather
> than just command-line tools.
Can you clarify which parts are under GPL-3.0+ & LGPL-3.0+ licenses.
is it possible to ship traditional functionality from squashfs-tools
without using code under these licenses.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
> recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
>
> .../squashfs-tools-ng_1.0.2.bb | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
>
> diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> new file mode 100644
> index 0000000000..293b31cd92
> --- /dev/null
> +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> @@ -0,0 +1,34 @@
> +SUMMARY = "New set of tools for working with SquashFS images"
> +SECTION = "base"
> +LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
> +LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
> + file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
> + file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
> + file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
> + file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
> + file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
> + file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
> + file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
> + file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
> +
> +SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
> +SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig
> +
> +PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
> +PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
> +PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
> +PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
> +PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
> +PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
> +PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
> +
> +PACKAGES =+ "libsquashfs"
> +FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +CVE_PRODUCT = "squashfs"
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH v3] Add new recipe for squashfs-tools-ng
2020-10-22 19:10 ` [OE-core] " Khem Raj
@ 2020-10-23 8:57 ` Luca Bocassi
0 siblings, 0 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-23 8:57 UTC (permalink / raw)
To: Khem Raj, openembedded-core
On Thu, 2020-10-22 at 12:10 -0700, Khem Raj wrote:
>
> On 10/22/20 4:30 AM, Luca Bocassi wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
>
> Can you clarify which parts are under GPL-3.0+ & LGPL-3.0+ licenses.
> is it possible to ship traditional functionality from squashfs-tools
> without using code under these licenses.
It's all defined in COPYING.md - the library is under LGPL3+, the rest
of the code (command-line tools) under GPL3+.
# License of squashfs-tools-ng
The `libsquashfs` library is released under the terms and conditions of the
**GNU Lesser General Public License version 3 or later**. This applies to
all source code in the directories `lib/sqfs`, `lib/util` and `include/sqfs`
with the following exceptions:
- `lib/util/xxhash.c` contains a modified implementation of the xxhash32
algorithm. See `licenses/xxhash.txt` for copyright and licensing
information (2 clause BSD license).
- `lib/lz4` contains files extracted from the LZ4 compression library.
See `lib/lz4/README` for details and `licenses/LZ4.txt` for copyright and
licensing information (2 clause BSD license).
- `lib/zlib` contains files that have been extracted from the the zlib
compression library and modified. See `lib/zlib/README` for details
and `licenses/zlib.txt` for details.
- `lib/util/hash_table.c`, `include/hash_table.h` and
`lib/util/fast_urem_by_const.h` contain a hash table implementation (MIT
license). See `licenses/hash_table.txt` for details.
The rest of squashfs-tools-ng is released under the terms and conditions of
the **GNU General Public License version 3 or later**.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH v3] Add new recipe for squashfs-tools-ng
2020-10-22 11:30 ` [PATCH v3] " Luca Bocassi
2020-10-22 19:10 ` [OE-core] " Khem Raj
@ 2020-10-24 12:58 ` Richard Purdie
2020-10-26 10:05 ` Luca Bocassi
2020-10-26 10:05 ` [PATCH v4] " Luca Bocassi
2 siblings, 1 reply; 21+ messages in thread
From: Richard Purdie @ 2020-10-24 12:58 UTC (permalink / raw)
To: Luca Bocassi, openembedded-core; +Cc: peter.kjellerstedt
On Thu, 2020-10-22 at 12:30 +0100, Luca Bocassi wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> The main difference with squashfs-tools is the availability
> of a shared library and a programmatic interface, rather
> than just command-line tools.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
> recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
>
> .../squashfs-tools-ng_1.0.2.bb | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
>
> diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> new file mode 100644
> index 0000000000..293b31cd92
> --- /dev/null
> +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> @@ -0,0 +1,34 @@
> +SUMMARY = "New set of tools for working with SquashFS images"
> +SECTION = "base"
> +LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
> +LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
> + file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
> + file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
> + file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
> + file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
> + file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
> + file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
> + file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
> + file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
> +
> +SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
> +SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig
> +
> +PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
> +PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
> +PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
> +PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
> +PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
> +PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
Testing on the autobuilder showed up:
ERROR: Nothing PROVIDES 'zstd' (but /home/pokybuild/yocto-worker/check-layer/build/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb DEPENDS on or otherwise requires it)
(zstd isn't in OE-Core)
Cheers,
Richard
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v4] Add new recipe for squashfs-tools-ng
2020-10-22 11:30 ` [PATCH v3] " Luca Bocassi
2020-10-22 19:10 ` [OE-core] " Khem Raj
2020-10-24 12:58 ` Richard Purdie
@ 2020-10-26 10:05 ` Luca Bocassi
2020-10-26 10:29 ` Richard Purdie
2 siblings, 1 reply; 21+ messages in thread
From: Luca Bocassi @ 2020-10-26 10:05 UTC (permalink / raw)
To: openembedded-core; +Cc: richard.purdie
From: Luca Boccassi <luca.boccassi@microsoft.com>
The main difference with squashfs-tools is the availability
of a shared library and a programmatic interface, rather
than just command-line tools.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
v2: added MIT, Zlib and BSD-2-Clause to LICENSE
v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
v4: disable zstd support by default, dependency not available in oe-core
.../squashfs-tools-ng_1.0.2.bb | 34 +++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
new file mode 100644
index 0000000000..948a030810
--- /dev/null
+++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
@@ -0,0 +1,34 @@
+SUMMARY = "New set of tools for working with SquashFS images"
+SECTION = "base"
+LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
+LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
+ file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
+ file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
+ file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
+ file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
+ file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
+ file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
+ file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
+ file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
+
+SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
+SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "gzip xz lzo lz4 ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
+PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
+PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
+PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
+PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
+PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
+PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
+
+PACKAGES =+ "libsquashfs"
+FILES_libsquashfs = "${libdir}/libsquashfs*${SOLIBS}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+CVE_PRODUCT = "squashfs"
--
2.20.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH v3] Add new recipe for squashfs-tools-ng
2020-10-24 12:58 ` Richard Purdie
@ 2020-10-26 10:05 ` Luca Bocassi
0 siblings, 0 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-26 10:05 UTC (permalink / raw)
To: Richard Purdie, openembedded-core; +Cc: peter.kjellerstedt
On Sat, 2020-10-24 at 13:58 +0100, Richard Purdie wrote:
> On Thu, 2020-10-22 at 12:30 +0100, Luca Bocassi wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> > v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used), changed
> > recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
> >
> > .../squashfs-tools-ng_1.0.2.bb | 34 +++++++++++++++++++
> > 1 file changed, 34 insertions(+)
> > create mode 100644 meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> >
> > diff --git a/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> > new file mode 100644
> > index 0000000000..293b31cd92
> > --- /dev/null
> > +++ b/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb
> > @@ -0,0 +1,34 @@
> > +SUMMARY = "New set of tools for working with SquashFS images"
> > +SECTION = "base"
> > +LICENSE = "GPL-3.0+ & LGPL-3.0+ & MIT & BSD-2-Clause & Zlib"
> > +LIC_FILES_CHKSUM = "file://COPYING.md;md5=c0de2c0aca56349dab98e97992316f7e \
> > + file://licenses/GPLv3.txt;md5=1ebbd3e34237af26da5dc08a4e440464 \
> > + file://licenses/hash_table.txt;md5=874823605326caeaabaa95bfbd0f9fb0 \
> > + file://licenses/LGPLv3.txt;md5=3000208d539ec061b899bce1d9ce9404 \
> > + file://licenses/LZ4.txt;md5=ebc2ea4814a64de7708f1571904b32cc \
> > + file://licenses/xxhash.txt;md5=f042a9be092bd6d7fe6f217d8d00f4ca \
> > + file://licenses/xz.txt;md5=1c389b9610ccfdb25f7abaea6a0bb5a4 \
> > + file://licenses/zlib.txt;md5=ae27c72096606131f760e5f59cf98b06 \
> > + file://licenses/zstd.txt;md5=8df8137b630239cbdd4c0674124cb0c8"
> > +
> > +SRCREV = "b96f0fc154feef531be76034bf6e38925636146f"
> > +SRC_URI = "git://github.com/AgentD/squashfs-tools-ng.git;protocol=https"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +inherit autotools pkgconfig
> > +
> > +PACKAGECONFIG ??= "gzip xz lzo lz4 zstd ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)}"
> > +PACKAGECONFIG[gzip] = "--with-gzip,--without-gzip,zlib"
> > +PACKAGECONFIG[xz] = "--with-xz,--without-xz,xz"
> > +PACKAGECONFIG[lzo] = "--with-lzo,--without-lzo,lzo"
> > +PACKAGECONFIG[lz4] = "--with-lz4,--without-lz4,lz4"
> > +PACKAGECONFIG[zstd] = "--with-zstd,--without-zstd,zstd"
>
> Testing on the autobuilder showed up:
>
> ERROR: Nothing PROVIDES 'zstd' (but /home/pokybuild/yocto-worker/check-layer/build/meta/recipes-devtools/squashfs-tools-ng/squashfs-tools-ng_1.0.2.bb DEPENDS on or otherwise requires it)
>
> (zstd isn't in OE-Core)
>
> Cheers,
>
> Richard
Removed zstd from default config in v4.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v4] Add new recipe for squashfs-tools-ng
2020-10-26 10:05 ` [PATCH v4] " Luca Bocassi
@ 2020-10-26 10:29 ` Richard Purdie
2020-10-26 13:09 ` Luca Bocassi
0 siblings, 1 reply; 21+ messages in thread
From: Richard Purdie @ 2020-10-26 10:29 UTC (permalink / raw)
To: luca.boccassi, openembedded-core
On Mon, 2020-10-26 at 10:05 +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> The main difference with squashfs-tools is the availability
> of a shared library and a programmatic interface, rather
> than just command-line tools.
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used),
> changed
> recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
> v4: disable zstd support by default, dependency not available in oe-
> core
Sorry, there is one other issue. There is no maintainers entry for this
recipe (see meta/conf/distro/include/maintainers.inc) which would cause
oe-selftest to fail. Can you add an maintainers entry please?
Thanks,
Richard
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v4] Add new recipe for squashfs-tools-ng
2020-10-26 10:29 ` Richard Purdie
@ 2020-10-26 13:09 ` Luca Bocassi
2020-10-27 10:31 ` Luca Bocassi
2020-10-27 10:37 ` Richard Purdie
0 siblings, 2 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-26 13:09 UTC (permalink / raw)
To: Richard Purdie, openembedded-core
On Mon, 2020-10-26 at 10:29 +0000, Richard Purdie wrote:
> On Mon, 2020-10-26 at 10:05 +0000, luca.boccassi@gmail.com wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > The main difference with squashfs-tools is the availability
> > of a shared library and a programmatic interface, rather
> > than just command-line tools.
> >
> > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > ---
> > v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> > v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used),
> > changed
> > recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
> > v4: disable zstd support by default, dependency not available in oe-
> > core
>
> Sorry, there is one other issue. There is no maintainers entry for this
> recipe (see meta/conf/distro/include/maintainers.inc) which would cause
> oe-selftest to fail. Can you add an maintainers entry please?
>
> Thanks,
> Richard
Ok - who should be listed as maintainer?
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v4] Add new recipe for squashfs-tools-ng
2020-10-26 13:09 ` Luca Bocassi
@ 2020-10-27 10:31 ` Luca Bocassi
2020-10-27 10:37 ` Richard Purdie
1 sibling, 0 replies; 21+ messages in thread
From: Luca Bocassi @ 2020-10-27 10:31 UTC (permalink / raw)
To: Richard Purdie, openembedded-core
On Mon, 2020-10-26 at 13:09 +0000, Luca Boccassi wrote:
> On Mon, 2020-10-26 at 10:29 +0000, Richard Purdie wrote:
> > On Mon, 2020-10-26 at 10:05 +0000, luca.boccassi@gmail.com wrote:
> > > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > >
> > > The main difference with squashfs-tools is the availability
> > > of a shared library and a programmatic interface, rather
> > > than just command-line tools.
> > >
> > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > > ---
> > > v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> > > v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used),
> > > changed
> > > recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
> > > v4: disable zstd support by default, dependency not available in oe-
> > > core
> >
> > Sorry, there is one other issue. There is no maintainers entry for this
> > recipe (see meta/conf/distro/include/maintainers.inc) which would cause
> > oe-selftest to fail. Can you add an maintainers entry please?
> >
> > Thanks,
> > Richard
>
> Ok - who should be listed as maintainer?
Ping - please let me know and I'll send a v5. Thanks.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v4] Add new recipe for squashfs-tools-ng
2020-10-26 13:09 ` Luca Bocassi
2020-10-27 10:31 ` Luca Bocassi
@ 2020-10-27 10:37 ` Richard Purdie
2020-10-27 10:59 ` Luca Bocassi
1 sibling, 1 reply; 21+ messages in thread
From: Richard Purdie @ 2020-10-27 10:37 UTC (permalink / raw)
To: Luca Boccassi, openembedded-core
On Mon, 2020-10-26 at 13:09 +0000, Luca Boccassi wrote:
> On Mon, 2020-10-26 at 10:29 +0000, Richard Purdie wrote:
> > On Mon, 2020-10-26 at 10:05 +0000, luca.boccassi@gmail.com wrote:
> > > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > >
> > > The main difference with squashfs-tools is the availability
> > > of a shared library and a programmatic interface, rather
> > > than just command-line tools.
> > >
> > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > > ---
> > > v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> > > v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used),
> > > changed
> > > recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
> > > v4: disable zstd support by default, dependency not available in
> > > oe-
> > > core
> >
> > Sorry, there is one other issue. There is no maintainers entry for
> > this
> > recipe (see meta/conf/distro/include/maintainers.inc) which would
> > cause
> > oe-selftest to fail. Can you add an maintainers entry please?
> >
> > Thanks,
> > Richard
>
> Ok - who should be listed as maintainer?
The person who is going to look after this recipe in OE-Core. Each
recipe needs to have a maintainer listed, someone who is prepared to
get the upgrade helper emails, handle upgrades, help with security
issues, bugs related to the recipe and so on.
If we don't have anyone willing to maintain it, I'd argue its not
important enough to have in OE-Core...
Cheers,
Richard
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v4] Add new recipe for squashfs-tools-ng
2020-10-27 10:37 ` Richard Purdie
@ 2020-10-27 10:59 ` Luca Bocassi
2020-10-27 11:19 ` [OE-core] " Ross Burton
0 siblings, 1 reply; 21+ messages in thread
From: Luca Bocassi @ 2020-10-27 10:59 UTC (permalink / raw)
To: Richard Purdie, openembedded-core
On Tue, 2020-10-27 at 10:37 +0000, Richard Purdie wrote:
> On Mon, 2020-10-26 at 13:09 +0000, Luca Boccassi wrote:
> > On Mon, 2020-10-26 at 10:29 +0000, Richard Purdie wrote:
> > > On Mon, 2020-10-26 at 10:05 +0000, luca.boccassi@gmail.com wrote:
> > > > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > > >
> > > > The main difference with squashfs-tools is the availability
> > > > of a shared library and a programmatic interface, rather
> > > > than just command-line tools.
> > > >
> > > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > > > ---
> > > > v2: added MIT, Zlib and BSD-2-Clause to LICENSE
> > > > v3: fixed CPL-3.0+ tag, removed GPL2 from checksum (not used),
> > > > changed
> > > > recipe to be versioned, use bb.utils.filter in PACKAGE_CONFIG
> > > > v4: disable zstd support by default, dependency not available in
> > > > oe-
> > > > core
> > >
> > > Sorry, there is one other issue. There is no maintainers entry for
> > > this
> > > recipe (see meta/conf/distro/include/maintainers.inc) which would
> > > cause
> > > oe-selftest to fail. Can you add an maintainers entry please?
> > >
> > > Thanks,
> > > Richard
> >
> > Ok - who should be listed as maintainer?
>
> The person who is going to look after this recipe in OE-Core. Each
> recipe needs to have a maintainer listed, someone who is prepared to
> get the upgrade helper emails, handle upgrades, help with security
> issues, bugs related to the recipe and so on.
>
> If we don't have anyone willing to maintain it, I'd argue its not
> important enough to have in OE-Core...
>
> Cheers,
>
> Richard
Ok, I'll move to meta-openembedded then.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [OE-core] [PATCH v4] Add new recipe for squashfs-tools-ng
2020-10-27 10:59 ` Luca Bocassi
@ 2020-10-27 11:19 ` Ross Burton
0 siblings, 0 replies; 21+ messages in thread
From: Ross Burton @ 2020-10-27 11:19 UTC (permalink / raw)
To: Luca Bocassi; +Cc: Richard Purdie, OE-core
On Tue, 27 Oct 2020 at 10:59, Luca Bocassi <luca.boccassi@gmail.com> wrote:
> > > Ok - who should be listed as maintainer?
> >
> > The person who is going to look after this recipe in OE-Core. Each
> > recipe needs to have a maintainer listed, someone who is prepared to
> > get the upgrade helper emails, handle upgrades, help with security
> > issues, bugs related to the recipe and so on.
> >
> > If we don't have anyone willing to maintain it, I'd argue its not
> > important enough to have in OE-Core...
>
> Ok, I'll move to meta-openembedded then.
If you care enough to write and submit a recipe, don't you care enough
to maintain it in the future?
Ross
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2020-10-27 11:19 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 15:58 [PATCH] Add new recipe for squashfs-tools-ng Luca Bocassi
2020-10-21 19:02 ` [OE-core] " Richard Purdie
2020-10-22 2:21 ` Khem Raj
2020-10-22 9:13 ` Luca Bocassi
2020-10-21 19:08 ` Konrad Weihmann
2020-10-22 9:21 ` Luca Bocassi
2020-10-22 9:20 ` [PATCH v2] " Luca Bocassi
2020-10-22 11:10 ` [OE-core] " Peter Kjellerstedt
2020-10-22 11:30 ` Luca Bocassi
2020-10-22 11:30 ` [PATCH v3] " Luca Bocassi
2020-10-22 19:10 ` [OE-core] " Khem Raj
2020-10-23 8:57 ` Luca Bocassi
2020-10-24 12:58 ` Richard Purdie
2020-10-26 10:05 ` Luca Bocassi
2020-10-26 10:05 ` [PATCH v4] " Luca Bocassi
2020-10-26 10:29 ` Richard Purdie
2020-10-26 13:09 ` Luca Bocassi
2020-10-27 10:31 ` Luca Bocassi
2020-10-27 10:37 ` Richard Purdie
2020-10-27 10:59 ` Luca Bocassi
2020-10-27 11:19 ` [OE-core] " Ross Burton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.