* [PATCH] ibmveth: Fix use of ibmveth in a bridge.
@ 2020-10-26 10:42 ` Michal Suchanek
0 siblings, 0 replies; 8+ messages in thread
From: Michal Suchanek @ 2020-10-26 10:42 UTC (permalink / raw)
To: Thomas Bogendoerfer, netdev
Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
Cristobal Forno, David S. Miller, Jakub Kicinski, Cris Forno,
linuxppc-dev, linux-kernel, Michal Suchanek
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
The check for src mac address in ibmveth_is_packet_unsupported is wrong.
Commit 6f2275433a2f wanted to shut down messages for loopback packets,
but now suppresses bridged frames, which are accepted by the hypervisor
otherwise bridging won't work at all.
Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
ms: added commit message
---
drivers/net/ethernet/ibm/ibmveth.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 7ef3369953b6..c3ec9ceed833 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1031,12 +1031,6 @@ static int ibmveth_is_packet_unsupported(struct sk_buff *skb,
ret = -EOPNOTSUPP;
}
- if (!ether_addr_equal(ether_header->h_source, netdev->dev_addr)) {
- netdev_dbg(netdev, "source packet MAC address does not match veth device's, dropping packet.\n");
- netdev->stats.tx_dropped++;
- ret = -EOPNOTSUPP;
- }
-
return ret;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] ibmveth: Fix use of ibmveth in a bridge.
@ 2020-10-26 10:42 ` Michal Suchanek
0 siblings, 0 replies; 8+ messages in thread
From: Michal Suchanek @ 2020-10-26 10:42 UTC (permalink / raw)
To: Thomas Bogendoerfer, netdev
Cc: Cristobal Forno, linux-kernel, Paul Mackerras, Cris Forno,
Jakub Kicinski, Michal Suchanek, linuxppc-dev, David S. Miller
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
The check for src mac address in ibmveth_is_packet_unsupported is wrong.
Commit 6f2275433a2f wanted to shut down messages for loopback packets,
but now suppresses bridged frames, which are accepted by the hypervisor
otherwise bridging won't work at all.
Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
ms: added commit message
---
drivers/net/ethernet/ibm/ibmveth.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 7ef3369953b6..c3ec9ceed833 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1031,12 +1031,6 @@ static int ibmveth_is_packet_unsupported(struct sk_buff *skb,
ret = -EOPNOTSUPP;
}
- if (!ether_addr_equal(ether_header->h_source, netdev->dev_addr)) {
- netdev_dbg(netdev, "source packet MAC address does not match veth device's, dropping packet.\n");
- netdev->stats.tx_dropped++;
- ret = -EOPNOTSUPP;
- }
-
return ret;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.
2020-10-26 10:42 ` Michal Suchanek
@ 2020-10-26 18:52 ` Jakub Kicinski
-1 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2020-10-26 18:52 UTC (permalink / raw)
To: Michal Suchanek
Cc: Thomas Bogendoerfer, netdev, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras, Cristobal Forno,
David S. Miller, Cris Forno, linuxppc-dev, linux-kernel
On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> but now suppresses bridged frames, which are accepted by the hypervisor
> otherwise bridging won't work at all.
>
> Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Since the From: line says Thomas we need a signoff from him.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.
@ 2020-10-26 18:52 ` Jakub Kicinski
0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2020-10-26 18:52 UTC (permalink / raw)
To: Michal Suchanek
Cc: Cristobal Forno, netdev, linux-kernel, Thomas Bogendoerfer,
Paul Mackerras, linuxppc-dev, David S. Miller, Cris Forno
On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> but now suppresses bridged frames, which are accepted by the hypervisor
> otherwise bridging won't work at all.
>
> Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Since the From: line says Thomas we need a signoff from him.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.
2020-10-26 18:52 ` Jakub Kicinski
@ 2020-10-26 19:04 ` Thomas Bogendoerfer
-1 siblings, 0 replies; 8+ messages in thread
From: Thomas Bogendoerfer @ 2020-10-26 19:04 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Michal Suchanek, netdev, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras, Cristobal Forno,
David S. Miller, Cris Forno, linuxppc-dev, linux-kernel
On Mon, 26 Oct 2020 11:52:37 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:
> > From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> >
> > The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> > Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> > but now suppresses bridged frames, which are accepted by the hypervisor
> > otherwise bridging won't work at all.
> >
> > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
>
> Since the From: line says Thomas we need a signoff from him.
you can add
Signed-off-by: tbogendoerfer@suse.de
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.
@ 2020-10-26 19:04 ` Thomas Bogendoerfer
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Bogendoerfer @ 2020-10-26 19:04 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Cristobal Forno, netdev, linux-kernel, Paul Mackerras,
Michal Suchanek, linuxppc-dev, David S. Miller, Cris Forno
On Mon, 26 Oct 2020 11:52:37 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:
> > From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> >
> > The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> > Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> > but now suppresses bridged frames, which are accepted by the hypervisor
> > otherwise bridging won't work at all.
> >
> > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
>
> Since the From: line says Thomas we need a signoff from him.
you can add
Signed-off-by: tbogendoerfer@suse.de
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.
2020-10-26 19:04 ` Thomas Bogendoerfer
@ 2020-10-28 0:54 ` Jakub Kicinski
-1 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2020-10-28 0:54 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Michal Suchanek, netdev, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras, Cristobal Forno,
David S. Miller, Cris Forno, linuxppc-dev, linux-kernel
On Mon, 26 Oct 2020 20:04:07 +0100 Thomas Bogendoerfer wrote:
> > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:
> > > From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > >
> > > The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> > > Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> > > but now suppresses bridged frames, which are accepted by the hypervisor
> > > otherwise bridging won't work at all.
> > >
> > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> >
> > Since the From: line says Thomas we need a signoff from him.
>
> you can add
>
> Signed-off-by: tbogendoerfer@suse.de
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge.
@ 2020-10-28 0:54 ` Jakub Kicinski
0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2020-10-28 0:54 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Cristobal Forno, netdev, linux-kernel, Paul Mackerras,
Michal Suchanek, linuxppc-dev, David S. Miller, Cris Forno
On Mon, 26 Oct 2020 20:04:07 +0100 Thomas Bogendoerfer wrote:
> > On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote:
> > > From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > >
> > > The check for src mac address in ibmveth_is_packet_unsupported is wrong.
> > > Commit 6f2275433a2f wanted to shut down messages for loopback packets,
> > > but now suppresses bridged frames, which are accepted by the hypervisor
> > > otherwise bridging won't work at all.
> > >
> > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> >
> > Since the From: line says Thomas we need a signoff from him.
>
> you can add
>
> Signed-off-by: tbogendoerfer@suse.de
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-10-29 0:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 10:42 [PATCH] ibmveth: Fix use of ibmveth in a bridge Michal Suchanek
2020-10-26 10:42 ` Michal Suchanek
2020-10-26 18:52 ` Jakub Kicinski
2020-10-26 18:52 ` Jakub Kicinski
2020-10-26 19:04 ` Thomas Bogendoerfer
2020-10-26 19:04 ` Thomas Bogendoerfer
2020-10-28 0:54 ` Jakub Kicinski
2020-10-28 0:54 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.