* store a pointer to the block_device in struct bio (again)
@ 2020-12-01 16:54 ` Christoph Hellwig
0 siblings, 0 replies; 68+ messages in thread
From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw)
To: Jens Axboe
Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid,
linux-s390, linux-block
Hi Jens,
this series switches back from storing the gendisk + partno to storing
a block_device pointer in struct bio. The reason is two fold: for one
the new struct block_device actually is always available, removing the
need to avoid originally. Second the merge struct block_device is much
more useful than the old one, as storing it avoids the need for looking
up what used to be hd_struct during partition remapping and I/O
accounting.
Note that this series depends on the posted but not merged
"block tracepoint cleanups" series.
A git tree is also available:
git://git.infradead.org/users/hch/block.git bi_bdev
Gitweb:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bi_bdev
Diffstat:
arch/m68k/emu/nfblock.c | 2
arch/xtensa/platforms/iss/simdisk.c | 2
block/bio-integrity.c | 18 +-
block/bio.c | 31 +---
block/blk-cgroup.c | 7
block/blk-core.c | 99 ++++++-------
block/blk-crypto-fallback.c | 2
block/blk-crypto.c | 2
block/blk-merge.c | 17 +-
block/blk-mq.c | 2
block/blk-settings.c | 2
block/blk-throttle.c | 2
block/blk.h | 9 -
block/bounce.c | 2
block/genhd.c | 261 +++---------------------------------
block/partitions/core.c | 31 ----
drivers/block/brd.c | 8 -
drivers/block/drbd/drbd_int.h | 4
drivers/block/drbd/drbd_req.c | 2
drivers/block/null_blk_main.c | 2
drivers/block/pktcdvd.c | 4
drivers/block/ps3vram.c | 2
drivers/block/rsxx/dev.c | 2
drivers/block/umem.c | 2
drivers/block/zram/zram_drv.c | 2
drivers/lightnvm/pblk-init.c | 2
drivers/md/bcache/debug.c | 2
drivers/md/bcache/request.c | 39 +++--
drivers/md/dm-bio-record.h | 9 -
drivers/md/dm-raid1.c | 10 -
drivers/md/dm.c | 14 -
drivers/md/md-linear.c | 2
drivers/md/md.c | 10 -
drivers/md/md.h | 6
drivers/md/raid1.c | 6
drivers/md/raid10.c | 12 -
drivers/md/raid5.c | 2
drivers/nvdimm/blk.c | 4
drivers/nvdimm/btt.c | 4
drivers/nvdimm/pmem.c | 4
drivers/nvme/host/core.c | 6
drivers/nvme/host/lightnvm.c | 3
drivers/nvme/host/multipath.c | 6
drivers/nvme/host/rdma.c | 2
drivers/s390/block/dasd.c | 26 ---
drivers/s390/block/dcssblk.c | 6
drivers/s390/block/xpram.c | 2
fs/btrfs/check-integrity.c | 10 -
fs/btrfs/raid56.c | 7
fs/btrfs/scrub.c | 2
fs/direct-io.c | 2
fs/f2fs/data.c | 12 -
include/linux/bio.h | 18 +-
include/linux/blk_types.h | 3
include/linux/blkdev.h | 20 --
include/linux/genhd.h | 21 --
kernel/trace/blktrace.c | 16 +-
mm/page_io.c | 2
58 files changed, 251 insertions(+), 556 deletions(-)
^ permalink raw reply [flat|nested] 68+ messages in thread* [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo Hi Jens, this series switches back from storing the gendisk + partno to storing a block_device pointer in struct bio. The reason is two fold: for one the new struct block_device actually is always available, removing the need to avoid originally. Second the merge struct block_device is much more useful than the old one, as storing it avoids the need for looking up what used to be hd_struct during partition remapping and I/O accounting. Note that this series depends on the posted but not merged "block tracepoint cleanups" series. A git tree is also available: git://git.infradead.org/users/hch/block.git bi_bdev Gitweb: http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bi_bdev Diffstat: arch/m68k/emu/nfblock.c | 2 arch/xtensa/platforms/iss/simdisk.c | 2 block/bio-integrity.c | 18 +- block/bio.c | 31 +--- block/blk-cgroup.c | 7 block/blk-core.c | 99 ++++++------- block/blk-crypto-fallback.c | 2 block/blk-crypto.c | 2 block/blk-merge.c | 17 +- block/blk-mq.c | 2 block/blk-settings.c | 2 block/blk-throttle.c | 2 block/blk.h | 9 - block/bounce.c | 2 block/genhd.c | 261 +++--------------------------------- block/partitions/core.c | 31 ---- drivers/block/brd.c | 8 - drivers/block/drbd/drbd_int.h | 4 drivers/block/drbd/drbd_req.c | 2 drivers/block/null_blk_main.c | 2 drivers/block/pktcdvd.c | 4 drivers/block/ps3vram.c | 2 drivers/block/rsxx/dev.c | 2 drivers/block/umem.c | 2 drivers/block/zram/zram_drv.c | 2 drivers/lightnvm/pblk-init.c | 2 drivers/md/bcache/debug.c | 2 drivers/md/bcache/request.c | 39 +++-- drivers/md/dm-bio-record.h | 9 - drivers/md/dm-raid1.c | 10 - drivers/md/dm.c | 14 - drivers/md/md-linear.c | 2 drivers/md/md.c | 10 - drivers/md/md.h | 6 drivers/md/raid1.c | 6 drivers/md/raid10.c | 12 - drivers/md/raid5.c | 2 drivers/nvdimm/blk.c | 4 drivers/nvdimm/btt.c | 4 drivers/nvdimm/pmem.c | 4 drivers/nvme/host/core.c | 6 drivers/nvme/host/lightnvm.c | 3 drivers/nvme/host/multipath.c | 6 drivers/nvme/host/rdma.c | 2 drivers/s390/block/dasd.c | 26 --- drivers/s390/block/dcssblk.c | 6 drivers/s390/block/xpram.c | 2 fs/btrfs/check-integrity.c | 10 - fs/btrfs/raid56.c | 7 fs/btrfs/scrub.c | 2 fs/direct-io.c | 2 fs/f2fs/data.c | 12 - include/linux/bio.h | 18 +- include/linux/blk_types.h | 3 include/linux/blkdev.h | 20 -- include/linux/genhd.h | 21 -- kernel/trace/blktrace.c | 16 +- mm/page_io.c | 2 58 files changed, 251 insertions(+), 556 deletions(-) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 1/9] brd: remove the end of device check in brd_do_bvec 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block The block layer already checks for this conditions in bio_check_eod before calling the driver. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/brd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index c43a6ab4b1f39f..c7c8214190795c 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -285,14 +285,10 @@ static int brd_do_bvec(struct brd_device *brd, struct page *page, static blk_qc_t brd_submit_bio(struct bio *bio) { struct brd_device *brd = bio->bi_disk->private_data; + sector_t sector = bio->bi_iter.bi_sector; struct bio_vec bvec; - sector_t sector; struct bvec_iter iter; - sector = bio->bi_iter.bi_sector; - if (bio_end_sector(bio) > get_capacity(bio->bi_disk)) - goto io_error; - bio_for_each_segment(bvec, bio, iter) { unsigned int len = bvec.bv_len; int err; -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 1/9] brd: remove the end of device check in brd_do_bvec @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo The block layer already checks for this conditions in bio_check_eod before calling the driver. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/brd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index c43a6ab4b1f39f..c7c8214190795c 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -285,14 +285,10 @@ static int brd_do_bvec(struct brd_device *brd, struct page *page, static blk_qc_t brd_submit_bio(struct bio *bio) { struct brd_device *brd = bio->bi_disk->private_data; + sector_t sector = bio->bi_iter.bi_sector; struct bio_vec bvec; - sector_t sector; struct bvec_iter iter; - sector = bio->bi_iter.bi_sector; - if (bio_end_sector(bio) > get_capacity(bio->bi_disk)) - goto io_error; - bio_for_each_segment(bvec, bio, iter) { unsigned int len = bvec.bv_len; int err; -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 1/9] brd: remove the end of device check in brd_do_bvec 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 22:39 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:39 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:16PM +0100, Christoph Hellwig wrote: > The block layer already checks for this conditions in bio_check_eod > before calling the driver. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 1/9] brd: remove the end of device check in brd_do_bvec @ 2020-12-02 22:39 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:39 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:16PM +0100, Christoph Hellwig wrote: > The block layer already checks for this conditions in bio_check_eod > before calling the driver. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 2/9] dcssblk: remove the end of device check in brd_do_bvec 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block The block layer already checks for this conditions in bio_check_eod before calling the driver. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/s390/block/dcssblk.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 299e77ec2c4163..5c5cff3f237452 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -886,10 +886,6 @@ dcssblk_submit_bio(struct bio *bio) (bio->bi_iter.bi_size & 4095) != 0) /* Request is not page-aligned. */ goto fail; - if (bio_end_sector(bio) > get_capacity(bio->bi_disk)) { - /* Request beyond end of DCSS segment. */ - goto fail; - } /* verify data transfer direction */ if (dev_info->is_shared) { switch (dev_info->segment_type) { -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 2/9] dcssblk: remove the end of device check in brd_do_bvec @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo The block layer already checks for this conditions in bio_check_eod before calling the driver. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/s390/block/dcssblk.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 299e77ec2c4163..5c5cff3f237452 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -886,10 +886,6 @@ dcssblk_submit_bio(struct bio *bio) (bio->bi_iter.bi_size & 4095) != 0) /* Request is not page-aligned. */ goto fail; - if (bio_end_sector(bio) > get_capacity(bio->bi_disk)) { - /* Request beyond end of DCSS segment. */ - goto fail; - } /* verify data transfer direction */ if (dev_info->is_shared) { switch (dev_info->segment_type) { -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 2/9] dcssblk: remove the end of device check in brd_do_bvec 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 22:39 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:39 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:17PM +0100, Christoph Hellwig wrote: > The block layer already checks for this conditions in bio_check_eod > before calling the driver. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 2/9] dcssblk: remove the end of device check in brd_do_bvec @ 2020-12-02 22:39 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:39 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:17PM +0100, Christoph Hellwig wrote: > The block layer already checks for this conditions in bio_check_eod > before calling the driver. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 3/9] block: store a block_device pointer in struct bio 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block Replace the gendisk pointer in struct bio with a pointer to the newly improved struct block device. From that the gendisk can be trivially accessed with an extra indirection, but it also allows to directly look up all information related to partition remapping. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/m68k/emu/nfblock.c | 2 +- arch/xtensa/platforms/iss/simdisk.c | 2 +- block/bio-integrity.c | 18 +++++++-------- block/bio.c | 31 +++++++++---------------- block/blk-cgroup.c | 7 +++--- block/blk-core.c | 36 +++++++++++++---------------- block/blk-crypto-fallback.c | 2 +- block/blk-crypto.c | 2 +- block/blk-merge.c | 17 +++++++------- block/blk-mq.c | 2 +- block/blk-throttle.c | 2 +- block/blk.h | 6 ++--- block/bounce.c | 2 +- block/genhd.c | 2 +- drivers/block/brd.c | 2 +- drivers/block/drbd/drbd_int.h | 4 ++-- drivers/block/drbd/drbd_req.c | 2 +- drivers/block/null_blk_main.c | 2 +- drivers/block/pktcdvd.c | 4 ++-- drivers/block/ps3vram.c | 2 +- drivers/block/rsxx/dev.c | 2 +- drivers/block/umem.c | 2 +- drivers/block/zram/zram_drv.c | 2 +- drivers/lightnvm/pblk-init.c | 2 +- drivers/md/bcache/debug.c | 2 +- drivers/md/bcache/request.c | 7 +++--- drivers/md/dm-bio-record.h | 9 +++----- drivers/md/dm-raid1.c | 10 ++++---- drivers/md/dm.c | 14 +++++------ drivers/md/md-linear.c | 2 +- drivers/md/md.c | 2 +- drivers/md/md.h | 6 ++--- drivers/md/raid1.c | 6 ++--- drivers/md/raid10.c | 12 +++++----- drivers/md/raid5.c | 2 +- drivers/nvdimm/blk.c | 4 ++-- drivers/nvdimm/btt.c | 4 ++-- drivers/nvdimm/pmem.c | 4 ++-- drivers/nvme/host/core.c | 6 ++--- drivers/nvme/host/lightnvm.c | 3 +-- drivers/nvme/host/multipath.c | 6 ++--- drivers/nvme/host/rdma.c | 2 +- drivers/s390/block/dcssblk.c | 2 +- drivers/s390/block/xpram.c | 2 +- fs/btrfs/check-integrity.c | 10 ++++---- fs/btrfs/raid56.c | 7 ++---- fs/btrfs/scrub.c | 2 +- fs/direct-io.c | 2 +- fs/f2fs/data.c | 12 +--------- include/linux/bio.h | 18 +++++++-------- include/linux/blk_types.h | 3 +-- include/linux/blkdev.h | 5 ++-- kernel/trace/blktrace.c | 16 +++++++------ mm/page_io.c | 2 +- 54 files changed, 153 insertions(+), 184 deletions(-) diff --git a/arch/m68k/emu/nfblock.c b/arch/m68k/emu/nfblock.c index 92d26c81244134..ba808543161a02 100644 --- a/arch/m68k/emu/nfblock.c +++ b/arch/m68k/emu/nfblock.c @@ -61,7 +61,7 @@ struct nfhd_device { static blk_qc_t nfhd_submit_bio(struct bio *bio) { - struct nfhd_device *dev = bio->bi_disk->private_data; + struct nfhd_device *dev = bio->bi_bdev->bd_disk->private_data; struct bio_vec bvec; struct bvec_iter iter; int dir, len, shift; diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index 3447556d276d32..fc09be7b13479c 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -103,7 +103,7 @@ static void simdisk_transfer(struct simdisk *dev, unsigned long sector, static blk_qc_t simdisk_submit_bio(struct bio *bio) { - struct simdisk *dev = bio->bi_disk->private_data; + struct simdisk *dev = bio->bi_bdev->bd_disk->private_data; struct bio_vec bvec; struct bvec_iter iter; sector_t sector = bio->bi_iter.bi_sector; diff --git a/block/bio-integrity.c b/block/bio-integrity.c index 9ffd7e28955476..c3e5abcfdc98c3 100644 --- a/block/bio-integrity.c +++ b/block/bio-integrity.c @@ -140,7 +140,7 @@ int bio_integrity_add_page(struct bio *bio, struct page *page, iv = bip->bip_vec + bip->bip_vcnt; if (bip->bip_vcnt && - bvec_gap_to_prev(bio->bi_disk->queue, + bvec_gap_to_prev(bio->bi_bdev->bd_disk->queue, &bip->bip_vec[bip->bip_vcnt - 1], offset)) return 0; @@ -162,7 +162,7 @@ EXPORT_SYMBOL(bio_integrity_add_page); static blk_status_t bio_integrity_process(struct bio *bio, struct bvec_iter *proc_iter, integrity_processing_fn *proc_fn) { - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); struct blk_integrity_iter iter; struct bvec_iter bviter; struct bio_vec bv; @@ -171,7 +171,7 @@ static blk_status_t bio_integrity_process(struct bio *bio, void *prot_buf = page_address(bip->bip_vec->bv_page) + bip->bip_vec->bv_offset; - iter.disk_name = bio->bi_disk->disk_name; + iter.disk_name = bio->bi_bdev->bd_disk->disk_name; iter.interval = 1 << bi->interval_exp; iter.seed = proc_iter->bi_sector; iter.prot_buf = prot_buf; @@ -208,8 +208,8 @@ static blk_status_t bio_integrity_process(struct bio *bio, bool bio_integrity_prep(struct bio *bio) { struct bio_integrity_payload *bip; - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); - struct request_queue *q = bio->bi_disk->queue; + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); + struct request_queue *q = bio->bi_bdev->bd_disk->queue; void *buf; unsigned long start, end; unsigned int len, nr_pages; @@ -329,7 +329,7 @@ static void bio_integrity_verify_fn(struct work_struct *work) struct bio_integrity_payload *bip = container_of(work, struct bio_integrity_payload, bip_work); struct bio *bio = bip->bip_bio; - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); /* * At the moment verify is called bio's iterator was advanced @@ -355,7 +355,7 @@ static void bio_integrity_verify_fn(struct work_struct *work) */ bool __bio_integrity_endio(struct bio *bio) { - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); struct bio_integrity_payload *bip = bio_integrity(bio); if (bio_op(bio) == REQ_OP_READ && !bio->bi_status && @@ -381,7 +381,7 @@ bool __bio_integrity_endio(struct bio *bio) void bio_integrity_advance(struct bio *bio, unsigned int bytes_done) { struct bio_integrity_payload *bip = bio_integrity(bio); - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); unsigned bytes = bio_integrity_bytes(bi, bytes_done >> 9); bip->bip_iter.bi_sector += bytes_done >> 9; @@ -397,7 +397,7 @@ void bio_integrity_advance(struct bio *bio, unsigned int bytes_done) void bio_integrity_trim(struct bio *bio) { struct bio_integrity_payload *bip = bio_integrity(bio); - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); bip->bip_iter.bi_size = bio_integrity_bytes(bi, bio_sectors(bio)); } diff --git a/block/bio.c b/block/bio.c index ebb18136b86f2f..a58afe4a50dc7a 100644 --- a/block/bio.c +++ b/block/bio.c @@ -607,16 +607,7 @@ void bio_truncate(struct bio *bio, unsigned new_size) */ void guard_bio_eod(struct bio *bio) { - sector_t maxsector; - struct block_device *part; - - rcu_read_lock(); - part = __disk_get_part(bio->bi_disk, bio->bi_partno); - if (part) - maxsector = bdev_nr_sectors(part); - else - maxsector = get_capacity(bio->bi_disk); - rcu_read_unlock(); + sector_t maxsector = bdev_nr_sectors(bio->bi_bdev); if (!maxsector) return; @@ -676,11 +667,10 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src) BUG_ON(bio->bi_pool && BVEC_POOL_IDX(bio)); /* - * most users will be overriding ->bi_disk with a new target, + * most users will be overriding ->bi_bdev with a new target, * so we don't set nor calculate new physical/hw segment counts here */ - bio->bi_disk = bio_src->bi_disk; - bio->bi_partno = bio_src->bi_partno; + bio->bi_bdev = bio_src->bi_bdev; bio_set_flag(bio, BIO_CLONED); if (bio_flagged(bio_src, BIO_THROTTLED)) bio_set_flag(bio, BIO_THROTTLED); @@ -730,7 +720,7 @@ EXPORT_SYMBOL(bio_clone_fast); const char *bio_devname(struct bio *bio, char *buf) { - return disk_name(bio->bi_disk, bio->bi_partno, buf); + return bdevname(bio->bi_bdev, buf); } EXPORT_SYMBOL(bio_devname); @@ -1037,7 +1027,7 @@ static int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter) { unsigned short nr_pages = bio->bi_max_vecs - bio->bi_vcnt; unsigned short entries_left = bio->bi_max_vecs - bio->bi_vcnt; - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; unsigned int max_append_sectors = queue_max_zone_append_sectors(q); struct bio_vec *bv = bio->bi_io_vec + bio->bi_vcnt; struct page **pages = (struct page **)bv; @@ -1145,7 +1135,8 @@ static void submit_bio_wait_endio(struct bio *bio) */ int submit_bio_wait(struct bio *bio) { - DECLARE_COMPLETION_ONSTACK_MAP(done, bio->bi_disk->lockdep_map); + DECLARE_COMPLETION_ONSTACK_MAP(done, + bio->bi_bdev->bd_disk->lockdep_map); unsigned long hang_check; bio->bi_private = &done; @@ -1422,8 +1413,8 @@ void bio_endio(struct bio *bio) if (!bio_integrity_endio(bio)) return; - if (bio->bi_disk) - rq_qos_done_bio(bio->bi_disk->queue, bio); + if (bio->bi_bdev) + rq_qos_done_bio(bio->bi_bdev->bd_disk->queue, bio); /* * Need to have a real endio function for chained bios, otherwise @@ -1438,8 +1429,8 @@ void bio_endio(struct bio *bio) goto again; } - if (bio->bi_disk && bio_flagged(bio, BIO_TRACE_COMPLETION)) { - trace_block_bio_complete(bio->bi_disk->queue, bio); + if (bio->bi_bdev && bio_flagged(bio, BIO_TRACE_COMPLETION)) { + trace_block_bio_complete(bio->bi_bdev->bd_disk->queue, bio); bio_clear_flag(bio, BIO_TRACE_COMPLETION); } diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 031114d454a604..3465d6ee708edf 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1800,7 +1800,8 @@ static inline struct blkcg_gq *blkg_tryget_closest(struct bio *bio, struct blkcg_gq *blkg, *ret_blkg = NULL; rcu_read_lock(); - blkg = blkg_lookup_create(css_to_blkcg(css), bio->bi_disk->queue); + blkg = blkg_lookup_create(css_to_blkcg(css), + bio->bi_bdev->bd_disk->queue); while (blkg) { if (blkg_tryget(blkg)) { ret_blkg = blkg; @@ -1836,8 +1837,8 @@ void bio_associate_blkg_from_css(struct bio *bio, if (css && css->parent) { bio->bi_blkg = blkg_tryget_closest(bio, css); } else { - blkg_get(bio->bi_disk->queue->root_blkg); - bio->bi_blkg = bio->bi_disk->queue->root_blkg; + blkg_get(bio->bi_bdev->bd_disk->queue->root_blkg); + bio->bi_blkg = bio->bi_bdev->bd_disk->queue->root_blkg; } } EXPORT_SYMBOL_GPL(bio_associate_blkg_from_css); diff --git a/block/blk-core.c b/block/blk-core.c index 96e5fcd7f071b6..95005a8db5ab2f 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -475,7 +475,7 @@ int blk_queue_enter(struct request_queue *q, blk_mq_req_flags_t flags) static inline int bio_queue_enter(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; bool nowait = bio->bi_opf & REQ_NOWAIT; int ret; @@ -713,7 +713,7 @@ static inline bool bio_check_ro(struct bio *bio, struct block_device *part) static noinline int should_fail_bio(struct bio *bio) { - if (should_fail_request(bio->bi_disk->part0, bio->bi_iter.bi_size)) + if (should_fail_request(bdev_whole(bio->bi_bdev), bio->bi_iter.bi_size)) return -EIO; return 0; } @@ -742,13 +742,9 @@ static inline int bio_check_eod(struct bio *bio, sector_t maxsector) */ static inline int blk_partition_remap(struct bio *bio) { - struct block_device *p; + struct block_device *p = bio->bi_bdev; int ret = -EIO; - rcu_read_lock(); - p = __disk_get_part(bio->bi_disk, bio->bi_partno); - if (unlikely(!p)) - goto out; if (unlikely(should_fail_request(p, bio->bi_iter.bi_size))) goto out; if (unlikely(bio_check_ro(bio, p))) @@ -762,10 +758,8 @@ static inline int blk_partition_remap(struct bio *bio) bio->bi_iter.bi_sector - p->bd_start_sect); } - bio->bi_partno = 0; ret = 0; out: - rcu_read_unlock(); return ret; } @@ -806,7 +800,8 @@ static inline blk_status_t blk_check_zone_append(struct request_queue *q, static noinline_for_stack bool submit_bio_checks(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct block_device *bdev = bio->bi_bdev; + struct request_queue *q = bdev->bd_disk->queue; blk_status_t status = BLK_STS_IOERR; struct blk_plug *plug; @@ -826,13 +821,13 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) if (should_fail_bio(bio)) goto end_io; - if (bio->bi_partno) { + if (bio->bi_bdev->bd_partno) { if (unlikely(blk_partition_remap(bio))) goto end_io; } else { - if (unlikely(bio_check_ro(bio, bio->bi_disk->part0))) + if (unlikely(bio_check_ro(bio, bdev_whole(bdev)))) goto end_io; - if (unlikely(bio_check_eod(bio, get_capacity(bio->bi_disk)))) + if (unlikely(bio_check_eod(bio, get_capacity(bdev->bd_disk)))) goto end_io; } @@ -925,7 +920,7 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) static blk_qc_t __submit_bio(struct bio *bio) { - struct gendisk *disk = bio->bi_disk; + struct gendisk *disk = bio->bi_bdev->bd_disk; blk_qc_t ret = BLK_QC_T_NONE; if (blk_crypto_bio_prep(&bio)) { @@ -967,7 +962,7 @@ static blk_qc_t __submit_bio_noacct(struct bio *bio) current->bio_list = bio_list_on_stack; do { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct bio_list lower, same; if (unlikely(bio_queue_enter(bio) != 0)) @@ -988,7 +983,7 @@ static blk_qc_t __submit_bio_noacct(struct bio *bio) bio_list_init(&lower); bio_list_init(&same); while ((bio = bio_list_pop(&bio_list_on_stack[0])) != NULL) - if (q == bio->bi_disk->queue) + if (q == bio->bi_bdev->bd_disk->queue) bio_list_add(&same, bio); else bio_list_add(&lower, bio); @@ -1013,7 +1008,7 @@ static blk_qc_t __submit_bio_noacct_mq(struct bio *bio) current->bio_list = bio_list; do { - struct gendisk *disk = bio->bi_disk; + struct gendisk *disk = bio->bi_bdev->bd_disk; if (unlikely(bio_queue_enter(bio) != 0)) continue; @@ -1056,7 +1051,7 @@ blk_qc_t submit_bio_noacct(struct bio *bio) return BLK_QC_T_NONE; } - if (!bio->bi_disk->fops->submit_bio) + if (!bio->bi_bdev->bd_disk->fops->submit_bio) return __submit_bio_noacct_mq(bio); return __submit_bio_noacct(bio); } @@ -1068,7 +1063,7 @@ EXPORT_SYMBOL(submit_bio_noacct); * * submit_bio() is used to submit I/O requests to block devices. It is passed a * fully set up &struct bio that describes the I/O that needs to be done. The - * bio will be send to the device described by the bi_disk and bi_partno fields. + * bio will be send to the device described by the bi_bdev field. * * The success/failure status of the request, along with notification of * completion, is delivered asynchronously through the ->bi_end_io() callback @@ -1088,7 +1083,8 @@ blk_qc_t submit_bio(struct bio *bio) unsigned int count; if (unlikely(bio_op(bio) == REQ_OP_WRITE_SAME)) - count = queue_logical_block_size(bio->bi_disk->queue) >> 9; + count = queue_logical_block_size( + bio->bi_bdev->bd_disk->queue) >> 9; else count = bio_sectors(bio); diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c index c162b754efbd6a..8f1e1817673115 100644 --- a/block/blk-crypto-fallback.c +++ b/block/blk-crypto-fallback.c @@ -167,7 +167,7 @@ static struct bio *blk_crypto_clone_bio(struct bio *bio_src) bio = bio_alloc_bioset(GFP_NOIO, bio_segments(bio_src), NULL); if (!bio) return NULL; - bio->bi_disk = bio_src->bi_disk; + bio->bi_bdev = bio_src->bi_bdev; bio->bi_opf = bio_src->bi_opf; bio->bi_ioprio = bio_src->bi_ioprio; bio->bi_write_hint = bio_src->bi_write_hint; diff --git a/block/blk-crypto.c b/block/blk-crypto.c index 5da43f0973b46b..09fcb18fa778fa 100644 --- a/block/blk-crypto.c +++ b/block/blk-crypto.c @@ -280,7 +280,7 @@ bool __blk_crypto_bio_prep(struct bio **bio_ptr) * Success if device supports the encryption context, or if we succeeded * in falling back to the crypto API. */ - if (blk_ksm_crypto_cfg_supported(bio->bi_disk->queue->ksm, + if (blk_ksm_crypto_cfg_supported(bio->bi_bdev->bd_disk->queue->ksm, &bc_key->crypto_cfg)) return true; diff --git a/block/blk-merge.c b/block/blk-merge.c index 7497d86fff3834..30707a4acd1f9b 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -290,14 +290,13 @@ static struct bio *blk_bio_segment_split(struct request_queue *q, * Split a bio into two bios, chain the two bios, submit the second half and * store a pointer to the first half in *@bio. If the second bio is still too * big it will be split by a recursive call to this function. Since this - * function may allocate a new bio from @bio->bi_disk->queue->bio_split, it is - * the responsibility of the caller to ensure that - * @bio->bi_disk->queue->bio_split is only released after processing of the - * split bio has finished. + * function may allocate a new bio from q->bio_split, it is the responsibility + * of the caller to ensure that q->bio_split is only released after processing + * of the split bio has finished. */ void __blk_queue_split(struct bio **bio, unsigned int *nr_segs) { - struct request_queue *q = (*bio)->bi_disk->queue; + struct request_queue *q = (*bio)->bi_bdev->bd_disk->queue; struct bio *split = NULL; switch (bio_op(*bio)) { @@ -350,9 +349,9 @@ void __blk_queue_split(struct bio **bio, unsigned int *nr_segs) * * Split a bio into two bios, chains the two bios, submit the second half and * store a pointer to the first half in *@bio. Since this function may allocate - * a new bio from @bio->bi_disk->queue->bio_split, it is the responsibility of - * the caller to ensure that @bio->bi_disk->queue->bio_split is only released - * after processing of the split bio has finished. + * a new bio from q->bio_split, it is the responsibility of the caller to ensure + * that q->bio_split is only released after processing of the split bio has + * finished. */ void blk_queue_split(struct bio **bio) { @@ -858,7 +857,7 @@ bool blk_rq_merge_ok(struct request *rq, struct bio *bio) return false; /* must be same device */ - if (rq->rq_disk != bio->bi_disk) + if (rq->rq_disk != bio->bi_bdev->bd_disk) return false; /* only merge integrity protected bio into ditto rq */ diff --git a/block/blk-mq.c b/block/blk-mq.c index bb669b415a387e..e9e5c0487d2813 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2146,7 +2146,7 @@ static void blk_add_rq_to_plug(struct blk_plug *plug, struct request *rq) */ blk_qc_t blk_mq_submit_bio(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; const int is_sync = op_is_sync(bio->bi_opf); const int is_flush_fua = op_is_flush(bio->bi_opf); struct blk_mq_alloc_data data = { diff --git a/block/blk-throttle.c b/block/blk-throttle.c index b771c42999827c..73589f8e187ebd 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -2172,7 +2172,7 @@ static inline void throtl_update_latency_buckets(struct throtl_data *td) bool blk_throtl_bio(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct blkcg_gq *blkg = bio->bi_blkg; struct throtl_qnode *qn = NULL; struct throtl_grp *tg = blkg_to_tg(blkg); diff --git a/block/blk.h b/block/blk.h index 98f0b1ae264120..64dc8e5a3f44cb 100644 --- a/block/blk.h +++ b/block/blk.h @@ -99,8 +99,8 @@ static inline void blk_rq_bio_prep(struct request *rq, struct bio *bio, rq->bio = rq->biotail = bio; rq->ioprio = bio_prio(bio); - if (bio->bi_disk) - rq->rq_disk = bio->bi_disk; + if (bio->bi_bdev) + rq->rq_disk = bio->bi_bdev->bd_disk; } #ifdef CONFIG_BLK_DEV_INTEGRITY @@ -215,8 +215,6 @@ static inline void elevator_exit(struct request_queue *q, __elevator_exit(q, e); } -struct block_device *__disk_get_part(struct gendisk *disk, int partno); - ssize_t part_size_show(struct device *dev, struct device_attribute *attr, char *buf); ssize_t part_stat_show(struct device *dev, struct device_attribute *attr, diff --git a/block/bounce.c b/block/bounce.c index d3f51acd6e3b51..a22a8a1942b24f 100644 --- a/block/bounce.c +++ b/block/bounce.c @@ -246,7 +246,7 @@ static struct bio *bounce_clone_bio(struct bio *bio_src, gfp_t gfp_mask, bio = bio_alloc_bioset(gfp_mask, bio_segments(bio_src), bs); if (!bio) return NULL; - bio->bi_disk = bio_src->bi_disk; + bio->bi_bdev = bio_src->bi_bdev; bio->bi_opf = bio_src->bi_opf; bio->bi_ioprio = bio_src->bi_ioprio; bio->bi_write_hint = bio_src->bi_write_hint; diff --git a/block/genhd.c b/block/genhd.c index b84b8671e6270a..57c709a9f90267 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -159,7 +159,7 @@ static void part_in_flight_rw(struct block_device *part, inflight[1] = 0; } -struct block_device *__disk_get_part(struct gendisk *disk, int partno) +static struct block_device *__disk_get_part(struct gendisk *disk, int partno) { struct disk_part_tbl *ptbl = rcu_dereference(disk->part_tbl); diff --git a/drivers/block/brd.c b/drivers/block/brd.c index c7c8214190795c..18bf9990666207 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -284,7 +284,7 @@ static int brd_do_bvec(struct brd_device *brd, struct page *page, static blk_qc_t brd_submit_bio(struct bio *bio) { - struct brd_device *brd = bio->bi_disk->private_data; + struct brd_device *brd = bio->bi_bdev->bd_disk->private_data; sector_t sector = bio->bi_iter.bi_sector; struct bio_vec bvec; struct bvec_iter iter; diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index 8f879e5c2f6706..b2c93a29c251fd 100644 --- a/drivers/block/drbd/drbd_int.h +++ b/drivers/block/drbd/drbd_int.h @@ -1579,8 +1579,8 @@ static inline void drbd_submit_bio_noacct(struct drbd_device *device, int fault_type, struct bio *bio) { __release(local); - if (!bio->bi_disk) { - drbd_err(device, "drbd_submit_bio_noacct: bio->bi_disk == NULL\n"); + if (!bio->bi_bdev) { + drbd_err(device, "drbd_submit_bio_noacct: bio->bi_bdev == NULL\n"); bio->bi_status = BLK_STS_IOERR; bio_endio(bio); return; diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 330f851cb8f0b0..ea0f31ab334361 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -1595,7 +1595,7 @@ void do_submit(struct work_struct *ws) blk_qc_t drbd_submit_bio(struct bio *bio) { - struct drbd_device *device = bio->bi_disk->private_data; + struct drbd_device *device = bio->bi_bdev->bd_disk->private_data; unsigned long start_jif; blk_queue_split(&bio); diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c index 4685ea401d5b12..783a9629e2944e 100644 --- a/drivers/block/null_blk_main.c +++ b/drivers/block/null_blk_main.c @@ -1418,7 +1418,7 @@ static blk_qc_t null_submit_bio(struct bio *bio) { sector_t sector = bio->bi_iter.bi_sector; sector_t nr_sectors = bio_sectors(bio); - struct nullb *nullb = bio->bi_disk->private_data; + struct nullb *nullb = bio->bi_bdev->bd_disk->private_data; struct nullb_queue *nq = nullb_to_queue(nullb); struct nullb_cmd *cmd; diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index b8bb8ec7538d9b..658a0981cb5471 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2374,7 +2374,7 @@ static blk_qc_t pkt_submit_bio(struct bio *bio) blk_queue_split(&bio); - pd = bio->bi_disk->queue->queuedata; + pd = bio->bi_bdev->bd_disk->queue->queuedata; if (!pd) { pr_err("%s incorrect request queue\n", bio_devname(bio, b)); goto end_io; @@ -2418,7 +2418,7 @@ static blk_qc_t pkt_submit_bio(struct bio *bio) split = bio; } - pkt_make_request_write(bio->bi_disk->queue, split); + pkt_make_request_write(bio->bi_bdev->bd_disk->queue, split); } while (split != bio); return BLK_QC_T_NONE; diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index 1088798c8dd0c9..511403cc6317a1 100644 --- a/drivers/block/ps3vram.c +++ b/drivers/block/ps3vram.c @@ -581,7 +581,7 @@ static struct bio *ps3vram_do_bio(struct ps3_system_bus_device *dev, static blk_qc_t ps3vram_submit_bio(struct bio *bio) { - struct ps3_system_bus_device *dev = bio->bi_disk->private_data; + struct ps3_system_bus_device *dev = bio->bi_bdev->bd_disk->private_data; struct ps3vram_priv *priv = ps3_system_bus_get_drvdata(dev); int busy; diff --git a/drivers/block/rsxx/dev.c b/drivers/block/rsxx/dev.c index edacefff6e355b..9a28322a8cd893 100644 --- a/drivers/block/rsxx/dev.c +++ b/drivers/block/rsxx/dev.c @@ -122,7 +122,7 @@ static void bio_dma_done_cb(struct rsxx_cardinfo *card, static blk_qc_t rsxx_submit_bio(struct bio *bio) { - struct rsxx_cardinfo *card = bio->bi_disk->private_data; + struct rsxx_cardinfo *card = bio->bi_bdev->bd_disk->private_data; struct rsxx_bio_meta *bio_meta; blk_status_t st = BLK_STS_IOERR; diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 2b95d7b33b9186..982732dbe82e69 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -521,7 +521,7 @@ static int mm_check_plugged(struct cardinfo *card) static blk_qc_t mm_submit_bio(struct bio *bio) { - struct cardinfo *card = bio->bi_disk->private_data; + struct cardinfo *card = bio->bi_bdev->bd_disk->private_data; pr_debug("mm_make_request %llu %u\n", (unsigned long long)bio->bi_iter.bi_sector, diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index b0701bae6e9800..f2807fd98e703c 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1581,7 +1581,7 @@ static void __zram_make_request(struct zram *zram, struct bio *bio) */ static blk_qc_t zram_submit_bio(struct bio *bio) { - struct zram *zram = bio->bi_disk->private_data; + struct zram *zram = bio->bi_bdev->bd_disk->private_data; if (!valid_io_request(zram, bio->bi_iter.bi_sector, bio->bi_iter.bi_size)) { diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index b6246f73895cf8..5924f09c217b62 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -49,7 +49,7 @@ struct bio_set pblk_bio_set; static blk_qc_t pblk_submit_bio(struct bio *bio) { - struct pblk *pblk = bio->bi_disk->queue->queuedata; + struct pblk *pblk = bio->bi_bdev->bd_disk->queue->queuedata; if (bio_op(bio) == REQ_OP_DISCARD) { pblk_discard(pblk, bio); diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c index b00fd08d696b5f..058dd80144281e 100644 --- a/drivers/md/bcache/debug.c +++ b/drivers/md/bcache/debug.c @@ -114,7 +114,7 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio) check = bio_kmalloc(GFP_NOIO, bio_segments(bio)); if (!check) return; - check->bi_disk = bio->bi_disk; + check->bi_bdev = bio->bi_bdev; check->bi_opf = REQ_OP_READ; check->bi_iter.bi_sector = bio->bi_iter.bi_sector; check->bi_iter.bi_size = bio->bi_iter.bi_size; diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index 85b1f2a9b72d68..dfc35d6d05ed1c 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -894,7 +894,8 @@ static int cached_dev_cache_miss(struct btree *b, struct search *s, !(bio->bi_opf & (REQ_META|REQ_PRIO)) && s->iop.c->gc_stats.in_use < CUTOFF_CACHE_READA) reada = min_t(sector_t, dc->readahead >> 9, - get_capacity(bio->bi_disk) - bio_end_sector(bio)); + get_capacity(bio->bi_bdev->bd_disk) - + bio_end_sector(bio)); s->insert_bio_sectors = min(sectors, bio_sectors(bio) + reada); @@ -1167,7 +1168,7 @@ static void quit_max_writeback_rate(struct cache_set *c, blk_qc_t cached_dev_submit_bio(struct bio *bio) { struct search *s; - struct bcache_device *d = bio->bi_disk->private_data; + struct bcache_device *d = bio->bi_bdev->bd_disk->private_data; struct cached_dev *dc = container_of(d, struct cached_dev, disk); int rw = bio_data_dir(bio); @@ -1274,7 +1275,7 @@ blk_qc_t flash_dev_submit_bio(struct bio *bio) { struct search *s; struct closure *cl; - struct bcache_device *d = bio->bi_disk->private_data; + struct bcache_device *d = bio->bi_bdev->bd_disk->private_data; if (unlikely(d->c && test_bit(CACHE_SET_IO_DISABLE, &d->c->flags))) { bio->bi_status = BLK_STS_IOERR; diff --git a/drivers/md/dm-bio-record.h b/drivers/md/dm-bio-record.h index 2ea0360108e1d4..a3b71350eec84e 100644 --- a/drivers/md/dm-bio-record.h +++ b/drivers/md/dm-bio-record.h @@ -18,8 +18,7 @@ */ struct dm_bio_details { - struct gendisk *bi_disk; - u8 bi_partno; + struct block_device *bi_bdev; int __bi_remaining; unsigned long bi_flags; struct bvec_iter bi_iter; @@ -31,8 +30,7 @@ struct dm_bio_details { static inline void dm_bio_record(struct dm_bio_details *bd, struct bio *bio) { - bd->bi_disk = bio->bi_disk; - bd->bi_partno = bio->bi_partno; + bd->bi_bdev = bio->bi_bdev; bd->bi_flags = bio->bi_flags; bd->bi_iter = bio->bi_iter; bd->__bi_remaining = atomic_read(&bio->__bi_remaining); @@ -44,8 +42,7 @@ static inline void dm_bio_record(struct dm_bio_details *bd, struct bio *bio) static inline void dm_bio_restore(struct dm_bio_details *bd, struct bio *bio) { - bio->bi_disk = bd->bi_disk; - bio->bi_partno = bd->bi_partno; + bio->bi_bdev = bd->bi_bdev; bio->bi_flags = bd->bi_flags; bio->bi_iter = bd->bi_iter; atomic_set(&bio->__bi_remaining, bd->__bi_remaining); diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c index fa09bc4e4c54a1..b0a82f29a2e451 100644 --- a/drivers/md/dm-raid1.c +++ b/drivers/md/dm-raid1.c @@ -145,7 +145,7 @@ static void dispatch_bios(void *context, struct bio_list *bio_list) struct dm_raid1_bio_record { struct mirror *m; - /* if details->bi_disk == NULL, details were not saved */ + /* if details->bi_bdev == NULL, details were not saved */ struct dm_bio_details details; region_t write_region; }; @@ -1190,7 +1190,7 @@ static int mirror_map(struct dm_target *ti, struct bio *bio) struct dm_raid1_bio_record *bio_record = dm_per_bio_data(bio, sizeof(struct dm_raid1_bio_record)); - bio_record->details.bi_disk = NULL; + bio_record->details.bi_bdev = NULL; if (rw == WRITE) { /* Save region for mirror_end_io() handler */ @@ -1257,7 +1257,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, goto out; if (unlikely(*error)) { - if (!bio_record->details.bi_disk) { + if (!bio_record->details.bi_bdev) { /* * There wasn't enough memory to record necessary * information for a retry or there was no other @@ -1282,7 +1282,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, bd = &bio_record->details; dm_bio_restore(bd, bio); - bio_record->details.bi_disk = NULL; + bio_record->details.bi_bdev = NULL; bio->bi_status = 0; queue_bio(ms, bio, rw); @@ -1292,7 +1292,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, } out: - bio_record->details.bi_disk = NULL; + bio_record->details.bi_bdev = NULL; return DM_ENDIO_DONE; } diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 5181907dc59537..1c8a8c3c1aca0e 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -977,16 +977,17 @@ static void clone_endio(struct bio *bio) struct mapped_device *md = tio->io->md; dm_endio_fn endio = tio->ti->type->end_io; struct bio *orig_bio = io->orig_bio; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; if (unlikely(error == BLK_STS_TARGET)) { if (bio_op(bio) == REQ_OP_DISCARD && - !bio->bi_disk->queue->limits.max_discard_sectors) + !q->limits.max_discard_sectors) disable_discard(md); else if (bio_op(bio) == REQ_OP_WRITE_SAME && - !bio->bi_disk->queue->limits.max_write_same_sectors) + !q->limits.max_write_same_sectors) disable_write_same(md); else if (bio_op(bio) == REQ_OP_WRITE_ZEROES && - !bio->bi_disk->queue->limits.max_write_zeroes_sectors) + !q->limits.max_write_zeroes_sectors) disable_write_zeroes(md); } @@ -996,7 +997,7 @@ static void clone_endio(struct bio *bio) */ if (bio_op(orig_bio) == REQ_OP_ZONE_APPEND) { sector_t written_sector = bio->bi_iter.bi_sector; - struct request_queue *q = orig_bio->bi_disk->queue; + struct request_queue *q = orig_bio->bi_bdev->bd_disk->queue; u64 mask = (u64)blk_queue_zone_sectors(q) - 1; orig_bio->bi_iter.bi_sector += written_sector & mask; @@ -1421,8 +1422,7 @@ static int __send_empty_flush(struct clone_info *ci) */ bio_init(&flush_bio, NULL, 0); flush_bio.bi_opf = REQ_OP_WRITE | REQ_PREFLUSH | REQ_SYNC; - flush_bio.bi_disk = ci->io->md->disk; - bio_associate_blkg(&flush_bio); + bio_set_dev(&flush_bio, ci->io->md->disk->part0); ci->bio = &flush_bio; ci->sector_count = 0; @@ -1625,7 +1625,7 @@ static blk_qc_t __split_and_process_bio(struct mapped_device *md, static blk_qc_t dm_submit_bio(struct bio *bio) { - struct mapped_device *md = bio->bi_disk->private_data; + struct mapped_device *md = bio->bi_bdev->bd_disk->private_data; blk_qc_t ret = BLK_QC_T_NONE; int srcu_idx; struct dm_table *map; diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c index 68cac7d1927823..63ed8329a98d01 100644 --- a/drivers/md/md-linear.c +++ b/drivers/md/md-linear.c @@ -252,7 +252,7 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio) start_sector + data_offset; if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) { + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) { /* Just ignore it */ bio_endio(bio); } else { diff --git a/drivers/md/md.c b/drivers/md/md.c index c555be0a8dce78..3e72fc24f80f57 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -486,7 +486,7 @@ static void md_end_io(struct bio *bio) static blk_qc_t md_submit_bio(struct bio *bio) { const int rw = bio_data_dir(bio); - struct mddev *mddev = bio->bi_disk->private_data; + struct mddev *mddev = bio->bi_bdev->bd_disk->private_data; if (mddev == NULL || mddev->pers == NULL) { bio_io_error(bio); diff --git a/drivers/md/md.h b/drivers/md/md.h index ccfb69868c2ec9..b6939df0754d25 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -556,7 +556,7 @@ static inline void md_sync_acct(struct block_device *bdev, unsigned long nr_sect static inline void md_sync_acct_bio(struct bio *bio, unsigned long nr_sectors) { - atomic_add(nr_sectors, &bio->bi_disk->sync_io); + md_sync_acct(bio->bi_bdev, nr_sectors); } struct md_personality @@ -795,14 +795,14 @@ static inline void mddev_clear_unsupported_flags(struct mddev *mddev, static inline void mddev_check_writesame(struct mddev *mddev, struct bio *bio) { if (bio_op(bio) == REQ_OP_WRITE_SAME && - !bio->bi_disk->queue->limits.max_write_same_sectors) + !bio->bi_bdev->bd_disk->queue->limits.max_write_same_sectors) mddev->queue->limits.max_write_same_sectors = 0; } static inline void mddev_check_write_zeroes(struct mddev *mddev, struct bio *bio) { if (bio_op(bio) == REQ_OP_WRITE_ZEROES && - !bio->bi_disk->queue->limits.max_write_zeroes_sectors) + !bio->bi_bdev->bd_disk->queue->limits.max_write_zeroes_sectors) mddev->queue->limits.max_write_zeroes_sectors = 0; } diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index c0347997f6ff73..3b19141cdb4bc2 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -794,13 +794,13 @@ static void flush_bio_list(struct r1conf *conf, struct bio *bio) while (bio) { /* submit pending writes */ struct bio *next = bio->bi_next; - struct md_rdev *rdev = (void *)bio->bi_disk; + struct md_rdev *rdev = (void *)bio->bi_bdev; bio->bi_next = NULL; bio_set_dev(bio, rdev->bdev); if (test_bit(Faulty, &rdev->flags)) { bio_io_error(bio); } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) /* Just ignore it */ bio_endio(bio); else @@ -1520,7 +1520,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio, trace_block_bio_remap(mbio, disk_devt(mddev->gendisk), r1_bio->sector); /* flush_pending_writes() needs access to the rdev so...*/ - mbio->bi_disk = (void *)conf->mirrors[i].rdev; + mbio->bi_bdev = (void *)conf->mirrors[i].rdev; cb = blk_check_plugged(raid1_unplug, mddev, sizeof(*plug)); if (cb) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index a6f99fa0b32cfc..34f8116c88ddb3 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -881,13 +881,13 @@ static void flush_pending_writes(struct r10conf *conf) while (bio) { /* submit pending writes */ struct bio *next = bio->bi_next; - struct md_rdev *rdev = (void*)bio->bi_disk; + struct md_rdev *rdev = (void*)bio->bi_bdev; bio->bi_next = NULL; bio_set_dev(bio, rdev->bdev); if (test_bit(Faulty, &rdev->flags)) { bio_io_error(bio); } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) /* Just ignore it */ bio_endio(bio); else @@ -1074,13 +1074,13 @@ static void raid10_unplug(struct blk_plug_cb *cb, bool from_schedule) while (bio) { /* submit pending writes */ struct bio *next = bio->bi_next; - struct md_rdev *rdev = (void*)bio->bi_disk; + struct md_rdev *rdev = (void*)bio->bi_bdev; bio->bi_next = NULL; bio_set_dev(bio, rdev->bdev); if (test_bit(Faulty, &rdev->flags)) { bio_io_error(bio); } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) /* Just ignore it */ bio_endio(bio); else @@ -1252,7 +1252,7 @@ static void raid10_write_one_disk(struct mddev *mddev, struct r10bio *r10_bio, trace_block_bio_remap(mbio, disk_devt(conf->mddev->gendisk), r10_bio->sector); /* flush_pending_writes() needs access to the rdev so...*/ - mbio->bi_disk = (void *)rdev; + mbio->bi_bdev = (void *)rdev; atomic_inc(&r10_bio->remaining); @@ -3311,7 +3311,7 @@ static sector_t raid10_sync_request(struct mddev *mddev, sector_t sector_nr, /* Again, very different code for resync and recovery. * Both must result in an r10bio with a list of bios that - * have bi_end_io, bi_sector, bi_disk set, + * have bi_end_io, bi_sector, bi_bdev set, * and bi_private set to the r10bio. * For recovery, we may actually create several r10bios * with 2 bios in each, that correspond to the bios in the main one. diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 3a90cc0e43ca8e..f411b9e5c332f4 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -5310,7 +5310,7 @@ static int in_chunk_boundary(struct mddev *mddev, struct bio *bio) unsigned int chunk_sectors; unsigned int bio_sectors = bio_sectors(bio); - WARN_ON_ONCE(bio->bi_partno); + WARN_ON_ONCE(bio->bi_bdev->bd_partno); chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors); return chunk_sectors >= diff --git a/drivers/nvdimm/blk.c b/drivers/nvdimm/blk.c index 22e5617b2cea14..e03a1f38d75040 100644 --- a/drivers/nvdimm/blk.c +++ b/drivers/nvdimm/blk.c @@ -165,7 +165,7 @@ static int nsblk_do_bvec(struct nd_namespace_blk *nsblk, static blk_qc_t nd_blk_submit_bio(struct bio *bio) { struct bio_integrity_payload *bip; - struct nd_namespace_blk *nsblk = bio->bi_disk->private_data; + struct nd_namespace_blk *nsblk = bio->bi_bdev->bd_disk->private_data; struct bvec_iter iter; unsigned long start; struct bio_vec bvec; @@ -177,7 +177,7 @@ static blk_qc_t nd_blk_submit_bio(struct bio *bio) bip = bio_integrity(bio); rw = bio_data_dir(bio); - do_acct = blk_queue_io_stat(bio->bi_disk->queue); + do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue); if (do_acct) start = bio_start_io_acct(bio); bio_for_each_segment(bvec, bio, iter) { diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 12ff6f8784ac11..41aa1f01fc0752 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1442,7 +1442,7 @@ static int btt_do_bvec(struct btt *btt, struct bio_integrity_payload *bip, static blk_qc_t btt_submit_bio(struct bio *bio) { struct bio_integrity_payload *bip = bio_integrity(bio); - struct btt *btt = bio->bi_disk->private_data; + struct btt *btt = bio->bi_bdev->bd_disk->private_data; struct bvec_iter iter; unsigned long start; struct bio_vec bvec; @@ -1452,7 +1452,7 @@ static blk_qc_t btt_submit_bio(struct bio *bio) if (!bio_integrity_prep(bio)) return BLK_QC_T_NONE; - do_acct = blk_queue_io_stat(bio->bi_disk->queue); + do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue); if (do_acct) start = bio_start_io_acct(bio); bio_for_each_segment(bvec, bio, iter) { diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 875076b0ea6c13..72740835c85c9b 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -197,13 +197,13 @@ static blk_qc_t pmem_submit_bio(struct bio *bio) unsigned long start; struct bio_vec bvec; struct bvec_iter iter; - struct pmem_device *pmem = bio->bi_disk->private_data; + struct pmem_device *pmem = bio->bi_bdev->bd_disk->private_data; struct nd_region *nd_region = to_region(pmem); if (bio->bi_opf & REQ_PREFLUSH) ret = nvdimm_flush(nd_region, bio); - do_acct = blk_queue_io_stat(bio->bi_disk->queue); + do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue); if (do_acct) start = bio_start_io_acct(bio); bio_for_each_segment(bvec, bio, iter) { diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index bc89e8659c403f..daeb011666463c 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1050,7 +1050,7 @@ static int nvme_submit_user_cmd(struct request_queue *q, { bool write = nvme_is_write(cmd); struct nvme_ns *ns = q->queuedata; - struct gendisk *disk = ns ? ns->disk : NULL; + struct block_device *bdev = ns ? ns->disk->part0 : NULL; struct request *req; struct bio *bio = NULL; void *meta = NULL; @@ -1069,8 +1069,8 @@ static int nvme_submit_user_cmd(struct request_queue *q, if (ret) goto out; bio = req->bio; - bio->bi_disk = disk; - if (disk && meta_buffer && meta_len) { + bio->bi_bdev = bdev; + if (bdev && meta_buffer && meta_len) { meta = nvme_add_user_metadata(bio, meta_buffer, meta_len, meta_seed, write); if (IS_ERR(meta)) { diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c index 8e562d0f2c3014..3752cc349a157b 100644 --- a/drivers/nvme/host/lightnvm.c +++ b/drivers/nvme/host/lightnvm.c @@ -757,7 +757,6 @@ static int nvme_nvm_submit_user_cmd(struct request_queue *q, { bool write = nvme_is_write((struct nvme_command *)vcmd); struct nvm_dev *dev = ns->ndev; - struct gendisk *disk = ns->disk; struct request *rq; struct bio *bio = NULL; __le64 *ppa_list = NULL; @@ -817,7 +816,7 @@ static int nvme_nvm_submit_user_cmd(struct request_queue *q, vcmd->ph_rw.metadata = cpu_to_le64(metadata_dma); } - bio->bi_disk = disk; + bio->bi_bdev = ns->disk->part0; } blk_execute_rq(q, NULL, rq, 0); diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 106cf5c44ee7ab..78f992ef7bf361 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -294,7 +294,7 @@ static bool nvme_available_path(struct nvme_ns_head *head) blk_qc_t nvme_ns_head_submit_bio(struct bio *bio) { - struct nvme_ns_head *head = bio->bi_disk->private_data; + struct nvme_ns_head *head = bio->bi_bdev->bd_disk->private_data; struct device *dev = disk_to_dev(head->disk); struct nvme_ns *ns; blk_qc_t ret = BLK_QC_T_NONE; @@ -310,7 +310,7 @@ blk_qc_t nvme_ns_head_submit_bio(struct bio *bio) srcu_idx = srcu_read_lock(&head->srcu); ns = nvme_find_path(head); if (likely(ns)) { - bio->bi_disk = ns->disk; + bio->bi_bdev = ns->disk->part0; bio->bi_opf |= REQ_NVME_MPATH; trace_block_bio_remap(bio, disk_devt(ns->head->disk), bio->bi_iter.bi_sector); @@ -350,7 +350,7 @@ static void nvme_requeue_work(struct work_struct *work) * Reset disk to the mpath node and resubmit to select a new * path. */ - bio->bi_disk = head->disk; + bio->bi_bdev = head->disk->part0; submit_bio_noacct(bio); } } diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 65e3d0ef36e1a3..e01592d60a86dd 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c @@ -1461,7 +1461,7 @@ static int nvme_rdma_map_sg_pi(struct nvme_rdma_queue *queue, if (unlikely(nr)) goto mr_put; - nvme_rdma_set_sig_attrs(blk_get_integrity(bio->bi_disk), c, + nvme_rdma_set_sig_attrs(blk_get_integrity(bio->bi_bdev->bd_disk), c, req->mr->sig_attrs, ns->pi_type); nvme_rdma_set_prot_checks(c, &req->mr->sig_attrs->check_mask); diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 5c5cff3f237452..da33cb4cba28eb 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -879,7 +879,7 @@ dcssblk_submit_bio(struct bio *bio) blk_queue_split(&bio); bytes_done = 0; - dev_info = bio->bi_disk->private_data; + dev_info = bio->bi_bdev->bd_disk->private_data; if (dev_info == NULL) goto fail; if ((bio->bi_iter.bi_sector & 7) != 0 || diff --git a/drivers/s390/block/xpram.c b/drivers/s390/block/xpram.c index c2536f7767b366..d1ed39162943d5 100644 --- a/drivers/s390/block/xpram.c +++ b/drivers/s390/block/xpram.c @@ -184,7 +184,7 @@ static unsigned long xpram_highest_page_index(void) */ static blk_qc_t xpram_submit_bio(struct bio *bio) { - xpram_device_t *xdev = bio->bi_disk->private_data; + xpram_device_t *xdev = bio->bi_bdev->bd_disk->private_data; struct bio_vec bvec; struct bvec_iter iter; unsigned int index; diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 81a8c87a5afbb2..8791ad9b3ca5be 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c @@ -2677,7 +2677,7 @@ static void __btrfsic_submit_bio(struct bio *bio) mutex_lock(&btrfsic_mutex); /* since btrfsic_submit_bio() is also called before * btrfsic_mount(), this might return NULL */ - dev_state = btrfsic_dev_state_lookup(bio_dev(bio) + bio->bi_partno); + dev_state = btrfsic_dev_state_lookup(bio->bi_bdev->bd_dev); if (NULL != dev_state && (bio_op(bio) == REQ_OP_WRITE) && bio_has_data(bio)) { unsigned int i = 0; @@ -2693,10 +2693,10 @@ static void __btrfsic_submit_bio(struct bio *bio) bio_is_patched = 0; if (dev_state->state->print_mask & BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH) - pr_info("submit_bio(rw=%d,0x%x, bi_vcnt=%u, bi_sector=%llu (bytenr %llu), bi_disk=%p)\n", + pr_info("submit_bio(rw=%d,0x%x, bi_vcnt=%u, bi_sector=%llu (bytenr %llu), bi_bdev=%p)\n", bio_op(bio), bio->bi_opf, segs, (unsigned long long)bio->bi_iter.bi_sector, - dev_bytenr, bio->bi_disk); + dev_bytenr, bio->bi_bdev); mapped_datav = kmalloc_array(segs, sizeof(*mapped_datav), GFP_NOFS); @@ -2725,8 +2725,8 @@ static void __btrfsic_submit_bio(struct bio *bio) } else if (NULL != dev_state && (bio->bi_opf & REQ_PREFLUSH)) { if (dev_state->state->print_mask & BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH) - pr_info("submit_bio(rw=%d,0x%x FLUSH, disk=%p)\n", - bio_op(bio), bio->bi_opf, bio->bi_disk); + pr_info("submit_bio(rw=%d,0x%x FLUSH, bdev=%p)\n", + bio_op(bio), bio->bi_opf, bio->bi_bdev); if (!dev_state->dummy_block_for_bio_bh_flush.is_iodone) { if ((dev_state->state->print_mask & (BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH | diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c index 255490f42b5d5b..2a4d4484500a4f 100644 --- a/fs/btrfs/raid56.c +++ b/fs/btrfs/raid56.c @@ -1105,8 +1105,7 @@ static int rbio_add_io_page(struct btrfs_raid_bio *rbio, * devices or if they are not contiguous */ if (last_end == disk_start && !last->bi_status && - last->bi_disk == stripe->dev->bdev->bd_disk && - last->bi_partno == stripe->dev->bdev->bd_partno) { + last->bi_bdev == stripe->dev->bdev) { ret = bio_add_page(last, page, PAGE_SIZE, 0); if (ret == PAGE_SIZE) return 0; @@ -1357,9 +1356,7 @@ static int find_bio_stripe(struct btrfs_raid_bio *rbio, for (i = 0; i < rbio->bbio->num_stripes; i++) { stripe = &rbio->bbio->stripes[i]; if (in_range(physical, stripe->physical, rbio->stripe_len) && - stripe->dev->bdev && - bio->bi_disk == stripe->dev->bdev->bd_disk && - bio->bi_partno == stripe->dev->bdev->bd_partno) { + stripe->dev->bdev && bio->bi_bdev == stripe->dev->bdev) { return i; } } diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index e71e7586e9eb06..45d6f770ccdce1 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -1698,7 +1698,7 @@ static void scrub_wr_submit(struct scrub_ctx *sctx) sbio = sctx->wr_curr_bio; sctx->wr_curr_bio = NULL; - WARN_ON(!sbio->bio->bi_disk); + WARN_ON(!sbio->bio->bi_bdev); scrub_pending_bio_inc(sctx); /* process all writes in a single worker thread. Then the block layer * orders the requests before sending them to the driver which diff --git a/fs/direct-io.c b/fs/direct-io.c index d53fa92a1ab656..2660e744da2d81 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -434,7 +434,7 @@ static inline void dio_bio_submit(struct dio *dio, struct dio_submit *sdio) if (dio->is_async && dio->op == REQ_OP_READ && dio->should_dirty) bio_set_pages_dirty(bio); - dio->bio_disk = bio->bi_disk; + dio->bio_disk = bio->bi_bdev->bd_disk; if (sdio->submit_io) { sdio->submit_io(bio, dio->inode, sdio->logical_offset_in_bio); diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index be4da52604edc1..9a2936187d8585 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -427,16 +427,6 @@ int f2fs_target_device_index(struct f2fs_sb_info *sbi, block_t blkaddr) return 0; } -/* - * Return true, if pre_bio's bdev is same as its target device. - */ -static bool __same_bdev(struct f2fs_sb_info *sbi, - block_t blk_addr, struct bio *bio) -{ - struct block_device *b = f2fs_target_device(sbi, blk_addr, NULL); - return bio->bi_disk == b->bd_disk && bio->bi_partno == b->bd_partno; -} - static struct bio *__bio_alloc(struct f2fs_io_info *fio, int npages) { struct f2fs_sb_info *sbi = fio->sbi; @@ -738,7 +728,7 @@ static bool page_is_mergeable(struct f2fs_sb_info *sbi, struct bio *bio, { if (last_blkaddr + 1 != cur_blkaddr) return false; - return __same_bdev(sbi, cur_blkaddr, bio); + return bio->bi_bdev == f2fs_target_device(sbi, cur_blkaddr, NULL); } static bool io_type_is_mergeable(struct f2fs_bio_info *io, diff --git a/include/linux/bio.h b/include/linux/bio.h index ecf67108f091d7..149e367619fcbe 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -470,24 +470,22 @@ extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int); extern unsigned int bvec_nr_vecs(unsigned short idx); extern const char *bio_devname(struct bio *bio, char *buffer); -#define bio_set_dev(bio, bdev) \ -do { \ - if ((bio)->bi_disk != (bdev)->bd_disk) \ - bio_clear_flag(bio, BIO_THROTTLED);\ - (bio)->bi_disk = (bdev)->bd_disk; \ - (bio)->bi_partno = (bdev)->bd_partno; \ - bio_associate_blkg(bio); \ +#define bio_set_dev(bio, bdev) \ +do { \ + if ((bio)->bi_bdev != (bdev)) \ + bio_clear_flag(bio, BIO_THROTTLED); \ + (bio)->bi_bdev = (bdev); \ + bio_associate_blkg(bio); \ } while (0) #define bio_copy_dev(dst, src) \ do { \ - (dst)->bi_disk = (src)->bi_disk; \ - (dst)->bi_partno = (src)->bi_partno; \ + (dst)->bi_bdev = (src)->bi_bdev; \ bio_clone_blkg_association(dst, src); \ } while (0) #define bio_dev(bio) \ - disk_devt((bio)->bi_disk) + disk_devt((bio)->bi_bdev->bd_disk) #ifdef CONFIG_BLK_CGROUP void bio_associate_blkg(struct bio *bio); diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 866f74261b3ba8..8ebd8be3e05082 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -222,7 +222,7 @@ static inline void bio_issue_init(struct bio_issue *issue, */ struct bio { struct bio *bi_next; /* request queue link */ - struct gendisk *bi_disk; + struct block_device *bi_bdev; unsigned int bi_opf; /* bottom bits req flags, * top bits REQ_OP. Use * accessors. @@ -231,7 +231,6 @@ struct bio { unsigned short bi_ioprio; unsigned short bi_write_hint; blk_status_t bi_status; - u8 bi_partno; atomic_t __bi_remaining; struct bvec_iter bi_iter; diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 17cedf0dc83db0..989c5d19eb7d2d 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1956,7 +1956,8 @@ void part_end_io_acct(struct block_device *part, struct bio *bio, */ static inline unsigned long bio_start_io_acct(struct bio *bio) { - return disk_start_io_acct(bio->bi_disk, bio_sectors(bio), bio_op(bio)); + return disk_start_io_acct(bio->bi_bdev->bd_disk, bio_sectors(bio), + bio_op(bio)); } /** @@ -1966,7 +1967,7 @@ static inline unsigned long bio_start_io_acct(struct bio *bio) */ static inline void bio_end_io_acct(struct bio *bio, unsigned long start_time) { - return disk_end_io_acct(bio->bi_disk, bio_op(bio), start_time); + return disk_end_io_acct(bio->bi_bdev->bd_disk, bio_op(bio), start_time); } int bdev_read_only(struct block_device *bdev); diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index 7839a78205c243..774f965d9aca3c 100644 --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c @@ -903,7 +903,7 @@ static void blk_add_trace_bio(struct request_queue *q, struct bio *bio, static void blk_add_trace_bio_bounce(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_BOUNCE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_BOUNCE, 0); } static void blk_add_trace_bio_complete(void *ignore, @@ -915,22 +915,24 @@ static void blk_add_trace_bio_complete(void *ignore, static void blk_add_trace_bio_backmerge(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_BACKMERGE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_BACKMERGE, + 0); } static void blk_add_trace_bio_frontmerge(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_FRONTMERGE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_FRONTMERGE, + 0); } static void blk_add_trace_bio_queue(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_QUEUE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_QUEUE, 0); } static void blk_add_trace_getrq(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_GETRQ, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_GETRQ, 0); } static void blk_add_trace_plug(void *ignore, struct request_queue *q) @@ -967,7 +969,7 @@ static void blk_add_trace_unplug(void *ignore, struct request_queue *q, static void blk_add_trace_split(void *ignore, struct bio *bio, unsigned int pdu) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct blk_trace *bt; rcu_read_lock(); @@ -997,7 +999,7 @@ static void blk_add_trace_split(void *ignore, struct bio *bio, unsigned int pdu) static void blk_add_trace_bio_remap(void *ignore, struct bio *bio, dev_t dev, sector_t from) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct blk_trace *bt; struct blk_io_trace_remap r; diff --git a/mm/page_io.c b/mm/page_io.c index 433df126334958..cf3c997d2b49d9 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -431,7 +431,7 @@ int swap_readpage(struct page *page, bool synchronous) ret = -ENOMEM; goto out; } - disk = bio->bi_disk; + disk = bio->bi_bdev->bd_disk; /* * Keep this task valid during swap readpage because the oom killer may * attempt to access it in the page fault retry time check. -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 3/9] block: store a block_device pointer in struct bio @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo Replace the gendisk pointer in struct bio with a pointer to the newly improved struct block device. From that the gendisk can be trivially accessed with an extra indirection, but it also allows to directly look up all information related to partition remapping. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/m68k/emu/nfblock.c | 2 +- arch/xtensa/platforms/iss/simdisk.c | 2 +- block/bio-integrity.c | 18 +++++++-------- block/bio.c | 31 +++++++++---------------- block/blk-cgroup.c | 7 +++--- block/blk-core.c | 36 +++++++++++++---------------- block/blk-crypto-fallback.c | 2 +- block/blk-crypto.c | 2 +- block/blk-merge.c | 17 +++++++------- block/blk-mq.c | 2 +- block/blk-throttle.c | 2 +- block/blk.h | 6 ++--- block/bounce.c | 2 +- block/genhd.c | 2 +- drivers/block/brd.c | 2 +- drivers/block/drbd/drbd_int.h | 4 ++-- drivers/block/drbd/drbd_req.c | 2 +- drivers/block/null_blk_main.c | 2 +- drivers/block/pktcdvd.c | 4 ++-- drivers/block/ps3vram.c | 2 +- drivers/block/rsxx/dev.c | 2 +- drivers/block/umem.c | 2 +- drivers/block/zram/zram_drv.c | 2 +- drivers/lightnvm/pblk-init.c | 2 +- drivers/md/bcache/debug.c | 2 +- drivers/md/bcache/request.c | 7 +++--- drivers/md/dm-bio-record.h | 9 +++----- drivers/md/dm-raid1.c | 10 ++++---- drivers/md/dm.c | 14 +++++------ drivers/md/md-linear.c | 2 +- drivers/md/md.c | 2 +- drivers/md/md.h | 6 ++--- drivers/md/raid1.c | 6 ++--- drivers/md/raid10.c | 12 +++++----- drivers/md/raid5.c | 2 +- drivers/nvdimm/blk.c | 4 ++-- drivers/nvdimm/btt.c | 4 ++-- drivers/nvdimm/pmem.c | 4 ++-- drivers/nvme/host/core.c | 6 ++--- drivers/nvme/host/lightnvm.c | 3 +-- drivers/nvme/host/multipath.c | 6 ++--- drivers/nvme/host/rdma.c | 2 +- drivers/s390/block/dcssblk.c | 2 +- drivers/s390/block/xpram.c | 2 +- fs/btrfs/check-integrity.c | 10 ++++---- fs/btrfs/raid56.c | 7 ++---- fs/btrfs/scrub.c | 2 +- fs/direct-io.c | 2 +- fs/f2fs/data.c | 12 +--------- include/linux/bio.h | 18 +++++++-------- include/linux/blk_types.h | 3 +-- include/linux/blkdev.h | 5 ++-- kernel/trace/blktrace.c | 16 +++++++------ mm/page_io.c | 2 +- 54 files changed, 153 insertions(+), 184 deletions(-) diff --git a/arch/m68k/emu/nfblock.c b/arch/m68k/emu/nfblock.c index 92d26c81244134..ba808543161a02 100644 --- a/arch/m68k/emu/nfblock.c +++ b/arch/m68k/emu/nfblock.c @@ -61,7 +61,7 @@ struct nfhd_device { static blk_qc_t nfhd_submit_bio(struct bio *bio) { - struct nfhd_device *dev = bio->bi_disk->private_data; + struct nfhd_device *dev = bio->bi_bdev->bd_disk->private_data; struct bio_vec bvec; struct bvec_iter iter; int dir, len, shift; diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index 3447556d276d32..fc09be7b13479c 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -103,7 +103,7 @@ static void simdisk_transfer(struct simdisk *dev, unsigned long sector, static blk_qc_t simdisk_submit_bio(struct bio *bio) { - struct simdisk *dev = bio->bi_disk->private_data; + struct simdisk *dev = bio->bi_bdev->bd_disk->private_data; struct bio_vec bvec; struct bvec_iter iter; sector_t sector = bio->bi_iter.bi_sector; diff --git a/block/bio-integrity.c b/block/bio-integrity.c index 9ffd7e28955476..c3e5abcfdc98c3 100644 --- a/block/bio-integrity.c +++ b/block/bio-integrity.c @@ -140,7 +140,7 @@ int bio_integrity_add_page(struct bio *bio, struct page *page, iv = bip->bip_vec + bip->bip_vcnt; if (bip->bip_vcnt && - bvec_gap_to_prev(bio->bi_disk->queue, + bvec_gap_to_prev(bio->bi_bdev->bd_disk->queue, &bip->bip_vec[bip->bip_vcnt - 1], offset)) return 0; @@ -162,7 +162,7 @@ EXPORT_SYMBOL(bio_integrity_add_page); static blk_status_t bio_integrity_process(struct bio *bio, struct bvec_iter *proc_iter, integrity_processing_fn *proc_fn) { - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); struct blk_integrity_iter iter; struct bvec_iter bviter; struct bio_vec bv; @@ -171,7 +171,7 @@ static blk_status_t bio_integrity_process(struct bio *bio, void *prot_buf = page_address(bip->bip_vec->bv_page) + bip->bip_vec->bv_offset; - iter.disk_name = bio->bi_disk->disk_name; + iter.disk_name = bio->bi_bdev->bd_disk->disk_name; iter.interval = 1 << bi->interval_exp; iter.seed = proc_iter->bi_sector; iter.prot_buf = prot_buf; @@ -208,8 +208,8 @@ static blk_status_t bio_integrity_process(struct bio *bio, bool bio_integrity_prep(struct bio *bio) { struct bio_integrity_payload *bip; - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); - struct request_queue *q = bio->bi_disk->queue; + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); + struct request_queue *q = bio->bi_bdev->bd_disk->queue; void *buf; unsigned long start, end; unsigned int len, nr_pages; @@ -329,7 +329,7 @@ static void bio_integrity_verify_fn(struct work_struct *work) struct bio_integrity_payload *bip = container_of(work, struct bio_integrity_payload, bip_work); struct bio *bio = bip->bip_bio; - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); /* * At the moment verify is called bio's iterator was advanced @@ -355,7 +355,7 @@ static void bio_integrity_verify_fn(struct work_struct *work) */ bool __bio_integrity_endio(struct bio *bio) { - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); struct bio_integrity_payload *bip = bio_integrity(bio); if (bio_op(bio) == REQ_OP_READ && !bio->bi_status && @@ -381,7 +381,7 @@ bool __bio_integrity_endio(struct bio *bio) void bio_integrity_advance(struct bio *bio, unsigned int bytes_done) { struct bio_integrity_payload *bip = bio_integrity(bio); - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); unsigned bytes = bio_integrity_bytes(bi, bytes_done >> 9); bip->bip_iter.bi_sector += bytes_done >> 9; @@ -397,7 +397,7 @@ void bio_integrity_advance(struct bio *bio, unsigned int bytes_done) void bio_integrity_trim(struct bio *bio) { struct bio_integrity_payload *bip = bio_integrity(bio); - struct blk_integrity *bi = blk_get_integrity(bio->bi_disk); + struct blk_integrity *bi = blk_get_integrity(bio->bi_bdev->bd_disk); bip->bip_iter.bi_size = bio_integrity_bytes(bi, bio_sectors(bio)); } diff --git a/block/bio.c b/block/bio.c index ebb18136b86f2f..a58afe4a50dc7a 100644 --- a/block/bio.c +++ b/block/bio.c @@ -607,16 +607,7 @@ void bio_truncate(struct bio *bio, unsigned new_size) */ void guard_bio_eod(struct bio *bio) { - sector_t maxsector; - struct block_device *part; - - rcu_read_lock(); - part = __disk_get_part(bio->bi_disk, bio->bi_partno); - if (part) - maxsector = bdev_nr_sectors(part); - else - maxsector = get_capacity(bio->bi_disk); - rcu_read_unlock(); + sector_t maxsector = bdev_nr_sectors(bio->bi_bdev); if (!maxsector) return; @@ -676,11 +667,10 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src) BUG_ON(bio->bi_pool && BVEC_POOL_IDX(bio)); /* - * most users will be overriding ->bi_disk with a new target, + * most users will be overriding ->bi_bdev with a new target, * so we don't set nor calculate new physical/hw segment counts here */ - bio->bi_disk = bio_src->bi_disk; - bio->bi_partno = bio_src->bi_partno; + bio->bi_bdev = bio_src->bi_bdev; bio_set_flag(bio, BIO_CLONED); if (bio_flagged(bio_src, BIO_THROTTLED)) bio_set_flag(bio, BIO_THROTTLED); @@ -730,7 +720,7 @@ EXPORT_SYMBOL(bio_clone_fast); const char *bio_devname(struct bio *bio, char *buf) { - return disk_name(bio->bi_disk, bio->bi_partno, buf); + return bdevname(bio->bi_bdev, buf); } EXPORT_SYMBOL(bio_devname); @@ -1037,7 +1027,7 @@ static int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter) { unsigned short nr_pages = bio->bi_max_vecs - bio->bi_vcnt; unsigned short entries_left = bio->bi_max_vecs - bio->bi_vcnt; - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; unsigned int max_append_sectors = queue_max_zone_append_sectors(q); struct bio_vec *bv = bio->bi_io_vec + bio->bi_vcnt; struct page **pages = (struct page **)bv; @@ -1145,7 +1135,8 @@ static void submit_bio_wait_endio(struct bio *bio) */ int submit_bio_wait(struct bio *bio) { - DECLARE_COMPLETION_ONSTACK_MAP(done, bio->bi_disk->lockdep_map); + DECLARE_COMPLETION_ONSTACK_MAP(done, + bio->bi_bdev->bd_disk->lockdep_map); unsigned long hang_check; bio->bi_private = &done; @@ -1422,8 +1413,8 @@ void bio_endio(struct bio *bio) if (!bio_integrity_endio(bio)) return; - if (bio->bi_disk) - rq_qos_done_bio(bio->bi_disk->queue, bio); + if (bio->bi_bdev) + rq_qos_done_bio(bio->bi_bdev->bd_disk->queue, bio); /* * Need to have a real endio function for chained bios, otherwise @@ -1438,8 +1429,8 @@ void bio_endio(struct bio *bio) goto again; } - if (bio->bi_disk && bio_flagged(bio, BIO_TRACE_COMPLETION)) { - trace_block_bio_complete(bio->bi_disk->queue, bio); + if (bio->bi_bdev && bio_flagged(bio, BIO_TRACE_COMPLETION)) { + trace_block_bio_complete(bio->bi_bdev->bd_disk->queue, bio); bio_clear_flag(bio, BIO_TRACE_COMPLETION); } diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 031114d454a604..3465d6ee708edf 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1800,7 +1800,8 @@ static inline struct blkcg_gq *blkg_tryget_closest(struct bio *bio, struct blkcg_gq *blkg, *ret_blkg = NULL; rcu_read_lock(); - blkg = blkg_lookup_create(css_to_blkcg(css), bio->bi_disk->queue); + blkg = blkg_lookup_create(css_to_blkcg(css), + bio->bi_bdev->bd_disk->queue); while (blkg) { if (blkg_tryget(blkg)) { ret_blkg = blkg; @@ -1836,8 +1837,8 @@ void bio_associate_blkg_from_css(struct bio *bio, if (css && css->parent) { bio->bi_blkg = blkg_tryget_closest(bio, css); } else { - blkg_get(bio->bi_disk->queue->root_blkg); - bio->bi_blkg = bio->bi_disk->queue->root_blkg; + blkg_get(bio->bi_bdev->bd_disk->queue->root_blkg); + bio->bi_blkg = bio->bi_bdev->bd_disk->queue->root_blkg; } } EXPORT_SYMBOL_GPL(bio_associate_blkg_from_css); diff --git a/block/blk-core.c b/block/blk-core.c index 96e5fcd7f071b6..95005a8db5ab2f 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -475,7 +475,7 @@ int blk_queue_enter(struct request_queue *q, blk_mq_req_flags_t flags) static inline int bio_queue_enter(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; bool nowait = bio->bi_opf & REQ_NOWAIT; int ret; @@ -713,7 +713,7 @@ static inline bool bio_check_ro(struct bio *bio, struct block_device *part) static noinline int should_fail_bio(struct bio *bio) { - if (should_fail_request(bio->bi_disk->part0, bio->bi_iter.bi_size)) + if (should_fail_request(bdev_whole(bio->bi_bdev), bio->bi_iter.bi_size)) return -EIO; return 0; } @@ -742,13 +742,9 @@ static inline int bio_check_eod(struct bio *bio, sector_t maxsector) */ static inline int blk_partition_remap(struct bio *bio) { - struct block_device *p; + struct block_device *p = bio->bi_bdev; int ret = -EIO; - rcu_read_lock(); - p = __disk_get_part(bio->bi_disk, bio->bi_partno); - if (unlikely(!p)) - goto out; if (unlikely(should_fail_request(p, bio->bi_iter.bi_size))) goto out; if (unlikely(bio_check_ro(bio, p))) @@ -762,10 +758,8 @@ static inline int blk_partition_remap(struct bio *bio) bio->bi_iter.bi_sector - p->bd_start_sect); } - bio->bi_partno = 0; ret = 0; out: - rcu_read_unlock(); return ret; } @@ -806,7 +800,8 @@ static inline blk_status_t blk_check_zone_append(struct request_queue *q, static noinline_for_stack bool submit_bio_checks(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct block_device *bdev = bio->bi_bdev; + struct request_queue *q = bdev->bd_disk->queue; blk_status_t status = BLK_STS_IOERR; struct blk_plug *plug; @@ -826,13 +821,13 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) if (should_fail_bio(bio)) goto end_io; - if (bio->bi_partno) { + if (bio->bi_bdev->bd_partno) { if (unlikely(blk_partition_remap(bio))) goto end_io; } else { - if (unlikely(bio_check_ro(bio, bio->bi_disk->part0))) + if (unlikely(bio_check_ro(bio, bdev_whole(bdev)))) goto end_io; - if (unlikely(bio_check_eod(bio, get_capacity(bio->bi_disk)))) + if (unlikely(bio_check_eod(bio, get_capacity(bdev->bd_disk)))) goto end_io; } @@ -925,7 +920,7 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) static blk_qc_t __submit_bio(struct bio *bio) { - struct gendisk *disk = bio->bi_disk; + struct gendisk *disk = bio->bi_bdev->bd_disk; blk_qc_t ret = BLK_QC_T_NONE; if (blk_crypto_bio_prep(&bio)) { @@ -967,7 +962,7 @@ static blk_qc_t __submit_bio_noacct(struct bio *bio) current->bio_list = bio_list_on_stack; do { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct bio_list lower, same; if (unlikely(bio_queue_enter(bio) != 0)) @@ -988,7 +983,7 @@ static blk_qc_t __submit_bio_noacct(struct bio *bio) bio_list_init(&lower); bio_list_init(&same); while ((bio = bio_list_pop(&bio_list_on_stack[0])) != NULL) - if (q == bio->bi_disk->queue) + if (q == bio->bi_bdev->bd_disk->queue) bio_list_add(&same, bio); else bio_list_add(&lower, bio); @@ -1013,7 +1008,7 @@ static blk_qc_t __submit_bio_noacct_mq(struct bio *bio) current->bio_list = bio_list; do { - struct gendisk *disk = bio->bi_disk; + struct gendisk *disk = bio->bi_bdev->bd_disk; if (unlikely(bio_queue_enter(bio) != 0)) continue; @@ -1056,7 +1051,7 @@ blk_qc_t submit_bio_noacct(struct bio *bio) return BLK_QC_T_NONE; } - if (!bio->bi_disk->fops->submit_bio) + if (!bio->bi_bdev->bd_disk->fops->submit_bio) return __submit_bio_noacct_mq(bio); return __submit_bio_noacct(bio); } @@ -1068,7 +1063,7 @@ EXPORT_SYMBOL(submit_bio_noacct); * * submit_bio() is used to submit I/O requests to block devices. It is passed a * fully set up &struct bio that describes the I/O that needs to be done. The - * bio will be send to the device described by the bi_disk and bi_partno fields. + * bio will be send to the device described by the bi_bdev field. * * The success/failure status of the request, along with notification of * completion, is delivered asynchronously through the ->bi_end_io() callback @@ -1088,7 +1083,8 @@ blk_qc_t submit_bio(struct bio *bio) unsigned int count; if (unlikely(bio_op(bio) == REQ_OP_WRITE_SAME)) - count = queue_logical_block_size(bio->bi_disk->queue) >> 9; + count = queue_logical_block_size( + bio->bi_bdev->bd_disk->queue) >> 9; else count = bio_sectors(bio); diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c index c162b754efbd6a..8f1e1817673115 100644 --- a/block/blk-crypto-fallback.c +++ b/block/blk-crypto-fallback.c @@ -167,7 +167,7 @@ static struct bio *blk_crypto_clone_bio(struct bio *bio_src) bio = bio_alloc_bioset(GFP_NOIO, bio_segments(bio_src), NULL); if (!bio) return NULL; - bio->bi_disk = bio_src->bi_disk; + bio->bi_bdev = bio_src->bi_bdev; bio->bi_opf = bio_src->bi_opf; bio->bi_ioprio = bio_src->bi_ioprio; bio->bi_write_hint = bio_src->bi_write_hint; diff --git a/block/blk-crypto.c b/block/blk-crypto.c index 5da43f0973b46b..09fcb18fa778fa 100644 --- a/block/blk-crypto.c +++ b/block/blk-crypto.c @@ -280,7 +280,7 @@ bool __blk_crypto_bio_prep(struct bio **bio_ptr) * Success if device supports the encryption context, or if we succeeded * in falling back to the crypto API. */ - if (blk_ksm_crypto_cfg_supported(bio->bi_disk->queue->ksm, + if (blk_ksm_crypto_cfg_supported(bio->bi_bdev->bd_disk->queue->ksm, &bc_key->crypto_cfg)) return true; diff --git a/block/blk-merge.c b/block/blk-merge.c index 7497d86fff3834..30707a4acd1f9b 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -290,14 +290,13 @@ static struct bio *blk_bio_segment_split(struct request_queue *q, * Split a bio into two bios, chain the two bios, submit the second half and * store a pointer to the first half in *@bio. If the second bio is still too * big it will be split by a recursive call to this function. Since this - * function may allocate a new bio from @bio->bi_disk->queue->bio_split, it is - * the responsibility of the caller to ensure that - * @bio->bi_disk->queue->bio_split is only released after processing of the - * split bio has finished. + * function may allocate a new bio from q->bio_split, it is the responsibility + * of the caller to ensure that q->bio_split is only released after processing + * of the split bio has finished. */ void __blk_queue_split(struct bio **bio, unsigned int *nr_segs) { - struct request_queue *q = (*bio)->bi_disk->queue; + struct request_queue *q = (*bio)->bi_bdev->bd_disk->queue; struct bio *split = NULL; switch (bio_op(*bio)) { @@ -350,9 +349,9 @@ void __blk_queue_split(struct bio **bio, unsigned int *nr_segs) * * Split a bio into two bios, chains the two bios, submit the second half and * store a pointer to the first half in *@bio. Since this function may allocate - * a new bio from @bio->bi_disk->queue->bio_split, it is the responsibility of - * the caller to ensure that @bio->bi_disk->queue->bio_split is only released - * after processing of the split bio has finished. + * a new bio from q->bio_split, it is the responsibility of the caller to ensure + * that q->bio_split is only released after processing of the split bio has + * finished. */ void blk_queue_split(struct bio **bio) { @@ -858,7 +857,7 @@ bool blk_rq_merge_ok(struct request *rq, struct bio *bio) return false; /* must be same device */ - if (rq->rq_disk != bio->bi_disk) + if (rq->rq_disk != bio->bi_bdev->bd_disk) return false; /* only merge integrity protected bio into ditto rq */ diff --git a/block/blk-mq.c b/block/blk-mq.c index bb669b415a387e..e9e5c0487d2813 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2146,7 +2146,7 @@ static void blk_add_rq_to_plug(struct blk_plug *plug, struct request *rq) */ blk_qc_t blk_mq_submit_bio(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; const int is_sync = op_is_sync(bio->bi_opf); const int is_flush_fua = op_is_flush(bio->bi_opf); struct blk_mq_alloc_data data = { diff --git a/block/blk-throttle.c b/block/blk-throttle.c index b771c42999827c..73589f8e187ebd 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -2172,7 +2172,7 @@ static inline void throtl_update_latency_buckets(struct throtl_data *td) bool blk_throtl_bio(struct bio *bio) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct blkcg_gq *blkg = bio->bi_blkg; struct throtl_qnode *qn = NULL; struct throtl_grp *tg = blkg_to_tg(blkg); diff --git a/block/blk.h b/block/blk.h index 98f0b1ae264120..64dc8e5a3f44cb 100644 --- a/block/blk.h +++ b/block/blk.h @@ -99,8 +99,8 @@ static inline void blk_rq_bio_prep(struct request *rq, struct bio *bio, rq->bio = rq->biotail = bio; rq->ioprio = bio_prio(bio); - if (bio->bi_disk) - rq->rq_disk = bio->bi_disk; + if (bio->bi_bdev) + rq->rq_disk = bio->bi_bdev->bd_disk; } #ifdef CONFIG_BLK_DEV_INTEGRITY @@ -215,8 +215,6 @@ static inline void elevator_exit(struct request_queue *q, __elevator_exit(q, e); } -struct block_device *__disk_get_part(struct gendisk *disk, int partno); - ssize_t part_size_show(struct device *dev, struct device_attribute *attr, char *buf); ssize_t part_stat_show(struct device *dev, struct device_attribute *attr, diff --git a/block/bounce.c b/block/bounce.c index d3f51acd6e3b51..a22a8a1942b24f 100644 --- a/block/bounce.c +++ b/block/bounce.c @@ -246,7 +246,7 @@ static struct bio *bounce_clone_bio(struct bio *bio_src, gfp_t gfp_mask, bio = bio_alloc_bioset(gfp_mask, bio_segments(bio_src), bs); if (!bio) return NULL; - bio->bi_disk = bio_src->bi_disk; + bio->bi_bdev = bio_src->bi_bdev; bio->bi_opf = bio_src->bi_opf; bio->bi_ioprio = bio_src->bi_ioprio; bio->bi_write_hint = bio_src->bi_write_hint; diff --git a/block/genhd.c b/block/genhd.c index b84b8671e6270a..57c709a9f90267 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -159,7 +159,7 @@ static void part_in_flight_rw(struct block_device *part, inflight[1] = 0; } -struct block_device *__disk_get_part(struct gendisk *disk, int partno) +static struct block_device *__disk_get_part(struct gendisk *disk, int partno) { struct disk_part_tbl *ptbl = rcu_dereference(disk->part_tbl); diff --git a/drivers/block/brd.c b/drivers/block/brd.c index c7c8214190795c..18bf9990666207 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -284,7 +284,7 @@ static int brd_do_bvec(struct brd_device *brd, struct page *page, static blk_qc_t brd_submit_bio(struct bio *bio) { - struct brd_device *brd = bio->bi_disk->private_data; + struct brd_device *brd = bio->bi_bdev->bd_disk->private_data; sector_t sector = bio->bi_iter.bi_sector; struct bio_vec bvec; struct bvec_iter iter; diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index 8f879e5c2f6706..b2c93a29c251fd 100644 --- a/drivers/block/drbd/drbd_int.h +++ b/drivers/block/drbd/drbd_int.h @@ -1579,8 +1579,8 @@ static inline void drbd_submit_bio_noacct(struct drbd_device *device, int fault_type, struct bio *bio) { __release(local); - if (!bio->bi_disk) { - drbd_err(device, "drbd_submit_bio_noacct: bio->bi_disk == NULL\n"); + if (!bio->bi_bdev) { + drbd_err(device, "drbd_submit_bio_noacct: bio->bi_bdev == NULL\n"); bio->bi_status = BLK_STS_IOERR; bio_endio(bio); return; diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 330f851cb8f0b0..ea0f31ab334361 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -1595,7 +1595,7 @@ void do_submit(struct work_struct *ws) blk_qc_t drbd_submit_bio(struct bio *bio) { - struct drbd_device *device = bio->bi_disk->private_data; + struct drbd_device *device = bio->bi_bdev->bd_disk->private_data; unsigned long start_jif; blk_queue_split(&bio); diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c index 4685ea401d5b12..783a9629e2944e 100644 --- a/drivers/block/null_blk_main.c +++ b/drivers/block/null_blk_main.c @@ -1418,7 +1418,7 @@ static blk_qc_t null_submit_bio(struct bio *bio) { sector_t sector = bio->bi_iter.bi_sector; sector_t nr_sectors = bio_sectors(bio); - struct nullb *nullb = bio->bi_disk->private_data; + struct nullb *nullb = bio->bi_bdev->bd_disk->private_data; struct nullb_queue *nq = nullb_to_queue(nullb); struct nullb_cmd *cmd; diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index b8bb8ec7538d9b..658a0981cb5471 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2374,7 +2374,7 @@ static blk_qc_t pkt_submit_bio(struct bio *bio) blk_queue_split(&bio); - pd = bio->bi_disk->queue->queuedata; + pd = bio->bi_bdev->bd_disk->queue->queuedata; if (!pd) { pr_err("%s incorrect request queue\n", bio_devname(bio, b)); goto end_io; @@ -2418,7 +2418,7 @@ static blk_qc_t pkt_submit_bio(struct bio *bio) split = bio; } - pkt_make_request_write(bio->bi_disk->queue, split); + pkt_make_request_write(bio->bi_bdev->bd_disk->queue, split); } while (split != bio); return BLK_QC_T_NONE; diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index 1088798c8dd0c9..511403cc6317a1 100644 --- a/drivers/block/ps3vram.c +++ b/drivers/block/ps3vram.c @@ -581,7 +581,7 @@ static struct bio *ps3vram_do_bio(struct ps3_system_bus_device *dev, static blk_qc_t ps3vram_submit_bio(struct bio *bio) { - struct ps3_system_bus_device *dev = bio->bi_disk->private_data; + struct ps3_system_bus_device *dev = bio->bi_bdev->bd_disk->private_data; struct ps3vram_priv *priv = ps3_system_bus_get_drvdata(dev); int busy; diff --git a/drivers/block/rsxx/dev.c b/drivers/block/rsxx/dev.c index edacefff6e355b..9a28322a8cd893 100644 --- a/drivers/block/rsxx/dev.c +++ b/drivers/block/rsxx/dev.c @@ -122,7 +122,7 @@ static void bio_dma_done_cb(struct rsxx_cardinfo *card, static blk_qc_t rsxx_submit_bio(struct bio *bio) { - struct rsxx_cardinfo *card = bio->bi_disk->private_data; + struct rsxx_cardinfo *card = bio->bi_bdev->bd_disk->private_data; struct rsxx_bio_meta *bio_meta; blk_status_t st = BLK_STS_IOERR; diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 2b95d7b33b9186..982732dbe82e69 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -521,7 +521,7 @@ static int mm_check_plugged(struct cardinfo *card) static blk_qc_t mm_submit_bio(struct bio *bio) { - struct cardinfo *card = bio->bi_disk->private_data; + struct cardinfo *card = bio->bi_bdev->bd_disk->private_data; pr_debug("mm_make_request %llu %u\n", (unsigned long long)bio->bi_iter.bi_sector, diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index b0701bae6e9800..f2807fd98e703c 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1581,7 +1581,7 @@ static void __zram_make_request(struct zram *zram, struct bio *bio) */ static blk_qc_t zram_submit_bio(struct bio *bio) { - struct zram *zram = bio->bi_disk->private_data; + struct zram *zram = bio->bi_bdev->bd_disk->private_data; if (!valid_io_request(zram, bio->bi_iter.bi_sector, bio->bi_iter.bi_size)) { diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index b6246f73895cf8..5924f09c217b62 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -49,7 +49,7 @@ struct bio_set pblk_bio_set; static blk_qc_t pblk_submit_bio(struct bio *bio) { - struct pblk *pblk = bio->bi_disk->queue->queuedata; + struct pblk *pblk = bio->bi_bdev->bd_disk->queue->queuedata; if (bio_op(bio) == REQ_OP_DISCARD) { pblk_discard(pblk, bio); diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c index b00fd08d696b5f..058dd80144281e 100644 --- a/drivers/md/bcache/debug.c +++ b/drivers/md/bcache/debug.c @@ -114,7 +114,7 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio) check = bio_kmalloc(GFP_NOIO, bio_segments(bio)); if (!check) return; - check->bi_disk = bio->bi_disk; + check->bi_bdev = bio->bi_bdev; check->bi_opf = REQ_OP_READ; check->bi_iter.bi_sector = bio->bi_iter.bi_sector; check->bi_iter.bi_size = bio->bi_iter.bi_size; diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index 85b1f2a9b72d68..dfc35d6d05ed1c 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -894,7 +894,8 @@ static int cached_dev_cache_miss(struct btree *b, struct search *s, !(bio->bi_opf & (REQ_META|REQ_PRIO)) && s->iop.c->gc_stats.in_use < CUTOFF_CACHE_READA) reada = min_t(sector_t, dc->readahead >> 9, - get_capacity(bio->bi_disk) - bio_end_sector(bio)); + get_capacity(bio->bi_bdev->bd_disk) - + bio_end_sector(bio)); s->insert_bio_sectors = min(sectors, bio_sectors(bio) + reada); @@ -1167,7 +1168,7 @@ static void quit_max_writeback_rate(struct cache_set *c, blk_qc_t cached_dev_submit_bio(struct bio *bio) { struct search *s; - struct bcache_device *d = bio->bi_disk->private_data; + struct bcache_device *d = bio->bi_bdev->bd_disk->private_data; struct cached_dev *dc = container_of(d, struct cached_dev, disk); int rw = bio_data_dir(bio); @@ -1274,7 +1275,7 @@ blk_qc_t flash_dev_submit_bio(struct bio *bio) { struct search *s; struct closure *cl; - struct bcache_device *d = bio->bi_disk->private_data; + struct bcache_device *d = bio->bi_bdev->bd_disk->private_data; if (unlikely(d->c && test_bit(CACHE_SET_IO_DISABLE, &d->c->flags))) { bio->bi_status = BLK_STS_IOERR; diff --git a/drivers/md/dm-bio-record.h b/drivers/md/dm-bio-record.h index 2ea0360108e1d4..a3b71350eec84e 100644 --- a/drivers/md/dm-bio-record.h +++ b/drivers/md/dm-bio-record.h @@ -18,8 +18,7 @@ */ struct dm_bio_details { - struct gendisk *bi_disk; - u8 bi_partno; + struct block_device *bi_bdev; int __bi_remaining; unsigned long bi_flags; struct bvec_iter bi_iter; @@ -31,8 +30,7 @@ struct dm_bio_details { static inline void dm_bio_record(struct dm_bio_details *bd, struct bio *bio) { - bd->bi_disk = bio->bi_disk; - bd->bi_partno = bio->bi_partno; + bd->bi_bdev = bio->bi_bdev; bd->bi_flags = bio->bi_flags; bd->bi_iter = bio->bi_iter; bd->__bi_remaining = atomic_read(&bio->__bi_remaining); @@ -44,8 +42,7 @@ static inline void dm_bio_record(struct dm_bio_details *bd, struct bio *bio) static inline void dm_bio_restore(struct dm_bio_details *bd, struct bio *bio) { - bio->bi_disk = bd->bi_disk; - bio->bi_partno = bd->bi_partno; + bio->bi_bdev = bd->bi_bdev; bio->bi_flags = bd->bi_flags; bio->bi_iter = bd->bi_iter; atomic_set(&bio->__bi_remaining, bd->__bi_remaining); diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c index fa09bc4e4c54a1..b0a82f29a2e451 100644 --- a/drivers/md/dm-raid1.c +++ b/drivers/md/dm-raid1.c @@ -145,7 +145,7 @@ static void dispatch_bios(void *context, struct bio_list *bio_list) struct dm_raid1_bio_record { struct mirror *m; - /* if details->bi_disk == NULL, details were not saved */ + /* if details->bi_bdev == NULL, details were not saved */ struct dm_bio_details details; region_t write_region; }; @@ -1190,7 +1190,7 @@ static int mirror_map(struct dm_target *ti, struct bio *bio) struct dm_raid1_bio_record *bio_record = dm_per_bio_data(bio, sizeof(struct dm_raid1_bio_record)); - bio_record->details.bi_disk = NULL; + bio_record->details.bi_bdev = NULL; if (rw == WRITE) { /* Save region for mirror_end_io() handler */ @@ -1257,7 +1257,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, goto out; if (unlikely(*error)) { - if (!bio_record->details.bi_disk) { + if (!bio_record->details.bi_bdev) { /* * There wasn't enough memory to record necessary * information for a retry or there was no other @@ -1282,7 +1282,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, bd = &bio_record->details; dm_bio_restore(bd, bio); - bio_record->details.bi_disk = NULL; + bio_record->details.bi_bdev = NULL; bio->bi_status = 0; queue_bio(ms, bio, rw); @@ -1292,7 +1292,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, } out: - bio_record->details.bi_disk = NULL; + bio_record->details.bi_bdev = NULL; return DM_ENDIO_DONE; } diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 5181907dc59537..1c8a8c3c1aca0e 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -977,16 +977,17 @@ static void clone_endio(struct bio *bio) struct mapped_device *md = tio->io->md; dm_endio_fn endio = tio->ti->type->end_io; struct bio *orig_bio = io->orig_bio; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; if (unlikely(error == BLK_STS_TARGET)) { if (bio_op(bio) == REQ_OP_DISCARD && - !bio->bi_disk->queue->limits.max_discard_sectors) + !q->limits.max_discard_sectors) disable_discard(md); else if (bio_op(bio) == REQ_OP_WRITE_SAME && - !bio->bi_disk->queue->limits.max_write_same_sectors) + !q->limits.max_write_same_sectors) disable_write_same(md); else if (bio_op(bio) == REQ_OP_WRITE_ZEROES && - !bio->bi_disk->queue->limits.max_write_zeroes_sectors) + !q->limits.max_write_zeroes_sectors) disable_write_zeroes(md); } @@ -996,7 +997,7 @@ static void clone_endio(struct bio *bio) */ if (bio_op(orig_bio) == REQ_OP_ZONE_APPEND) { sector_t written_sector = bio->bi_iter.bi_sector; - struct request_queue *q = orig_bio->bi_disk->queue; + struct request_queue *q = orig_bio->bi_bdev->bd_disk->queue; u64 mask = (u64)blk_queue_zone_sectors(q) - 1; orig_bio->bi_iter.bi_sector += written_sector & mask; @@ -1421,8 +1422,7 @@ static int __send_empty_flush(struct clone_info *ci) */ bio_init(&flush_bio, NULL, 0); flush_bio.bi_opf = REQ_OP_WRITE | REQ_PREFLUSH | REQ_SYNC; - flush_bio.bi_disk = ci->io->md->disk; - bio_associate_blkg(&flush_bio); + bio_set_dev(&flush_bio, ci->io->md->disk->part0); ci->bio = &flush_bio; ci->sector_count = 0; @@ -1625,7 +1625,7 @@ static blk_qc_t __split_and_process_bio(struct mapped_device *md, static blk_qc_t dm_submit_bio(struct bio *bio) { - struct mapped_device *md = bio->bi_disk->private_data; + struct mapped_device *md = bio->bi_bdev->bd_disk->private_data; blk_qc_t ret = BLK_QC_T_NONE; int srcu_idx; struct dm_table *map; diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c index 68cac7d1927823..63ed8329a98d01 100644 --- a/drivers/md/md-linear.c +++ b/drivers/md/md-linear.c @@ -252,7 +252,7 @@ static bool linear_make_request(struct mddev *mddev, struct bio *bio) start_sector + data_offset; if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) { + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) { /* Just ignore it */ bio_endio(bio); } else { diff --git a/drivers/md/md.c b/drivers/md/md.c index c555be0a8dce78..3e72fc24f80f57 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -486,7 +486,7 @@ static void md_end_io(struct bio *bio) static blk_qc_t md_submit_bio(struct bio *bio) { const int rw = bio_data_dir(bio); - struct mddev *mddev = bio->bi_disk->private_data; + struct mddev *mddev = bio->bi_bdev->bd_disk->private_data; if (mddev == NULL || mddev->pers == NULL) { bio_io_error(bio); diff --git a/drivers/md/md.h b/drivers/md/md.h index ccfb69868c2ec9..b6939df0754d25 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -556,7 +556,7 @@ static inline void md_sync_acct(struct block_device *bdev, unsigned long nr_sect static inline void md_sync_acct_bio(struct bio *bio, unsigned long nr_sectors) { - atomic_add(nr_sectors, &bio->bi_disk->sync_io); + md_sync_acct(bio->bi_bdev, nr_sectors); } struct md_personality @@ -795,14 +795,14 @@ static inline void mddev_clear_unsupported_flags(struct mddev *mddev, static inline void mddev_check_writesame(struct mddev *mddev, struct bio *bio) { if (bio_op(bio) == REQ_OP_WRITE_SAME && - !bio->bi_disk->queue->limits.max_write_same_sectors) + !bio->bi_bdev->bd_disk->queue->limits.max_write_same_sectors) mddev->queue->limits.max_write_same_sectors = 0; } static inline void mddev_check_write_zeroes(struct mddev *mddev, struct bio *bio) { if (bio_op(bio) == REQ_OP_WRITE_ZEROES && - !bio->bi_disk->queue->limits.max_write_zeroes_sectors) + !bio->bi_bdev->bd_disk->queue->limits.max_write_zeroes_sectors) mddev->queue->limits.max_write_zeroes_sectors = 0; } diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index c0347997f6ff73..3b19141cdb4bc2 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -794,13 +794,13 @@ static void flush_bio_list(struct r1conf *conf, struct bio *bio) while (bio) { /* submit pending writes */ struct bio *next = bio->bi_next; - struct md_rdev *rdev = (void *)bio->bi_disk; + struct md_rdev *rdev = (void *)bio->bi_bdev; bio->bi_next = NULL; bio_set_dev(bio, rdev->bdev); if (test_bit(Faulty, &rdev->flags)) { bio_io_error(bio); } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) /* Just ignore it */ bio_endio(bio); else @@ -1520,7 +1520,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio, trace_block_bio_remap(mbio, disk_devt(mddev->gendisk), r1_bio->sector); /* flush_pending_writes() needs access to the rdev so...*/ - mbio->bi_disk = (void *)conf->mirrors[i].rdev; + mbio->bi_bdev = (void *)conf->mirrors[i].rdev; cb = blk_check_plugged(raid1_unplug, mddev, sizeof(*plug)); if (cb) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index a6f99fa0b32cfc..34f8116c88ddb3 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -881,13 +881,13 @@ static void flush_pending_writes(struct r10conf *conf) while (bio) { /* submit pending writes */ struct bio *next = bio->bi_next; - struct md_rdev *rdev = (void*)bio->bi_disk; + struct md_rdev *rdev = (void*)bio->bi_bdev; bio->bi_next = NULL; bio_set_dev(bio, rdev->bdev); if (test_bit(Faulty, &rdev->flags)) { bio_io_error(bio); } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) /* Just ignore it */ bio_endio(bio); else @@ -1074,13 +1074,13 @@ static void raid10_unplug(struct blk_plug_cb *cb, bool from_schedule) while (bio) { /* submit pending writes */ struct bio *next = bio->bi_next; - struct md_rdev *rdev = (void*)bio->bi_disk; + struct md_rdev *rdev = (void*)bio->bi_bdev; bio->bi_next = NULL; bio_set_dev(bio, rdev->bdev); if (test_bit(Faulty, &rdev->flags)) { bio_io_error(bio); } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !blk_queue_discard(bio->bi_disk->queue))) + !blk_queue_discard(bio->bi_bdev->bd_disk->queue))) /* Just ignore it */ bio_endio(bio); else @@ -1252,7 +1252,7 @@ static void raid10_write_one_disk(struct mddev *mddev, struct r10bio *r10_bio, trace_block_bio_remap(mbio, disk_devt(conf->mddev->gendisk), r10_bio->sector); /* flush_pending_writes() needs access to the rdev so...*/ - mbio->bi_disk = (void *)rdev; + mbio->bi_bdev = (void *)rdev; atomic_inc(&r10_bio->remaining); @@ -3311,7 +3311,7 @@ static sector_t raid10_sync_request(struct mddev *mddev, sector_t sector_nr, /* Again, very different code for resync and recovery. * Both must result in an r10bio with a list of bios that - * have bi_end_io, bi_sector, bi_disk set, + * have bi_end_io, bi_sector, bi_bdev set, * and bi_private set to the r10bio. * For recovery, we may actually create several r10bios * with 2 bios in each, that correspond to the bios in the main one. diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 3a90cc0e43ca8e..f411b9e5c332f4 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -5310,7 +5310,7 @@ static int in_chunk_boundary(struct mddev *mddev, struct bio *bio) unsigned int chunk_sectors; unsigned int bio_sectors = bio_sectors(bio); - WARN_ON_ONCE(bio->bi_partno); + WARN_ON_ONCE(bio->bi_bdev->bd_partno); chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors); return chunk_sectors >= diff --git a/drivers/nvdimm/blk.c b/drivers/nvdimm/blk.c index 22e5617b2cea14..e03a1f38d75040 100644 --- a/drivers/nvdimm/blk.c +++ b/drivers/nvdimm/blk.c @@ -165,7 +165,7 @@ static int nsblk_do_bvec(struct nd_namespace_blk *nsblk, static blk_qc_t nd_blk_submit_bio(struct bio *bio) { struct bio_integrity_payload *bip; - struct nd_namespace_blk *nsblk = bio->bi_disk->private_data; + struct nd_namespace_blk *nsblk = bio->bi_bdev->bd_disk->private_data; struct bvec_iter iter; unsigned long start; struct bio_vec bvec; @@ -177,7 +177,7 @@ static blk_qc_t nd_blk_submit_bio(struct bio *bio) bip = bio_integrity(bio); rw = bio_data_dir(bio); - do_acct = blk_queue_io_stat(bio->bi_disk->queue); + do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue); if (do_acct) start = bio_start_io_acct(bio); bio_for_each_segment(bvec, bio, iter) { diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 12ff6f8784ac11..41aa1f01fc0752 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1442,7 +1442,7 @@ static int btt_do_bvec(struct btt *btt, struct bio_integrity_payload *bip, static blk_qc_t btt_submit_bio(struct bio *bio) { struct bio_integrity_payload *bip = bio_integrity(bio); - struct btt *btt = bio->bi_disk->private_data; + struct btt *btt = bio->bi_bdev->bd_disk->private_data; struct bvec_iter iter; unsigned long start; struct bio_vec bvec; @@ -1452,7 +1452,7 @@ static blk_qc_t btt_submit_bio(struct bio *bio) if (!bio_integrity_prep(bio)) return BLK_QC_T_NONE; - do_acct = blk_queue_io_stat(bio->bi_disk->queue); + do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue); if (do_acct) start = bio_start_io_acct(bio); bio_for_each_segment(bvec, bio, iter) { diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 875076b0ea6c13..72740835c85c9b 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -197,13 +197,13 @@ static blk_qc_t pmem_submit_bio(struct bio *bio) unsigned long start; struct bio_vec bvec; struct bvec_iter iter; - struct pmem_device *pmem = bio->bi_disk->private_data; + struct pmem_device *pmem = bio->bi_bdev->bd_disk->private_data; struct nd_region *nd_region = to_region(pmem); if (bio->bi_opf & REQ_PREFLUSH) ret = nvdimm_flush(nd_region, bio); - do_acct = blk_queue_io_stat(bio->bi_disk->queue); + do_acct = blk_queue_io_stat(bio->bi_bdev->bd_disk->queue); if (do_acct) start = bio_start_io_acct(bio); bio_for_each_segment(bvec, bio, iter) { diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index bc89e8659c403f..daeb011666463c 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1050,7 +1050,7 @@ static int nvme_submit_user_cmd(struct request_queue *q, { bool write = nvme_is_write(cmd); struct nvme_ns *ns = q->queuedata; - struct gendisk *disk = ns ? ns->disk : NULL; + struct block_device *bdev = ns ? ns->disk->part0 : NULL; struct request *req; struct bio *bio = NULL; void *meta = NULL; @@ -1069,8 +1069,8 @@ static int nvme_submit_user_cmd(struct request_queue *q, if (ret) goto out; bio = req->bio; - bio->bi_disk = disk; - if (disk && meta_buffer && meta_len) { + bio->bi_bdev = bdev; + if (bdev && meta_buffer && meta_len) { meta = nvme_add_user_metadata(bio, meta_buffer, meta_len, meta_seed, write); if (IS_ERR(meta)) { diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c index 8e562d0f2c3014..3752cc349a157b 100644 --- a/drivers/nvme/host/lightnvm.c +++ b/drivers/nvme/host/lightnvm.c @@ -757,7 +757,6 @@ static int nvme_nvm_submit_user_cmd(struct request_queue *q, { bool write = nvme_is_write((struct nvme_command *)vcmd); struct nvm_dev *dev = ns->ndev; - struct gendisk *disk = ns->disk; struct request *rq; struct bio *bio = NULL; __le64 *ppa_list = NULL; @@ -817,7 +816,7 @@ static int nvme_nvm_submit_user_cmd(struct request_queue *q, vcmd->ph_rw.metadata = cpu_to_le64(metadata_dma); } - bio->bi_disk = disk; + bio->bi_bdev = ns->disk->part0; } blk_execute_rq(q, NULL, rq, 0); diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 106cf5c44ee7ab..78f992ef7bf361 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -294,7 +294,7 @@ static bool nvme_available_path(struct nvme_ns_head *head) blk_qc_t nvme_ns_head_submit_bio(struct bio *bio) { - struct nvme_ns_head *head = bio->bi_disk->private_data; + struct nvme_ns_head *head = bio->bi_bdev->bd_disk->private_data; struct device *dev = disk_to_dev(head->disk); struct nvme_ns *ns; blk_qc_t ret = BLK_QC_T_NONE; @@ -310,7 +310,7 @@ blk_qc_t nvme_ns_head_submit_bio(struct bio *bio) srcu_idx = srcu_read_lock(&head->srcu); ns = nvme_find_path(head); if (likely(ns)) { - bio->bi_disk = ns->disk; + bio->bi_bdev = ns->disk->part0; bio->bi_opf |= REQ_NVME_MPATH; trace_block_bio_remap(bio, disk_devt(ns->head->disk), bio->bi_iter.bi_sector); @@ -350,7 +350,7 @@ static void nvme_requeue_work(struct work_struct *work) * Reset disk to the mpath node and resubmit to select a new * path. */ - bio->bi_disk = head->disk; + bio->bi_bdev = head->disk->part0; submit_bio_noacct(bio); } } diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index 65e3d0ef36e1a3..e01592d60a86dd 100644 --- a/drivers/nvme/host/rdma.c +++ b/drivers/nvme/host/rdma.c @@ -1461,7 +1461,7 @@ static int nvme_rdma_map_sg_pi(struct nvme_rdma_queue *queue, if (unlikely(nr)) goto mr_put; - nvme_rdma_set_sig_attrs(blk_get_integrity(bio->bi_disk), c, + nvme_rdma_set_sig_attrs(blk_get_integrity(bio->bi_bdev->bd_disk), c, req->mr->sig_attrs, ns->pi_type); nvme_rdma_set_prot_checks(c, &req->mr->sig_attrs->check_mask); diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 5c5cff3f237452..da33cb4cba28eb 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -879,7 +879,7 @@ dcssblk_submit_bio(struct bio *bio) blk_queue_split(&bio); bytes_done = 0; - dev_info = bio->bi_disk->private_data; + dev_info = bio->bi_bdev->bd_disk->private_data; if (dev_info == NULL) goto fail; if ((bio->bi_iter.bi_sector & 7) != 0 || diff --git a/drivers/s390/block/xpram.c b/drivers/s390/block/xpram.c index c2536f7767b366..d1ed39162943d5 100644 --- a/drivers/s390/block/xpram.c +++ b/drivers/s390/block/xpram.c @@ -184,7 +184,7 @@ static unsigned long xpram_highest_page_index(void) */ static blk_qc_t xpram_submit_bio(struct bio *bio) { - xpram_device_t *xdev = bio->bi_disk->private_data; + xpram_device_t *xdev = bio->bi_bdev->bd_disk->private_data; struct bio_vec bvec; struct bvec_iter iter; unsigned int index; diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 81a8c87a5afbb2..8791ad9b3ca5be 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c @@ -2677,7 +2677,7 @@ static void __btrfsic_submit_bio(struct bio *bio) mutex_lock(&btrfsic_mutex); /* since btrfsic_submit_bio() is also called before * btrfsic_mount(), this might return NULL */ - dev_state = btrfsic_dev_state_lookup(bio_dev(bio) + bio->bi_partno); + dev_state = btrfsic_dev_state_lookup(bio->bi_bdev->bd_dev); if (NULL != dev_state && (bio_op(bio) == REQ_OP_WRITE) && bio_has_data(bio)) { unsigned int i = 0; @@ -2693,10 +2693,10 @@ static void __btrfsic_submit_bio(struct bio *bio) bio_is_patched = 0; if (dev_state->state->print_mask & BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH) - pr_info("submit_bio(rw=%d,0x%x, bi_vcnt=%u, bi_sector=%llu (bytenr %llu), bi_disk=%p)\n", + pr_info("submit_bio(rw=%d,0x%x, bi_vcnt=%u, bi_sector=%llu (bytenr %llu), bi_bdev=%p)\n", bio_op(bio), bio->bi_opf, segs, (unsigned long long)bio->bi_iter.bi_sector, - dev_bytenr, bio->bi_disk); + dev_bytenr, bio->bi_bdev); mapped_datav = kmalloc_array(segs, sizeof(*mapped_datav), GFP_NOFS); @@ -2725,8 +2725,8 @@ static void __btrfsic_submit_bio(struct bio *bio) } else if (NULL != dev_state && (bio->bi_opf & REQ_PREFLUSH)) { if (dev_state->state->print_mask & BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH) - pr_info("submit_bio(rw=%d,0x%x FLUSH, disk=%p)\n", - bio_op(bio), bio->bi_opf, bio->bi_disk); + pr_info("submit_bio(rw=%d,0x%x FLUSH, bdev=%p)\n", + bio_op(bio), bio->bi_opf, bio->bi_bdev); if (!dev_state->dummy_block_for_bio_bh_flush.is_iodone) { if ((dev_state->state->print_mask & (BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH | diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c index 255490f42b5d5b..2a4d4484500a4f 100644 --- a/fs/btrfs/raid56.c +++ b/fs/btrfs/raid56.c @@ -1105,8 +1105,7 @@ static int rbio_add_io_page(struct btrfs_raid_bio *rbio, * devices or if they are not contiguous */ if (last_end == disk_start && !last->bi_status && - last->bi_disk == stripe->dev->bdev->bd_disk && - last->bi_partno == stripe->dev->bdev->bd_partno) { + last->bi_bdev == stripe->dev->bdev) { ret = bio_add_page(last, page, PAGE_SIZE, 0); if (ret == PAGE_SIZE) return 0; @@ -1357,9 +1356,7 @@ static int find_bio_stripe(struct btrfs_raid_bio *rbio, for (i = 0; i < rbio->bbio->num_stripes; i++) { stripe = &rbio->bbio->stripes[i]; if (in_range(physical, stripe->physical, rbio->stripe_len) && - stripe->dev->bdev && - bio->bi_disk == stripe->dev->bdev->bd_disk && - bio->bi_partno == stripe->dev->bdev->bd_partno) { + stripe->dev->bdev && bio->bi_bdev == stripe->dev->bdev) { return i; } } diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index e71e7586e9eb06..45d6f770ccdce1 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -1698,7 +1698,7 @@ static void scrub_wr_submit(struct scrub_ctx *sctx) sbio = sctx->wr_curr_bio; sctx->wr_curr_bio = NULL; - WARN_ON(!sbio->bio->bi_disk); + WARN_ON(!sbio->bio->bi_bdev); scrub_pending_bio_inc(sctx); /* process all writes in a single worker thread. Then the block layer * orders the requests before sending them to the driver which diff --git a/fs/direct-io.c b/fs/direct-io.c index d53fa92a1ab656..2660e744da2d81 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -434,7 +434,7 @@ static inline void dio_bio_submit(struct dio *dio, struct dio_submit *sdio) if (dio->is_async && dio->op == REQ_OP_READ && dio->should_dirty) bio_set_pages_dirty(bio); - dio->bio_disk = bio->bi_disk; + dio->bio_disk = bio->bi_bdev->bd_disk; if (sdio->submit_io) { sdio->submit_io(bio, dio->inode, sdio->logical_offset_in_bio); diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index be4da52604edc1..9a2936187d8585 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -427,16 +427,6 @@ int f2fs_target_device_index(struct f2fs_sb_info *sbi, block_t blkaddr) return 0; } -/* - * Return true, if pre_bio's bdev is same as its target device. - */ -static bool __same_bdev(struct f2fs_sb_info *sbi, - block_t blk_addr, struct bio *bio) -{ - struct block_device *b = f2fs_target_device(sbi, blk_addr, NULL); - return bio->bi_disk == b->bd_disk && bio->bi_partno == b->bd_partno; -} - static struct bio *__bio_alloc(struct f2fs_io_info *fio, int npages) { struct f2fs_sb_info *sbi = fio->sbi; @@ -738,7 +728,7 @@ static bool page_is_mergeable(struct f2fs_sb_info *sbi, struct bio *bio, { if (last_blkaddr + 1 != cur_blkaddr) return false; - return __same_bdev(sbi, cur_blkaddr, bio); + return bio->bi_bdev == f2fs_target_device(sbi, cur_blkaddr, NULL); } static bool io_type_is_mergeable(struct f2fs_bio_info *io, diff --git a/include/linux/bio.h b/include/linux/bio.h index ecf67108f091d7..149e367619fcbe 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -470,24 +470,22 @@ extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int); extern unsigned int bvec_nr_vecs(unsigned short idx); extern const char *bio_devname(struct bio *bio, char *buffer); -#define bio_set_dev(bio, bdev) \ -do { \ - if ((bio)->bi_disk != (bdev)->bd_disk) \ - bio_clear_flag(bio, BIO_THROTTLED);\ - (bio)->bi_disk = (bdev)->bd_disk; \ - (bio)->bi_partno = (bdev)->bd_partno; \ - bio_associate_blkg(bio); \ +#define bio_set_dev(bio, bdev) \ +do { \ + if ((bio)->bi_bdev != (bdev)) \ + bio_clear_flag(bio, BIO_THROTTLED); \ + (bio)->bi_bdev = (bdev); \ + bio_associate_blkg(bio); \ } while (0) #define bio_copy_dev(dst, src) \ do { \ - (dst)->bi_disk = (src)->bi_disk; \ - (dst)->bi_partno = (src)->bi_partno; \ + (dst)->bi_bdev = (src)->bi_bdev; \ bio_clone_blkg_association(dst, src); \ } while (0) #define bio_dev(bio) \ - disk_devt((bio)->bi_disk) + disk_devt((bio)->bi_bdev->bd_disk) #ifdef CONFIG_BLK_CGROUP void bio_associate_blkg(struct bio *bio); diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 866f74261b3ba8..8ebd8be3e05082 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -222,7 +222,7 @@ static inline void bio_issue_init(struct bio_issue *issue, */ struct bio { struct bio *bi_next; /* request queue link */ - struct gendisk *bi_disk; + struct block_device *bi_bdev; unsigned int bi_opf; /* bottom bits req flags, * top bits REQ_OP. Use * accessors. @@ -231,7 +231,6 @@ struct bio { unsigned short bi_ioprio; unsigned short bi_write_hint; blk_status_t bi_status; - u8 bi_partno; atomic_t __bi_remaining; struct bvec_iter bi_iter; diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 17cedf0dc83db0..989c5d19eb7d2d 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1956,7 +1956,8 @@ void part_end_io_acct(struct block_device *part, struct bio *bio, */ static inline unsigned long bio_start_io_acct(struct bio *bio) { - return disk_start_io_acct(bio->bi_disk, bio_sectors(bio), bio_op(bio)); + return disk_start_io_acct(bio->bi_bdev->bd_disk, bio_sectors(bio), + bio_op(bio)); } /** @@ -1966,7 +1967,7 @@ static inline unsigned long bio_start_io_acct(struct bio *bio) */ static inline void bio_end_io_acct(struct bio *bio, unsigned long start_time) { - return disk_end_io_acct(bio->bi_disk, bio_op(bio), start_time); + return disk_end_io_acct(bio->bi_bdev->bd_disk, bio_op(bio), start_time); } int bdev_read_only(struct block_device *bdev); diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index 7839a78205c243..774f965d9aca3c 100644 --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c @@ -903,7 +903,7 @@ static void blk_add_trace_bio(struct request_queue *q, struct bio *bio, static void blk_add_trace_bio_bounce(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_BOUNCE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_BOUNCE, 0); } static void blk_add_trace_bio_complete(void *ignore, @@ -915,22 +915,24 @@ static void blk_add_trace_bio_complete(void *ignore, static void blk_add_trace_bio_backmerge(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_BACKMERGE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_BACKMERGE, + 0); } static void blk_add_trace_bio_frontmerge(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_FRONTMERGE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_FRONTMERGE, + 0); } static void blk_add_trace_bio_queue(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_QUEUE, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_QUEUE, 0); } static void blk_add_trace_getrq(void *ignore, struct bio *bio) { - blk_add_trace_bio(bio->bi_disk->queue, bio, BLK_TA_GETRQ, 0); + blk_add_trace_bio(bio->bi_bdev->bd_disk->queue, bio, BLK_TA_GETRQ, 0); } static void blk_add_trace_plug(void *ignore, struct request_queue *q) @@ -967,7 +969,7 @@ static void blk_add_trace_unplug(void *ignore, struct request_queue *q, static void blk_add_trace_split(void *ignore, struct bio *bio, unsigned int pdu) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct blk_trace *bt; rcu_read_lock(); @@ -997,7 +999,7 @@ static void blk_add_trace_split(void *ignore, struct bio *bio, unsigned int pdu) static void blk_add_trace_bio_remap(void *ignore, struct bio *bio, dev_t dev, sector_t from) { - struct request_queue *q = bio->bi_disk->queue; + struct request_queue *q = bio->bi_bdev->bd_disk->queue; struct blk_trace *bt; struct blk_io_trace_remap r; diff --git a/mm/page_io.c b/mm/page_io.c index 433df126334958..cf3c997d2b49d9 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -431,7 +431,7 @@ int swap_readpage(struct page *page, bool synchronous) ret = -ENOMEM; goto out; } - disk = bio->bi_disk; + disk = bio->bi_bdev->bd_disk; /* * Keep this task valid during swap readpage because the oom killer may * attempt to access it in the page fault retry time check. -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 3/9] block: store a block_device pointer in struct bio 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 22:54 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:54 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > Replace the gendisk pointer in struct bio with a pointer to the newly > improved struct block device. From that the gendisk can be trivially > accessed with an extra indirection, but it also allows to directly > look up all information related to partition remapping. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 3/9] block: store a block_device pointer in struct bio @ 2020-12-02 22:54 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:54 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > Replace the gendisk pointer in struct bio with a pointer to the newly > improved struct block device. From that the gendisk can be trivially > accessed with an extra indirection, but it also allows to directly > look up all information related to partition remapping. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [PATCH 3/9] block: store a block_device pointer in struct bio 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-03 6:39 ` Ming Lei -1 siblings, 0 replies; 68+ messages in thread From: Ming Lei @ 2020-12-03 6:39 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > Replace the gendisk pointer in struct bio with a pointer to the newly > improved struct block device. From that the gendisk can be trivially > accessed with an extra indirection, but it also allows to directly > look up all information related to partition remapping. The extra indirection is often done in fast path, so just wondering why you don't consider to embed gendisk into block_device? Then the extra indirection can be avoided. Thanks, Ming ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 3/9] block: store a block_device pointer in struct bio @ 2020-12-03 6:39 ` Ming Lei 0 siblings, 0 replies; 68+ messages in thread From: Ming Lei @ 2020-12-03 6:39 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > Replace the gendisk pointer in struct bio with a pointer to the newly > improved struct block device. From that the gendisk can be trivially > accessed with an extra indirection, but it also allows to directly > look up all information related to partition remapping. The extra indirection is often done in fast path, so just wondering why you don't consider to embed gendisk into block_device? Then the extra indirection can be avoided. Thanks, Ming -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [PATCH 3/9] block: store a block_device pointer in struct bio 2020-12-03 6:39 ` [dm-devel] " Ming Lei @ 2020-12-03 7:10 ` Ming Lei -1 siblings, 0 replies; 68+ messages in thread From: Ming Lei @ 2020-12-03 7:10 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Thu, Dec 03, 2020 at 02:40:04PM +0800, Ming Lei wrote: > On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > > Replace the gendisk pointer in struct bio with a pointer to the newly > > improved struct block device. From that the gendisk can be trivially > > accessed with an extra indirection, but it also allows to directly > > look up all information related to partition remapping. > > The extra indirection is often done in fast path, so just wondering why > you don't consider to embed gendisk into block_device? Then the extra > indirection can be avoided. oops, that is only possible for disk, and indirection is still needed for partitions. Thanks, Ming ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 3/9] block: store a block_device pointer in struct bio @ 2020-12-03 7:10 ` Ming Lei 0 siblings, 0 replies; 68+ messages in thread From: Ming Lei @ 2020-12-03 7:10 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo On Thu, Dec 03, 2020 at 02:40:04PM +0800, Ming Lei wrote: > On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > > Replace the gendisk pointer in struct bio with a pointer to the newly > > improved struct block device. From that the gendisk can be trivially > > accessed with an extra indirection, but it also allows to directly > > look up all information related to partition remapping. > > The extra indirection is often done in fast path, so just wondering why > you don't consider to embed gendisk into block_device? Then the extra > indirection can be avoided. oops, that is only possible for disk, and indirection is still needed for partitions. Thanks, Ming -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [PATCH 3/9] block: store a block_device pointer in struct bio 2020-12-03 7:10 ` [dm-devel] " Ming Lei @ 2020-12-03 8:29 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-03 8:29 UTC (permalink / raw) To: Ming Lei Cc: Christoph Hellwig, Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Thu, Dec 03, 2020 at 03:10:55PM +0800, Ming Lei wrote: > On Thu, Dec 03, 2020 at 02:40:04PM +0800, Ming Lei wrote: > > On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > > > Replace the gendisk pointer in struct bio with a pointer to the newly > > > improved struct block device. From that the gendisk can be trivially > > > accessed with an extra indirection, but it also allows to directly > > > look up all information related to partition remapping. > > > > The extra indirection is often done in fast path, so just wondering why > > you don't consider to embed gendisk into block_device? Then the extra > > indirection can be avoided. > > oops, that is only possible for disk, and indirection is still needed > for partitions. I looked into that, but given that the block device is allocated as part of the inode we'd need to tell ->alloc_inode if we want to allocate the small inode without the gendisk, or the large one with it which doesn't work with the current interface. Beause the hd_struct is gone we're still not using more structures in the I/O path than we did before. ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 3/9] block: store a block_device pointer in struct bio @ 2020-12-03 8:29 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-03 8:29 UTC (permalink / raw) To: Ming Lei Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo, Christoph Hellwig On Thu, Dec 03, 2020 at 03:10:55PM +0800, Ming Lei wrote: > On Thu, Dec 03, 2020 at 02:40:04PM +0800, Ming Lei wrote: > > On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > > > Replace the gendisk pointer in struct bio with a pointer to the newly > > > improved struct block device. From that the gendisk can be trivially > > > accessed with an extra indirection, but it also allows to directly > > > look up all information related to partition remapping. > > > > The extra indirection is often done in fast path, so just wondering why > > you don't consider to embed gendisk into block_device? Then the extra > > indirection can be avoided. > > oops, that is only possible for disk, and indirection is still needed > for partitions. I looked into that, but given that the block device is allocated as part of the inode we'd need to tell ->alloc_inode if we want to allocate the small inode without the gendisk, or the large one with it which doesn't work with the current interface. Beause the hd_struct is gone we're still not using more structures in the I/O path than we did before. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [PATCH 3/9] block: store a block_device pointer in struct bio 2020-12-03 8:29 ` [dm-devel] " Christoph Hellwig @ 2020-12-03 9:32 ` Ming Lei -1 siblings, 0 replies; 68+ messages in thread From: Ming Lei @ 2020-12-03 9:32 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Thu, Dec 03, 2020 at 09:29:51AM +0100, Christoph Hellwig wrote: > On Thu, Dec 03, 2020 at 03:10:55PM +0800, Ming Lei wrote: > > On Thu, Dec 03, 2020 at 02:40:04PM +0800, Ming Lei wrote: > > > On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > > > > Replace the gendisk pointer in struct bio with a pointer to the newly > > > > improved struct block device. From that the gendisk can be trivially > > > > accessed with an extra indirection, but it also allows to directly > > > > look up all information related to partition remapping. > > > > > > The extra indirection is often done in fast path, so just wondering why > > > you don't consider to embed gendisk into block_device? Then the extra > > > indirection can be avoided. > > > > oops, that is only possible for disk, and indirection is still needed > > for partitions. > > I looked into that, but given that the block device is allocated as part > of the inode we'd need to tell ->alloc_inode if we want to allocate the > small inode without the gendisk, or the large one with it which doesn't > work with the current interface. I guess it could be done without fs code change, because now block device is always allocated by bdev_alloc() since 22ae8ce8b892("block: simplify bdev/disk lookup in blkdev_get"). And one manual inode allocation with a bit duplication from new_inode_pseudo() should be fine: allocate big inode for disk, and small for partition inode_init_always(sb, inode); if (inode) { spin_lock(&inode->i_lock); inode->i_state = 0; spin_unlock(&inode->i_lock); INIT_LIST_HEAD(&inode->i_sb_list); inode_sb_list_add(inode); } > Beause the hd_struct is gone we're > still not using more structures in the I/O path than we did before. Indeed, and block_device instance is often cached in IO path. thanks, Ming ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 3/9] block: store a block_device pointer in struct bio @ 2020-12-03 9:32 ` Ming Lei 0 siblings, 0 replies; 68+ messages in thread From: Ming Lei @ 2020-12-03 9:32 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo On Thu, Dec 03, 2020 at 09:29:51AM +0100, Christoph Hellwig wrote: > On Thu, Dec 03, 2020 at 03:10:55PM +0800, Ming Lei wrote: > > On Thu, Dec 03, 2020 at 02:40:04PM +0800, Ming Lei wrote: > > > On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > > > > Replace the gendisk pointer in struct bio with a pointer to the newly > > > > improved struct block device. From that the gendisk can be trivially > > > > accessed with an extra indirection, but it also allows to directly > > > > look up all information related to partition remapping. > > > > > > The extra indirection is often done in fast path, so just wondering why > > > you don't consider to embed gendisk into block_device? Then the extra > > > indirection can be avoided. > > > > oops, that is only possible for disk, and indirection is still needed > > for partitions. > > I looked into that, but given that the block device is allocated as part > of the inode we'd need to tell ->alloc_inode if we want to allocate the > small inode without the gendisk, or the large one with it which doesn't > work with the current interface. I guess it could be done without fs code change, because now block device is always allocated by bdev_alloc() since 22ae8ce8b892("block: simplify bdev/disk lookup in blkdev_get"). And one manual inode allocation with a bit duplication from new_inode_pseudo() should be fine: allocate big inode for disk, and small for partition inode_init_always(sb, inode); if (inode) { spin_lock(&inode->i_lock); inode->i_state = 0; spin_unlock(&inode->i_lock); INIT_LIST_HEAD(&inode->i_sb_list); inode_sb_list_add(inode); } > Beause the hd_struct is gone we're > still not using more structures in the I/O path than we did before. Indeed, and block_device instance is often cached in IO path. thanks, Ming -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [PATCH 3/9] block: store a block_device pointer in struct bio 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-03 20:53 ` Keith Busch -1 siblings, 0 replies; 68+ messages in thread From: Keith Busch @ 2020-12-03 20:53 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > diff --git a/block/blk.h b/block/blk.h > index 98f0b1ae264120..64dc8e5a3f44cb 100644 > --- a/block/blk.h > +++ b/block/blk.h > @@ -99,8 +99,8 @@ static inline void blk_rq_bio_prep(struct request *rq, struct bio *bio, > rq->bio = rq->biotail = bio; > rq->ioprio = bio_prio(bio); > > - if (bio->bi_disk) > - rq->rq_disk = bio->bi_disk; > + if (bio->bi_bdev) > + rq->rq_disk = bio->bi_bdev->bd_disk; > } Just fyi, this function has been relocated to include/linux/blk-mq.h ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 3/9] block: store a block_device pointer in struct bio @ 2020-12-03 20:53 ` Keith Busch 0 siblings, 0 replies; 68+ messages in thread From: Keith Busch @ 2020-12-03 20:53 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo On Tue, Dec 01, 2020 at 05:54:18PM +0100, Christoph Hellwig wrote: > diff --git a/block/blk.h b/block/blk.h > index 98f0b1ae264120..64dc8e5a3f44cb 100644 > --- a/block/blk.h > +++ b/block/blk.h > @@ -99,8 +99,8 @@ static inline void blk_rq_bio_prep(struct request *rq, struct bio *bio, > rq->bio = rq->biotail = bio; > rq->ioprio = bio_prio(bio); > > - if (bio->bi_disk) > - rq->rq_disk = bio->bi_disk; > + if (bio->bi_bdev) > + rq->rq_disk = bio->bi_bdev->bd_disk; > } Just fyi, this function has been relocated to include/linux/blk-mq.h -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 4/9] block: simplify submit_bio_checks a bit 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block Merge a few checks for whole devices vs partitions to streamline the sanity checks. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 40 ++++++++++++++-------------------------- 1 file changed, 14 insertions(+), 26 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 95005a8db5ab2f..3a8fef64d36bc1 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -691,11 +691,9 @@ static inline bool should_fail_request(struct block_device *part, #endif /* CONFIG_FAIL_MAKE_REQUEST */ -static inline bool bio_check_ro(struct bio *bio, struct block_device *part) +static inline bool bio_check_ro(struct bio *bio) { - const int op = bio_op(bio); - - if (part->bd_read_only && op_is_write(op)) { + if (op_is_write(bio_op(bio)) && bio->bi_bdev->bd_read_only) { char b[BDEVNAME_SIZE]; if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) @@ -703,7 +701,7 @@ static inline bool bio_check_ro(struct bio *bio, struct block_device *part) WARN_ONCE(1, "Trying to write to read-only block-device %s (partno %d)\n", - bio_devname(bio, b), part->bd_partno); + bio_devname(bio, b), bio->bi_bdev->bd_partno); /* Older lvm-tools actually trigger this */ return false; } @@ -724,8 +722,9 @@ ALLOW_ERROR_INJECTION(should_fail_bio, ERRNO); * This may well happen - the kernel calls bread() without checking the size of * the device, e.g., when mounting a file system. */ -static inline int bio_check_eod(struct bio *bio, sector_t maxsector) +static inline int bio_check_eod(struct bio *bio) { + sector_t maxsector = bdev_nr_sectors(bio->bi_bdev); unsigned int nr_sectors = bio_sectors(bio); if (nr_sectors && maxsector && @@ -740,27 +739,20 @@ static inline int bio_check_eod(struct bio *bio, sector_t maxsector) /* * Remap block n of partition p to block n+start(p) of the disk. */ -static inline int blk_partition_remap(struct bio *bio) +static int blk_partition_remap(struct bio *bio) { struct block_device *p = bio->bi_bdev; - int ret = -EIO; if (unlikely(should_fail_request(p, bio->bi_iter.bi_size))) - goto out; - if (unlikely(bio_check_ro(bio, p))) - goto out; + return -EIO; if (bio_sectors(bio)) { - if (bio_check_eod(bio, bdev_nr_sectors(p))) - goto out; bio->bi_iter.bi_sector += p->bd_start_sect; trace_block_bio_remap(bio, p->bd_dev, bio->bi_iter.bi_sector - p->bd_start_sect); } - ret = 0; -out: - return ret; + return 0; } /* @@ -820,16 +812,12 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) if (should_fail_bio(bio)) goto end_io; - - if (bio->bi_bdev->bd_partno) { - if (unlikely(blk_partition_remap(bio))) - goto end_io; - } else { - if (unlikely(bio_check_ro(bio, bdev_whole(bdev)))) - goto end_io; - if (unlikely(bio_check_eod(bio, get_capacity(bdev->bd_disk)))) - goto end_io; - } + if (unlikely(bio_check_ro(bio))) + goto end_io; + if (unlikely(bio_check_eod(bio))) + goto end_io; + if (bio->bi_bdev->bd_partno && unlikely(blk_partition_remap(bio))) + goto end_io; /* * Filter flush bio's early so that bio based drivers without flush -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 4/9] block: simplify submit_bio_checks a bit @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo Merge a few checks for whole devices vs partitions to streamline the sanity checks. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 40 ++++++++++++++-------------------------- 1 file changed, 14 insertions(+), 26 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 95005a8db5ab2f..3a8fef64d36bc1 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -691,11 +691,9 @@ static inline bool should_fail_request(struct block_device *part, #endif /* CONFIG_FAIL_MAKE_REQUEST */ -static inline bool bio_check_ro(struct bio *bio, struct block_device *part) +static inline bool bio_check_ro(struct bio *bio) { - const int op = bio_op(bio); - - if (part->bd_read_only && op_is_write(op)) { + if (op_is_write(bio_op(bio)) && bio->bi_bdev->bd_read_only) { char b[BDEVNAME_SIZE]; if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) @@ -703,7 +701,7 @@ static inline bool bio_check_ro(struct bio *bio, struct block_device *part) WARN_ONCE(1, "Trying to write to read-only block-device %s (partno %d)\n", - bio_devname(bio, b), part->bd_partno); + bio_devname(bio, b), bio->bi_bdev->bd_partno); /* Older lvm-tools actually trigger this */ return false; } @@ -724,8 +722,9 @@ ALLOW_ERROR_INJECTION(should_fail_bio, ERRNO); * This may well happen - the kernel calls bread() without checking the size of * the device, e.g., when mounting a file system. */ -static inline int bio_check_eod(struct bio *bio, sector_t maxsector) +static inline int bio_check_eod(struct bio *bio) { + sector_t maxsector = bdev_nr_sectors(bio->bi_bdev); unsigned int nr_sectors = bio_sectors(bio); if (nr_sectors && maxsector && @@ -740,27 +739,20 @@ static inline int bio_check_eod(struct bio *bio, sector_t maxsector) /* * Remap block n of partition p to block n+start(p) of the disk. */ -static inline int blk_partition_remap(struct bio *bio) +static int blk_partition_remap(struct bio *bio) { struct block_device *p = bio->bi_bdev; - int ret = -EIO; if (unlikely(should_fail_request(p, bio->bi_iter.bi_size))) - goto out; - if (unlikely(bio_check_ro(bio, p))) - goto out; + return -EIO; if (bio_sectors(bio)) { - if (bio_check_eod(bio, bdev_nr_sectors(p))) - goto out; bio->bi_iter.bi_sector += p->bd_start_sect; trace_block_bio_remap(bio, p->bd_dev, bio->bi_iter.bi_sector - p->bd_start_sect); } - ret = 0; -out: - return ret; + return 0; } /* @@ -820,16 +812,12 @@ static noinline_for_stack bool submit_bio_checks(struct bio *bio) if (should_fail_bio(bio)) goto end_io; - - if (bio->bi_bdev->bd_partno) { - if (unlikely(blk_partition_remap(bio))) - goto end_io; - } else { - if (unlikely(bio_check_ro(bio, bdev_whole(bdev)))) - goto end_io; - if (unlikely(bio_check_eod(bio, get_capacity(bdev->bd_disk)))) - goto end_io; - } + if (unlikely(bio_check_ro(bio))) + goto end_io; + if (unlikely(bio_check_eod(bio))) + goto end_io; + if (bio->bi_bdev->bd_partno && unlikely(blk_partition_remap(bio))) + goto end_io; /* * Filter flush bio's early so that bio based drivers without flush -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 4/9] block: simplify submit_bio_checks a bit 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 22:55 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:55 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:19PM +0100, Christoph Hellwig wrote: > Merge a few checks for whole devices vs partitions to streamline the > sanity checks. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 4/9] block: simplify submit_bio_checks a bit @ 2020-12-02 22:55 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:55 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:19PM +0100, Christoph Hellwig wrote: > Merge a few checks for whole devices vs partitions to streamline the > sanity checks. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 5/9] block: use ->bi_bdev for bio based I/O accounting 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block Rework the I/O accounting for bio based drivers to use ->bi_bdev. This means all drivers can now simply use bio_start_io_acct to start accounting, and it will take partitions into account automatically. To end I/O account either bio_end_io_acct can be used if the driver never remaps I/O to a different device, or bio_end_io_acct_remapped if the driver did remap the I/O. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 23 +++++++++++++---------- drivers/md/bcache/request.c | 34 +++++++++++++++++++++------------- drivers/md/md.c | 8 ++++---- include/linux/blkdev.h | 21 ++++----------------- 4 files changed, 42 insertions(+), 44 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 3a8fef64d36bc1..d53cc887e1b8ea 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1319,14 +1319,17 @@ static unsigned long __part_start_io_acct(struct block_device *part, return now; } -unsigned long part_start_io_acct(struct gendisk *disk, struct block_device **part, - struct bio *bio) +/** + * bio_start_io_acct - start I/O accounting for bio based drivers + * @bio: bio to start account for + * + * Returns the start time that should be passed back to bio_end_io_acct(). + */ +unsigned long bio_start_io_acct(struct bio *bio) { - *part = disk_map_sector_rcu(disk, bio->bi_iter.bi_sector); - - return __part_start_io_acct(*part, bio_sectors(bio), bio_op(bio)); + return __part_start_io_acct(bio->bi_bdev, bio_sectors(bio), bio_op(bio)); } -EXPORT_SYMBOL_GPL(part_start_io_acct); +EXPORT_SYMBOL_GPL(bio_start_io_acct); unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors, unsigned int op) @@ -1349,12 +1352,12 @@ static void __part_end_io_acct(struct block_device *part, unsigned int op, part_stat_unlock(); } -void part_end_io_acct(struct block_device *part, struct bio *bio, - unsigned long start_time) +void bio_end_io_acct_remapped(struct bio *bio, unsigned long start_time, + struct block_device *orig_bdev) { - __part_end_io_acct(part, bio_op(bio), start_time); + __part_end_io_acct(orig_bdev, bio_op(bio), start_time); } -EXPORT_SYMBOL_GPL(part_end_io_acct); +EXPORT_SYMBOL_GPL(bio_end_io_acct_remapped); void disk_end_io_acct(struct gendisk *disk, unsigned int op, unsigned long start_time) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index dfc35d6d05ed1c..29c231758293e2 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -475,7 +475,7 @@ struct search { unsigned int read_dirty_data:1; unsigned int cache_missed:1; - struct block_device *part; + struct block_device *orig_bdev; unsigned long start_time; struct btree_op op; @@ -670,8 +670,8 @@ static void bio_complete(struct search *s) { if (s->orig_bio) { /* Count on bcache device */ - part_end_io_acct(s->part, s->orig_bio, s->start_time); - + bio_end_io_acct_remapped(s->orig_bio, s->start_time, + s->orig_bdev); trace_bcache_request_end(s->d, s->orig_bio); s->orig_bio->bi_status = s->iop.status; bio_endio(s->orig_bio); @@ -714,7 +714,8 @@ static void search_free(struct closure *cl) } static inline struct search *search_alloc(struct bio *bio, - struct bcache_device *d) + struct bcache_device *d, struct block_device *orig_bdev, + unsigned long start_time) { struct search *s; @@ -732,7 +733,8 @@ static inline struct search *search_alloc(struct bio *bio, s->write = op_is_write(bio_op(bio)); s->read_dirty_data = 0; /* Count on the bcache device */ - s->start_time = part_start_io_acct(d->disk, &s->part, bio); + s->orig_bdev = orig_bdev; + s->start_time = start_time; s->iop.c = d->c; s->iop.bio = NULL; s->iop.inode = d->id; @@ -1074,7 +1076,7 @@ struct detached_dev_io_private { unsigned long start_time; bio_end_io_t *bi_end_io; void *bi_private; - struct block_device *part; + struct block_device *orig_bdev; }; static void detached_dev_end_io(struct bio *bio) @@ -1086,7 +1088,7 @@ static void detached_dev_end_io(struct bio *bio) bio->bi_private = ddip->bi_private; /* Count on the bcache device */ - part_end_io_acct(ddip->part, bio, ddip->start_time); + bio_end_io_acct_remapped(bio, ddip->start_time, ddip->orig_bdev); if (bio->bi_status) { struct cached_dev *dc = container_of(ddip->d, @@ -1099,7 +1101,8 @@ static void detached_dev_end_io(struct bio *bio) bio->bi_end_io(bio); } -static void detached_dev_do_request(struct bcache_device *d, struct bio *bio) +static void detached_dev_do_request(struct bcache_device *d, struct bio *bio, + struct block_device *orig_bdev, unsigned long start_time) { struct detached_dev_io_private *ddip; struct cached_dev *dc = container_of(d, struct cached_dev, disk); @@ -1112,7 +1115,8 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio) ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); ddip->d = d; /* Count on the bcache device */ - ddip->start_time = part_start_io_acct(d->disk, &ddip->part, bio); + ddip->orig_bdev = orig_bdev; + ddip->start_time = start_time; ddip->bi_end_io = bio->bi_end_io; ddip->bi_private = bio->bi_private; bio->bi_end_io = detached_dev_end_io; @@ -1168,8 +1172,10 @@ static void quit_max_writeback_rate(struct cache_set *c, blk_qc_t cached_dev_submit_bio(struct bio *bio) { struct search *s; - struct bcache_device *d = bio->bi_bdev->bd_disk->private_data; + struct block_device *orig_bdev = bio->bi_bdev; + struct bcache_device *d = orig_bdev->bd_disk->private_data; struct cached_dev *dc = container_of(d, struct cached_dev, disk); + unsigned long start_time; int rw = bio_data_dir(bio); if (unlikely((d->c && test_bit(CACHE_SET_IO_DISABLE, &d->c->flags)) || @@ -1194,11 +1200,13 @@ blk_qc_t cached_dev_submit_bio(struct bio *bio) } } + start_time = bio_start_io_acct(bio); + bio_set_dev(bio, dc->bdev); bio->bi_iter.bi_sector += dc->sb.data_offset; if (cached_dev_get(dc)) { - s = search_alloc(bio, d); + s = search_alloc(bio, d, orig_bdev, start_time); trace_bcache_request_start(s->d, bio); if (!bio->bi_iter.bi_size) { @@ -1219,7 +1227,7 @@ blk_qc_t cached_dev_submit_bio(struct bio *bio) } } else /* I/O request sent to backing device */ - detached_dev_do_request(d, bio); + detached_dev_do_request(d, bio, orig_bdev, start_time); return BLK_QC_T_NONE; } @@ -1283,7 +1291,7 @@ blk_qc_t flash_dev_submit_bio(struct bio *bio) return BLK_QC_T_NONE; } - s = search_alloc(bio, d); + s = search_alloc(bio, d, bio->bi_bdev, bio_start_io_acct(bio)); cl = &s->cl; bio = &s->bio.bio; diff --git a/drivers/md/md.c b/drivers/md/md.c index 3e72fc24f80f57..ced01ca5d7f090 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -463,8 +463,8 @@ struct md_io { struct mddev *mddev; bio_end_io_t *orig_bi_end_io; void *orig_bi_private; + struct block_device *orig_bi_bdev; unsigned long start_time; - struct block_device *part; }; static void md_end_io(struct bio *bio) @@ -472,7 +472,7 @@ static void md_end_io(struct bio *bio) struct md_io *md_io = bio->bi_private; struct mddev *mddev = md_io->mddev; - part_end_io_acct(md_io->part, bio, md_io->start_time); + bio_end_io_acct_remapped(bio, md_io->start_time, md_io->orig_bi_bdev); bio->bi_end_io = md_io->orig_bi_end_io; bio->bi_private = md_io->orig_bi_private; @@ -514,12 +514,12 @@ static blk_qc_t md_submit_bio(struct bio *bio) md_io->mddev = mddev; md_io->orig_bi_end_io = bio->bi_end_io; md_io->orig_bi_private = bio->bi_private; + md_io->orig_bi_bdev = bio->bi_bdev; bio->bi_end_io = md_end_io; bio->bi_private = md_io; - md_io->start_time = part_start_io_acct(mddev->gendisk, - &md_io->part, bio); + md_io->start_time = bio_start_io_acct(bio); } /* bio could be mergeable after passing to underlayer */ diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 989c5d19eb7d2d..3a6103562fa8f7 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1943,22 +1943,9 @@ unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors, void disk_end_io_acct(struct gendisk *disk, unsigned int op, unsigned long start_time); -unsigned long part_start_io_acct(struct gendisk *disk, - struct block_device **part, struct bio *bio); -void part_end_io_acct(struct block_device *part, struct bio *bio, - unsigned long start_time); - -/** - * bio_start_io_acct - start I/O accounting for bio based drivers - * @bio: bio to start account for - * - * Returns the start time that should be passed back to bio_end_io_acct(). - */ -static inline unsigned long bio_start_io_acct(struct bio *bio) -{ - return disk_start_io_acct(bio->bi_bdev->bd_disk, bio_sectors(bio), - bio_op(bio)); -} +unsigned long bio_start_io_acct(struct bio *bio); +void bio_end_io_acct_remapped(struct bio *bio, unsigned long start_time, + struct block_device *orig_bdev); /** * bio_end_io_acct - end I/O accounting for bio based drivers @@ -1967,7 +1954,7 @@ static inline unsigned long bio_start_io_acct(struct bio *bio) */ static inline void bio_end_io_acct(struct bio *bio, unsigned long start_time) { - return disk_end_io_acct(bio->bi_bdev->bd_disk, bio_op(bio), start_time); + return bio_end_io_acct_remapped(bio, start_time, bio->bi_bdev); } int bdev_read_only(struct block_device *bdev); -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 5/9] block: use ->bi_bdev for bio based I/O accounting @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo Rework the I/O accounting for bio based drivers to use ->bi_bdev. This means all drivers can now simply use bio_start_io_acct to start accounting, and it will take partitions into account automatically. To end I/O account either bio_end_io_acct can be used if the driver never remaps I/O to a different device, or bio_end_io_acct_remapped if the driver did remap the I/O. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 23 +++++++++++++---------- drivers/md/bcache/request.c | 34 +++++++++++++++++++++------------- drivers/md/md.c | 8 ++++---- include/linux/blkdev.h | 21 ++++----------------- 4 files changed, 42 insertions(+), 44 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 3a8fef64d36bc1..d53cc887e1b8ea 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1319,14 +1319,17 @@ static unsigned long __part_start_io_acct(struct block_device *part, return now; } -unsigned long part_start_io_acct(struct gendisk *disk, struct block_device **part, - struct bio *bio) +/** + * bio_start_io_acct - start I/O accounting for bio based drivers + * @bio: bio to start account for + * + * Returns the start time that should be passed back to bio_end_io_acct(). + */ +unsigned long bio_start_io_acct(struct bio *bio) { - *part = disk_map_sector_rcu(disk, bio->bi_iter.bi_sector); - - return __part_start_io_acct(*part, bio_sectors(bio), bio_op(bio)); + return __part_start_io_acct(bio->bi_bdev, bio_sectors(bio), bio_op(bio)); } -EXPORT_SYMBOL_GPL(part_start_io_acct); +EXPORT_SYMBOL_GPL(bio_start_io_acct); unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors, unsigned int op) @@ -1349,12 +1352,12 @@ static void __part_end_io_acct(struct block_device *part, unsigned int op, part_stat_unlock(); } -void part_end_io_acct(struct block_device *part, struct bio *bio, - unsigned long start_time) +void bio_end_io_acct_remapped(struct bio *bio, unsigned long start_time, + struct block_device *orig_bdev) { - __part_end_io_acct(part, bio_op(bio), start_time); + __part_end_io_acct(orig_bdev, bio_op(bio), start_time); } -EXPORT_SYMBOL_GPL(part_end_io_acct); +EXPORT_SYMBOL_GPL(bio_end_io_acct_remapped); void disk_end_io_acct(struct gendisk *disk, unsigned int op, unsigned long start_time) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index dfc35d6d05ed1c..29c231758293e2 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -475,7 +475,7 @@ struct search { unsigned int read_dirty_data:1; unsigned int cache_missed:1; - struct block_device *part; + struct block_device *orig_bdev; unsigned long start_time; struct btree_op op; @@ -670,8 +670,8 @@ static void bio_complete(struct search *s) { if (s->orig_bio) { /* Count on bcache device */ - part_end_io_acct(s->part, s->orig_bio, s->start_time); - + bio_end_io_acct_remapped(s->orig_bio, s->start_time, + s->orig_bdev); trace_bcache_request_end(s->d, s->orig_bio); s->orig_bio->bi_status = s->iop.status; bio_endio(s->orig_bio); @@ -714,7 +714,8 @@ static void search_free(struct closure *cl) } static inline struct search *search_alloc(struct bio *bio, - struct bcache_device *d) + struct bcache_device *d, struct block_device *orig_bdev, + unsigned long start_time) { struct search *s; @@ -732,7 +733,8 @@ static inline struct search *search_alloc(struct bio *bio, s->write = op_is_write(bio_op(bio)); s->read_dirty_data = 0; /* Count on the bcache device */ - s->start_time = part_start_io_acct(d->disk, &s->part, bio); + s->orig_bdev = orig_bdev; + s->start_time = start_time; s->iop.c = d->c; s->iop.bio = NULL; s->iop.inode = d->id; @@ -1074,7 +1076,7 @@ struct detached_dev_io_private { unsigned long start_time; bio_end_io_t *bi_end_io; void *bi_private; - struct block_device *part; + struct block_device *orig_bdev; }; static void detached_dev_end_io(struct bio *bio) @@ -1086,7 +1088,7 @@ static void detached_dev_end_io(struct bio *bio) bio->bi_private = ddip->bi_private; /* Count on the bcache device */ - part_end_io_acct(ddip->part, bio, ddip->start_time); + bio_end_io_acct_remapped(bio, ddip->start_time, ddip->orig_bdev); if (bio->bi_status) { struct cached_dev *dc = container_of(ddip->d, @@ -1099,7 +1101,8 @@ static void detached_dev_end_io(struct bio *bio) bio->bi_end_io(bio); } -static void detached_dev_do_request(struct bcache_device *d, struct bio *bio) +static void detached_dev_do_request(struct bcache_device *d, struct bio *bio, + struct block_device *orig_bdev, unsigned long start_time) { struct detached_dev_io_private *ddip; struct cached_dev *dc = container_of(d, struct cached_dev, disk); @@ -1112,7 +1115,8 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio) ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); ddip->d = d; /* Count on the bcache device */ - ddip->start_time = part_start_io_acct(d->disk, &ddip->part, bio); + ddip->orig_bdev = orig_bdev; + ddip->start_time = start_time; ddip->bi_end_io = bio->bi_end_io; ddip->bi_private = bio->bi_private; bio->bi_end_io = detached_dev_end_io; @@ -1168,8 +1172,10 @@ static void quit_max_writeback_rate(struct cache_set *c, blk_qc_t cached_dev_submit_bio(struct bio *bio) { struct search *s; - struct bcache_device *d = bio->bi_bdev->bd_disk->private_data; + struct block_device *orig_bdev = bio->bi_bdev; + struct bcache_device *d = orig_bdev->bd_disk->private_data; struct cached_dev *dc = container_of(d, struct cached_dev, disk); + unsigned long start_time; int rw = bio_data_dir(bio); if (unlikely((d->c && test_bit(CACHE_SET_IO_DISABLE, &d->c->flags)) || @@ -1194,11 +1200,13 @@ blk_qc_t cached_dev_submit_bio(struct bio *bio) } } + start_time = bio_start_io_acct(bio); + bio_set_dev(bio, dc->bdev); bio->bi_iter.bi_sector += dc->sb.data_offset; if (cached_dev_get(dc)) { - s = search_alloc(bio, d); + s = search_alloc(bio, d, orig_bdev, start_time); trace_bcache_request_start(s->d, bio); if (!bio->bi_iter.bi_size) { @@ -1219,7 +1227,7 @@ blk_qc_t cached_dev_submit_bio(struct bio *bio) } } else /* I/O request sent to backing device */ - detached_dev_do_request(d, bio); + detached_dev_do_request(d, bio, orig_bdev, start_time); return BLK_QC_T_NONE; } @@ -1283,7 +1291,7 @@ blk_qc_t flash_dev_submit_bio(struct bio *bio) return BLK_QC_T_NONE; } - s = search_alloc(bio, d); + s = search_alloc(bio, d, bio->bi_bdev, bio_start_io_acct(bio)); cl = &s->cl; bio = &s->bio.bio; diff --git a/drivers/md/md.c b/drivers/md/md.c index 3e72fc24f80f57..ced01ca5d7f090 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -463,8 +463,8 @@ struct md_io { struct mddev *mddev; bio_end_io_t *orig_bi_end_io; void *orig_bi_private; + struct block_device *orig_bi_bdev; unsigned long start_time; - struct block_device *part; }; static void md_end_io(struct bio *bio) @@ -472,7 +472,7 @@ static void md_end_io(struct bio *bio) struct md_io *md_io = bio->bi_private; struct mddev *mddev = md_io->mddev; - part_end_io_acct(md_io->part, bio, md_io->start_time); + bio_end_io_acct_remapped(bio, md_io->start_time, md_io->orig_bi_bdev); bio->bi_end_io = md_io->orig_bi_end_io; bio->bi_private = md_io->orig_bi_private; @@ -514,12 +514,12 @@ static blk_qc_t md_submit_bio(struct bio *bio) md_io->mddev = mddev; md_io->orig_bi_end_io = bio->bi_end_io; md_io->orig_bi_private = bio->bi_private; + md_io->orig_bi_bdev = bio->bi_bdev; bio->bi_end_io = md_end_io; bio->bi_private = md_io; - md_io->start_time = part_start_io_acct(mddev->gendisk, - &md_io->part, bio); + md_io->start_time = bio_start_io_acct(bio); } /* bio could be mergeable after passing to underlayer */ diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 989c5d19eb7d2d..3a6103562fa8f7 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1943,22 +1943,9 @@ unsigned long disk_start_io_acct(struct gendisk *disk, unsigned int sectors, void disk_end_io_acct(struct gendisk *disk, unsigned int op, unsigned long start_time); -unsigned long part_start_io_acct(struct gendisk *disk, - struct block_device **part, struct bio *bio); -void part_end_io_acct(struct block_device *part, struct bio *bio, - unsigned long start_time); - -/** - * bio_start_io_acct - start I/O accounting for bio based drivers - * @bio: bio to start account for - * - * Returns the start time that should be passed back to bio_end_io_acct(). - */ -static inline unsigned long bio_start_io_acct(struct bio *bio) -{ - return disk_start_io_acct(bio->bi_bdev->bd_disk, bio_sectors(bio), - bio_op(bio)); -} +unsigned long bio_start_io_acct(struct bio *bio); +void bio_end_io_acct_remapped(struct bio *bio, unsigned long start_time, + struct block_device *orig_bdev); /** * bio_end_io_acct - end I/O accounting for bio based drivers @@ -1967,7 +1954,7 @@ static inline unsigned long bio_start_io_acct(struct bio *bio) */ static inline void bio_end_io_acct(struct bio *bio, unsigned long start_time) { - return disk_end_io_acct(bio->bi_bdev->bd_disk, bio_op(bio), start_time); + return bio_end_io_acct_remapped(bio, start_time, bio->bi_bdev); } int bdev_read_only(struct block_device *bdev); -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 5/9] block: use ->bi_bdev for bio based I/O accounting 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 23:05 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:05 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:20PM +0100, Christoph Hellwig wrote: > Rework the I/O accounting for bio based drivers to use ->bi_bdev. This > means all drivers can now simply use bio_start_io_acct to start > accounting, and it will take partitions into account automatically. To > end I/O account either bio_end_io_acct can be used if the driver never > remaps I/O to a different device, or bio_end_io_acct_remapped if the > driver did remap the I/O. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 5/9] block: use ->bi_bdev for bio based I/O accounting @ 2020-12-02 23:05 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:05 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:20PM +0100, Christoph Hellwig wrote: > Rework the I/O accounting for bio based drivers to use ->bi_bdev. This > means all drivers can now simply use bio_start_io_acct to start > accounting, and it will take partitions into account automatically. To > end I/O account either bio_end_io_acct can be used if the driver never > remaps I/O to a different device, or bio_end_io_acct_remapped if the > driver did remap the I/O. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 6/9] blk-mq: use ->bi_bdev for I/O accounting 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block Remove the reverse map from a sector to a partition for I/O accounting by simply using ->bi_bdev. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 6 +++++- block/blk.h | 2 -- block/genhd.c | 48 ------------------------------------------------ 3 files changed, 5 insertions(+), 51 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index d53cc887e1b8ea..ad041e903b0a8f 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1296,7 +1296,11 @@ void blk_account_io_start(struct request *rq) if (!blk_do_io_stat(rq)) return; - rq->part = disk_map_sector_rcu(rq->rq_disk, blk_rq_pos(rq)); + /* passthrough requests can hold bios that do not have ->bi_bdev set */ + if (rq->bio && rq->bio->bi_bdev) + rq->part = rq->bio->bi_bdev; + else + rq->part = rq->rq_disk->part0; part_stat_lock(); update_io_ticks(rq->part, jiffies, false); diff --git a/block/blk.h b/block/blk.h index 64dc8e5a3f44cb..f93a6af04adbd1 100644 --- a/block/blk.h +++ b/block/blk.h @@ -346,8 +346,6 @@ void blk_queue_free_zone_bitmaps(struct request_queue *q); static inline void blk_queue_free_zone_bitmaps(struct request_queue *q) {} #endif -struct block_device *disk_map_sector_rcu(struct gendisk *disk, sector_t sector); - int blk_alloc_devt(struct block_device *part, dev_t *devt); void blk_free_devt(dev_t devt); char *disk_name(struct gendisk *hd, int partno, char *buf); diff --git a/block/genhd.c b/block/genhd.c index 57c709a9f90267..3b9cd766d95228 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -280,54 +280,6 @@ void disk_part_iter_exit(struct disk_part_iter *piter) } EXPORT_SYMBOL_GPL(disk_part_iter_exit); -static inline int sector_in_part(struct block_device *part, sector_t sector) -{ - return part->bd_start_sect <= sector && - sector < part->bd_start_sect + bdev_nr_sectors(part); -} - -/** - * disk_map_sector_rcu - map sector to partition - * @disk: gendisk of interest - * @sector: sector to map - * - * Find out which partition @sector maps to on @disk. This is - * primarily used for stats accounting. - * - * CONTEXT: - * RCU read locked. - * - * RETURNS: - * Found partition on success, part0 is returned if no partition matches - * or the matched partition is being deleted. - */ -struct block_device *disk_map_sector_rcu(struct gendisk *disk, sector_t sector) -{ - struct disk_part_tbl *ptbl; - struct block_device *part; - int i; - - rcu_read_lock(); - ptbl = rcu_dereference(disk->part_tbl); - - part = rcu_dereference(ptbl->last_lookup); - if (part && sector_in_part(part, sector)) - goto out_unlock; - - for (i = 1; i < ptbl->len; i++) { - part = rcu_dereference(ptbl->part[i]); - if (part && sector_in_part(part, sector)) { - rcu_assign_pointer(ptbl->last_lookup, part); - goto out_unlock; - } - } - - part = disk->part0; -out_unlock: - rcu_read_unlock(); - return part; -} - /** * disk_has_partitions * @disk: gendisk of interest -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 6/9] blk-mq: use ->bi_bdev for I/O accounting @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo Remove the reverse map from a sector to a partition for I/O accounting by simply using ->bi_bdev. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 6 +++++- block/blk.h | 2 -- block/genhd.c | 48 ------------------------------------------------ 3 files changed, 5 insertions(+), 51 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index d53cc887e1b8ea..ad041e903b0a8f 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1296,7 +1296,11 @@ void blk_account_io_start(struct request *rq) if (!blk_do_io_stat(rq)) return; - rq->part = disk_map_sector_rcu(rq->rq_disk, blk_rq_pos(rq)); + /* passthrough requests can hold bios that do not have ->bi_bdev set */ + if (rq->bio && rq->bio->bi_bdev) + rq->part = rq->bio->bi_bdev; + else + rq->part = rq->rq_disk->part0; part_stat_lock(); update_io_ticks(rq->part, jiffies, false); diff --git a/block/blk.h b/block/blk.h index 64dc8e5a3f44cb..f93a6af04adbd1 100644 --- a/block/blk.h +++ b/block/blk.h @@ -346,8 +346,6 @@ void blk_queue_free_zone_bitmaps(struct request_queue *q); static inline void blk_queue_free_zone_bitmaps(struct request_queue *q) {} #endif -struct block_device *disk_map_sector_rcu(struct gendisk *disk, sector_t sector); - int blk_alloc_devt(struct block_device *part, dev_t *devt); void blk_free_devt(dev_t devt); char *disk_name(struct gendisk *hd, int partno, char *buf); diff --git a/block/genhd.c b/block/genhd.c index 57c709a9f90267..3b9cd766d95228 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -280,54 +280,6 @@ void disk_part_iter_exit(struct disk_part_iter *piter) } EXPORT_SYMBOL_GPL(disk_part_iter_exit); -static inline int sector_in_part(struct block_device *part, sector_t sector) -{ - return part->bd_start_sect <= sector && - sector < part->bd_start_sect + bdev_nr_sectors(part); -} - -/** - * disk_map_sector_rcu - map sector to partition - * @disk: gendisk of interest - * @sector: sector to map - * - * Find out which partition @sector maps to on @disk. This is - * primarily used for stats accounting. - * - * CONTEXT: - * RCU read locked. - * - * RETURNS: - * Found partition on success, part0 is returned if no partition matches - * or the matched partition is being deleted. - */ -struct block_device *disk_map_sector_rcu(struct gendisk *disk, sector_t sector) -{ - struct disk_part_tbl *ptbl; - struct block_device *part; - int i; - - rcu_read_lock(); - ptbl = rcu_dereference(disk->part_tbl); - - part = rcu_dereference(ptbl->last_lookup); - if (part && sector_in_part(part, sector)) - goto out_unlock; - - for (i = 1; i < ptbl->len; i++) { - part = rcu_dereference(ptbl->part[i]); - if (part && sector_in_part(part, sector)) { - rcu_assign_pointer(ptbl->last_lookup, part); - goto out_unlock; - } - } - - part = disk->part0; -out_unlock: - rcu_read_unlock(); - return part; -} - /** * disk_has_partitions * @disk: gendisk of interest -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 6/9] blk-mq: use ->bi_bdev for I/O accounting 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 23:06 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:06 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:21PM +0100, Christoph Hellwig wrote: > Remove the reverse map from a sector to a partition for I/O accounting by > simply using ->bi_bdev. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 6/9] blk-mq: use ->bi_bdev for I/O accounting @ 2020-12-02 23:06 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:06 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:21PM +0100, Christoph Hellwig wrote: > Remove the reverse map from a sector to a partition for I/O accounting by > simply using ->bi_bdev. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 7/9] block: add a disk_uevent helper 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block Add a helper to call kobject_uevent for the disk and all partitions, and unexport the disk_part_iter_* helpers that are now only used in the core block code. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/genhd.c | 27 ++++++++++++++------------- drivers/s390/block/dasd.c | 26 +++++--------------------- include/linux/genhd.h | 2 ++ 3 files changed, 21 insertions(+), 34 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 3b9cd766d95228..65dba32df5474f 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -201,7 +201,6 @@ void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, rcu_read_unlock(); } -EXPORT_SYMBOL_GPL(disk_part_iter_init); /** * disk_part_iter_next - proceed iterator to the next partition and return it @@ -261,7 +260,6 @@ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) return piter->part; } -EXPORT_SYMBOL_GPL(disk_part_iter_next); /** * disk_part_iter_exit - finish up partition iteration @@ -278,7 +276,6 @@ void disk_part_iter_exit(struct disk_part_iter *piter) bdput(piter->part); piter->part = NULL; } -EXPORT_SYMBOL_GPL(disk_part_iter_exit); /** * disk_has_partitions @@ -550,6 +547,18 @@ static char *bdevt_str(dev_t devt, char *buf) return buf; } +void disk_uevent(struct gendisk *disk, enum kobject_action action) +{ + struct disk_part_iter piter; + struct block_device *part; + + disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0); + while ((part = disk_part_iter_next(&piter))) + kobject_uevent(bdev_kobj(part), action); + disk_part_iter_exit(&piter); +} +EXPORT_SYMBOL_GPL(disk_uevent); + static void disk_scan_partitions(struct gendisk *disk) { struct block_device *bdev; @@ -567,8 +576,6 @@ static void register_disk(struct device *parent, struct gendisk *disk, const struct attribute_group **groups) { struct device *ddev = disk_to_dev(disk); - struct disk_part_iter piter; - struct block_device *part; int err; ddev->parent = parent; @@ -611,15 +618,9 @@ static void register_disk(struct device *parent, struct gendisk *disk, disk_scan_partitions(disk); - /* announce disk after possible partitions are created */ + /* announce the disk and partitions after all partitions are created */ dev_set_uevent_suppress(ddev, 0); - kobject_uevent(&ddev->kobj, KOBJ_ADD); - - /* announce possible partitions */ - disk_part_iter_init(&piter, disk, 0); - while ((part = disk_part_iter_next(&piter))) - kobject_uevent(bdev_kobj(part), KOBJ_ADD); - disk_part_iter_exit(&piter); + disk_uevent(disk, KOBJ_ADD); if (disk->queue->backing_dev_info->dev) { err = sysfs_create_link(&ddev->kobj, diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c index 1825fa8d05a780..bb0c63fbdabc01 100644 --- a/drivers/s390/block/dasd.c +++ b/drivers/s390/block/dasd.c @@ -430,23 +430,15 @@ static int dasd_state_unfmt_to_basic(struct dasd_device *device) static int dasd_state_ready_to_online(struct dasd_device * device) { - struct gendisk *disk; - struct disk_part_iter piter; - struct block_device *part; - device->state = DASD_STATE_ONLINE; if (device->block) { dasd_schedule_block_bh(device->block); if ((device->features & DASD_FEATURE_USERAW)) { - disk = device->block->gdp; - kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE); + kobject_uevent(&disk_to_dev(device->block->gdp)->kobj, + KOBJ_CHANGE); return 0; } - disk = device->block->bdev->bd_disk; - disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0); - while ((part = disk_part_iter_next(&piter))) - kobject_uevent(bdev_kobj(part), KOBJ_CHANGE); - disk_part_iter_exit(&piter); + disk_uevent(device->block->bdev->bd_disk, KOBJ_CHANGE); } return 0; } @@ -457,9 +449,6 @@ dasd_state_ready_to_online(struct dasd_device * device) static int dasd_state_online_to_ready(struct dasd_device *device) { int rc; - struct gendisk *disk; - struct disk_part_iter piter; - struct block_device *part; if (device->discipline->online_to_ready) { rc = device->discipline->online_to_ready(device); @@ -468,13 +457,8 @@ static int dasd_state_online_to_ready(struct dasd_device *device) } device->state = DASD_STATE_READY; - if (device->block && !(device->features & DASD_FEATURE_USERAW)) { - disk = device->block->bdev->bd_disk; - disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0); - while ((part = disk_part_iter_next(&piter))) - kobject_uevent(bdev_kobj(part), KOBJ_CHANGE); - disk_part_iter_exit(&piter); - } + if (device->block && !(device->features & DASD_FEATURE_USERAW)) + disk_uevent(device->block->bdev->bd_disk, KOBJ_CHANGE); return 0; } diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 809aaa32d53cba..191f5e4ae4e93b 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -212,6 +212,8 @@ static inline dev_t disk_devt(struct gendisk *disk) return MKDEV(disk->major, disk->first_minor); } +void disk_uevent(struct gendisk *disk, enum kobject_action action); + /* * Smarter partition iterator without context limits. */ -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 7/9] block: add a disk_uevent helper @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo Add a helper to call kobject_uevent for the disk and all partitions, and unexport the disk_part_iter_* helpers that are now only used in the core block code. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/genhd.c | 27 ++++++++++++++------------- drivers/s390/block/dasd.c | 26 +++++--------------------- include/linux/genhd.h | 2 ++ 3 files changed, 21 insertions(+), 34 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 3b9cd766d95228..65dba32df5474f 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -201,7 +201,6 @@ void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, rcu_read_unlock(); } -EXPORT_SYMBOL_GPL(disk_part_iter_init); /** * disk_part_iter_next - proceed iterator to the next partition and return it @@ -261,7 +260,6 @@ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) return piter->part; } -EXPORT_SYMBOL_GPL(disk_part_iter_next); /** * disk_part_iter_exit - finish up partition iteration @@ -278,7 +276,6 @@ void disk_part_iter_exit(struct disk_part_iter *piter) bdput(piter->part); piter->part = NULL; } -EXPORT_SYMBOL_GPL(disk_part_iter_exit); /** * disk_has_partitions @@ -550,6 +547,18 @@ static char *bdevt_str(dev_t devt, char *buf) return buf; } +void disk_uevent(struct gendisk *disk, enum kobject_action action) +{ + struct disk_part_iter piter; + struct block_device *part; + + disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0); + while ((part = disk_part_iter_next(&piter))) + kobject_uevent(bdev_kobj(part), action); + disk_part_iter_exit(&piter); +} +EXPORT_SYMBOL_GPL(disk_uevent); + static void disk_scan_partitions(struct gendisk *disk) { struct block_device *bdev; @@ -567,8 +576,6 @@ static void register_disk(struct device *parent, struct gendisk *disk, const struct attribute_group **groups) { struct device *ddev = disk_to_dev(disk); - struct disk_part_iter piter; - struct block_device *part; int err; ddev->parent = parent; @@ -611,15 +618,9 @@ static void register_disk(struct device *parent, struct gendisk *disk, disk_scan_partitions(disk); - /* announce disk after possible partitions are created */ + /* announce the disk and partitions after all partitions are created */ dev_set_uevent_suppress(ddev, 0); - kobject_uevent(&ddev->kobj, KOBJ_ADD); - - /* announce possible partitions */ - disk_part_iter_init(&piter, disk, 0); - while ((part = disk_part_iter_next(&piter))) - kobject_uevent(bdev_kobj(part), KOBJ_ADD); - disk_part_iter_exit(&piter); + disk_uevent(disk, KOBJ_ADD); if (disk->queue->backing_dev_info->dev) { err = sysfs_create_link(&ddev->kobj, diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c index 1825fa8d05a780..bb0c63fbdabc01 100644 --- a/drivers/s390/block/dasd.c +++ b/drivers/s390/block/dasd.c @@ -430,23 +430,15 @@ static int dasd_state_unfmt_to_basic(struct dasd_device *device) static int dasd_state_ready_to_online(struct dasd_device * device) { - struct gendisk *disk; - struct disk_part_iter piter; - struct block_device *part; - device->state = DASD_STATE_ONLINE; if (device->block) { dasd_schedule_block_bh(device->block); if ((device->features & DASD_FEATURE_USERAW)) { - disk = device->block->gdp; - kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE); + kobject_uevent(&disk_to_dev(device->block->gdp)->kobj, + KOBJ_CHANGE); return 0; } - disk = device->block->bdev->bd_disk; - disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0); - while ((part = disk_part_iter_next(&piter))) - kobject_uevent(bdev_kobj(part), KOBJ_CHANGE); - disk_part_iter_exit(&piter); + disk_uevent(device->block->bdev->bd_disk, KOBJ_CHANGE); } return 0; } @@ -457,9 +449,6 @@ dasd_state_ready_to_online(struct dasd_device * device) static int dasd_state_online_to_ready(struct dasd_device *device) { int rc; - struct gendisk *disk; - struct disk_part_iter piter; - struct block_device *part; if (device->discipline->online_to_ready) { rc = device->discipline->online_to_ready(device); @@ -468,13 +457,8 @@ static int dasd_state_online_to_ready(struct dasd_device *device) } device->state = DASD_STATE_READY; - if (device->block && !(device->features & DASD_FEATURE_USERAW)) { - disk = device->block->bdev->bd_disk; - disk_part_iter_init(&piter, disk, DISK_PITER_INCL_PART0); - while ((part = disk_part_iter_next(&piter))) - kobject_uevent(bdev_kobj(part), KOBJ_CHANGE); - disk_part_iter_exit(&piter); - } + if (device->block && !(device->features & DASD_FEATURE_USERAW)) + disk_uevent(device->block->bdev->bd_disk, KOBJ_CHANGE); return 0; } diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 809aaa32d53cba..191f5e4ae4e93b 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -212,6 +212,8 @@ static inline dev_t disk_devt(struct gendisk *disk) return MKDEV(disk->major, disk->first_minor); } +void disk_uevent(struct gendisk *disk, enum kobject_action action); + /* * Smarter partition iterator without context limits. */ -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 7/9] block: add a disk_uevent helper 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 23:08 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:08 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:22PM +0100, Christoph Hellwig wrote: > Add a helper to call kobject_uevent for the disk and all partitions, and > unexport the disk_part_iter_* helpers that are now only used in the core > block code. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 7/9] block: add a disk_uevent helper @ 2020-12-02 23:08 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:08 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:22PM +0100, Christoph Hellwig wrote: > Add a helper to call kobject_uevent for the disk and all partitions, and > unexport the disk_part_iter_* helpers that are now only used in the core > block code. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 8/9] block: remove DISK_PITER_REVERSE 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block There is good reason to iterate backwards when deleting all partitions in del_gendisk, just like we don't in blk_drop_partitions. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/genhd.c | 34 ++++------------------------------ include/linux/genhd.h | 1 - 2 files changed, 4 insertions(+), 31 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 65dba32df5474f..7730ddabebba92 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -182,24 +182,13 @@ static struct block_device *__disk_get_part(struct gendisk *disk, int partno) void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, unsigned int flags) { - struct disk_part_tbl *ptbl; - - rcu_read_lock(); - ptbl = rcu_dereference(disk->part_tbl); - piter->disk = disk; piter->part = NULL; - - if (flags & DISK_PITER_REVERSE) - piter->idx = ptbl->len - 1; - else if (flags & (DISK_PITER_INCL_PART0 | DISK_PITER_INCL_EMPTY_PART0)) + if (flags & (DISK_PITER_INCL_PART0 | DISK_PITER_INCL_EMPTY_PART0)) piter->idx = 0; else piter->idx = 1; - piter->flags = flags; - - rcu_read_unlock(); } /** @@ -214,7 +203,6 @@ void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, struct block_device *disk_part_iter_next(struct disk_part_iter *piter) { struct disk_part_tbl *ptbl; - int inc, end; /* put the last partition */ disk_part_iter_exit(piter); @@ -223,21 +211,8 @@ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) rcu_read_lock(); ptbl = rcu_dereference(piter->disk->part_tbl); - /* determine iteration parameters */ - if (piter->flags & DISK_PITER_REVERSE) { - inc = -1; - if (piter->flags & (DISK_PITER_INCL_PART0 | - DISK_PITER_INCL_EMPTY_PART0)) - end = -1; - else - end = 0; - } else { - inc = 1; - end = ptbl->len; - } - /* iterate to the next partition */ - for (; piter->idx != end; piter->idx += inc) { + for (; piter->idx != ptbl->len; piter->idx += 1) { struct block_device *part; part = rcu_dereference(ptbl->part[piter->idx]); @@ -252,7 +227,7 @@ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) piter->part = bdgrab(part); if (!piter->part) continue; - piter->idx += inc; + piter->idx += 1; break; } @@ -776,8 +751,7 @@ void del_gendisk(struct gendisk *disk) down_write(&bdev_lookup_sem); /* invalidate stuff */ - disk_part_iter_init(&piter, disk, - DISK_PITER_INCL_EMPTY | DISK_PITER_REVERSE); + disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY); while ((part = disk_part_iter_next(&piter))) { invalidate_partition(part); delete_partition(part); diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 191f5e4ae4e93b..425956ac9315fa 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -217,7 +217,6 @@ void disk_uevent(struct gendisk *disk, enum kobject_action action); /* * Smarter partition iterator without context limits. */ -#define DISK_PITER_REVERSE (1 << 0) /* iterate in the reverse direction */ #define DISK_PITER_INCL_EMPTY (1 << 1) /* include 0-sized parts */ #define DISK_PITER_INCL_PART0 (1 << 2) /* include partition 0 */ #define DISK_PITER_INCL_EMPTY_PART0 (1 << 3) /* include empty partition 0 */ -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 8/9] block: remove DISK_PITER_REVERSE @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo There is good reason to iterate backwards when deleting all partitions in del_gendisk, just like we don't in blk_drop_partitions. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/genhd.c | 34 ++++------------------------------ include/linux/genhd.h | 1 - 2 files changed, 4 insertions(+), 31 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 65dba32df5474f..7730ddabebba92 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -182,24 +182,13 @@ static struct block_device *__disk_get_part(struct gendisk *disk, int partno) void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, unsigned int flags) { - struct disk_part_tbl *ptbl; - - rcu_read_lock(); - ptbl = rcu_dereference(disk->part_tbl); - piter->disk = disk; piter->part = NULL; - - if (flags & DISK_PITER_REVERSE) - piter->idx = ptbl->len - 1; - else if (flags & (DISK_PITER_INCL_PART0 | DISK_PITER_INCL_EMPTY_PART0)) + if (flags & (DISK_PITER_INCL_PART0 | DISK_PITER_INCL_EMPTY_PART0)) piter->idx = 0; else piter->idx = 1; - piter->flags = flags; - - rcu_read_unlock(); } /** @@ -214,7 +203,6 @@ void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, struct block_device *disk_part_iter_next(struct disk_part_iter *piter) { struct disk_part_tbl *ptbl; - int inc, end; /* put the last partition */ disk_part_iter_exit(piter); @@ -223,21 +211,8 @@ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) rcu_read_lock(); ptbl = rcu_dereference(piter->disk->part_tbl); - /* determine iteration parameters */ - if (piter->flags & DISK_PITER_REVERSE) { - inc = -1; - if (piter->flags & (DISK_PITER_INCL_PART0 | - DISK_PITER_INCL_EMPTY_PART0)) - end = -1; - else - end = 0; - } else { - inc = 1; - end = ptbl->len; - } - /* iterate to the next partition */ - for (; piter->idx != end; piter->idx += inc) { + for (; piter->idx != ptbl->len; piter->idx += 1) { struct block_device *part; part = rcu_dereference(ptbl->part[piter->idx]); @@ -252,7 +227,7 @@ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) piter->part = bdgrab(part); if (!piter->part) continue; - piter->idx += inc; + piter->idx += 1; break; } @@ -776,8 +751,7 @@ void del_gendisk(struct gendisk *disk) down_write(&bdev_lookup_sem); /* invalidate stuff */ - disk_part_iter_init(&piter, disk, - DISK_PITER_INCL_EMPTY | DISK_PITER_REVERSE); + disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY); while ((part = disk_part_iter_next(&piter))) { invalidate_partition(part); delete_partition(part); diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 191f5e4ae4e93b..425956ac9315fa 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -217,7 +217,6 @@ void disk_uevent(struct gendisk *disk, enum kobject_action action); /* * Smarter partition iterator without context limits. */ -#define DISK_PITER_REVERSE (1 << 0) /* iterate in the reverse direction */ #define DISK_PITER_INCL_EMPTY (1 << 1) /* include 0-sized parts */ #define DISK_PITER_INCL_PART0 (1 << 2) /* include partition 0 */ #define DISK_PITER_INCL_EMPTY_PART0 (1 << 3) /* include empty partition 0 */ -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 8/9] block: remove DISK_PITER_REVERSE 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 23:15 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:15 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:23PM +0100, Christoph Hellwig wrote: > There is good reason to iterate backwards when deleting all partitions in > del_gendisk, just like we don't in blk_drop_partitions. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Yeah, I was blindly keeping the iteration order. Can't find any explicit explanation why it was that way. The reverse iteration there goes back to the initial git import. But yeah, I can't think of any meaningful difference which can come out of it. Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 8/9] block: remove DISK_PITER_REVERSE @ 2020-12-02 23:15 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:15 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:23PM +0100, Christoph Hellwig wrote: > There is good reason to iterate backwards when deleting all partitions in > del_gendisk, just like we don't in blk_drop_partitions. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Yeah, I was blindly keeping the iteration order. Can't find any explicit explanation why it was that way. The reverse iteration there goes back to the initial git import. But yeah, I can't think of any meaningful difference which can come out of it. Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* [PATCH 9/9] block: use an xarray for disk->part_tbl 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-01 16:54 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block Now that no fast path lookups in the partition table are left, there is no point in micro-optimizing the data structure for it. Just use a bog standard xarray. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-settings.c | 2 +- block/blk.h | 1 - block/genhd.c | 156 +++------------------------------------- block/partitions/core.c | 31 ++------ include/linux/genhd.h | 18 +---- 5 files changed, 21 insertions(+), 187 deletions(-) diff --git a/block/blk-settings.c b/block/blk-settings.c index 9741d1d83e989c..969031faa88f1c 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -849,7 +849,7 @@ void blk_queue_set_zoned(struct gendisk *disk, enum blk_zoned_model model) * we do nothing special as far as the block layer is concerned. */ if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED) || - disk_has_partitions(disk)) + !xa_empty(&disk->part_tbl)) model = BLK_ZONED_NONE; break; case BLK_ZONED_NONE: diff --git a/block/blk.h b/block/blk.h index f93a6af04adbd1..8d08b921bce585 100644 --- a/block/blk.h +++ b/block/blk.h @@ -358,7 +358,6 @@ int bdev_add_partition(struct block_device *bdev, int partno, int bdev_del_partition(struct block_device *bdev, int partno); int bdev_resize_partition(struct block_device *bdev, int partno, sector_t start, sector_t length); -int disk_expand_part_tbl(struct gendisk *disk, int target); int bio_add_hw_page(struct request_queue *q, struct bio *bio, struct page *page, unsigned int len, unsigned int offset, diff --git a/block/genhd.c b/block/genhd.c index 7730ddabebba92..09ff6cef028729 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -159,15 +159,6 @@ static void part_in_flight_rw(struct block_device *part, inflight[1] = 0; } -static struct block_device *__disk_get_part(struct gendisk *disk, int partno) -{ - struct disk_part_tbl *ptbl = rcu_dereference(disk->part_tbl); - - if (unlikely(partno < 0 || partno >= ptbl->len)) - return NULL; - return rcu_dereference(ptbl->part[partno]); -} - /** * disk_part_iter_init - initialize partition iterator * @piter: iterator to initialize @@ -202,35 +193,25 @@ void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, */ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) { - struct disk_part_tbl *ptbl; + struct block_device *part; + unsigned long idx; /* put the last partition */ disk_part_iter_exit(piter); - /* get part_tbl */ rcu_read_lock(); - ptbl = rcu_dereference(piter->disk->part_tbl); - - /* iterate to the next partition */ - for (; piter->idx != ptbl->len; piter->idx += 1) { - struct block_device *part; - - part = rcu_dereference(ptbl->part[piter->idx]); - if (!part) - continue; + xa_for_each_start(&piter->disk->part_tbl, idx, part, piter->idx) { if (!bdev_nr_sectors(part) && !(piter->flags & DISK_PITER_INCL_EMPTY) && !(piter->flags & DISK_PITER_INCL_EMPTY_PART0 && piter->idx == 0)) continue; - piter->part = bdgrab(part); if (!piter->part) continue; - piter->idx += 1; + piter->idx = idx + 1; break; } - rcu_read_unlock(); return piter->part; @@ -252,42 +233,6 @@ void disk_part_iter_exit(struct disk_part_iter *piter) piter->part = NULL; } -/** - * disk_has_partitions - * @disk: gendisk of interest - * - * Walk through the partition table and check if valid partition exists. - * - * CONTEXT: - * Don't care. - * - * RETURNS: - * True if the gendisk has at least one valid non-zero size partition. - * Otherwise false. - */ -bool disk_has_partitions(struct gendisk *disk) -{ - struct disk_part_tbl *ptbl; - int i; - bool ret = false; - - rcu_read_lock(); - ptbl = rcu_dereference(disk->part_tbl); - - /* Iterate partitions skipping the whole device at index 0 */ - for (i = 1; i < ptbl->len; i++) { - if (rcu_dereference(ptbl->part[i])) { - ret = true; - break; - } - } - - rcu_read_unlock(); - - return ret; -} -EXPORT_SYMBOL_GPL(disk_has_partitions); - /* * Can be deleted altogether. Later. * @@ -850,7 +795,7 @@ struct block_device *bdget_disk(struct gendisk *disk, int partno) struct block_device *bdev = NULL; rcu_read_lock(); - bdev = __disk_get_part(disk, partno); + bdev = xa_load(&disk->part_tbl, partno); if (bdev && !bdgrab(bdev)) bdev = NULL; rcu_read_unlock(); @@ -1240,83 +1185,6 @@ static const struct attribute_group *disk_attr_groups[] = { NULL }; -/** - * disk_replace_part_tbl - replace disk->part_tbl in RCU-safe way - * @disk: disk to replace part_tbl for - * @new_ptbl: new part_tbl to install - * - * Replace disk->part_tbl with @new_ptbl in RCU-safe way. The - * original ptbl is freed using RCU callback. - * - * LOCKING: - * Matching bd_mutex locked or the caller is the only user of @disk. - */ -static void disk_replace_part_tbl(struct gendisk *disk, - struct disk_part_tbl *new_ptbl) -{ - struct disk_part_tbl *old_ptbl = - rcu_dereference_protected(disk->part_tbl, 1); - - rcu_assign_pointer(disk->part_tbl, new_ptbl); - - if (old_ptbl) { - rcu_assign_pointer(old_ptbl->last_lookup, NULL); - kfree_rcu(old_ptbl, rcu_head); - } -} - -/** - * disk_expand_part_tbl - expand disk->part_tbl - * @disk: disk to expand part_tbl for - * @partno: expand such that this partno can fit in - * - * Expand disk->part_tbl such that @partno can fit in. disk->part_tbl - * uses RCU to allow unlocked dereferencing for stats and other stuff. - * - * LOCKING: - * Matching bd_mutex locked or the caller is the only user of @disk. - * Might sleep. - * - * RETURNS: - * 0 on success, -errno on failure. - */ -int disk_expand_part_tbl(struct gendisk *disk, int partno) -{ - struct disk_part_tbl *old_ptbl = - rcu_dereference_protected(disk->part_tbl, 1); - struct disk_part_tbl *new_ptbl; - int len = old_ptbl ? old_ptbl->len : 0; - int i, target; - - /* - * check for int overflow, since we can get here from blkpg_ioctl() - * with a user passed 'partno'. - */ - target = partno + 1; - if (target < 0) - return -EINVAL; - - /* disk_max_parts() is zero during initialization, ignore if so */ - if (disk_max_parts(disk) && target > disk_max_parts(disk)) - return -EINVAL; - - if (target <= len) - return 0; - - new_ptbl = kzalloc_node(struct_size(new_ptbl, part, target), GFP_KERNEL, - disk->node_id); - if (!new_ptbl) - return -ENOMEM; - - new_ptbl->len = target; - - for (i = 0; i < len; i++) - rcu_assign_pointer(new_ptbl->part[i], old_ptbl->part[i]); - - disk_replace_part_tbl(disk, new_ptbl); - return 0; -} - /** * disk_release - releases all allocated resources of the gendisk * @dev: the device representing this disk @@ -1340,7 +1208,7 @@ static void disk_release(struct device *dev) blk_free_devt(dev->devt); disk_release_events(disk); kfree(disk->random); - disk_replace_part_tbl(disk, NULL); + xa_destroy(&disk->part_tbl); bdput(disk->part0); if (disk->queue) blk_put_queue(disk->queue); @@ -1493,7 +1361,6 @@ dev_t blk_lookup_devt(const char *name, int partno) struct gendisk *__alloc_disk_node(int minors, int node_id) { struct gendisk *disk; - struct disk_part_tbl *ptbl; if (minors > DISK_MAX_PARTS) { printk(KERN_ERR @@ -1511,11 +1378,9 @@ struct gendisk *__alloc_disk_node(int minors, int node_id) goto out_free_disk; disk->node_id = node_id; - if (disk_expand_part_tbl(disk, 0)) - goto out_bdput; - - ptbl = rcu_dereference_protected(disk->part_tbl, 1); - rcu_assign_pointer(ptbl->part[0], disk->part0); + xa_init(&disk->part_tbl); + if (xa_insert(&disk->part_tbl, 0, disk->part0, GFP_KERNEL)) + goto out_destroy_part_tbl; disk->minors = minors; rand_initialize_disk(disk); @@ -1524,7 +1389,8 @@ struct gendisk *__alloc_disk_node(int minors, int node_id) device_initialize(disk_to_dev(disk)); return disk; -out_bdput: +out_destroy_part_tbl: + xa_destroy(&disk->part_tbl); bdput(disk->part0); out_free_disk: kfree(disk); diff --git a/block/partitions/core.c b/block/partitions/core.c index deca253583bd3f..c88f03ddaefe29 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -286,13 +286,7 @@ struct device_type part_type = { */ void delete_partition(struct block_device *part) { - struct gendisk *disk = part->bd_disk; - struct disk_part_tbl *ptbl = - rcu_dereference_protected(disk->part_tbl, 1); - - rcu_assign_pointer(ptbl->part[part->bd_partno], NULL); - rcu_assign_pointer(ptbl->last_lookup, NULL); - + xa_erase(&part->bd_disk->part_tbl, part->bd_partno); kobject_put(part->bd_holder_dir); device_del(&part->bd_device); @@ -324,7 +318,6 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, struct device *ddev = disk_to_dev(disk); struct device *pdev; struct block_device *bdev; - struct disk_part_tbl *ptbl; const char *dname; int err; @@ -346,12 +339,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, break; } - err = disk_expand_part_tbl(disk, partno); - if (err) - return ERR_PTR(err); - ptbl = rcu_dereference_protected(disk->part_tbl, 1); - - if (ptbl->part[partno]) + if (xa_load(&disk->part_tbl, partno)) return ERR_PTR(-EBUSY); bdev = bdev_alloc(disk, partno); @@ -405,8 +393,10 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, } /* everything is up and running, commence */ + err = xa_insert(&disk->part_tbl, partno, bdev, GFP_KERNEL); + if (err) + goto out_del; bdev_add(bdev, devt); - rcu_assign_pointer(ptbl->part[partno], bdev); /* suppress uevent if the disk suppresses it */ if (!dev_get_uevent_suppress(ddev)) @@ -612,7 +602,7 @@ static bool blk_add_partition(struct gendisk *disk, struct block_device *bdev, int blk_add_partitions(struct gendisk *disk, struct block_device *bdev) { struct parsed_partitions *state; - int ret = -EAGAIN, p, highest; + int ret = -EAGAIN, p; if (!disk_part_scan_enabled(disk)) return 0; @@ -660,15 +650,6 @@ int blk_add_partitions(struct gendisk *disk, struct block_device *bdev) /* tell userspace that the media / partition table may have changed */ kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE); - /* - * Detect the highest partition number and preallocate disk->part_tbl. - * This is an optimization and not strictly necessary. - */ - for (p = 1, highest = 0; p < state->limit; p++) - if (state->parts[p].size) - highest = p; - disk_expand_part_tbl(disk, highest); - for (p = 1; p < state->limit; p++) if (!blk_add_partition(disk, bdev, state, p)) goto out_free_state; diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 425956ac9315fa..e8821bfe07b955 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -32,6 +32,7 @@ extern struct class block_class; #include <linux/string.h> #include <linux/fs.h> #include <linux/workqueue.h> +#include <linux/xarray.h> #define PARTITION_META_INFO_VOLNAMELTH 64 /* @@ -116,13 +117,6 @@ enum { DISK_EVENT_FLAG_UEVENT = 1 << 1, }; -struct disk_part_tbl { - struct rcu_head rcu_head; - int len; - struct block_device __rcu *last_lookup; - struct block_device __rcu *part[]; -}; - struct disk_events; struct badblocks; @@ -148,12 +142,7 @@ struct gendisk { unsigned short events; /* supported events */ unsigned short event_flags; /* flags related to event processing */ - /* Array of pointers to partitions indexed by partno. - * Protected with matching bdev lock but stat and other - * non-critical accesses use RCU. Always access through - * helpers. - */ - struct disk_part_tbl __rcu *part_tbl; + struct xarray part_tbl; struct block_device *part0; const struct block_device_operations *fops; @@ -224,7 +213,7 @@ void disk_uevent(struct gendisk *disk, enum kobject_action action); struct disk_part_iter { struct gendisk *disk; struct block_device *part; - int idx; + unsigned long idx; unsigned int flags; }; @@ -232,7 +221,6 @@ extern void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, unsigned int flags); struct block_device *disk_part_iter_next(struct disk_part_iter *piter); extern void disk_part_iter_exit(struct disk_part_iter *piter); -extern bool disk_has_partitions(struct gendisk *disk); /* block/genhd.c */ extern void device_add_disk(struct device *parent, struct gendisk *disk, -- 2.29.2 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [dm-devel] [PATCH 9/9] block: use an xarray for disk->part_tbl @ 2020-12-01 16:54 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-01 16:54 UTC (permalink / raw) To: Jens Axboe Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo Now that no fast path lookups in the partition table are left, there is no point in micro-optimizing the data structure for it. Just use a bog standard xarray. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-settings.c | 2 +- block/blk.h | 1 - block/genhd.c | 156 +++------------------------------------- block/partitions/core.c | 31 ++------ include/linux/genhd.h | 18 +---- 5 files changed, 21 insertions(+), 187 deletions(-) diff --git a/block/blk-settings.c b/block/blk-settings.c index 9741d1d83e989c..969031faa88f1c 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -849,7 +849,7 @@ void blk_queue_set_zoned(struct gendisk *disk, enum blk_zoned_model model) * we do nothing special as far as the block layer is concerned. */ if (!IS_ENABLED(CONFIG_BLK_DEV_ZONED) || - disk_has_partitions(disk)) + !xa_empty(&disk->part_tbl)) model = BLK_ZONED_NONE; break; case BLK_ZONED_NONE: diff --git a/block/blk.h b/block/blk.h index f93a6af04adbd1..8d08b921bce585 100644 --- a/block/blk.h +++ b/block/blk.h @@ -358,7 +358,6 @@ int bdev_add_partition(struct block_device *bdev, int partno, int bdev_del_partition(struct block_device *bdev, int partno); int bdev_resize_partition(struct block_device *bdev, int partno, sector_t start, sector_t length); -int disk_expand_part_tbl(struct gendisk *disk, int target); int bio_add_hw_page(struct request_queue *q, struct bio *bio, struct page *page, unsigned int len, unsigned int offset, diff --git a/block/genhd.c b/block/genhd.c index 7730ddabebba92..09ff6cef028729 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -159,15 +159,6 @@ static void part_in_flight_rw(struct block_device *part, inflight[1] = 0; } -static struct block_device *__disk_get_part(struct gendisk *disk, int partno) -{ - struct disk_part_tbl *ptbl = rcu_dereference(disk->part_tbl); - - if (unlikely(partno < 0 || partno >= ptbl->len)) - return NULL; - return rcu_dereference(ptbl->part[partno]); -} - /** * disk_part_iter_init - initialize partition iterator * @piter: iterator to initialize @@ -202,35 +193,25 @@ void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, */ struct block_device *disk_part_iter_next(struct disk_part_iter *piter) { - struct disk_part_tbl *ptbl; + struct block_device *part; + unsigned long idx; /* put the last partition */ disk_part_iter_exit(piter); - /* get part_tbl */ rcu_read_lock(); - ptbl = rcu_dereference(piter->disk->part_tbl); - - /* iterate to the next partition */ - for (; piter->idx != ptbl->len; piter->idx += 1) { - struct block_device *part; - - part = rcu_dereference(ptbl->part[piter->idx]); - if (!part) - continue; + xa_for_each_start(&piter->disk->part_tbl, idx, part, piter->idx) { if (!bdev_nr_sectors(part) && !(piter->flags & DISK_PITER_INCL_EMPTY) && !(piter->flags & DISK_PITER_INCL_EMPTY_PART0 && piter->idx == 0)) continue; - piter->part = bdgrab(part); if (!piter->part) continue; - piter->idx += 1; + piter->idx = idx + 1; break; } - rcu_read_unlock(); return piter->part; @@ -252,42 +233,6 @@ void disk_part_iter_exit(struct disk_part_iter *piter) piter->part = NULL; } -/** - * disk_has_partitions - * @disk: gendisk of interest - * - * Walk through the partition table and check if valid partition exists. - * - * CONTEXT: - * Don't care. - * - * RETURNS: - * True if the gendisk has at least one valid non-zero size partition. - * Otherwise false. - */ -bool disk_has_partitions(struct gendisk *disk) -{ - struct disk_part_tbl *ptbl; - int i; - bool ret = false; - - rcu_read_lock(); - ptbl = rcu_dereference(disk->part_tbl); - - /* Iterate partitions skipping the whole device at index 0 */ - for (i = 1; i < ptbl->len; i++) { - if (rcu_dereference(ptbl->part[i])) { - ret = true; - break; - } - } - - rcu_read_unlock(); - - return ret; -} -EXPORT_SYMBOL_GPL(disk_has_partitions); - /* * Can be deleted altogether. Later. * @@ -850,7 +795,7 @@ struct block_device *bdget_disk(struct gendisk *disk, int partno) struct block_device *bdev = NULL; rcu_read_lock(); - bdev = __disk_get_part(disk, partno); + bdev = xa_load(&disk->part_tbl, partno); if (bdev && !bdgrab(bdev)) bdev = NULL; rcu_read_unlock(); @@ -1240,83 +1185,6 @@ static const struct attribute_group *disk_attr_groups[] = { NULL }; -/** - * disk_replace_part_tbl - replace disk->part_tbl in RCU-safe way - * @disk: disk to replace part_tbl for - * @new_ptbl: new part_tbl to install - * - * Replace disk->part_tbl with @new_ptbl in RCU-safe way. The - * original ptbl is freed using RCU callback. - * - * LOCKING: - * Matching bd_mutex locked or the caller is the only user of @disk. - */ -static void disk_replace_part_tbl(struct gendisk *disk, - struct disk_part_tbl *new_ptbl) -{ - struct disk_part_tbl *old_ptbl = - rcu_dereference_protected(disk->part_tbl, 1); - - rcu_assign_pointer(disk->part_tbl, new_ptbl); - - if (old_ptbl) { - rcu_assign_pointer(old_ptbl->last_lookup, NULL); - kfree_rcu(old_ptbl, rcu_head); - } -} - -/** - * disk_expand_part_tbl - expand disk->part_tbl - * @disk: disk to expand part_tbl for - * @partno: expand such that this partno can fit in - * - * Expand disk->part_tbl such that @partno can fit in. disk->part_tbl - * uses RCU to allow unlocked dereferencing for stats and other stuff. - * - * LOCKING: - * Matching bd_mutex locked or the caller is the only user of @disk. - * Might sleep. - * - * RETURNS: - * 0 on success, -errno on failure. - */ -int disk_expand_part_tbl(struct gendisk *disk, int partno) -{ - struct disk_part_tbl *old_ptbl = - rcu_dereference_protected(disk->part_tbl, 1); - struct disk_part_tbl *new_ptbl; - int len = old_ptbl ? old_ptbl->len : 0; - int i, target; - - /* - * check for int overflow, since we can get here from blkpg_ioctl() - * with a user passed 'partno'. - */ - target = partno + 1; - if (target < 0) - return -EINVAL; - - /* disk_max_parts() is zero during initialization, ignore if so */ - if (disk_max_parts(disk) && target > disk_max_parts(disk)) - return -EINVAL; - - if (target <= len) - return 0; - - new_ptbl = kzalloc_node(struct_size(new_ptbl, part, target), GFP_KERNEL, - disk->node_id); - if (!new_ptbl) - return -ENOMEM; - - new_ptbl->len = target; - - for (i = 0; i < len; i++) - rcu_assign_pointer(new_ptbl->part[i], old_ptbl->part[i]); - - disk_replace_part_tbl(disk, new_ptbl); - return 0; -} - /** * disk_release - releases all allocated resources of the gendisk * @dev: the device representing this disk @@ -1340,7 +1208,7 @@ static void disk_release(struct device *dev) blk_free_devt(dev->devt); disk_release_events(disk); kfree(disk->random); - disk_replace_part_tbl(disk, NULL); + xa_destroy(&disk->part_tbl); bdput(disk->part0); if (disk->queue) blk_put_queue(disk->queue); @@ -1493,7 +1361,6 @@ dev_t blk_lookup_devt(const char *name, int partno) struct gendisk *__alloc_disk_node(int minors, int node_id) { struct gendisk *disk; - struct disk_part_tbl *ptbl; if (minors > DISK_MAX_PARTS) { printk(KERN_ERR @@ -1511,11 +1378,9 @@ struct gendisk *__alloc_disk_node(int minors, int node_id) goto out_free_disk; disk->node_id = node_id; - if (disk_expand_part_tbl(disk, 0)) - goto out_bdput; - - ptbl = rcu_dereference_protected(disk->part_tbl, 1); - rcu_assign_pointer(ptbl->part[0], disk->part0); + xa_init(&disk->part_tbl); + if (xa_insert(&disk->part_tbl, 0, disk->part0, GFP_KERNEL)) + goto out_destroy_part_tbl; disk->minors = minors; rand_initialize_disk(disk); @@ -1524,7 +1389,8 @@ struct gendisk *__alloc_disk_node(int minors, int node_id) device_initialize(disk_to_dev(disk)); return disk; -out_bdput: +out_destroy_part_tbl: + xa_destroy(&disk->part_tbl); bdput(disk->part0); out_free_disk: kfree(disk); diff --git a/block/partitions/core.c b/block/partitions/core.c index deca253583bd3f..c88f03ddaefe29 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -286,13 +286,7 @@ struct device_type part_type = { */ void delete_partition(struct block_device *part) { - struct gendisk *disk = part->bd_disk; - struct disk_part_tbl *ptbl = - rcu_dereference_protected(disk->part_tbl, 1); - - rcu_assign_pointer(ptbl->part[part->bd_partno], NULL); - rcu_assign_pointer(ptbl->last_lookup, NULL); - + xa_erase(&part->bd_disk->part_tbl, part->bd_partno); kobject_put(part->bd_holder_dir); device_del(&part->bd_device); @@ -324,7 +318,6 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, struct device *ddev = disk_to_dev(disk); struct device *pdev; struct block_device *bdev; - struct disk_part_tbl *ptbl; const char *dname; int err; @@ -346,12 +339,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, break; } - err = disk_expand_part_tbl(disk, partno); - if (err) - return ERR_PTR(err); - ptbl = rcu_dereference_protected(disk->part_tbl, 1); - - if (ptbl->part[partno]) + if (xa_load(&disk->part_tbl, partno)) return ERR_PTR(-EBUSY); bdev = bdev_alloc(disk, partno); @@ -405,8 +393,10 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, } /* everything is up and running, commence */ + err = xa_insert(&disk->part_tbl, partno, bdev, GFP_KERNEL); + if (err) + goto out_del; bdev_add(bdev, devt); - rcu_assign_pointer(ptbl->part[partno], bdev); /* suppress uevent if the disk suppresses it */ if (!dev_get_uevent_suppress(ddev)) @@ -612,7 +602,7 @@ static bool blk_add_partition(struct gendisk *disk, struct block_device *bdev, int blk_add_partitions(struct gendisk *disk, struct block_device *bdev) { struct parsed_partitions *state; - int ret = -EAGAIN, p, highest; + int ret = -EAGAIN, p; if (!disk_part_scan_enabled(disk)) return 0; @@ -660,15 +650,6 @@ int blk_add_partitions(struct gendisk *disk, struct block_device *bdev) /* tell userspace that the media / partition table may have changed */ kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE); - /* - * Detect the highest partition number and preallocate disk->part_tbl. - * This is an optimization and not strictly necessary. - */ - for (p = 1, highest = 0; p < state->limit; p++) - if (state->parts[p].size) - highest = p; - disk_expand_part_tbl(disk, highest); - for (p = 1; p < state->limit; p++) if (!blk_add_partition(disk, bdev, state, p)) goto out_free_state; diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 425956ac9315fa..e8821bfe07b955 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -32,6 +32,7 @@ extern struct class block_class; #include <linux/string.h> #include <linux/fs.h> #include <linux/workqueue.h> +#include <linux/xarray.h> #define PARTITION_META_INFO_VOLNAMELTH 64 /* @@ -116,13 +117,6 @@ enum { DISK_EVENT_FLAG_UEVENT = 1 << 1, }; -struct disk_part_tbl { - struct rcu_head rcu_head; - int len; - struct block_device __rcu *last_lookup; - struct block_device __rcu *part[]; -}; - struct disk_events; struct badblocks; @@ -148,12 +142,7 @@ struct gendisk { unsigned short events; /* supported events */ unsigned short event_flags; /* flags related to event processing */ - /* Array of pointers to partitions indexed by partno. - * Protected with matching bdev lock but stat and other - * non-critical accesses use RCU. Always access through - * helpers. - */ - struct disk_part_tbl __rcu *part_tbl; + struct xarray part_tbl; struct block_device *part0; const struct block_device_operations *fops; @@ -224,7 +213,7 @@ void disk_uevent(struct gendisk *disk, enum kobject_action action); struct disk_part_iter { struct gendisk *disk; struct block_device *part; - int idx; + unsigned long idx; unsigned int flags; }; @@ -232,7 +221,6 @@ extern void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk, unsigned int flags); struct block_device *disk_part_iter_next(struct disk_part_iter *piter); extern void disk_part_iter_exit(struct disk_part_iter *piter); -extern bool disk_has_partitions(struct gendisk *disk); /* block/genhd.c */ extern void device_add_disk(struct device *parent, struct gendisk *disk, -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [PATCH 9/9] block: use an xarray for disk->part_tbl 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 23:22 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:22 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:24PM +0100, Christoph Hellwig wrote: > Now that no fast path lookups in the partition table are left, there is > no point in micro-optimizing the data structure for it. Just use a bog > standard xarray. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks! -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] [PATCH 9/9] block: use an xarray for disk->part_tbl @ 2020-12-02 23:22 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 23:22 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:24PM +0100, Christoph Hellwig wrote: > Now that no fast path lookups in the partition table are left, there is > no point in micro-optimizing the data structure for it. Just use a bog > standard xarray. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks! -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-02 22:35 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:35 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote: > Hi Jens, > > this series switches back from storing the gendisk + partno to storing > a block_device pointer in struct bio. The reason is two fold: for one > the new struct block_device actually is always available, removing the > need to avoid originally. Second the merge struct block_device is much > more useful than the old one, as storing it avoids the need for looking > up what used to be hd_struct during partition remapping and I/O > accounting. > > Note that this series depends on the posted but not merged > "block tracepoint cleanups" series. I'm late but everything looks good to me. So much better than the mess we had before. Thank you. The only thing I noticed is that blkdev_get_no_open() can now use kobject_get() instead of kobject_get_unless_zero() as bdev lookup is synchronously disabled before device_del(). -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-02 22:35 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:35 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote: > Hi Jens, > > this series switches back from storing the gendisk + partno to storing > a block_device pointer in struct bio. The reason is two fold: for one > the new struct block_device actually is always available, removing the > need to avoid originally. Second the merge struct block_device is much > more useful than the old one, as storing it avoids the need for looking > up what used to be hd_struct during partition remapping and I/O > accounting. > > Note that this series depends on the posted but not merged > "block tracepoint cleanups" series. I'm late but everything looks good to me. So much better than the mess we had before. Thank you. The only thing I noticed is that blkdev_get_no_open() can now use kobject_get() instead of kobject_get_unless_zero() as bdev lookup is synchronously disabled before device_del(). -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-02 22:35 ` [dm-devel] " Tejun Heo @ 2020-12-02 22:37 ` Tejun Heo -1 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:37 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On Wed, Dec 02, 2020 at 05:35:21PM -0500, Tejun Heo wrote: > On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote: > > Hi Jens, > > > > this series switches back from storing the gendisk + partno to storing > > a block_device pointer in struct bio. The reason is two fold: for one > > the new struct block_device actually is always available, removing the > > need to avoid originally. Second the merge struct block_device is much > > more useful than the old one, as storing it avoids the need for looking > > up what used to be hd_struct during partition remapping and I/O > > accounting. > > > > Note that this series depends on the posted but not merged > > "block tracepoint cleanups" series. > > I'm late but everything looks good to me. So much better than the mess we > had before. Thank you. > > The only thing I noticed is that blkdev_get_no_open() can now use > kobject_get() instead of kobject_get_unless_zero() as bdev lookup is > synchronously disabled before device_del(). Oops, sorry, this was supposed to be a reply to the earlier hd_struct removal patchset. Reviewing this patchset now. Thanks. -- tejun ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-02 22:37 ` Tejun Heo 0 siblings, 0 replies; 68+ messages in thread From: Tejun Heo @ 2020-12-02 22:37 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block On Wed, Dec 02, 2020 at 05:35:21PM -0500, Tejun Heo wrote: > On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote: > > Hi Jens, > > > > this series switches back from storing the gendisk + partno to storing > > a block_device pointer in struct bio. The reason is two fold: for one > > the new struct block_device actually is always available, removing the > > need to avoid originally. Second the merge struct block_device is much > > more useful than the old one, as storing it avoids the need for looking > > up what used to be hd_struct during partition remapping and I/O > > accounting. > > > > Note that this series depends on the posted but not merged > > "block tracepoint cleanups" series. > > I'm late but everything looks good to me. So much better than the mess we > had before. Thank you. > > The only thing I noticed is that blkdev_get_no_open() can now use > kobject_get() instead of kobject_get_unless_zero() as bdev lookup is > synchronously disabled before device_del(). Oops, sorry, this was supposed to be a reply to the earlier hd_struct removal patchset. Reviewing this patchset now. Thanks. -- tejun -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-04 16:43 ` Jens Axboe -1 siblings, 0 replies; 68+ messages in thread From: Jens Axboe @ 2020-12-04 16:43 UTC (permalink / raw) To: Christoph Hellwig Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block On 12/1/20 9:54 AM, Christoph Hellwig wrote: > Hi Jens, > > this series switches back from storing the gendisk + partno to storing > a block_device pointer in struct bio. The reason is two fold: for one > the new struct block_device actually is always available, removing the > need to avoid originally. Second the merge struct block_device is much > more useful than the old one, as storing it avoids the need for looking > up what used to be hd_struct during partition remapping and I/O > accounting. > > Note that this series depends on the posted but not merged > "block tracepoint cleanups" series. Applied, thanks. -- Jens Axboe ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-04 16:43 ` Jens Axboe 0 siblings, 0 replies; 68+ messages in thread From: Jens Axboe @ 2020-12-04 16:43 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-s390, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, linux-block, Tejun Heo On 12/1/20 9:54 AM, Christoph Hellwig wrote: > Hi Jens, > > this series switches back from storing the gendisk + partno to storing > a block_device pointer in struct bio. The reason is two fold: for one > the new struct block_device actually is always available, removing the > need to avoid originally. Second the merge struct block_device is much > more useful than the old one, as storing it avoids the need for looking > up what used to be hd_struct during partition remapping and I/O > accounting. > > Note that this series depends on the posted but not merged > "block tracepoint cleanups" series. Applied, thanks. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig @ 2020-12-07 18:56 ` Qian Cai -1 siblings, 0 replies; 68+ messages in thread From: Qian Cai @ 2020-12-07 18:56 UTC (permalink / raw) To: Christoph Hellwig, Jens Axboe Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block, Stephen Rothwell, Linux Next Mailing List On Tue, 2020-12-01 at 17:54 +0100, Christoph Hellwig wrote: > Hi Jens, > > this series switches back from storing the gendisk + partno to storing > a block_device pointer in struct bio. The reason is two fold: for one > the new struct block_device actually is always available, removing the > need to avoid originally. Second the merge struct block_device is much > more useful than the old one, as storing it avoids the need for looking > up what used to be hd_struct during partition remapping and I/O > accounting. > > Note that this series depends on the posted but not merged > "block tracepoint cleanups" series. Reverting this patchset on the top of today's linux-next fixed data corruptions everywhere, i.e., $ git revert --no-edit a54895fa057c..4498a8536c81 (with a trivial conflict resolution with the commit "block: move blk_rq_bio_prep() to linux/blk-mq.h") .config (if ever matters and also happened on POWER9 NV): https://cailca.coding.net/public/linux/mm/git/files/master/x86.config == XFS failed to mount == [ 55.116279][ T1507] XFS (dm-0): Mounting V5 Filesystem [ 55.144671][ T1507] XFS (dm-0): Corruption warning: Metadata has LSN (3:70242) ahead of current LSN (3:66504). Please unmount and run xfs_repair (>= v4.3) to resolve. [ 55.159965][ T1507] XFS (dm-0): log mount/recovery failed: error -22 [ 55.288632][ T1507] XFS (dm-0): log mount failed In this case, it is not possible to mount the XFS rootfs anymore, and it can be repaired with "-L". However, we could lost vital files. Then, I have to re- install the system. systemd[1]: System cannot boot: Missing /etc/machine-id and /etc is mounted read-only. systemd[1]: Booting up is supported only when: systemd[1]: 1) /etc/machine-id exists and is populated. systemd[1]: 2) /etc/machine-id exists and is empty. systemd[1]: 3) /etc/machine-id is missing and /etc is writable. lvm2-activation-generator: lvmconfig failed systemd[1]: Failed to populate /etc with preset unit settings, ignoring: No such file or directory == systemd core dump == [ 46.124485][ T1028] Process 1028(systemd-coredum) has RLIMIT_CORE set to 1 [ 46.131434][ T1028] Aborting core [ 46.143366][ T1027] systemd-cgroups (1027) used greatest stack depth: 23512 bytes left [ 46.384430][ T1] printk: systemd: 20 output lines suppressed due to ratelimiting [ 46.447620][ T1] traps: systemd[1] trap invalid opcode ip:7f44c485fee6 sp:7ffee96e6960 error:0 in libm-2.28.so[7f44c481a000+181000] [ 46.492643][ T1029] traps: systemd-coredum[1029] trap invalid opcode ip:7f2f60471ee6 sp:7ffd58f76e00 error:0 in libm-2.28.so[7f2f6042c000+181000] [ 46.505968][ T1029] Process 1029(systemd-coredum) has RLIMIT_CORE set to 1 [ 46.512900][ T1029] Aborting core [ 46.520024][ T1] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 [ 46.528437][ T1] CPU: 32 PID: 1 Comm: systemd Not tainted 5.10.0-rc6-next-20201207 #1 [ 46.536581][ T1] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 [ 46.545860][ T1] Call Trace: [ 46.549038][ T1] dump_stack+0x99/0xcb [ 46.553082][ T1] panic+0x20c/0x48b [ 46.556860][ T1] ? print_oops_end_marker.cold.10+0x10/0x10 [ 46.562739][ T1] ? do_signal_stop+0x690/0x690 [ 46.567478][ T1] ? do_exit+0x226/0x2410 [ 46.571690][ T1] do_exit.cold.38+0x1de/0x1e5 [ 46.576346][ T1] ? rcu_read_lock_sched_held+0xa1/0xd0 [ 46.581782][ T1] ? rcu_read_lock_bh_held+0xb0/0xb0 [ 46.586955][ T1] ? mm_update_next_owner+0x750/0x750 [ 46.592215][ T1] ? get_signal+0x80f/0x1f90 [ 46.596688][ T1] do_group_exit+0xf0/0x2e0 [ 46.601076][ T1] get_signal+0x35a/0x1f90 [ 46.605380][ T1] ? finish_task_switch+0x1bb/0xa80 [ 46.610468][ T1] arch_do_signal_or_restart+0x1d8/0x690 [ 46.615993][ T1] ? __setup_rt_frame.isra.15+0x1830/0x1830 [ 46.621781][ T1] ? __sched_text_start+0x8/0x8 [ 46.626521][ T1] ? asm_exc_invalid_op+0xa/0x20 [ 46.631347][ T1] exit_to_user_mode_prepare+0xde/0x170 [ 46.636782][ T1] irqentry_exit_to_user_mode+0x5/0x30 [ 46.642129][ T1] asm_exc_invalid_op+0x12/0x20 [ 46.646868][ T1] RIP: 0033:0x7f44c485fee6 [ 46.651171][ T1] Code: 6d 6e 6f 70 71 72 73 74 75 76 77 78 79 7a 0a 00 41 42 43 44 45 46 47 48 49 4a 4b 4c 4d 4e 4f 50 51 52 53 54 55 56 57 58 59 5a <61> 62 63 64 65 66 67 68 6a 69 6b 6c 6d 6e 6f 70 71 72 73 74 75 76 [ 46.670757][ T1] RSP: 002b:00007ffee96e6960 EFLAGS: 00010202 [ 46.676719][ T1] RAX: 00007f44c481c780 RBX: 00007f44c4825e78 RCX: 0000000000000000 [ 46.684600][ T1] RDX: 00007ffee96e6a90 RSI: 0000000000000000 RDI: 00007f44c481c780 [ 46.692480][ T1] RBP: 00007ffee96e6a90 R08: 00007f44c85d88a8 R09: 00007f44c85d88a8 [ 46.700360][ T1] R10: 00007f44ca38e4f0 R11: 00007f44c481a000 R12: 00007f44c481c780 [ 46.708241][ T1] R13: 00007f44c4826088 R14: 00007f44c4b9b128 R15: 00007f44ca38e4f0 [ 46.716523][ T1] Kernel Offset: 0x11000000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) [ 46.728244][ T1] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 ]--- == git coredump == # coredumpctl dump PID: 1906 (git) UID: 0 (root) GID: 0 (root) Signal: 11 (SEGV) Timestamp: Mon 2020-12-07 10:10:36 EST (34s ago) Boot ID: 5dd9e21b02e4487f96d2ffeed3140f22 Machine ID: 00f60cae470d4f54a377e935638619c5 Storage: /var/lib/systemd/coredump/core.git.0.5dd9e21b02e4487f96d2ffeed3140f22.1906.1607353836000000.lz4 Message: Process 1906 (git) of user 0 dumped core. Stack trace of thread 1906: #0 0x00007fff845af9dc _dl_relocate_object (/usr/lib64/ld-2.28.so) #1 0x00007fff845a6664 dl_main (/usr/lib64/ld-2.28.so) #2 0x00007fff845c0448 _dl_sysdep_start (/usr/lib64/ld-2.28.so) #3 0x00007fff845a1cbc _dl_start_final (/usr/lib64/ld-2.28.so) #4 0x00007fff845a2dbc _dl_start (/usr/lib64/ld-2.28.so) #5 0x00007fff845a1458 _start (/usr/lib64/ld-2.28.so) > > A git tree is also available: > > git://git.infradead.org/users/hch/block.git bi_bdev > > Gitweb: > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bi_bdev > > Diffstat: > arch/m68k/emu/nfblock.c | 2 > arch/xtensa/platforms/iss/simdisk.c | 2 > block/bio-integrity.c | 18 +- > block/bio.c | 31 +--- > block/blk-cgroup.c | 7 > block/blk-core.c | 99 ++++++------- > block/blk-crypto-fallback.c | 2 > block/blk-crypto.c | 2 > block/blk-merge.c | 17 +- > block/blk-mq.c | 2 > block/blk-settings.c | 2 > block/blk-throttle.c | 2 > block/blk.h | 9 - > block/bounce.c | 2 > block/genhd.c | 261 +++------------------------------- > -- > block/partitions/core.c | 31 ---- > drivers/block/brd.c | 8 - > drivers/block/drbd/drbd_int.h | 4 > drivers/block/drbd/drbd_req.c | 2 > drivers/block/null_blk_main.c | 2 > drivers/block/pktcdvd.c | 4 > drivers/block/ps3vram.c | 2 > drivers/block/rsxx/dev.c | 2 > drivers/block/umem.c | 2 > drivers/block/zram/zram_drv.c | 2 > drivers/lightnvm/pblk-init.c | 2 > drivers/md/bcache/debug.c | 2 > drivers/md/bcache/request.c | 39 +++-- > drivers/md/dm-bio-record.h | 9 - > drivers/md/dm-raid1.c | 10 - > drivers/md/dm.c | 14 - > drivers/md/md-linear.c | 2 > drivers/md/md.c | 10 - > drivers/md/md.h | 6 > drivers/md/raid1.c | 6 > drivers/md/raid10.c | 12 - > drivers/md/raid5.c | 2 > drivers/nvdimm/blk.c | 4 > drivers/nvdimm/btt.c | 4 > drivers/nvdimm/pmem.c | 4 > drivers/nvme/host/core.c | 6 > drivers/nvme/host/lightnvm.c | 3 > drivers/nvme/host/multipath.c | 6 > drivers/nvme/host/rdma.c | 2 > drivers/s390/block/dasd.c | 26 --- > drivers/s390/block/dcssblk.c | 6 > drivers/s390/block/xpram.c | 2 > fs/btrfs/check-integrity.c | 10 - > fs/btrfs/raid56.c | 7 > fs/btrfs/scrub.c | 2 > fs/direct-io.c | 2 > fs/f2fs/data.c | 12 - > include/linux/bio.h | 18 +- > include/linux/blk_types.h | 3 > include/linux/blkdev.h | 20 -- > include/linux/genhd.h | 21 -- > kernel/trace/blktrace.c | 16 +- > mm/page_io.c | 2 > 58 files changed, 251 insertions(+), 556 deletions(-) ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-07 18:56 ` Qian Cai 0 siblings, 0 replies; 68+ messages in thread From: Qian Cai @ 2020-12-07 18:56 UTC (permalink / raw) To: Christoph Hellwig, Jens Axboe Cc: linux-s390, Stephen Rothwell, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, Next Mailing List, linux-block, Linux, Tejun Heo On Tue, 2020-12-01 at 17:54 +0100, Christoph Hellwig wrote: > Hi Jens, > > this series switches back from storing the gendisk + partno to storing > a block_device pointer in struct bio. The reason is two fold: for one > the new struct block_device actually is always available, removing the > need to avoid originally. Second the merge struct block_device is much > more useful than the old one, as storing it avoids the need for looking > up what used to be hd_struct during partition remapping and I/O > accounting. > > Note that this series depends on the posted but not merged > "block tracepoint cleanups" series. Reverting this patchset on the top of today's linux-next fixed data corruptions everywhere, i.e., $ git revert --no-edit a54895fa057c..4498a8536c81 (with a trivial conflict resolution with the commit "block: move blk_rq_bio_prep() to linux/blk-mq.h") .config (if ever matters and also happened on POWER9 NV): https://cailca.coding.net/public/linux/mm/git/files/master/x86.config == XFS failed to mount == [ 55.116279][ T1507] XFS (dm-0): Mounting V5 Filesystem [ 55.144671][ T1507] XFS (dm-0): Corruption warning: Metadata has LSN (3:70242) ahead of current LSN (3:66504). Please unmount and run xfs_repair (>= v4.3) to resolve. [ 55.159965][ T1507] XFS (dm-0): log mount/recovery failed: error -22 [ 55.288632][ T1507] XFS (dm-0): log mount failed In this case, it is not possible to mount the XFS rootfs anymore, and it can be repaired with "-L". However, we could lost vital files. Then, I have to re- install the system. systemd[1]: System cannot boot: Missing /etc/machine-id and /etc is mounted read-only. systemd[1]: Booting up is supported only when: systemd[1]: 1) /etc/machine-id exists and is populated. systemd[1]: 2) /etc/machine-id exists and is empty. systemd[1]: 3) /etc/machine-id is missing and /etc is writable. lvm2-activation-generator: lvmconfig failed systemd[1]: Failed to populate /etc with preset unit settings, ignoring: No such file or directory == systemd core dump == [ 46.124485][ T1028] Process 1028(systemd-coredum) has RLIMIT_CORE set to 1 [ 46.131434][ T1028] Aborting core [ 46.143366][ T1027] systemd-cgroups (1027) used greatest stack depth: 23512 bytes left [ 46.384430][ T1] printk: systemd: 20 output lines suppressed due to ratelimiting [ 46.447620][ T1] traps: systemd[1] trap invalid opcode ip:7f44c485fee6 sp:7ffee96e6960 error:0 in libm-2.28.so[7f44c481a000+181000] [ 46.492643][ T1029] traps: systemd-coredum[1029] trap invalid opcode ip:7f2f60471ee6 sp:7ffd58f76e00 error:0 in libm-2.28.so[7f2f6042c000+181000] [ 46.505968][ T1029] Process 1029(systemd-coredum) has RLIMIT_CORE set to 1 [ 46.512900][ T1029] Aborting core [ 46.520024][ T1] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 [ 46.528437][ T1] CPU: 32 PID: 1 Comm: systemd Not tainted 5.10.0-rc6-next-20201207 #1 [ 46.536581][ T1] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 [ 46.545860][ T1] Call Trace: [ 46.549038][ T1] dump_stack+0x99/0xcb [ 46.553082][ T1] panic+0x20c/0x48b [ 46.556860][ T1] ? print_oops_end_marker.cold.10+0x10/0x10 [ 46.562739][ T1] ? do_signal_stop+0x690/0x690 [ 46.567478][ T1] ? do_exit+0x226/0x2410 [ 46.571690][ T1] do_exit.cold.38+0x1de/0x1e5 [ 46.576346][ T1] ? rcu_read_lock_sched_held+0xa1/0xd0 [ 46.581782][ T1] ? rcu_read_lock_bh_held+0xb0/0xb0 [ 46.586955][ T1] ? mm_update_next_owner+0x750/0x750 [ 46.592215][ T1] ? get_signal+0x80f/0x1f90 [ 46.596688][ T1] do_group_exit+0xf0/0x2e0 [ 46.601076][ T1] get_signal+0x35a/0x1f90 [ 46.605380][ T1] ? finish_task_switch+0x1bb/0xa80 [ 46.610468][ T1] arch_do_signal_or_restart+0x1d8/0x690 [ 46.615993][ T1] ? __setup_rt_frame.isra.15+0x1830/0x1830 [ 46.621781][ T1] ? __sched_text_start+0x8/0x8 [ 46.626521][ T1] ? asm_exc_invalid_op+0xa/0x20 [ 46.631347][ T1] exit_to_user_mode_prepare+0xde/0x170 [ 46.636782][ T1] irqentry_exit_to_user_mode+0x5/0x30 [ 46.642129][ T1] asm_exc_invalid_op+0x12/0x20 [ 46.646868][ T1] RIP: 0033:0x7f44c485fee6 [ 46.651171][ T1] Code: 6d 6e 6f 70 71 72 73 74 75 76 77 78 79 7a 0a 00 41 42 43 44 45 46 47 48 49 4a 4b 4c 4d 4e 4f 50 51 52 53 54 55 56 57 58 59 5a <61> 62 63 64 65 66 67 68 6a 69 6b 6c 6d 6e 6f 70 71 72 73 74 75 76 [ 46.670757][ T1] RSP: 002b:00007ffee96e6960 EFLAGS: 00010202 [ 46.676719][ T1] RAX: 00007f44c481c780 RBX: 00007f44c4825e78 RCX: 0000000000000000 [ 46.684600][ T1] RDX: 00007ffee96e6a90 RSI: 0000000000000000 RDI: 00007f44c481c780 [ 46.692480][ T1] RBP: 00007ffee96e6a90 R08: 00007f44c85d88a8 R09: 00007f44c85d88a8 [ 46.700360][ T1] R10: 00007f44ca38e4f0 R11: 00007f44c481a000 R12: 00007f44c481c780 [ 46.708241][ T1] R13: 00007f44c4826088 R14: 00007f44c4b9b128 R15: 00007f44ca38e4f0 [ 46.716523][ T1] Kernel Offset: 0x11000000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) [ 46.728244][ T1] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 ]--- == git coredump == # coredumpctl dump PID: 1906 (git) UID: 0 (root) GID: 0 (root) Signal: 11 (SEGV) Timestamp: Mon 2020-12-07 10:10:36 EST (34s ago) Boot ID: 5dd9e21b02e4487f96d2ffeed3140f22 Machine ID: 00f60cae470d4f54a377e935638619c5 Storage: /var/lib/systemd/coredump/core.git.0.5dd9e21b02e4487f96d2ffeed3140f22.1906.1607353836000000.lz4 Message: Process 1906 (git) of user 0 dumped core. Stack trace of thread 1906: #0 0x00007fff845af9dc _dl_relocate_object (/usr/lib64/ld-2.28.so) #1 0x00007fff845a6664 dl_main (/usr/lib64/ld-2.28.so) #2 0x00007fff845c0448 _dl_sysdep_start (/usr/lib64/ld-2.28.so) #3 0x00007fff845a1cbc _dl_start_final (/usr/lib64/ld-2.28.so) #4 0x00007fff845a2dbc _dl_start (/usr/lib64/ld-2.28.so) #5 0x00007fff845a1458 _start (/usr/lib64/ld-2.28.so) > > A git tree is also available: > > git://git.infradead.org/users/hch/block.git bi_bdev > > Gitweb: > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bi_bdev > > Diffstat: > arch/m68k/emu/nfblock.c | 2 > arch/xtensa/platforms/iss/simdisk.c | 2 > block/bio-integrity.c | 18 +- > block/bio.c | 31 +--- > block/blk-cgroup.c | 7 > block/blk-core.c | 99 ++++++------- > block/blk-crypto-fallback.c | 2 > block/blk-crypto.c | 2 > block/blk-merge.c | 17 +- > block/blk-mq.c | 2 > block/blk-settings.c | 2 > block/blk-throttle.c | 2 > block/blk.h | 9 - > block/bounce.c | 2 > block/genhd.c | 261 +++------------------------------- > -- > block/partitions/core.c | 31 ---- > drivers/block/brd.c | 8 - > drivers/block/drbd/drbd_int.h | 4 > drivers/block/drbd/drbd_req.c | 2 > drivers/block/null_blk_main.c | 2 > drivers/block/pktcdvd.c | 4 > drivers/block/ps3vram.c | 2 > drivers/block/rsxx/dev.c | 2 > drivers/block/umem.c | 2 > drivers/block/zram/zram_drv.c | 2 > drivers/lightnvm/pblk-init.c | 2 > drivers/md/bcache/debug.c | 2 > drivers/md/bcache/request.c | 39 +++-- > drivers/md/dm-bio-record.h | 9 - > drivers/md/dm-raid1.c | 10 - > drivers/md/dm.c | 14 - > drivers/md/md-linear.c | 2 > drivers/md/md.c | 10 - > drivers/md/md.h | 6 > drivers/md/raid1.c | 6 > drivers/md/raid10.c | 12 - > drivers/md/raid5.c | 2 > drivers/nvdimm/blk.c | 4 > drivers/nvdimm/btt.c | 4 > drivers/nvdimm/pmem.c | 4 > drivers/nvme/host/core.c | 6 > drivers/nvme/host/lightnvm.c | 3 > drivers/nvme/host/multipath.c | 6 > drivers/nvme/host/rdma.c | 2 > drivers/s390/block/dasd.c | 26 --- > drivers/s390/block/dcssblk.c | 6 > drivers/s390/block/xpram.c | 2 > fs/btrfs/check-integrity.c | 10 - > fs/btrfs/raid56.c | 7 > fs/btrfs/scrub.c | 2 > fs/direct-io.c | 2 > fs/f2fs/data.c | 12 - > include/linux/bio.h | 18 +- > include/linux/blk_types.h | 3 > include/linux/blkdev.h | 20 -- > include/linux/genhd.h | 21 -- > kernel/trace/blktrace.c | 16 +- > mm/page_io.c | 2 > 58 files changed, 251 insertions(+), 556 deletions(-) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-07 18:56 ` [dm-devel] " Qian Cai @ 2020-12-07 19:01 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-07 19:01 UTC (permalink / raw) To: Qian Cai Cc: Christoph Hellwig, Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block, Stephen Rothwell, Linux Next Mailing List Thanks for the report. Jens, can you revert the series for now? I think waiting any longer with a report like this is not helpful. I'll look into it with Qian in the meantime. ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-07 19:01 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-07 19:01 UTC (permalink / raw) To: Qian Cai Cc: Jens Axboe, linux-s390, Stephen Rothwell, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, Linux Next Mailing List, linux-block, Tejun Heo, Christoph Hellwig Thanks for the report. Jens, can you revert the series for now? I think waiting any longer with a report like this is not helpful. I'll look into it with Qian in the meantime. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-07 19:01 ` [dm-devel] " Christoph Hellwig @ 2020-12-07 20:20 ` Jens Axboe -1 siblings, 0 replies; 68+ messages in thread From: Jens Axboe @ 2020-12-07 20:20 UTC (permalink / raw) To: Christoph Hellwig, Qian Cai Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block, Stephen Rothwell, Linux Next Mailing List On 12/7/20 12:01 PM, Christoph Hellwig wrote: > Thanks for the report. > > Jens, can you revert the series for now? I think waiting any longer > with a report like this is not helpful. I'll look into it with > Qian in the meantime. Agree, I reverted it. -- Jens Axboe ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-07 20:20 ` Jens Axboe 0 siblings, 0 replies; 68+ messages in thread From: Jens Axboe @ 2020-12-07 20:20 UTC (permalink / raw) To: Christoph Hellwig, Qian Cai Cc: linux-s390, Stephen Rothwell, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, Linux Next Mailing List, linux-block, Tejun Heo On 12/7/20 12:01 PM, Christoph Hellwig wrote: > Thanks for the report. > > Jens, can you revert the series for now? I think waiting any longer > with a report like this is not helpful. I'll look into it with > Qian in the meantime. Agree, I reverted it. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-07 18:56 ` [dm-devel] " Qian Cai @ 2020-12-08 11:04 ` Christoph Hellwig -1 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-08 11:04 UTC (permalink / raw) To: Qian Cai Cc: Christoph Hellwig, Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block, Stephen Rothwell, Linux Next Mailing List Hi Qian, can you send me details of your device mapper setup, e.g. which targets are used, are they used on top of whole device or partitions. Do you use partitions on top of the dm devices? Are any other stacking devices involved? On Mon, Dec 07, 2020 at 01:56:26PM -0500, Qian Cai wrote: > On Tue, 2020-12-01 at 17:54 +0100, Christoph Hellwig wrote: > > Hi Jens, > > > > this series switches back from storing the gendisk + partno to storing > > a block_device pointer in struct bio. The reason is two fold: for one > > the new struct block_device actually is always available, removing the > > need to avoid originally. Second the merge struct block_device is much > > more useful than the old one, as storing it avoids the need for looking > > up what used to be hd_struct during partition remapping and I/O > > accounting. > > > > Note that this series depends on the posted but not merged > > "block tracepoint cleanups" series. > > Reverting this patchset on the top of today's linux-next fixed data corruptions > everywhere, i.e., > > $ git revert --no-edit a54895fa057c..4498a8536c81 > (with a trivial conflict resolution with the commit "block: move > blk_rq_bio_prep() to linux/blk-mq.h") > > .config (if ever matters and also happened on POWER9 NV): > https://cailca.coding.net/public/linux/mm/git/files/master/x86.config > > == XFS failed to mount == > [ 55.116279][ T1507] XFS (dm-0): Mounting V5 Filesystem > [ 55.144671][ T1507] XFS (dm-0): Corruption warning: Metadata has LSN (3:70242) ahead of current LSN (3:66504). Please unmount and run xfs_repair (>= v4.3) to resolve. > [ 55.159965][ T1507] XFS (dm-0): log mount/recovery failed: error -22 > [ 55.288632][ T1507] XFS (dm-0): log mount failed > > In this case, it is not possible to mount the XFS rootfs anymore, and it can be > repaired with "-L". However, we could lost vital files. Then, I have to re- > install the system. > > systemd[1]: System cannot boot: Missing /etc/machine-id and /etc is mounted read-only. > systemd[1]: Booting up is supported only when: > systemd[1]: 1) /etc/machine-id exists and is populated. > systemd[1]: 2) /etc/machine-id exists and is empty. > systemd[1]: 3) /etc/machine-id is missing and /etc is writable. > lvm2-activation-generator: lvmconfig failed > systemd[1]: Failed to populate /etc with preset unit settings, ignoring: No such file or directory > > == systemd core dump == > [ 46.124485][ T1028] Process 1028(systemd-coredum) has RLIMIT_CORE set to 1 > [ 46.131434][ T1028] Aborting core > [ 46.143366][ T1027] systemd-cgroups (1027) used greatest stack depth: 23512 bytes left > [ 46.384430][ T1] printk: systemd: 20 output lines suppressed due to ratelimiting > [ 46.447620][ T1] traps: systemd[1] trap invalid opcode ip:7f44c485fee6 sp:7ffee96e6960 error:0 in libm-2.28.so[7f44c481a000+181000] > [ 46.492643][ T1029] traps: systemd-coredum[1029] trap invalid opcode ip:7f2f60471ee6 sp:7ffd58f76e00 error:0 in libm-2.28.so[7f2f6042c000+181000] > [ 46.505968][ T1029] Process 1029(systemd-coredum) has RLIMIT_CORE set to 1 > [ 46.512900][ T1029] Aborting core > [ 46.520024][ T1] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 > [ 46.528437][ T1] CPU: 32 PID: 1 Comm: systemd Not tainted 5.10.0-rc6-next-20201207 #1 > [ 46.536581][ T1] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 > [ 46.545860][ T1] Call Trace: > [ 46.549038][ T1] dump_stack+0x99/0xcb > [ 46.553082][ T1] panic+0x20c/0x48b > [ 46.556860][ T1] ? print_oops_end_marker.cold.10+0x10/0x10 > [ 46.562739][ T1] ? do_signal_stop+0x690/0x690 > [ 46.567478][ T1] ? do_exit+0x226/0x2410 > [ 46.571690][ T1] do_exit.cold.38+0x1de/0x1e5 > [ 46.576346][ T1] ? rcu_read_lock_sched_held+0xa1/0xd0 > [ 46.581782][ T1] ? rcu_read_lock_bh_held+0xb0/0xb0 > [ 46.586955][ T1] ? mm_update_next_owner+0x750/0x750 > [ 46.592215][ T1] ? get_signal+0x80f/0x1f90 > [ 46.596688][ T1] do_group_exit+0xf0/0x2e0 > [ 46.601076][ T1] get_signal+0x35a/0x1f90 > [ 46.605380][ T1] ? finish_task_switch+0x1bb/0xa80 > [ 46.610468][ T1] arch_do_signal_or_restart+0x1d8/0x690 > [ 46.615993][ T1] ? __setup_rt_frame.isra.15+0x1830/0x1830 > [ 46.621781][ T1] ? __sched_text_start+0x8/0x8 > [ 46.626521][ T1] ? asm_exc_invalid_op+0xa/0x20 > [ 46.631347][ T1] exit_to_user_mode_prepare+0xde/0x170 > [ 46.636782][ T1] irqentry_exit_to_user_mode+0x5/0x30 > [ 46.642129][ T1] asm_exc_invalid_op+0x12/0x20 > [ 46.646868][ T1] RIP: 0033:0x7f44c485fee6 > [ 46.651171][ T1] Code: 6d 6e 6f 70 71 72 73 74 75 76 77 78 79 7a 0a 00 41 42 43 44 45 46 47 48 49 4a 4b 4c 4d 4e 4f 50 51 52 53 54 55 56 57 58 59 5a <61> 62 63 64 65 66 67 68 6a 69 6b 6c 6d 6e 6f 70 71 72 73 74 75 76 > [ 46.670757][ T1] RSP: 002b:00007ffee96e6960 EFLAGS: 00010202 > [ 46.676719][ T1] RAX: 00007f44c481c780 RBX: 00007f44c4825e78 RCX: 0000000000000000 > [ 46.684600][ T1] RDX: 00007ffee96e6a90 RSI: 0000000000000000 RDI: 00007f44c481c780 > [ 46.692480][ T1] RBP: 00007ffee96e6a90 R08: 00007f44c85d88a8 R09: 00007f44c85d88a8 > [ 46.700360][ T1] R10: 00007f44ca38e4f0 R11: 00007f44c481a000 R12: 00007f44c481c780 > [ 46.708241][ T1] R13: 00007f44c4826088 R14: 00007f44c4b9b128 R15: 00007f44ca38e4f0 > [ 46.716523][ T1] Kernel Offset: 0x11000000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > [ 46.728244][ T1] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 ]--- > > == git coredump == > # coredumpctl dump > PID: 1906 (git) > UID: 0 (root) > GID: 0 (root) > Signal: 11 (SEGV) > Timestamp: Mon 2020-12-07 10:10:36 EST (34s ago) > Boot ID: 5dd9e21b02e4487f96d2ffeed3140f22 > Machine ID: 00f60cae470d4f54a377e935638619c5 > Storage: /var/lib/systemd/coredump/core.git.0.5dd9e21b02e4487f96d2ffeed3140f22.1906.1607353836000000.lz4 > Message: Process 1906 (git) of user 0 dumped core. > > Stack trace of thread 1906: > #0 0x00007fff845af9dc _dl_relocate_object (/usr/lib64/ld-2.28.so) > #1 0x00007fff845a6664 dl_main (/usr/lib64/ld-2.28.so) > #2 0x00007fff845c0448 _dl_sysdep_start (/usr/lib64/ld-2.28.so) > #3 0x00007fff845a1cbc _dl_start_final (/usr/lib64/ld-2.28.so) > #4 0x00007fff845a2dbc _dl_start (/usr/lib64/ld-2.28.so) > #5 0x00007fff845a1458 _start (/usr/lib64/ld-2.28.so) > > > > > A git tree is also available: > > > > git://git.infradead.org/users/hch/block.git bi_bdev > > > > Gitweb: > > > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bi_bdev > > > > Diffstat: > > arch/m68k/emu/nfblock.c | 2 > > arch/xtensa/platforms/iss/simdisk.c | 2 > > block/bio-integrity.c | 18 +- > > block/bio.c | 31 +--- > > block/blk-cgroup.c | 7 > > block/blk-core.c | 99 ++++++------- > > block/blk-crypto-fallback.c | 2 > > block/blk-crypto.c | 2 > > block/blk-merge.c | 17 +- > > block/blk-mq.c | 2 > > block/blk-settings.c | 2 > > block/blk-throttle.c | 2 > > block/blk.h | 9 - > > block/bounce.c | 2 > > block/genhd.c | 261 +++------------------------------- > > -- > > block/partitions/core.c | 31 ---- > > drivers/block/brd.c | 8 - > > drivers/block/drbd/drbd_int.h | 4 > > drivers/block/drbd/drbd_req.c | 2 > > drivers/block/null_blk_main.c | 2 > > drivers/block/pktcdvd.c | 4 > > drivers/block/ps3vram.c | 2 > > drivers/block/rsxx/dev.c | 2 > > drivers/block/umem.c | 2 > > drivers/block/zram/zram_drv.c | 2 > > drivers/lightnvm/pblk-init.c | 2 > > drivers/md/bcache/debug.c | 2 > > drivers/md/bcache/request.c | 39 +++-- > > drivers/md/dm-bio-record.h | 9 - > > drivers/md/dm-raid1.c | 10 - > > drivers/md/dm.c | 14 - > > drivers/md/md-linear.c | 2 > > drivers/md/md.c | 10 - > > drivers/md/md.h | 6 > > drivers/md/raid1.c | 6 > > drivers/md/raid10.c | 12 - > > drivers/md/raid5.c | 2 > > drivers/nvdimm/blk.c | 4 > > drivers/nvdimm/btt.c | 4 > > drivers/nvdimm/pmem.c | 4 > > drivers/nvme/host/core.c | 6 > > drivers/nvme/host/lightnvm.c | 3 > > drivers/nvme/host/multipath.c | 6 > > drivers/nvme/host/rdma.c | 2 > > drivers/s390/block/dasd.c | 26 --- > > drivers/s390/block/dcssblk.c | 6 > > drivers/s390/block/xpram.c | 2 > > fs/btrfs/check-integrity.c | 10 - > > fs/btrfs/raid56.c | 7 > > fs/btrfs/scrub.c | 2 > > fs/direct-io.c | 2 > > fs/f2fs/data.c | 12 - > > include/linux/bio.h | 18 +- > > include/linux/blk_types.h | 3 > > include/linux/blkdev.h | 20 -- > > include/linux/genhd.h | 21 -- > > kernel/trace/blktrace.c | 16 +- > > mm/page_io.c | 2 > > 58 files changed, 251 insertions(+), 556 deletions(-) ---end quoted text--- ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-08 11:04 ` Christoph Hellwig 0 siblings, 0 replies; 68+ messages in thread From: Christoph Hellwig @ 2020-12-08 11:04 UTC (permalink / raw) To: Qian Cai Cc: Jens Axboe, linux-s390, Stephen Rothwell, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, Linux Next Mailing List, linux-block, Tejun Heo, Christoph Hellwig Hi Qian, can you send me details of your device mapper setup, e.g. which targets are used, are they used on top of whole device or partitions. Do you use partitions on top of the dm devices? Are any other stacking devices involved? On Mon, Dec 07, 2020 at 01:56:26PM -0500, Qian Cai wrote: > On Tue, 2020-12-01 at 17:54 +0100, Christoph Hellwig wrote: > > Hi Jens, > > > > this series switches back from storing the gendisk + partno to storing > > a block_device pointer in struct bio. The reason is two fold: for one > > the new struct block_device actually is always available, removing the > > need to avoid originally. Second the merge struct block_device is much > > more useful than the old one, as storing it avoids the need for looking > > up what used to be hd_struct during partition remapping and I/O > > accounting. > > > > Note that this series depends on the posted but not merged > > "block tracepoint cleanups" series. > > Reverting this patchset on the top of today's linux-next fixed data corruptions > everywhere, i.e., > > $ git revert --no-edit a54895fa057c..4498a8536c81 > (with a trivial conflict resolution with the commit "block: move > blk_rq_bio_prep() to linux/blk-mq.h") > > .config (if ever matters and also happened on POWER9 NV): > https://cailca.coding.net/public/linux/mm/git/files/master/x86.config > > == XFS failed to mount == > [ 55.116279][ T1507] XFS (dm-0): Mounting V5 Filesystem > [ 55.144671][ T1507] XFS (dm-0): Corruption warning: Metadata has LSN (3:70242) ahead of current LSN (3:66504). Please unmount and run xfs_repair (>= v4.3) to resolve. > [ 55.159965][ T1507] XFS (dm-0): log mount/recovery failed: error -22 > [ 55.288632][ T1507] XFS (dm-0): log mount failed > > In this case, it is not possible to mount the XFS rootfs anymore, and it can be > repaired with "-L". However, we could lost vital files. Then, I have to re- > install the system. > > systemd[1]: System cannot boot: Missing /etc/machine-id and /etc is mounted read-only. > systemd[1]: Booting up is supported only when: > systemd[1]: 1) /etc/machine-id exists and is populated. > systemd[1]: 2) /etc/machine-id exists and is empty. > systemd[1]: 3) /etc/machine-id is missing and /etc is writable. > lvm2-activation-generator: lvmconfig failed > systemd[1]: Failed to populate /etc with preset unit settings, ignoring: No such file or directory > > == systemd core dump == > [ 46.124485][ T1028] Process 1028(systemd-coredum) has RLIMIT_CORE set to 1 > [ 46.131434][ T1028] Aborting core > [ 46.143366][ T1027] systemd-cgroups (1027) used greatest stack depth: 23512 bytes left > [ 46.384430][ T1] printk: systemd: 20 output lines suppressed due to ratelimiting > [ 46.447620][ T1] traps: systemd[1] trap invalid opcode ip:7f44c485fee6 sp:7ffee96e6960 error:0 in libm-2.28.so[7f44c481a000+181000] > [ 46.492643][ T1029] traps: systemd-coredum[1029] trap invalid opcode ip:7f2f60471ee6 sp:7ffd58f76e00 error:0 in libm-2.28.so[7f2f6042c000+181000] > [ 46.505968][ T1029] Process 1029(systemd-coredum) has RLIMIT_CORE set to 1 > [ 46.512900][ T1029] Aborting core > [ 46.520024][ T1] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 > [ 46.528437][ T1] CPU: 32 PID: 1 Comm: systemd Not tainted 5.10.0-rc6-next-20201207 #1 > [ 46.536581][ T1] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 > [ 46.545860][ T1] Call Trace: > [ 46.549038][ T1] dump_stack+0x99/0xcb > [ 46.553082][ T1] panic+0x20c/0x48b > [ 46.556860][ T1] ? print_oops_end_marker.cold.10+0x10/0x10 > [ 46.562739][ T1] ? do_signal_stop+0x690/0x690 > [ 46.567478][ T1] ? do_exit+0x226/0x2410 > [ 46.571690][ T1] do_exit.cold.38+0x1de/0x1e5 > [ 46.576346][ T1] ? rcu_read_lock_sched_held+0xa1/0xd0 > [ 46.581782][ T1] ? rcu_read_lock_bh_held+0xb0/0xb0 > [ 46.586955][ T1] ? mm_update_next_owner+0x750/0x750 > [ 46.592215][ T1] ? get_signal+0x80f/0x1f90 > [ 46.596688][ T1] do_group_exit+0xf0/0x2e0 > [ 46.601076][ T1] get_signal+0x35a/0x1f90 > [ 46.605380][ T1] ? finish_task_switch+0x1bb/0xa80 > [ 46.610468][ T1] arch_do_signal_or_restart+0x1d8/0x690 > [ 46.615993][ T1] ? __setup_rt_frame.isra.15+0x1830/0x1830 > [ 46.621781][ T1] ? __sched_text_start+0x8/0x8 > [ 46.626521][ T1] ? asm_exc_invalid_op+0xa/0x20 > [ 46.631347][ T1] exit_to_user_mode_prepare+0xde/0x170 > [ 46.636782][ T1] irqentry_exit_to_user_mode+0x5/0x30 > [ 46.642129][ T1] asm_exc_invalid_op+0x12/0x20 > [ 46.646868][ T1] RIP: 0033:0x7f44c485fee6 > [ 46.651171][ T1] Code: 6d 6e 6f 70 71 72 73 74 75 76 77 78 79 7a 0a 00 41 42 43 44 45 46 47 48 49 4a 4b 4c 4d 4e 4f 50 51 52 53 54 55 56 57 58 59 5a <61> 62 63 64 65 66 67 68 6a 69 6b 6c 6d 6e 6f 70 71 72 73 74 75 76 > [ 46.670757][ T1] RSP: 002b:00007ffee96e6960 EFLAGS: 00010202 > [ 46.676719][ T1] RAX: 00007f44c481c780 RBX: 00007f44c4825e78 RCX: 0000000000000000 > [ 46.684600][ T1] RDX: 00007ffee96e6a90 RSI: 0000000000000000 RDI: 00007f44c481c780 > [ 46.692480][ T1] RBP: 00007ffee96e6a90 R08: 00007f44c85d88a8 R09: 00007f44c85d88a8 > [ 46.700360][ T1] R10: 00007f44ca38e4f0 R11: 00007f44c481a000 R12: 00007f44c481c780 > [ 46.708241][ T1] R13: 00007f44c4826088 R14: 00007f44c4b9b128 R15: 00007f44ca38e4f0 > [ 46.716523][ T1] Kernel Offset: 0x11000000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > [ 46.728244][ T1] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000084 ]--- > > == git coredump == > # coredumpctl dump > PID: 1906 (git) > UID: 0 (root) > GID: 0 (root) > Signal: 11 (SEGV) > Timestamp: Mon 2020-12-07 10:10:36 EST (34s ago) > Boot ID: 5dd9e21b02e4487f96d2ffeed3140f22 > Machine ID: 00f60cae470d4f54a377e935638619c5 > Storage: /var/lib/systemd/coredump/core.git.0.5dd9e21b02e4487f96d2ffeed3140f22.1906.1607353836000000.lz4 > Message: Process 1906 (git) of user 0 dumped core. > > Stack trace of thread 1906: > #0 0x00007fff845af9dc _dl_relocate_object (/usr/lib64/ld-2.28.so) > #1 0x00007fff845a6664 dl_main (/usr/lib64/ld-2.28.so) > #2 0x00007fff845c0448 _dl_sysdep_start (/usr/lib64/ld-2.28.so) > #3 0x00007fff845a1cbc _dl_start_final (/usr/lib64/ld-2.28.so) > #4 0x00007fff845a2dbc _dl_start (/usr/lib64/ld-2.28.so) > #5 0x00007fff845a1458 _start (/usr/lib64/ld-2.28.so) > > > > > A git tree is also available: > > > > git://git.infradead.org/users/hch/block.git bi_bdev > > > > Gitweb: > > > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bi_bdev > > > > Diffstat: > > arch/m68k/emu/nfblock.c | 2 > > arch/xtensa/platforms/iss/simdisk.c | 2 > > block/bio-integrity.c | 18 +- > > block/bio.c | 31 +--- > > block/blk-cgroup.c | 7 > > block/blk-core.c | 99 ++++++------- > > block/blk-crypto-fallback.c | 2 > > block/blk-crypto.c | 2 > > block/blk-merge.c | 17 +- > > block/blk-mq.c | 2 > > block/blk-settings.c | 2 > > block/blk-throttle.c | 2 > > block/blk.h | 9 - > > block/bounce.c | 2 > > block/genhd.c | 261 +++------------------------------- > > -- > > block/partitions/core.c | 31 ---- > > drivers/block/brd.c | 8 - > > drivers/block/drbd/drbd_int.h | 4 > > drivers/block/drbd/drbd_req.c | 2 > > drivers/block/null_blk_main.c | 2 > > drivers/block/pktcdvd.c | 4 > > drivers/block/ps3vram.c | 2 > > drivers/block/rsxx/dev.c | 2 > > drivers/block/umem.c | 2 > > drivers/block/zram/zram_drv.c | 2 > > drivers/lightnvm/pblk-init.c | 2 > > drivers/md/bcache/debug.c | 2 > > drivers/md/bcache/request.c | 39 +++-- > > drivers/md/dm-bio-record.h | 9 - > > drivers/md/dm-raid1.c | 10 - > > drivers/md/dm.c | 14 - > > drivers/md/md-linear.c | 2 > > drivers/md/md.c | 10 - > > drivers/md/md.h | 6 > > drivers/md/raid1.c | 6 > > drivers/md/raid10.c | 12 - > > drivers/md/raid5.c | 2 > > drivers/nvdimm/blk.c | 4 > > drivers/nvdimm/btt.c | 4 > > drivers/nvdimm/pmem.c | 4 > > drivers/nvme/host/core.c | 6 > > drivers/nvme/host/lightnvm.c | 3 > > drivers/nvme/host/multipath.c | 6 > > drivers/nvme/host/rdma.c | 2 > > drivers/s390/block/dasd.c | 26 --- > > drivers/s390/block/dcssblk.c | 6 > > drivers/s390/block/xpram.c | 2 > > fs/btrfs/check-integrity.c | 10 - > > fs/btrfs/raid56.c | 7 > > fs/btrfs/scrub.c | 2 > > fs/direct-io.c | 2 > > fs/f2fs/data.c | 12 - > > include/linux/bio.h | 18 +- > > include/linux/blk_types.h | 3 > > include/linux/blkdev.h | 20 -- > > include/linux/genhd.h | 21 -- > > kernel/trace/blktrace.c | 16 +- > > mm/page_io.c | 2 > > 58 files changed, 251 insertions(+), 556 deletions(-) ---end quoted text--- -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-08 11:04 ` [dm-devel] " Christoph Hellwig @ 2020-12-08 13:08 ` Qian Cai -1 siblings, 0 replies; 68+ messages in thread From: Qian Cai @ 2020-12-08 13:08 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block, Stephen Rothwell, Linux Next Mailing List On Tue, 2020-12-08 at 12:04 +0100, Christoph Hellwig wrote: > can you send me details of your device mapper setup, e.g. which targets > are used, are they used on top of whole device or partitions. Do you > use partitions on top of the dm devices? Are any other stacking devices > involved? It is a standard RHEL8 installation using "autopart", so I don't think it uses any particular targets. It is just a plain LVM backed by ahci (sda2 and sdb1. Some other affected systems use smartpqi/NVM). The kernel has only dm-mirror enabled but I don't think it uses it anyway. # grep -i _DM_ .config | grep -v ^# CONFIG_BLK_DEV_DM_BUILTIN=y CONFIG_DM_MIRROR=m CONFIG_DM_UEVENT=y # lvdisplay --- Logical volume --- LV Path /dev/rhel_ibm-p9wr-10/home LV Name home VG Name rhel_ibm-p9wr-10 LV UUID ETS2PI-yedc-7AJ6-NUP2-uAYD-6api-bp9nqv LV Write Access read/write LV Status available # open 1 LV Size <3.57 TiB Current LE 934662 Segments 2 Allocation inherit Read ahead sectors auto - currently set to 8192 Block device 254:2 --- Logical volume --- LV Path /dev/rhel_ibm-p9wr-10/root LV Name root VG Name rhel_ibm-p9wr-10 LV UUID ozakb8-2DWE-YBI9-4nnc-gwk8-mMuf-s3EPsB LV Write Access read/write LV Status available # open 1 LV Size 70.00 GiB Current LE 17920 Segments 1 Allocation inherit Read ahead sectors auto - currently set to 8192 Block device 254:0 # pvdisplay --- Physical volume --- PV Name /dev/sda2 VG Name rhel_ibm-p9wr-10 PV Size <1.82 TiB / not usable 4.00 MiB Allocatable yes (but full) PE Size 4.00 MiB Total PE 476675 Free PE 0 Allocated PE 476675 PV UUID 0Tv2Az-vx7S-HLPd-66Ff-tH6H-dte1-tjSZ7i --- Physical volume --- PV Name /dev/sdb1 VG Name rhel_ibm-p9wr-10 PV Size <1.82 TiB / not usable 4.00 MiB Allocatable yes (but full) PE Size 4.00 MiB Total PE 476931 Free PE 0 Allocated PE 476931 PV UUID 4LfZJN-NxbJ-39OC-VBKP-jv5P-hciK-BOdiML # lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT sda 8:0 1 1.8T 0 disk ├─sda1 8:1 1 1G 0 part /boot └─sda2 8:2 1 1.8T 0 part ├─rhel_ibm--p9wr--10-root 254:0 0 70G 0 lvm / └─rhel_ibm--p9wr--10-home 254:2 0 3.6T 0 lvm /home sdb 8:16 1 1.8T 0 disk └─sdb1 8:17 1 1.8T 0 part └─rhel_ibm--p9wr--10-home 254:2 0 3.6T 0 lvm /home ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-08 13:08 ` Qian Cai 0 siblings, 0 replies; 68+ messages in thread From: Qian Cai @ 2020-12-08 13:08 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, Stephen Rothwell, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, Linux Next Mailing List, linux-block, Tejun Heo On Tue, 2020-12-08 at 12:04 +0100, Christoph Hellwig wrote: > can you send me details of your device mapper setup, e.g. which targets > are used, are they used on top of whole device or partitions. Do you > use partitions on top of the dm devices? Are any other stacking devices > involved? It is a standard RHEL8 installation using "autopart", so I don't think it uses any particular targets. It is just a plain LVM backed by ahci (sda2 and sdb1. Some other affected systems use smartpqi/NVM). The kernel has only dm-mirror enabled but I don't think it uses it anyway. # grep -i _DM_ .config | grep -v ^# CONFIG_BLK_DEV_DM_BUILTIN=y CONFIG_DM_MIRROR=m CONFIG_DM_UEVENT=y # lvdisplay --- Logical volume --- LV Path /dev/rhel_ibm-p9wr-10/home LV Name home VG Name rhel_ibm-p9wr-10 LV UUID ETS2PI-yedc-7AJ6-NUP2-uAYD-6api-bp9nqv LV Write Access read/write LV Status available # open 1 LV Size <3.57 TiB Current LE 934662 Segments 2 Allocation inherit Read ahead sectors auto - currently set to 8192 Block device 254:2 --- Logical volume --- LV Path /dev/rhel_ibm-p9wr-10/root LV Name root VG Name rhel_ibm-p9wr-10 LV UUID ozakb8-2DWE-YBI9-4nnc-gwk8-mMuf-s3EPsB LV Write Access read/write LV Status available # open 1 LV Size 70.00 GiB Current LE 17920 Segments 1 Allocation inherit Read ahead sectors auto - currently set to 8192 Block device 254:0 # pvdisplay --- Physical volume --- PV Name /dev/sda2 VG Name rhel_ibm-p9wr-10 PV Size <1.82 TiB / not usable 4.00 MiB Allocatable yes (but full) PE Size 4.00 MiB Total PE 476675 Free PE 0 Allocated PE 476675 PV UUID 0Tv2Az-vx7S-HLPd-66Ff-tH6H-dte1-tjSZ7i --- Physical volume --- PV Name /dev/sdb1 VG Name rhel_ibm-p9wr-10 PV Size <1.82 TiB / not usable 4.00 MiB Allocatable yes (but full) PE Size 4.00 MiB Total PE 476931 Free PE 0 Allocated PE 476931 PV UUID 4LfZJN-NxbJ-39OC-VBKP-jv5P-hciK-BOdiML # lsblk NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT sda 8:0 1 1.8T 0 disk ├─sda1 8:1 1 1G 0 part /boot └─sda2 8:2 1 1.8T 0 part ├─rhel_ibm--p9wr--10-root 254:0 0 70G 0 lvm / └─rhel_ibm--p9wr--10-home 254:2 0 3.6T 0 lvm /home sdb 8:16 1 1.8T 0 disk └─sdb1 8:17 1 1.8T 0 part └─rhel_ibm--p9wr--10-home 254:2 0 3.6T 0 lvm /home -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-08 11:04 ` [dm-devel] " Christoph Hellwig @ 2020-12-08 13:38 ` Daniel Wagner -1 siblings, 0 replies; 68+ messages in thread From: Daniel Wagner @ 2020-12-08 13:38 UTC (permalink / raw) To: Christoph Hellwig Cc: Qian Cai, Jens Axboe, Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block, Stephen Rothwell, Linux Next Mailing List On Tue, Dec 08, 2020 at 12:04:03PM +0100, Christoph Hellwig wrote: > can you send me details of your device mapper setup, e.g. which targets > are used, are they used on top of whole device or partitions. Do you > use partitions on top of the dm devices? Are any other stacking devices > involved? FWIW, I tried linux-next yesterday and got the root fs (btrfs) corrupted. It is a very simple setup, just plain FS on SCSI device. ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-08 13:38 ` Daniel Wagner 0 siblings, 0 replies; 68+ messages in thread From: Daniel Wagner @ 2020-12-08 13:38 UTC (permalink / raw) To: Christoph Hellwig Cc: Jens Axboe, linux-s390, Stephen Rothwell, Qian Cai, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, Linux Next Mailing List, linux-block, Tejun Heo On Tue, Dec 08, 2020 at 12:04:03PM +0100, Christoph Hellwig wrote: > can you send me details of your device mapper setup, e.g. which targets > are used, are they used on top of whole device or partitions. Do you > use partitions on top of the dm devices? Are any other stacking devices > involved? FWIW, I tried linux-next yesterday and got the root fs (btrfs) corrupted. It is a very simple setup, just plain FS on SCSI device. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: store a pointer to the block_device in struct bio (again) 2020-12-08 11:04 ` [dm-devel] " Christoph Hellwig @ 2020-12-08 14:15 ` Jens Axboe -1 siblings, 0 replies; 68+ messages in thread From: Jens Axboe @ 2020-12-08 14:15 UTC (permalink / raw) To: Christoph Hellwig, Qian Cai Cc: Tejun Heo, Coly Li, Song Liu, dm-devel, linux-bcache, linux-raid, linux-s390, linux-block, Stephen Rothwell, Linux Next Mailing List On 12/8/20 4:04 AM, Christoph Hellwig wrote: > Hi Qian, > > can you send me details of your device mapper setup, e.g. which targets > are used, are they used on top of whole device or partitions. Do you > use partitions on top of the dm devices? Are any other stacking devices > involved? Don't think this needs anything fancy at all - I know Pavel got his test box corrupted, and mine did as well. Looks like it pretty much affected everyone that got unlucky enough to try it, not great... Mine is just ext4 root on nvme. -- Jens Axboe ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [dm-devel] store a pointer to the block_device in struct bio (again) @ 2020-12-08 14:15 ` Jens Axboe 0 siblings, 0 replies; 68+ messages in thread From: Jens Axboe @ 2020-12-08 14:15 UTC (permalink / raw) To: Christoph Hellwig, Qian Cai Cc: linux-s390, Stephen Rothwell, linux-bcache, Coly Li, linux-raid, Song Liu, dm-devel, Linux Next Mailing List, linux-block, Tejun Heo On 12/8/20 4:04 AM, Christoph Hellwig wrote: > Hi Qian, > > can you send me details of your device mapper setup, e.g. which targets > are used, are they used on top of whole device or partitions. Do you > use partitions on top of the dm devices? Are any other stacking devices > involved? Don't think this needs anything fancy at all - I know Pavel got his test box corrupted, and mine did as well. Looks like it pretty much affected everyone that got unlucky enough to try it, not great... Mine is just ext4 root on nvme. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 68+ messages in thread
end of thread, other threads:[~2020-12-09 9:58 UTC | newest] Thread overview: 68+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-01 16:54 store a pointer to the block_device in struct bio (again) Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-01 16:54 ` [PATCH 1/9] brd: remove the end of device check in brd_do_bvec Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 22:39 ` Tejun Heo 2020-12-02 22:39 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 2/9] dcssblk: " Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 22:39 ` Tejun Heo 2020-12-02 22:39 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 3/9] block: store a block_device pointer in struct bio Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 22:54 ` Tejun Heo 2020-12-02 22:54 ` [dm-devel] " Tejun Heo 2020-12-03 6:39 ` Ming Lei 2020-12-03 6:39 ` [dm-devel] " Ming Lei 2020-12-03 7:10 ` Ming Lei 2020-12-03 7:10 ` [dm-devel] " Ming Lei 2020-12-03 8:29 ` Christoph Hellwig 2020-12-03 8:29 ` [dm-devel] " Christoph Hellwig 2020-12-03 9:32 ` Ming Lei 2020-12-03 9:32 ` [dm-devel] " Ming Lei 2020-12-03 20:53 ` Keith Busch 2020-12-03 20:53 ` [dm-devel] " Keith Busch 2020-12-01 16:54 ` [PATCH 4/9] block: simplify submit_bio_checks a bit Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 22:55 ` Tejun Heo 2020-12-02 22:55 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 5/9] block: use ->bi_bdev for bio based I/O accounting Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:05 ` Tejun Heo 2020-12-02 23:05 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 6/9] blk-mq: use ->bi_bdev for " Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:06 ` Tejun Heo 2020-12-02 23:06 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 7/9] block: add a disk_uevent helper Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:08 ` Tejun Heo 2020-12-02 23:08 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 8/9] block: remove DISK_PITER_REVERSE Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:15 ` Tejun Heo 2020-12-02 23:15 ` [dm-devel] " Tejun Heo 2020-12-01 16:54 ` [PATCH 9/9] block: use an xarray for disk->part_tbl Christoph Hellwig 2020-12-01 16:54 ` [dm-devel] " Christoph Hellwig 2020-12-02 23:22 ` Tejun Heo 2020-12-02 23:22 ` [dm-devel] " Tejun Heo 2020-12-02 22:35 ` store a pointer to the block_device in struct bio (again) Tejun Heo 2020-12-02 22:35 ` [dm-devel] " Tejun Heo 2020-12-02 22:37 ` Tejun Heo 2020-12-02 22:37 ` [dm-devel] " Tejun Heo 2020-12-04 16:43 ` Jens Axboe 2020-12-04 16:43 ` [dm-devel] " Jens Axboe 2020-12-07 18:56 ` Qian Cai 2020-12-07 18:56 ` [dm-devel] " Qian Cai 2020-12-07 19:01 ` Christoph Hellwig 2020-12-07 19:01 ` [dm-devel] " Christoph Hellwig 2020-12-07 20:20 ` Jens Axboe 2020-12-07 20:20 ` [dm-devel] " Jens Axboe 2020-12-08 11:04 ` Christoph Hellwig 2020-12-08 11:04 ` [dm-devel] " Christoph Hellwig 2020-12-08 13:08 ` Qian Cai 2020-12-08 13:08 ` [dm-devel] " Qian Cai 2020-12-08 13:38 ` Daniel Wagner 2020-12-08 13:38 ` [dm-devel] " Daniel Wagner 2020-12-08 14:15 ` Jens Axboe 2020-12-08 14:15 ` [dm-devel] " Jens Axboe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.