From: Catalin Marinas <catalin.marinas@arm.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Marco Elver <elver@google.com>, Evgenii Stepanov <eugenis@google.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Andrey Konovalov <andreyknvl@google.com> Subject: Re: [PATCH v3 3/4] arm64: mte: Enable async tag check fault Date: Mon, 18 Jan 2021 12:57:15 +0000 [thread overview] Message-ID: <20210118125715.GA4483@gaia> (raw) In-Reply-To: <20210115120043.50023-4-vincenzo.frascino@arm.com> On Fri, Jan 15, 2021 at 12:00:42PM +0000, Vincenzo Frascino wrote: > diff --git a/arch/arm64/include/asm/mte.h b/arch/arm64/include/asm/mte.h > index d02aff9f493d..1a715963d909 100644 > --- a/arch/arm64/include/asm/mte.h > +++ b/arch/arm64/include/asm/mte.h > @@ -92,5 +92,26 @@ static inline void mte_assign_mem_tag_range(void *addr, size_t size) > > #endif /* CONFIG_ARM64_MTE */ > > +#ifdef CONFIG_KASAN_HW_TAGS > +void mte_check_tfsr_el1_no_sync(void); > +static inline void mte_check_tfsr_el1(void) > +{ > + mte_check_tfsr_el1_no_sync(); > + /* > + * The asynchronous faults are synch'ed automatically with > + * TFSR_EL1 on kernel entry but for exit an explicit dsb() > + * is required. > + */ > + dsb(ish); > +} Mark commented already, the barrier should be above mte_check_tfsr_el1_no_sync(). Regarding the ISB, we are waiting for confirmation from the architects. > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index df7a1ae26d7c..6cb92e9d6ad1 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -180,6 +180,32 @@ void mte_enable_kernel(enum kasan_hw_tags_mode mode) > isb(); > } > > +#ifdef CONFIG_KASAN_HW_TAGS > +void mte_check_tfsr_el1_no_sync(void) > +{ > + u64 tfsr_el1; > + > + if (!system_supports_mte()) > + return; > + > + tfsr_el1 = read_sysreg_s(SYS_TFSR_EL1); > + > + /* > + * The kernel should never hit the condition TF0 == 1 > + * at this point because for the futex code we set > + * PSTATE.TCO. > + */ > + WARN_ON(tfsr_el1 & SYS_TFSR_EL1_TF0); I'd change this to a WARN_ON_ONCE() in case we trip over this due to model bugs etc. and it floods the log. > + if (tfsr_el1 & SYS_TFSR_EL1_TF1) { > + write_sysreg_s(0, SYS_TFSR_EL1); > + isb(); While in general we use ISB after a sysreg update, I haven't convinced myself it's needed here. There's no side-effect to updating this reg and a subsequent TFSR access should see the new value. If a speculated load is allowed to update this reg, we'd probably need an ISB+DSB (I don't think it does, something to check with the architects). > + > + pr_err("MTE: Asynchronous tag exception detected!"); We discussed this already, I think we should replace this pr_err() with a call to kasan_report(). In principle, kasan already knows the mode as it asked for sync/async but we could make this explicit and expand the kasan API to take some argument (or have separate function like kasan_report_async()). -- Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: Branislav Rankov <Branislav.Rankov@arm.com>, Marco Elver <elver@google.com>, Andrey Konovalov <andreyknvl@google.com>, Evgenii Stepanov <eugenis@google.com>, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Alexander Potapenko <glider@google.com>, linux-arm-kernel@lists.infradead.org, Andrey Ryabinin <aryabinin@virtuozzo.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH v3 3/4] arm64: mte: Enable async tag check fault Date: Mon, 18 Jan 2021 12:57:15 +0000 [thread overview] Message-ID: <20210118125715.GA4483@gaia> (raw) In-Reply-To: <20210115120043.50023-4-vincenzo.frascino@arm.com> On Fri, Jan 15, 2021 at 12:00:42PM +0000, Vincenzo Frascino wrote: > diff --git a/arch/arm64/include/asm/mte.h b/arch/arm64/include/asm/mte.h > index d02aff9f493d..1a715963d909 100644 > --- a/arch/arm64/include/asm/mte.h > +++ b/arch/arm64/include/asm/mte.h > @@ -92,5 +92,26 @@ static inline void mte_assign_mem_tag_range(void *addr, size_t size) > > #endif /* CONFIG_ARM64_MTE */ > > +#ifdef CONFIG_KASAN_HW_TAGS > +void mte_check_tfsr_el1_no_sync(void); > +static inline void mte_check_tfsr_el1(void) > +{ > + mte_check_tfsr_el1_no_sync(); > + /* > + * The asynchronous faults are synch'ed automatically with > + * TFSR_EL1 on kernel entry but for exit an explicit dsb() > + * is required. > + */ > + dsb(ish); > +} Mark commented already, the barrier should be above mte_check_tfsr_el1_no_sync(). Regarding the ISB, we are waiting for confirmation from the architects. > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index df7a1ae26d7c..6cb92e9d6ad1 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -180,6 +180,32 @@ void mte_enable_kernel(enum kasan_hw_tags_mode mode) > isb(); > } > > +#ifdef CONFIG_KASAN_HW_TAGS > +void mte_check_tfsr_el1_no_sync(void) > +{ > + u64 tfsr_el1; > + > + if (!system_supports_mte()) > + return; > + > + tfsr_el1 = read_sysreg_s(SYS_TFSR_EL1); > + > + /* > + * The kernel should never hit the condition TF0 == 1 > + * at this point because for the futex code we set > + * PSTATE.TCO. > + */ > + WARN_ON(tfsr_el1 & SYS_TFSR_EL1_TF0); I'd change this to a WARN_ON_ONCE() in case we trip over this due to model bugs etc. and it floods the log. > + if (tfsr_el1 & SYS_TFSR_EL1_TF1) { > + write_sysreg_s(0, SYS_TFSR_EL1); > + isb(); While in general we use ISB after a sysreg update, I haven't convinced myself it's needed here. There's no side-effect to updating this reg and a subsequent TFSR access should see the new value. If a speculated load is allowed to update this reg, we'd probably need an ISB+DSB (I don't think it does, something to check with the architects). > + > + pr_err("MTE: Asynchronous tag exception detected!"); We discussed this already, I think we should replace this pr_err() with a call to kasan_report(). In principle, kasan already knows the mode as it asked for sync/async but we could make this explicit and expand the kasan API to take some argument (or have separate function like kasan_report_async()). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-18 13:02 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-15 12:00 [PATCH v3 0/4] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino 2021-01-15 12:00 ` Vincenzo Frascino 2021-01-15 12:00 ` [PATCH v3 1/4] kasan, arm64: Add KASAN light mode Vincenzo Frascino 2021-01-15 12:00 ` Vincenzo Frascino 2021-01-15 15:08 ` Mark Rutland 2021-01-15 15:08 ` Mark Rutland 2021-01-16 13:47 ` Vincenzo Frascino 2021-01-16 13:47 ` Vincenzo Frascino 2021-01-16 14:09 ` Andrey Konovalov 2021-01-16 14:09 ` Andrey Konovalov 2021-01-18 10:24 ` Mark Rutland 2021-01-18 10:24 ` Mark Rutland 2021-01-15 18:59 ` Andrey Konovalov 2021-01-15 18:59 ` Andrey Konovalov 2021-01-16 13:40 ` Vincenzo Frascino 2021-01-16 13:40 ` Vincenzo Frascino 2021-01-16 13:59 ` Andrey Konovalov 2021-01-16 13:59 ` Andrey Konovalov 2021-01-16 14:06 ` Vincenzo Frascino 2021-01-16 14:06 ` Vincenzo Frascino 2021-01-15 12:00 ` [PATCH v3 2/4] arm64: mte: Add asynchronous mode support Vincenzo Frascino 2021-01-15 12:00 ` Vincenzo Frascino 2021-01-15 15:13 ` Mark Rutland 2021-01-15 15:13 ` Mark Rutland 2021-01-16 13:49 ` Vincenzo Frascino 2021-01-16 13:49 ` Vincenzo Frascino 2021-01-15 12:00 ` [PATCH v3 3/4] arm64: mte: Enable async tag check fault Vincenzo Frascino 2021-01-15 12:00 ` Vincenzo Frascino 2021-01-15 15:37 ` Mark Rutland 2021-01-15 15:37 ` Mark Rutland 2021-01-18 12:57 ` Catalin Marinas [this message] 2021-01-18 12:57 ` Catalin Marinas 2021-01-18 13:37 ` Vincenzo Frascino 2021-01-18 13:37 ` Vincenzo Frascino 2021-01-18 14:14 ` Mark Rutland 2021-01-18 14:14 ` Mark Rutland 2021-01-18 14:48 ` Vincenzo Frascino 2021-01-18 14:48 ` Vincenzo Frascino 2021-01-18 15:39 ` Vincenzo Frascino 2021-01-18 15:39 ` Vincenzo Frascino 2021-01-18 15:40 ` Vincenzo Frascino 2021-01-18 15:40 ` Vincenzo Frascino 2021-01-15 12:00 ` [PATCH v3 4/4] arm64: mte: Optimize mte_assign_mem_tag_range() Vincenzo Frascino 2021-01-15 12:00 ` Vincenzo Frascino 2021-01-15 15:45 ` Mark Rutland 2021-01-15 15:45 ` Mark Rutland 2021-01-16 14:22 ` Vincenzo Frascino 2021-01-16 14:22 ` Vincenzo Frascino 2021-01-17 12:27 ` Vincenzo Frascino 2021-01-17 12:27 ` Vincenzo Frascino 2021-01-18 10:41 ` Mark Rutland 2021-01-18 10:41 ` Mark Rutland 2021-01-18 11:00 ` Vincenzo Frascino 2021-01-18 11:00 ` Vincenzo Frascino
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210118125715.GA4483@gaia \ --to=catalin.marinas@arm.com \ --cc=Branislav.Rankov@arm.com \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.