From: Vinicius Costa Gomes <vinicius.gomes@intel.com> To: intel-wired-lan@lists.osuosl.org Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>, sasha.neftin@intel.com, anthony.l.nguyen@intel.com, linux-pci@vger.kernel.org, bhelgaas@google.com, netdev@vger.kernel.org, mlichvar@redhat.com, richardcochran@gmail.com Subject: [PATCH next-queue v3 1/3] Revert "PCI: Make pci_enable_ptm() private" Date: Mon, 22 Mar 2021 09:18:20 -0700 [thread overview] Message-ID: <20210322161822.1546454-2-vinicius.gomes@intel.com> (raw) In-Reply-To: <20210322161822.1546454-1-vinicius.gomes@intel.com> Make pci_enable_ptm() accessible from the drivers. Even if PTM still works on the platform I am using without calling this function, it might be possible that it's not always the case. Exposing this to the driver enables the driver to use the 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not. This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c. Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/pci/pci.h | 3 --- include/linux/pci.h | 7 +++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index ef7c4661314f..2c61557e1cc1 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -599,11 +599,8 @@ static inline void pcie_ecrc_get_policy(char *str) { } #ifdef CONFIG_PCIE_PTM void pci_ptm_init(struct pci_dev *dev); -int pci_enable_ptm(struct pci_dev *dev, u8 *granularity); #else static inline void pci_ptm_init(struct pci_dev *dev) { } -static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity) -{ return -EINVAL; } #endif struct pci_dev_reset_methods { diff --git a/include/linux/pci.h b/include/linux/pci.h index 86c799c97b77..3d3dc07eac3b 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1610,6 +1610,13 @@ static inline bool pci_aer_available(void) { return false; } bool pci_ats_disabled(void); +#ifdef CONFIG_PCIE_PTM +int pci_enable_ptm(struct pci_dev *dev, u8 *granularity); +#else +static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity) +{ return -EINVAL; } +#endif + void pci_cfg_access_lock(struct pci_dev *dev); bool pci_cfg_access_trylock(struct pci_dev *dev); void pci_cfg_access_unlock(struct pci_dev *dev); -- 2.31.0
WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH next-queue v3 1/3] Revert "PCI: Make pci_enable_ptm() private" Date: Mon, 22 Mar 2021 09:18:20 -0700 [thread overview] Message-ID: <20210322161822.1546454-2-vinicius.gomes@intel.com> (raw) In-Reply-To: <20210322161822.1546454-1-vinicius.gomes@intel.com> Make pci_enable_ptm() accessible from the drivers. Even if PTM still works on the platform I am using without calling this function, it might be possible that it's not always the case. Exposing this to the driver enables the driver to use the 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not. This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c. Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/pci/pci.h | 3 --- include/linux/pci.h | 7 +++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index ef7c4661314f..2c61557e1cc1 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -599,11 +599,8 @@ static inline void pcie_ecrc_get_policy(char *str) { } #ifdef CONFIG_PCIE_PTM void pci_ptm_init(struct pci_dev *dev); -int pci_enable_ptm(struct pci_dev *dev, u8 *granularity); #else static inline void pci_ptm_init(struct pci_dev *dev) { } -static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity) -{ return -EINVAL; } #endif struct pci_dev_reset_methods { diff --git a/include/linux/pci.h b/include/linux/pci.h index 86c799c97b77..3d3dc07eac3b 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1610,6 +1610,13 @@ static inline bool pci_aer_available(void) { return false; } bool pci_ats_disabled(void); +#ifdef CONFIG_PCIE_PTM +int pci_enable_ptm(struct pci_dev *dev, u8 *granularity); +#else +static inline int pci_enable_ptm(struct pci_dev *dev, u8 *granularity) +{ return -EINVAL; } +#endif + void pci_cfg_access_lock(struct pci_dev *dev); bool pci_cfg_access_trylock(struct pci_dev *dev); void pci_cfg_access_unlock(struct pci_dev *dev); -- 2.31.0
next prev parent reply other threads:[~2021-03-22 16:20 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-22 16:18 [PATCH next-queue v3 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes 2021-03-22 16:18 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-22 16:18 ` Vinicius Costa Gomes [this message] 2021-03-22 16:18 ` [Intel-wired-lan] [PATCH next-queue v3 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes 2021-03-23 16:01 ` Christoph Hellwig 2021-03-23 16:01 ` [Intel-wired-lan] " Christoph Hellwig 2021-03-23 18:40 ` Vinicius Costa Gomes 2021-03-23 18:40 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-23 18:45 ` Christoph Hellwig 2021-03-23 18:45 ` [Intel-wired-lan] " Christoph Hellwig 2021-03-23 19:40 ` Bjorn Helgaas 2021-03-23 19:40 ` [Intel-wired-lan] " Bjorn Helgaas 2021-03-23 22:49 ` Vinicius Costa Gomes 2021-03-23 22:49 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-22 16:18 ` [PATCH next-queue v3 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes 2021-03-22 16:18 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-23 19:29 ` Bjorn Helgaas 2021-03-23 19:29 ` [Intel-wired-lan] " Bjorn Helgaas 2021-03-23 19:40 ` Vinicius Costa Gomes 2021-03-23 19:40 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-22 16:18 ` [PATCH next-queue v3 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes 2021-03-22 16:18 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-23 19:39 ` Bjorn Helgaas 2021-03-23 19:39 ` [Intel-wired-lan] " Bjorn Helgaas 2021-03-23 21:37 ` Vinicius Costa Gomes 2021-03-23 21:37 ` [Intel-wired-lan] " Vinicius Costa Gomes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210322161822.1546454-2-vinicius.gomes@intel.com \ --to=vinicius.gomes@intel.com \ --cc=anthony.l.nguyen@intel.com \ --cc=bhelgaas@google.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=linux-pci@vger.kernel.org \ --cc=mlichvar@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=richardcochran@gmail.com \ --cc=sasha.neftin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.