From: Bjorn Helgaas <helgaas@kernel.org> To: Vinicius Costa Gomes <vinicius.gomes@intel.com> Cc: intel-wired-lan@lists.osuosl.org, sasha.neftin@intel.com, anthony.l.nguyen@intel.com, linux-pci@vger.kernel.org, bhelgaas@google.com, netdev@vger.kernel.org, mlichvar@redhat.com, richardcochran@gmail.com Subject: Re: [PATCH next-queue v3 2/3] igc: Enable PCIe PTM Date: Tue, 23 Mar 2021 14:29:20 -0500 [thread overview] Message-ID: <20210323192920.GA597326@bjorn-Precision-5520> (raw) In-Reply-To: <20210322161822.1546454-3-vinicius.gomes@intel.com> On Mon, Mar 22, 2021 at 09:18:21AM -0700, Vinicius Costa Gomes wrote: > In practice, enabling PTM also sets the enabled_ptm flag in the PCI > device, the flag will be used for detecting if PTM is enabled before > adding support for the SYSOFFSET_PRECISE ioctl() (which is added by > implementing the getcrosststamp() PTP function). I think you're referring to the "pci_dev.ptm_enabled" flag. I'm not sure what the connection to this patch is. The SYSOFFSET_PRECISE stuff also seems to belong with some other patch. This patch merely enables PTM if it's supported (might be worth expanding Precision Time Measurement for context). > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index f77feadde8d2..04319ffae288 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -12,6 +12,8 @@ > #include <net/pkt_sched.h> > #include <linux/bpf_trace.h> > #include <net/xdp_sock_drv.h> > +#include <linux/pci.h> > + > #include <net/ipv6.h> > > #include "igc.h" > @@ -5792,6 +5794,10 @@ static int igc_probe(struct pci_dev *pdev, > > pci_enable_pcie_error_reporting(pdev); > > + err = pci_enable_ptm(pdev, NULL); > + if (err < 0) > + dev_err(&pdev->dev, "PTM not supported\n"); > + > pci_set_master(pdev); > > err = -ENOMEM; > -- > 2.31.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH next-queue v3 2/3] igc: Enable PCIe PTM Date: Tue, 23 Mar 2021 14:29:20 -0500 [thread overview] Message-ID: <20210323192920.GA597326@bjorn-Precision-5520> (raw) In-Reply-To: <20210322161822.1546454-3-vinicius.gomes@intel.com> On Mon, Mar 22, 2021 at 09:18:21AM -0700, Vinicius Costa Gomes wrote: > In practice, enabling PTM also sets the enabled_ptm flag in the PCI > device, the flag will be used for detecting if PTM is enabled before > adding support for the SYSOFFSET_PRECISE ioctl() (which is added by > implementing the getcrosststamp() PTP function). I think you're referring to the "pci_dev.ptm_enabled" flag. I'm not sure what the connection to this patch is. The SYSOFFSET_PRECISE stuff also seems to belong with some other patch. This patch merely enables PTM if it's supported (might be worth expanding Precision Time Measurement for context). > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index f77feadde8d2..04319ffae288 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -12,6 +12,8 @@ > #include <net/pkt_sched.h> > #include <linux/bpf_trace.h> > #include <net/xdp_sock_drv.h> > +#include <linux/pci.h> > + > #include <net/ipv6.h> > > #include "igc.h" > @@ -5792,6 +5794,10 @@ static int igc_probe(struct pci_dev *pdev, > > pci_enable_pcie_error_reporting(pdev); > > + err = pci_enable_ptm(pdev, NULL); > + if (err < 0) > + dev_err(&pdev->dev, "PTM not supported\n"); > + > pci_set_master(pdev); > > err = -ENOMEM; > -- > 2.31.0 >
next prev parent reply other threads:[~2021-03-23 19:30 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-22 16:18 [PATCH next-queue v3 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes 2021-03-22 16:18 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-22 16:18 ` [PATCH next-queue v3 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes 2021-03-22 16:18 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-23 16:01 ` Christoph Hellwig 2021-03-23 16:01 ` [Intel-wired-lan] " Christoph Hellwig 2021-03-23 18:40 ` Vinicius Costa Gomes 2021-03-23 18:40 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-23 18:45 ` Christoph Hellwig 2021-03-23 18:45 ` [Intel-wired-lan] " Christoph Hellwig 2021-03-23 19:40 ` Bjorn Helgaas 2021-03-23 19:40 ` [Intel-wired-lan] " Bjorn Helgaas 2021-03-23 22:49 ` Vinicius Costa Gomes 2021-03-23 22:49 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-22 16:18 ` [PATCH next-queue v3 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes 2021-03-22 16:18 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-23 19:29 ` Bjorn Helgaas [this message] 2021-03-23 19:29 ` Bjorn Helgaas 2021-03-23 19:40 ` Vinicius Costa Gomes 2021-03-23 19:40 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-22 16:18 ` [PATCH next-queue v3 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes 2021-03-22 16:18 ` [Intel-wired-lan] " Vinicius Costa Gomes 2021-03-23 19:39 ` Bjorn Helgaas 2021-03-23 19:39 ` [Intel-wired-lan] " Bjorn Helgaas 2021-03-23 21:37 ` Vinicius Costa Gomes 2021-03-23 21:37 ` [Intel-wired-lan] " Vinicius Costa Gomes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210323192920.GA597326@bjorn-Precision-5520 \ --to=helgaas@kernel.org \ --cc=anthony.l.nguyen@intel.com \ --cc=bhelgaas@google.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=linux-pci@vger.kernel.org \ --cc=mlichvar@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=richardcochran@gmail.com \ --cc=sasha.neftin@intel.com \ --cc=vinicius.gomes@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.