All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kbuild@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] Raise the minimum GCC version to 5.2
Date: Mon, 3 May 2021 14:27:36 +0200	[thread overview]
Message-ID: <20210503122736.GG7604@twin.jikos.cz> (raw)
In-Reply-To: <20210501151538.145449-1-masahiroy@kernel.org>

On Sun, May 02, 2021 at 12:15:38AM +0900, Masahiro Yamada wrote:
> The current minimum GCC version is 4.9 except ARCH=arm64 requiring
> GCC 5.1.
> 
> When we discussed last time, we agreed to raise the minimum GCC version
> to 5.1 globally. [1]

There are still a lot of comment references to old gcc releases with
workarounds or bugfixes, a quick serarch:

$ git grep -in 'gcc.*[234]\.x'
arch/alpha/include/asm/string.h:30:/* For gcc 3.x, we cannot have the inline function named "memset" because
arch/arc/include/asm/checksum.h:9: *  -gcc 4.4.x broke networking. Alias analysis needed to be primed.
arch/arm/Makefile:127:# Need -Uarm for gcc < 3.x
arch/ia64/lib/memcpy_mck.S:535: * Due to lack of local tag support in gcc 2.x assembler, it is not clear which
arch/mips/include/asm/page.h:210: * also affect MIPS so we keep this one until GCC 3.x has been retired
arch/x86/include/asm/page.h:53: * remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated)
arch/x86/kvm/x86.c:5569:         * This union makes it completely explicit to gcc-3.x
arch/x86/mm/pgtable.c:302:      if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
drivers/net/ethernet/renesas/sh_eth.c:51: * that warning from W=1 builds. GCC has supported this option since 4.2.X, but
lib/xz/xz_dec_lzma2.c:494: * of the code generated by GCC 3.x decreases 10-15 %. (GCC 4.3 doesn't care,
lib/xz/xz_dec_lzma2.c:495: * and it generates 10-20 % faster code than GCC 3.x from this file anyway.)
net/core/skbuff.c:32: * The functions in this file will not compile correctly with gcc 2.4.x

This misses version-specific quirks, but the following returns 216
results and not all are problematic (eg. just referring to gcc for some
historical reason) so I'm not pasting it here.

$ git grep -in 'gcc.*[234]\.[0-9]'
...

WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kbuild@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] Raise the minimum GCC version to 5.2
Date: Mon, 3 May 2021 14:27:36 +0200	[thread overview]
Message-ID: <20210503122736.GG7604@twin.jikos.cz> (raw)
In-Reply-To: <20210501151538.145449-1-masahiroy@kernel.org>

On Sun, May 02, 2021 at 12:15:38AM +0900, Masahiro Yamada wrote:
> The current minimum GCC version is 4.9 except ARCH=arm64 requiring
> GCC 5.1.
> 
> When we discussed last time, we agreed to raise the minimum GCC version
> to 5.1 globally. [1]

There are still a lot of comment references to old gcc releases with
workarounds or bugfixes, a quick serarch:

$ git grep -in 'gcc.*[234]\.x'
arch/alpha/include/asm/string.h:30:/* For gcc 3.x, we cannot have the inline function named "memset" because
arch/arc/include/asm/checksum.h:9: *  -gcc 4.4.x broke networking. Alias analysis needed to be primed.
arch/arm/Makefile:127:# Need -Uarm for gcc < 3.x
arch/ia64/lib/memcpy_mck.S:535: * Due to lack of local tag support in gcc 2.x assembler, it is not clear which
arch/mips/include/asm/page.h:210: * also affect MIPS so we keep this one until GCC 3.x has been retired
arch/x86/include/asm/page.h:53: * remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated)
arch/x86/kvm/x86.c:5569:         * This union makes it completely explicit to gcc-3.x
arch/x86/mm/pgtable.c:302:      if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
drivers/net/ethernet/renesas/sh_eth.c:51: * that warning from W=1 builds. GCC has supported this option since 4.2.X, but
lib/xz/xz_dec_lzma2.c:494: * of the code generated by GCC 3.x decreases 10-15 %. (GCC 4.3 doesn't care,
lib/xz/xz_dec_lzma2.c:495: * and it generates 10-20 % faster code than GCC 3.x from this file anyway.)
net/core/skbuff.c:32: * The functions in this file will not compile correctly with gcc 2.4.x

This misses version-specific quirks, but the following returns 216
results and not all are problematic (eg. just referring to gcc for some
historical reason) so I'm not pasting it here.

$ git grep -in 'gcc.*[234]\.[0-9]'
...

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>, Arnd Bergmann <arnd@arndb.de>,
	linux-kbuild@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Raise the minimum GCC version to 5.2
Date: Mon, 3 May 2021 14:27:36 +0200	[thread overview]
Message-ID: <20210503122736.GG7604@twin.jikos.cz> (raw)
In-Reply-To: <20210501151538.145449-1-masahiroy@kernel.org>

On Sun, May 02, 2021 at 12:15:38AM +0900, Masahiro Yamada wrote:
> The current minimum GCC version is 4.9 except ARCH=arm64 requiring
> GCC 5.1.
> 
> When we discussed last time, we agreed to raise the minimum GCC version
> to 5.1 globally. [1]

There are still a lot of comment references to old gcc releases with
workarounds or bugfixes, a quick serarch:

$ git grep -in 'gcc.*[234]\.x'
arch/alpha/include/asm/string.h:30:/* For gcc 3.x, we cannot have the inline function named "memset" because
arch/arc/include/asm/checksum.h:9: *  -gcc 4.4.x broke networking. Alias analysis needed to be primed.
arch/arm/Makefile:127:# Need -Uarm for gcc < 3.x
arch/ia64/lib/memcpy_mck.S:535: * Due to lack of local tag support in gcc 2.x assembler, it is not clear which
arch/mips/include/asm/page.h:210: * also affect MIPS so we keep this one until GCC 3.x has been retired
arch/x86/include/asm/page.h:53: * remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated)
arch/x86/kvm/x86.c:5569:         * This union makes it completely explicit to gcc-3.x
arch/x86/mm/pgtable.c:302:      if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
drivers/net/ethernet/renesas/sh_eth.c:51: * that warning from W=1 builds. GCC has supported this option since 4.2.X, but
lib/xz/xz_dec_lzma2.c:494: * of the code generated by GCC 3.x decreases 10-15 %. (GCC 4.3 doesn't care,
lib/xz/xz_dec_lzma2.c:495: * and it generates 10-20 % faster code than GCC 3.x from this file anyway.)
net/core/skbuff.c:32: * The functions in this file will not compile correctly with gcc 2.4.x

This misses version-specific quirks, but the following returns 216
results and not all are problematic (eg. just referring to gcc for some
historical reason) so I'm not pasting it here.

$ git grep -in 'gcc.*[234]\.[0-9]'
...

WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kbuild@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] Raise the minimum GCC version to 5.2
Date: Mon, 3 May 2021 14:27:36 +0200	[thread overview]
Message-ID: <20210503122736.GG7604@twin.jikos.cz> (raw)
In-Reply-To: <20210501151538.145449-1-masahiroy@kernel.org>

On Sun, May 02, 2021 at 12:15:38AM +0900, Masahiro Yamada wrote:
> The current minimum GCC version is 4.9 except ARCH=arm64 requiring
> GCC 5.1.
> 
> When we discussed last time, we agreed to raise the minimum GCC version
> to 5.1 globally. [1]

There are still a lot of comment references to old gcc releases with
workarounds or bugfixes, a quick serarch:

$ git grep -in 'gcc.*[234]\.x'
arch/alpha/include/asm/string.h:30:/* For gcc 3.x, we cannot have the inline function named "memset" because
arch/arc/include/asm/checksum.h:9: *  -gcc 4.4.x broke networking. Alias analysis needed to be primed.
arch/arm/Makefile:127:# Need -Uarm for gcc < 3.x
arch/ia64/lib/memcpy_mck.S:535: * Due to lack of local tag support in gcc 2.x assembler, it is not clear which
arch/mips/include/asm/page.h:210: * also affect MIPS so we keep this one until GCC 3.x has been retired
arch/x86/include/asm/page.h:53: * remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated)
arch/x86/kvm/x86.c:5569:         * This union makes it completely explicit to gcc-3.x
arch/x86/mm/pgtable.c:302:      if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
drivers/net/ethernet/renesas/sh_eth.c:51: * that warning from W=1 builds. GCC has supported this option since 4.2.X, but
lib/xz/xz_dec_lzma2.c:494: * of the code generated by GCC 3.x decreases 10-15 %. (GCC 4.3 doesn't care,
lib/xz/xz_dec_lzma2.c:495: * and it generates 10-20 % faster code than GCC 3.x from this file anyway.)
net/core/skbuff.c:32: * The functions in this file will not compile correctly with gcc 2.4.x

This misses version-specific quirks, but the following returns 216
results and not all are problematic (eg. just referring to gcc for some
historical reason) so I'm not pasting it here.

$ git grep -in 'gcc.*[234]\.[0-9]'
...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-05-03 12:30 UTC|newest]

Thread overview: 146+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-01 15:15 [PATCH] Raise the minimum GCC version to 5.2 Masahiro Yamada
2021-05-01 15:15 ` Masahiro Yamada
2021-05-01 15:15 ` Masahiro Yamada
2021-05-01 15:15 ` Masahiro Yamada
2021-05-01 15:52 ` Miguel Ojeda
2021-05-01 15:52   ` Miguel Ojeda
2021-05-01 15:52   ` Miguel Ojeda
2021-05-01 15:52   ` Miguel Ojeda
2021-05-01 17:38   ` Christophe Leroy
2021-05-01 17:38     ` Christophe Leroy
2021-05-01 17:38     ` Christophe Leroy
2021-05-01 17:38     ` Christophe Leroy
2021-05-02  2:41   ` Joe Perches
2021-05-02  2:41     ` Joe Perches
2021-05-02  2:41     ` Joe Perches
2021-05-02  2:41     ` Joe Perches
2021-05-02 18:30     ` Segher Boessenkool
2021-05-02 18:30       ` Segher Boessenkool
2021-05-02 18:30       ` Segher Boessenkool
2021-05-02 18:30       ` Segher Boessenkool
2021-05-02 20:00       ` Joe Perches
2021-05-02 20:00         ` Joe Perches
2021-05-02 20:00         ` Joe Perches
2021-05-02 20:00         ` Joe Perches
2021-05-02 20:32         ` Segher Boessenkool
2021-05-02 20:32           ` Segher Boessenkool
2021-05-02 20:32           ` Segher Boessenkool
2021-05-02 20:32           ` Segher Boessenkool
2021-05-02 21:05           ` Ali Kaasinen
2021-05-02 21:05             ` Ali Kaasinen
2021-05-02 21:05             ` Ali Kaasinen
2021-05-02 21:05             ` Ali Kaasinen
2021-05-02 21:08           ` Linus Torvalds
2021-05-02 21:08             ` Linus Torvalds
2021-05-02 21:08             ` Linus Torvalds
2021-05-02 21:08             ` Linus Torvalds
2021-05-02 22:30             ` Matthew Wilcox
2021-05-02 22:30               ` Matthew Wilcox
2021-05-02 22:30               ` Matthew Wilcox
2021-05-02 22:30               ` Matthew Wilcox
2021-05-03  7:34               ` Alexander Dahl
2021-05-03  7:34                 ` Alexander Dahl
2021-05-03  7:34                 ` Alexander Dahl
2021-05-03  7:34                 ` Alexander Dahl
2021-05-03  8:54                 ` Joe Perches
2021-05-03  8:54                   ` Joe Perches
2021-05-03  8:54                   ` Joe Perches
2021-05-03  8:54                   ` Joe Perches
2021-05-03  9:25                 ` Arnd Bergmann
2021-05-03  9:25                   ` Arnd Bergmann
2021-05-03  9:25                   ` Arnd Bergmann
2021-05-03  9:25                   ` Arnd Bergmann
2021-05-03 12:20                   ` David Laight
2021-05-03 12:20                     ` David Laight
2021-05-03 12:20                     ` David Laight
2021-05-03 13:10                     ` Miguel Ojeda
2021-05-03 13:10                       ` Miguel Ojeda
2021-05-03 13:10                       ` Miguel Ojeda
2021-05-03 13:10                       ` Miguel Ojeda
2021-05-04  5:30                   ` Alexander Dahl
2021-05-04  5:30                     ` Alexander Dahl
2021-05-04  5:30                     ` Alexander Dahl
2021-05-04  5:30                     ` Alexander Dahl
2021-05-04  6:33                     ` Christophe Leroy
2021-05-04  6:33                       ` Christophe Leroy
2021-05-04  6:33                       ` Christophe Leroy
2021-05-04 12:07                     ` Arnd Bergmann
2021-05-04 12:07                       ` Arnd Bergmann
2021-05-04 12:07                       ` Arnd Bergmann
2021-05-04 12:07                       ` Arnd Bergmann
2021-05-04 13:25                   ` Andy Shevchenko
2021-05-04 13:25                     ` Andy Shevchenko
2021-05-04 13:25                     ` Andy Shevchenko
2021-05-04 13:25                     ` Andy Shevchenko
2021-05-03 11:35               ` Arnd Bergmann
2021-05-03 11:35                 ` Arnd Bergmann
2021-05-03 11:35                 ` Arnd Bergmann
2021-05-03 11:35                 ` Arnd Bergmann
2021-05-03  9:49             ` Kirill A. Shutemov
2021-05-03  9:49               ` Kirill A. Shutemov
2021-05-03  9:49               ` Kirill A. Shutemov
2021-05-03  9:49               ` Kirill A. Shutemov
2021-05-02 21:23           ` Joe Perches
2021-05-02 21:23             ` Joe Perches
2021-05-02 21:23             ` Joe Perches
2021-05-02 21:23             ` Joe Perches
2021-05-03  0:44             ` Segher Boessenkool
2021-05-03  0:44               ` Segher Boessenkool
2021-05-03  0:44               ` Segher Boessenkool
2021-05-03  0:44               ` Segher Boessenkool
2021-05-03  9:57               ` Arnd Bergmann
2021-05-03  9:57                 ` Arnd Bergmann
2021-05-03  9:57                 ` Arnd Bergmann
2021-05-03  9:57                 ` Arnd Bergmann
2021-05-04  7:56     ` Ben Dooks
2021-05-04  7:56       ` Ben Dooks
2021-05-04  7:56       ` Ben Dooks
2021-05-04  7:56       ` Ben Dooks
2021-05-04  8:38       ` Miguel Ojeda
2021-05-04  8:38         ` Miguel Ojeda
2021-05-04  8:38         ` Miguel Ojeda
2021-05-04  8:38         ` Miguel Ojeda
2021-05-04  9:22         ` Michal Suchánek
2021-05-04  9:22           ` Michal Suchánek
2021-05-04  9:22           ` Michal Suchánek
2021-05-04  9:22           ` Michal Suchánek
2021-05-04 12:09           ` Miguel Ojeda
2021-05-04 12:09             ` Miguel Ojeda
2021-05-04 12:09             ` Miguel Ojeda
2021-05-04 12:09             ` Miguel Ojeda
2021-05-04 12:17             ` Michal Suchánek
2021-05-04 12:17               ` Michal Suchánek
2021-05-04 12:17               ` Michal Suchánek
2021-05-04 12:17               ` Michal Suchánek
2021-05-04 12:26               ` Christophe Leroy
2021-05-04 12:26                 ` Christophe Leroy
2021-05-04 12:26                 ` Christophe Leroy
2021-05-04 12:26                 ` Christophe Leroy
2021-05-02 18:37 ` Segher Boessenkool
2021-05-02 18:37   ` Segher Boessenkool
2021-05-02 18:37   ` Segher Boessenkool
2021-05-02 18:37   ` Segher Boessenkool
2021-05-03  6:16 ` Christophe Leroy
2021-05-03  6:16   ` Christophe Leroy
2021-05-03  6:16   ` Christophe Leroy
2021-05-03  6:16   ` Christophe Leroy
2021-05-04  2:13   ` Masahiro Yamada
2021-05-04  2:13     ` Masahiro Yamada
2021-05-04  2:13     ` Masahiro Yamada
2021-05-04  2:13     ` Masahiro Yamada
2021-05-04 13:18   ` Andy Shevchenko
2021-05-04 13:18     ` Andy Shevchenko
2021-05-04 13:18     ` Andy Shevchenko
2021-05-04 13:18     ` Andy Shevchenko
2021-05-03 12:27 ` David Sterba [this message]
2021-05-03 12:27   ` David Sterba
2021-05-03 12:27   ` David Sterba
2021-05-03 12:27   ` David Sterba
2021-05-15  7:14 ` Pavel Machek
2021-05-15  7:14   ` Pavel Machek
2021-05-15  7:14   ` Pavel Machek
2021-05-15  7:14   ` Pavel Machek
2021-05-15  7:27   ` Joe Perches
2021-05-15  7:27     ` Joe Perches
2021-05-15  7:27     ` Joe Perches
2021-05-15  7:27     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503122736.GG7604@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=masahiroy@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=ojeda@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paulus@samba.org \
    --cc=torvalds@linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.