All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH v3 03/28] target/alpha: Remove in_superpage
Date: Thu,  8 Jul 2021 09:40:25 -0700	[thread overview]
Message-ID: <20210708164050.711967-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210708164050.711967-1-richard.henderson@linaro.org>

The number of links across (normal) pages using this is low,
and it will shortly violate the contract for breakpoints.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/alpha/translate.c | 24 ++----------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index aaedf78116..8fa00a79d1 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -439,24 +439,9 @@ static DisasJumpType gen_store_conditional(DisasContext *ctx, int ra, int rb,
     return DISAS_NEXT;
 }
 
-static bool in_superpage(DisasContext *ctx, int64_t addr)
-{
-#ifndef CONFIG_USER_ONLY
-    return ((ctx->tbflags & ENV_FLAG_PS_USER) == 0
-            && addr >> TARGET_VIRT_ADDR_SPACE_BITS == -1
-            && ((addr >> 41) & 3) == 2);
-#else
-    return false;
-#endif
-}
-
 static bool use_goto_tb(DisasContext *ctx, uint64_t dest)
 {
 #ifndef CONFIG_USER_ONLY
-    /* If the destination is in the superpage, the page perms can't change.  */
-    if (in_superpage(ctx, dest)) {
-        return true;
-    }
     /* Check for the dest on the same page as the start of the TB.  */
     return ((ctx->base.tb->pc ^ dest) & TARGET_PAGE_MASK) == 0;
 #else
@@ -2991,7 +2976,7 @@ static void alpha_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
 {
     DisasContext *ctx = container_of(dcbase, DisasContext, base);
     CPUAlphaState *env = cpu->env_ptr;
-    int64_t bound, mask;
+    int64_t bound;
 
     ctx->tbflags = ctx->base.tb->flags;
     ctx->mem_idx = cpu_mmu_index(env, false);
@@ -3020,12 +3005,7 @@ static void alpha_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
     ctx->lit = NULL;
 
     /* Bound the number of insns to execute to those left on the page.  */
-    if (in_superpage(ctx, ctx->base.pc_first)) {
-        mask = -1ULL << 41;
-    } else {
-        mask = TARGET_PAGE_MASK;
-    }
-    bound = -(ctx->base.pc_first | mask) / 4;
+    bound = -(ctx->base.pc_first | TARGET_PAGE_MASK) / 4;
     ctx->base.max_insns = MIN(ctx->base.max_insns, bound);
 }
 
-- 
2.25.1



  parent reply	other threads:[~2021-07-08 17:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 16:40 [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 01/28] " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 02/28] target/alpha: Remove use_exit_tb Richard Henderson
2021-07-08 16:40 ` Richard Henderson [this message]
2021-07-08 16:40 ` [PATCH v3 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB Richard Henderson
2021-07-08 16:40 ` [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson
2021-07-08 16:40 ` [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson
2021-07-08 16:40 ` [PATCH v3 08/28] target/avr: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 09/28] target/avr: Mark some helpers noreturn Richard Henderson
2021-07-08 16:40 ` [PATCH v3 10/28] target/cris: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 11/28] target/hppa: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 12/28] target/i386: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 13/28] target/m68k: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 14/28] target/microblaze: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 15/28] target/mips: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 18/28] target/openrisc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 19/28] target/ppc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 20/28] target/riscv: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 21/28] target/rx: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 22/28] target/s390x: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 23/28] target/s390x: Remove use_exit_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 25/28] target/sparc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 26/28] target/tricore: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-07-08 16:40 ` [PATCH v3 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210708164050.711967-4-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [PATCH v3 03/28] target/alpha: Remove in_superpage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.