All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
To: <ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<robh@kernel.org>,
	Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Subject: [PATCH v3 09/12] ath11k: Do not put HW in DBS mode for WCN6750
Date: Mon, 28 Mar 2022 15:18:35 +0530	[thread overview]
Message-ID: <20220328094838.14093-10-quic_mpubbise@quicinc.com> (raw)
In-Reply-To: <20220328094838.14093-1-quic_mpubbise@quicinc.com>

Though WCN6750 is a single PDEV device, it is not a
DBS solution. So, do not put HW in DBS mode for WCN6750.

Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1

Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/core.c | 2 +-
 drivers/net/wireless/ath/ath11k/wmi.c  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 1955426ca549..d9a06629651c 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -1249,7 +1249,7 @@ static int ath11k_core_start(struct ath11k_base *ab,
 	}
 
 	/* put hardware to DBS mode */
-	if (ab->hw_params.single_pdev_only) {
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1) {
 		ret = ath11k_wmi_set_hw_mode(ab, WMI_HOST_HW_MODE_DBS);
 		if (ret) {
 			ath11k_err(ab, "failed to send dbs mode: %d\n", ret);
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 7f97c26bffd9..119fe1e6a07a 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause-Clear
 /*
  * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved.
  */
 #include <linux/skbuff.h>
 #include <linux/ctype.h>
@@ -8196,7 +8197,7 @@ int ath11k_wmi_attach(struct ath11k_base *ab)
 	ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_MAX;
 
 	/* It's overwritten when service_ext_ready is handled */
-	if (ab->hw_params.single_pdev_only)
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1)
 		ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_SINGLE;
 
 	/* TODO: Init remaining wmi soc resources required */
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
To: <ath11k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<robh@kernel.org>,
	Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Subject: [PATCH v3 09/12] ath11k: Do not put HW in DBS mode for WCN6750
Date: Mon, 28 Mar 2022 15:18:35 +0530	[thread overview]
Message-ID: <20220328094838.14093-10-quic_mpubbise@quicinc.com> (raw)
In-Reply-To: <20220328094838.14093-1-quic_mpubbise@quicinc.com>

Though WCN6750 is a single PDEV device, it is not a
DBS solution. So, do not put HW in DBS mode for WCN6750.

Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1

Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/core.c | 2 +-
 drivers/net/wireless/ath/ath11k/wmi.c  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 1955426ca549..d9a06629651c 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -1249,7 +1249,7 @@ static int ath11k_core_start(struct ath11k_base *ab,
 	}
 
 	/* put hardware to DBS mode */
-	if (ab->hw_params.single_pdev_only) {
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1) {
 		ret = ath11k_wmi_set_hw_mode(ab, WMI_HOST_HW_MODE_DBS);
 		if (ret) {
 			ath11k_err(ab, "failed to send dbs mode: %d\n", ret);
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index 7f97c26bffd9..119fe1e6a07a 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause-Clear
 /*
  * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved.
  */
 #include <linux/skbuff.h>
 #include <linux/ctype.h>
@@ -8196,7 +8197,7 @@ int ath11k_wmi_attach(struct ath11k_base *ab)
 	ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_MAX;
 
 	/* It's overwritten when service_ext_ready is handled */
-	if (ab->hw_params.single_pdev_only)
+	if (ab->hw_params.single_pdev_only && ab->hw_params.num_rxmda_per_pdev > 1)
 		ab->wmi_ab.preferred_hw_mode = WMI_HOST_HW_MODE_SINGLE;
 
 	/* TODO: Init remaining wmi soc resources required */
-- 
2.35.1


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  parent reply	other threads:[~2022-03-28  9:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28  9:48 [PATCH v3 00/12] add support for WCN6750 Manikanta Pubbisetty
2022-03-28  9:48 ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 01/12] dt: bindings: net: add bindings of WCN6750 for ath11k Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-29 23:37   ` Rob Herring
2022-03-29 23:37     ` Rob Herring
2022-03-30  5:19     ` Manikanta Pubbisetty
2022-03-30  5:19       ` Manikanta Pubbisetty
2022-04-04 19:11   ` Matthias Kaehlcke
2022-04-04 19:11     ` Matthias Kaehlcke
2022-04-05  6:25     ` Manikanta Pubbisetty
2022-04-05  6:25       ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 02/12] ath11k: Add HW params for WCN6750 Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 03/12] ath11k: Add bus " Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 04/12] ath11k: Add register access logic " Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 05/12] ath11k: Fetch device information via QMI " Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 06/12] ath11k: Add QMI changes " Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 07/12] ath11k: HAL changes to support WCN6750 Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 08/12] ath11k: Datapath " Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` Manikanta Pubbisetty [this message]
2022-03-28  9:48   ` [PATCH v3 09/12] ath11k: Do not put HW in DBS mode for WCN6750 Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 10/12] ath11k: WMI changes to support WCN6750 Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 11/12] ath11k: Update WBM idle ring HP after FW mode on Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
2022-03-28  9:48 ` [PATCH v3 12/12] ath11k: Add support for WCN6750 device Manikanta Pubbisetty
2022-03-28  9:48   ` Manikanta Pubbisetty
  -- strict thread matches above, loose matches on Subject: below --
2022-03-28  6:09 [PATCH v3 00/12] add support for WCN6750 Manikanta Pubbisetty
2022-03-28  6:09 ` [PATCH v3 09/12] ath11k: Do not put HW in DBS mode " Manikanta Pubbisetty
2022-03-28  6:09   ` Manikanta Pubbisetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220328094838.14093-10-quic_mpubbise@quicinc.com \
    --to=quic_mpubbise@quicinc.com \
    --cc=ath11k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.