Re: [Buildroot] [PATCH v4 07/20] boot/ti-k3-image-gen: manage HS hardware

[Andreas Dannenberg via buildroot <buildroot@buildroot.org>]

On Mon, Feb 19, 2024 at 10:58:26AM +0100, Romain Naour wrote:
> Hello Dario,
> 
> Le 17/02/2024 à 17:02, Dario Binacchi a écrit :
> > The patch sets the configurations required by TI HS systems. Some of these
> > configurations (i. e. HS SYSFW image signing key, HS Software Revision)
> > are provided by the ti-k3-core-secdev package in the binaries directory.
> 
> Such keys has been added to u-boot v2023.10:
> 
> https://git.ti.com/cgit/security-development-tools/core-secdev-k3/tree/keys
> 
> https://source.denx.de/u-boot/u-boot/-/commit/d5b1ef30d7ffabb9f57d5c62b9f0608837af0f4f
> 
> Do we need something else from ti-k3-core-secdev package that is not already
> provided by u-boot?

No, we don't need anything from that. If you look at TI's current SDKs/Yocto
builds this package is not used at all. The TI goal is to do things in a
standard upstream way (in upstream) as much as possible, hence we are
trying to move away from all these "vendor quirks" however possible.

Regards, Andreas



> 
> Best regards,
> Romain
> 
> > 
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > 
> > ---
> > 
> > no changes since v3:
> > 
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> >  boot/ti-k3-image-gen/Config.in          |  1 +
> >  boot/ti-k3-image-gen/ti-k3-image-gen.mk | 16 ++++++++++++++--
> >  2 files changed, 15 insertions(+), 2 deletions(-)
> > 
> > diff --git a/boot/ti-k3-image-gen/Config.in b/boot/ti-k3-image-gen/Config.in
> > index d76cef82e911..38d1598d9fc0 100644
> > --- a/boot/ti-k3-image-gen/Config.in
> > +++ b/boot/ti-k3-image-gen/Config.in
> > @@ -2,6 +2,7 @@ config BR2_TARGET_TI_K3_IMAGE_GEN
> >  	bool "ti-k3-image-gen"
> >  	depends on BR2_TARGET_TI_K3_R5_LOADER
> >  	select BR2_TARGET_TI_K3_BOOT_FIRMWARE
> > +	select BR2_TARGET_TI_K3_CORE_SECDEV if BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS_FS || BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS
> >  	# We need FIT support in uboot-tools, which is why we select a
> >  	# host package
> >  	select BR2_PACKAGE_HOST_UBOOT_TOOLS
> > diff --git a/boot/ti-k3-image-gen/ti-k3-image-gen.mk b/boot/ti-k3-image-gen/ti-k3-image-gen.mk
> > index 64be9a18f2c4..74b4fcb4bf89 100644
> > --- a/boot/ti-k3-image-gen/ti-k3-image-gen.mk
> > +++ b/boot/ti-k3-image-gen/ti-k3-image-gen.mk
> > @@ -29,10 +29,21 @@ TI_K3_IMAGE_GEN_FW_TYPE = $(call qstrip,$(BR2_TARGET_TI_K3_IMAGE_GEN_FW_TYPE))
> >  TI_K3_IMAGE_GEN_SOC = $(call qstrip,$(BR2_TARGET_TI_K3_IMAGE_GEN_SOC))
> >  TI_K3_IMAGE_GEN_SECTYPE = $(call qstrip,$(BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE))
> >  
> > -TI_K3_IMAGE_GEN_SYSFW = $(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE).bin
> > +ifeq ($(BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_GP),y)
> > +TI_K3_IMAGE_GEN_SYSFW = \
> > +	$(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE).bin
> > +else
> > +TI_K3_IMAGE_GEN_DEPENDENCIES += ti-k3-core-secdev
> > +
> > +TI_K3_IMAGE_GEN_SYSFW = \
> > +	$(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE)-enc.bin \
> > +	$(TI_K3_IMAGE_GEN_FW_TYPE)-firmware-$(TI_K3_IMAGE_GEN_SOC)-$(TI_K3_IMAGE_GEN_SECTYPE)-cert.bin
> > +endif
> >  
> >  define TI_K3_IMAGE_GEN_CONFIGURE_CMDS
> > -	cp $(BINARIES_DIR)/ti-sysfw/$(TI_K3_IMAGE_GEN_SYSFW) $(@D)
> > +	$(foreach t,$(TI_K3_IMAGE_GEN_SYSFW),\
> > +		cp $(BINARIES_DIR)/ti-sysfw/$(t) $(@D)/
> > +	)
> >  endef
> >  
> >  define TI_K3_IMAGE_GEN_BUILD_CMDS
> > @@ -40,6 +51,7 @@ define TI_K3_IMAGE_GEN_BUILD_CMDS
> >  	$(BR2_MAKE) -C $(@D) \
> >  		SOC=$(TI_K3_IMAGE_GEN_SOC) \
> >  		SOC_TYPE=$(TI_K3_IMAGE_GEN_SECTYPE) \
> > +		TI_SECURE_DEV_PKG=$(BINARIES_DIR)/ti-k3-core-secdev \
> >  		CONFIG=evm \
> >  		CROSS_COMPILE=$(HOST_DIR)/bin/arm-none-eabi- \
> >  		SBL=$(BINARIES_DIR)/r5-u-boot-spl.bin \
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot