Re: [Buildroot] [PATCH v4 01/20] configs/ti_am62x_sk_defconfig: fix BR2_TARGET_OPTEE_OS_PLATFORM setting

From: Romain Naour <romain.naour@smile.fr>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	buildroot@buildroot.org
Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com,
	Asaf Kahlon <asafka7@gmail.com>,
	Xuanhao Shi <X15000177@gmail.com>,
	James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Andreas Dannenberg <dannenberg@ti.com>,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	bryce@redpinelabs.com, Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [Buildroot] [PATCH v4 01/20] configs/ti_am62x_sk_defconfig: fix BR2_TARGET_OPTEE_OS_PLATFORM setting
Date: Mon, 19 Feb 2024 10:36:56 +0100	[thread overview]
Message-ID: <6b3561ef-a245-4bb4-baa3-c41864aa8b61@smile.fr> (raw)
In-Reply-To: <20240217160244.1320482-2-dario.binacchi@amarulasolutions.com>

Hello Dario,

Le 17/02/2024 à 17:02, Dario Binacchi a écrit :
> Checking the output of the command `git grep PLATFORM | grep k3`, we can
> found the proper settings for the optee-os package:
> 
> .github/workflows/ci.yml:          _make PLATFORM=k3-am62x
> .github/workflows/ci.yml:          _make PLATFORM=k3-am62x CFG_ARM64_core=y
> ...
> core/arch/arm/plat-k3/conf.mk:ifneq (,$(filter ${PLATFORM_FLAVOR},am65x j721e j784s4 am64x am62x))

Setting BR2_TARGET_OPTEE_OS_PLATFORM_FLAVOR doesn't seems necessary since
optee-os Makefile can extract it from BR2_TARGET_OPTEE_OS_PLATFORM [1].

[1]
https://git.yoctoproject.org/meta-ti/commit/?id=912983dd562ba5f009a4db34e8abe3810c8ed7ac

Best regards,
Romain

> 
> Suggested-by: Romain Naour <romain.naour@smile.fr>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
> Added in v4
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>  configs/ti_am62x_sk_defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/ti_am62x_sk_defconfig b/configs/ti_am62x_sk_defconfig
> index f88252a89c68..fde6f8f5636a 100644
> --- a/configs/ti_am62x_sk_defconfig
> +++ b/configs/ti_am62x_sk_defconfig
> @@ -21,7 +21,8 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="k3"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_TARGET_BOARD="lite"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
>  BR2_TARGET_OPTEE_OS=y
> -BR2_TARGET_OPTEE_OS_PLATFORM="k3"
> +BR2_TARGET_OPTEE_OS_PLATFORM="k3-am62x"
> +BR2_TARGET_OPTEE_OS_PLATFORM_FLAVOR="am62x"
>  BR2_TARGET_TI_K3_IMAGE_GEN=y
>  BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM62X=y
>  BR2_TARGET_TI_K3_R5_LOADER=y

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot