Re: [Buildroot] [PATCH v4 00/20] Add support for AM62x-SK HS-FS devices

From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	 buildroot@buildroot.org
Cc: michael@amarulasolutions.com, Asaf Kahlon <asafka7@gmail.com>,
	Xuanhao Shi <X15000177@gmail.com>,
	James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Romain Naour <romain.naour@smile.fr>,
	Andreas Dannenberg <dannenberg@ti.com>,
	linux-amarula@amarulasolutions.com, bryce@redpinelabs.com,
	Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [Buildroot] [PATCH v4 00/20] Add support for AM62x-SK HS-FS devices
Date: Sat, 17 Feb 2024 18:40:33 +0100	[thread overview]
Message-ID: <4a8d7f2252b46118554a9e22c49901822e461f2f.camel@gmail.com> (raw)
In-Reply-To: <20240217160244.1320482-1-dario.binacchi@amarulasolutions.com>

Hi Dario!

On Sat, 2024-02-17 at 17:02 +0100, Dario Binacchi wrote:
> This series, which in my humble opinion, should have been immediately
> considered to correct the compilation errors in case of HS-FS devcies, has
> seen an increase in patches in version 4 to remove the ti-k3-image-gen

I wasn't aware of the preceeding versions, but...

> package thanks to Binman. Additionally, it shares some modifications and
> views on how to implement certain changes with the series
> https://patchwork.ozlabs.org/project/buildroot/list/?series=394840.
> Therefore, I think it is necessary not to run them in parallel but to decide
> whether to merge one before the other or to consider a single series where
> the patches can be coherent with each other. I am available for both solutions.
> Let me know.

... as the broken HS-FS went unnoticed, seems there is no rush to fix the
build now? I'd vote for a combined series, because yours and Romains do
overlap here and there, but I personally would pick different parts from
different series. I'd not introduce secdev package unless absolutely
necessary, and I actually build HS-FS images with yocto with custom keys
and using upstream U-Boot binman alone, so maybe I miss something, but
I don't see the package as required.

From my side I can offer testing on SK-AM62x variants, both GP and HS-FS.
I will definitely test your v4 because in contrast to Romain's U-Boot
v2024.01 bump yours may actually boot...

-- 
Alexander Sverdlin.

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot