Re: [Buildroot] [PATCH v4 00/20] Add support for AM62x-SK HS-FS devices

From: Patrick Oppenlander <patrick.oppenlander@gmail.com>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: michael@amarulasolutions.com, Anand Gadiyar <gadiyar@ti.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	Xuanhao Shi <X15000177@gmail.com>,
	James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@smile.fr>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	linux-amarula@amarulasolutions.com, bryce@redpinelabs.com,
	Andreas Dannenberg <dannenberg@ti.com>
Subject: Re: [Buildroot] [PATCH v4 00/20] Add support for AM62x-SK HS-FS devices
Date: Tue, 20 Feb 2024 09:42:07 +1100	[thread overview]
Message-ID: <CAEg67G=H7smzSZ65BcZT4qxE6kwUEb8d=xBROXHz76mXaLKXVA@mail.gmail.com> (raw)
In-Reply-To: <4a8d7f2252b46118554a9e22c49901822e461f2f.camel@gmail.com>

On Sun, 18 Feb 2024 at 04:40, Alexander Sverdlin
<alexander.sverdlin@gmail.com> wrote:
>
> Hi Dario!
>
> On Sat, 2024-02-17 at 17:02 +0100, Dario Binacchi wrote:
> > This series, which in my humble opinion, should have been immediately
> > considered to correct the compilation errors in case of HS-FS devcies, has
> > seen an increase in patches in version 4 to remove the ti-k3-image-gen
>
> I wasn't aware of the preceeding versions, but...
>
> > package thanks to Binman. Additionally, it shares some modifications and
> > views on how to implement certain changes with the series
> > https://patchwork.ozlabs.org/project/buildroot/list/?series=394840.
> > Therefore, I think it is necessary not to run them in parallel but to decide
> > whether to merge one before the other or to consider a single series where
> > the patches can be coherent with each other. I am available for both solutions.
> > Let me know.
>
> ... as the broken HS-FS went unnoticed, seems there is no rush to fix the
> build now?

I noticed, and hacked in some am64x specific fixes here:
https://github.com/relectrify/buildroot/commits/2023.11.1_relectrify.

I was going to submit a cleaned up version of the patches, but I got
distracted by fixing encrypted boot (see below) and never got back to
cleaning them up. Sorry about that.

Apparently TI don't support encrypted boot in their Linux SDK (yet?),
only in the MCU SDK. There's a python script in the MCU SDK
(rom_image_gen.py) which kinda works once you teach it how to read
ascii keys as generated by the keywriter package. Except, it changes
the size of the plaintext because it aligns it to 16-bytes and appends
32 random bytes, which causes a boot failure somewhere early on in
U-Boot. I hacked around that by sticking the original binary size into
some of those random bytes (it's not part of the X509 cert..) and
teaching U-Boot to detect the encrypted image
(https://github.com/relectrify/u-boot/commit/d16b4705ffebb0881633dfd5300bf4ac8490e75c)
and doing a fixup. Once you do that, and change all the right places
to run rom_image_gen.py it works, but it's pretty painful to get
there.

Hopefully this situation is a bit better in the binman version.

Patrick
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot