Re: [Buildroot] [PATCH v4 06/20] boot/ti-k3-core-secdev: new package

From: Romain Naour <romain.naour@smile.fr>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	buildroot@buildroot.org
Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com,
	Asaf Kahlon <asafka7@gmail.com>,
	Xuanhao Shi <X15000177@gmail.com>,
	James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Andreas Dannenberg <dannenberg@ti.com>,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	bryce@redpinelabs.com, Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [Buildroot] [PATCH v4 06/20] boot/ti-k3-core-secdev: new package
Date: Mon, 19 Feb 2024 10:48:59 +0100	[thread overview]
Message-ID: <5f007c47-0c4c-438b-8978-4fe6e2515db1@smile.fr> (raw)
In-Reply-To: <20240217160244.1320482-7-dario.binacchi@amarulasolutions.com>

Hello Dario,

Le 17/02/2024 à 17:02, Dario Binacchi a écrit :
> This is a security development package containing tools for
> High-Security(HS) TI K3 platform devices.

Note: this tool can also handle TI "legacy" platform such AM57xx or AM43xx (not
sure we really want do that).

Can you try without this package when using binman?
This tool doesn't seems "future proof".

http://lists.busybox.net/pipermail/buildroot/2024-February/685820.html

Best regards,
Romain

> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> 
> Changes in v4:
> - Remove the trailing '/' at the end of the url in the help of
>   Config.in
> - Fixed license issues
> - Use $(BINARIES_DIR)/ti-k3-core-secdev as the directory where to
>   install files.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>  DEVELOPERS                                    |  1 +
>  boot/Config.in                                |  1 +
>  boot/ti-k3-core-secdev/Config.in              |  9 ++++++++
>  boot/ti-k3-core-secdev/ti-k3-core-secdev.hash |  3 +++
>  boot/ti-k3-core-secdev/ti-k3-core-secdev.mk   | 22 +++++++++++++++++++
>  5 files changed, 36 insertions(+)
>  create mode 100644 boot/ti-k3-core-secdev/Config.in
>  create mode 100644 boot/ti-k3-core-secdev/ti-k3-core-secdev.hash
>  create mode 100644 boot/ti-k3-core-secdev/ti-k3-core-secdev.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 0d12c3abcb11..33d99ab2440f 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -753,6 +753,7 @@ F:	package/xinetd/
>  N:	Dario Binacchi <dario.binacchi@amarulasolutions.com>
>  F:	board/bsh/
>  F:	board/stmicroelectronics/stm32f769-disco/
> +F:	boot/ti-k3-core-secdev/
>  F:	configs/imx8mn_bsh_smm_s2_defconfig
>  F:	configs/imx8mn_bsh_smm_s2_pro_defconfig
>  F:	configs/stm32f769_disco_sd_defconfig
> diff --git a/boot/Config.in b/boot/Config.in
> index e5fdf7ad439e..18a7d268f95a 100644
> --- a/boot/Config.in
> +++ b/boot/Config.in
> @@ -20,6 +20,7 @@ source "boot/s500-bootloader/Config.in"
>  source "boot/shim/Config.in"
>  source "boot/syslinux/Config.in"
>  source "boot/ti-k3-boot-firmware/Config.in"
> +source "boot/ti-k3-core-secdev/Config.in"
>  source "boot/ti-k3-image-gen/Config.in"
>  source "boot/ti-k3-r5-loader/Config.in"
>  source "boot/uboot/Config.in"
> diff --git a/boot/ti-k3-core-secdev/Config.in b/boot/ti-k3-core-secdev/Config.in
> new file mode 100644
> index 000000000000..f7b4e2962042
> --- /dev/null
> +++ b/boot/ti-k3-core-secdev/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_TARGET_TI_K3_CORE_SECDEV
> +	bool "ti-k3-core-secdev"
> +	depends on BR2_aarch64
> +	help
> +	  This package downloads and installs development tools for
> +	  High-Security(HS) TI K3 platforms (which include AM62x,
> +	  AM64x, AM65x and more).
> +
> +	  https://git.ti.com/cgit/security-development-tools/core-secdev-k3
> diff --git a/boot/ti-k3-core-secdev/ti-k3-core-secdev.hash b/boot/ti-k3-core-secdev/ti-k3-core-secdev.hash
> new file mode 100644
> index 000000000000..e3074a398d62
> --- /dev/null
> +++ b/boot/ti-k3-core-secdev/ti-k3-core-secdev.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  b6d3bca0d561d055c6869c5564b06f2fb1b9f67e4ef180c2baf8a14a6a6afa06  core-secdev-k3-08.06.00.007.tar.xz
> +sha256  3e5cf4f5ab9f0333f46cd68fabede3f21e55de1a9e3c6ad673f241f4514d8369  manifest/k3-secdev-0.2-manifest.html
> diff --git a/boot/ti-k3-core-secdev/ti-k3-core-secdev.mk b/boot/ti-k3-core-secdev/ti-k3-core-secdev.mk
> new file mode 100644
> index 000000000000..f7655a0fefc8
> --- /dev/null
> +++ b/boot/ti-k3-core-secdev/ti-k3-core-secdev.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# ti-k3-core-secdev
> +#
> +################################################################################
> +
> +TI_K3_CORE_SECDEV_VERSION = 08.06.00.007
> +TI_K3_CORE_SECDEV_SITE = https://git.ti.com/cgit/security-development-tools/core-secdev-k3/snapshot
> +TI_K3_CORE_SECDEV_SOURCE = core-secdev-k3-$(TI_K3_CORE_SECDEV_VERSION).tar.xz
> +TI_K3_CORE_SECDEV_INSTALL_IMAGES = YES
> +TI_K3_CORE_SECDEV_LICENSE = BSD-3-Clause
> +TI_K3_CORE_SECDEV_LICENSE_FILES = manifest/k3-secdev-0.2-manifest.html
> +
> +TI_K3_CORE_SECDEV_INSTALL_DIR = $(BINARIES_DIR)/ti-k3-core-secdev
> +
> +define TI_K3_CORE_SECDEV_INSTALL_IMAGES_CMDS
> +	mkdir -p $(TI_K3_CORE_SECDEV_INSTALL_DIR)
> +	cp -dpfr $(@D)/keys $(TI_K3_CORE_SECDEV_INSTALL_DIR)/
> +	cp -dpfr $(@D)/scripts $(TI_K3_CORE_SECDEV_INSTALL_DIR)/
> +endef
> +
> +$(eval $(generic-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot