From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: "David Laight" <David.Laight@ACULAB.COM>, "'Christian König'" <christian.koenig@amd.com>, "Lucas Stach" <l.stach@pengutronix.de>, "Simon Ser" <contact@emersion.fr> Cc: "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>, linux-media <linux-media@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Sharma, Shashank" <Shashank.Sharma@amd.com> Subject: Re: [Linaro-mm-sig] DMA-buf and uncached system memory Date: Mon, 15 Feb 2021 15:54:43 +0100 [thread overview] Message-ID: <33ffa837-a88a-db1c-7861-c70d67557665@gmail.com> (raw) In-Reply-To: <fa3f6eefc0a940b38448b0efd4b3f4e3@AcuMS.aculab.com> Am 15.02.21 um 15:41 schrieb David Laight: > From: Christian König >> Sent: 15 February 2021 12:05 > ... >> Snooping the CPU caches introduces some extra latency, so what can >> happen is that the response to the PCIe read comes to late for the >> scanout. The result is an underflow and flickering whenever something is >> in the cache which needs to be flushed first. > Aren't you going to get the same problem if any other endpoints are > doing memory reads? The PCIe device in this case is part of the SoC, so we have a high priority channel to memory. Because of this the hardware designer assumed they have a guaranteed memory latency. > Possibly even ones that don't require a cache snoop and flush. > > What about just the cpu doing a real memory transfer? > > Or a combination of the two above happening just before your request. > > If you don't have a big enough fifo you'll lose. > > I did 'fix' a similar(ish) issue with video DMA latency on an embedded > system based the on SA1100/SA1101 by significantly reducing the clock > to the VGA panel whenever the cpu was doing 'slow io'. > (Interleaving an uncached cpu DRAM write between the slow io cycles > also fixed it.) > But the video was the only DMA device and that was an embedded system. > Given the application note about video latency didn't mention what was > actually happening, I'm not sure how many people actually got it working! Yeah, I'm also not sure if AMD doesn't solve this with deeper fifos or more prefetching in future designs. But you gave me at least one example where somebody had similar problems. Thanks for the feedback, Christian. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > _______________________________________________ > Linaro-mm-sig mailing list > Linaro-mm-sig@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-mm-sig
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: "David Laight" <David.Laight@ACULAB.COM>, "'Christian König'" <christian.koenig@amd.com>, "Lucas Stach" <l.stach@pengutronix.de>, "Simon Ser" <contact@emersion.fr> Cc: "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>, "Sharma, Shashank" <Shashank.Sharma@amd.com>, lkml <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-media <linux-media@vger.kernel.org> Subject: Re: [Linaro-mm-sig] DMA-buf and uncached system memory Date: Mon, 15 Feb 2021 15:54:43 +0100 [thread overview] Message-ID: <33ffa837-a88a-db1c-7861-c70d67557665@gmail.com> (raw) In-Reply-To: <fa3f6eefc0a940b38448b0efd4b3f4e3@AcuMS.aculab.com> Am 15.02.21 um 15:41 schrieb David Laight: > From: Christian König >> Sent: 15 February 2021 12:05 > ... >> Snooping the CPU caches introduces some extra latency, so what can >> happen is that the response to the PCIe read comes to late for the >> scanout. The result is an underflow and flickering whenever something is >> in the cache which needs to be flushed first. > Aren't you going to get the same problem if any other endpoints are > doing memory reads? The PCIe device in this case is part of the SoC, so we have a high priority channel to memory. Because of this the hardware designer assumed they have a guaranteed memory latency. > Possibly even ones that don't require a cache snoop and flush. > > What about just the cpu doing a real memory transfer? > > Or a combination of the two above happening just before your request. > > If you don't have a big enough fifo you'll lose. > > I did 'fix' a similar(ish) issue with video DMA latency on an embedded > system based the on SA1100/SA1101 by significantly reducing the clock > to the VGA panel whenever the cpu was doing 'slow io'. > (Interleaving an uncached cpu DRAM write between the slow io cycles > also fixed it.) > But the video was the only DMA device and that was an embedded system. > Given the application note about video latency didn't mention what was > actually happening, I'm not sure how many people actually got it working! Yeah, I'm also not sure if AMD doesn't solve this with deeper fifos or more prefetching in future designs. But you gave me at least one example where somebody had similar problems. Thanks for the feedback, Christian. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > _______________________________________________ > Linaro-mm-sig mailing list > Linaro-mm-sig@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-mm-sig _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-15 14:55 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-15 8:58 DMA-buf and uncached system memory Christian König 2021-02-15 8:58 ` Christian König 2021-02-15 9:06 ` Simon Ser 2021-02-15 9:06 ` Simon Ser 2021-02-15 9:34 ` Christian König 2021-02-15 9:34 ` Christian König 2021-02-15 11:53 ` Lucas Stach 2021-02-15 11:53 ` Lucas Stach 2021-02-15 12:04 ` Christian König 2021-02-15 12:04 ` Christian König 2021-02-15 12:16 ` Lucas Stach 2021-02-15 12:16 ` Lucas Stach 2021-02-15 12:25 ` Christian König 2021-02-15 12:25 ` Christian König 2021-02-15 14:41 ` David Laight 2021-02-15 14:41 ` David Laight 2021-02-15 14:54 ` Christian König [this message] 2021-02-15 14:54 ` [Linaro-mm-sig] " Christian König 2021-02-15 9:49 ` Thomas Zimmermann 2021-02-15 9:49 ` Thomas Zimmermann 2021-02-15 12:00 ` Thomas Zimmermann 2021-02-15 12:00 ` Thomas Zimmermann 2021-02-15 12:10 ` Christian König 2021-02-15 12:10 ` Christian König 2021-02-15 20:46 ` Nicolas Dufresne 2021-02-15 20:46 ` Nicolas Dufresne 2021-02-15 20:39 ` Nicolas Dufresne 2021-02-15 20:39 ` Nicolas Dufresne 2022-06-21 10:17 ` Andy.Hsieh 2022-06-21 10:34 ` Christian König 2022-06-21 15:42 ` Nicolas Dufresne 2022-06-21 15:42 ` Nicolas Dufresne 2022-06-22 9:05 ` [Linaro-mm-sig] " Christian König 2022-06-22 9:05 ` Christian König 2021-02-16 9:25 ` Daniel Vetter 2021-02-16 9:25 ` Daniel Vetter 2022-06-22 19:39 ` Nicolas Dufresne 2022-06-22 19:39 ` Nicolas Dufresne 2022-06-22 23:34 ` Daniel Stone 2022-06-22 23:34 ` Daniel Stone 2022-06-23 6:59 ` Christian König 2022-06-23 6:59 ` Christian König 2022-06-23 7:13 ` Pekka Paalanen 2022-06-23 7:13 ` Pekka Paalanen 2022-06-23 7:26 ` Christian König 2022-06-23 7:26 ` Christian König 2022-06-23 8:04 ` Lucas Stach 2022-06-23 8:14 ` Christian König 2022-06-23 8:58 ` Lucas Stach 2022-06-23 9:09 ` Christian König 2022-06-23 9:33 ` Lucas Stach 2022-06-23 9:46 ` Christian König 2022-06-23 10:13 ` Lucas Stach 2022-06-23 11:10 ` Christian König 2022-06-23 11:27 ` Daniel Stone 2022-06-23 11:27 ` Daniel Stone 2022-06-23 11:32 ` Christian König 2022-06-23 11:32 ` Christian König 2022-06-24 22:02 ` [Linaro-mm-sig] " Daniel Vetter 2022-06-24 22:02 ` Daniel Vetter 2022-07-04 13:48 ` Christian König 2022-08-09 14:46 ` Daniel Vetter 2022-08-09 14:46 ` Daniel Vetter 2022-08-10 5:55 ` Christian König 2022-06-23 11:29 ` Lucas Stach 2022-06-23 11:54 ` Christian König 2022-06-23 12:14 ` Lucas Stach 2022-06-23 12:52 ` Christian König 2022-06-23 15:26 ` Lucas Stach 2022-06-24 6:54 ` Christian König 2022-06-24 8:10 ` Lucas Stach 2022-06-27 13:54 ` Nicolas Dufresne 2022-06-27 14:06 ` Lucas Stach 2022-06-27 14:30 ` Nicolas Dufresne 2022-06-27 13:51 ` Nicolas Dufresne 2022-06-23 8:13 ` Thomas Zimmermann 2022-06-23 8:26 ` Christian König 2022-06-23 8:42 ` Thomas Zimmermann 2022-08-09 15:01 ` Rob Clark 2022-08-09 15:01 ` Rob Clark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=33ffa837-a88a-db1c-7861-c70d67557665@gmail.com \ --to=ckoenig.leichtzumerken@gmail.com \ --cc=David.Laight@ACULAB.COM \ --cc=Shashank.Sharma@amd.com \ --cc=christian.koenig@amd.com \ --cc=contact@emersion.fr \ --cc=dri-devel@lists.freedesktop.org \ --cc=l.stach@pengutronix.de \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.