From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Eduardo Valentin <eduardo.valentin@ti.com> Cc: devicetree-discuss@lists.ozlabs.org, wni@nvidia.com, l.stach@pengutronix.de, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, lm-sensors@lm-sensors.org, Viresh Kumar <viresh.kumar@linaro.org>, Grant Likely <grant.likely@linaro.org>, Rob Herring <rob.herring@calxeda.com>, cpufreq@vger.kernel.org Subject: Re: [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Date: Fri, 26 Jul 2013 01:28:36 +0200 [thread overview] Message-ID: <36180776.zbN9qNcjis@vostro.rjw.lan> (raw) In-Reply-To: <1374074248-31690-2-git-send-email-eduardo.valentin@ti.com> On Wednesday, July 17, 2013 11:17:20 AM Eduardo Valentin wrote: > This patch changes the cpufreq-cpu0 driver to consider if > a cpu needs cooling (with cpufreq). In case the cooling is needed, > it can be flagged at the cpu0 device tree node, with the boolean > property 'needs-cooling'. > > In case this boolean is present, the driver will > load a cpufreq cooling device in the system. The cpufreq-cpu0 > driver is not interested in determining how the system should > be using the cooling device. The driver is responsible > only of loading the cooling device. > > Describing how the cooling device will be used can be > accomplished by setting up a thermal zone that references > and is composed by the cpufreq cooling device. > > Cc: "Rafael J. Wysocki" <rjw@sisk.pl> FWIW, this change is fine by me, but I guess it should be handled along with the entire series. > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Grant Likely <grant.likely@linaro.org> > Cc: Rob Herring <rob.herring@calxeda.com> > Cc: cpufreq@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: devicetree-discuss@lists.ozlabs.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 3 +++ > drivers/cpufreq/cpufreq-cpu0.c | 8 ++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt > index 051f764..e8ff916 100644 > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt > @@ -15,6 +15,8 @@ Optional properties: > - clock-latency: Specify the possible maximum transition latency for clock, > in unit of nanoseconds. > - voltage-tolerance: Specify the CPU voltage tolerance in percentage. > +- needs-cooling: The generic cpu cooling (freq clipping) is loaded by the > +generic cpufreq-cpu0 driver in case the device tree node has this boolean. > > Examples: > > @@ -33,6 +35,7 @@ cpus { > 198000 850000 > >; > clock-latency = <61036>; /* two CLK32 periods */ > + needs-cooling; > }; > > cpu@1 { > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index ad1fde2..4a8747a 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -20,6 +20,9 @@ > #include <linux/platform_device.h> > #include <linux/regulator/consumer.h> > #include <linux/slab.h> > +#include <linux/thermal.h> > +#include <linux/cpu_cooling.h> > +#include <linux/cpumask.h> > > static unsigned int transition_latency; > static unsigned int voltage_tolerance; /* in percentage */ > @@ -28,6 +31,7 @@ static struct device *cpu_dev; > static struct clk *cpu_clk; > static struct regulator *cpu_reg; > static struct cpufreq_frequency_table *freq_table; > +static struct thermal_cooling_device *cdev; > > static int cpu0_verify_speed(struct cpufreq_policy *policy) > { > @@ -268,6 +272,9 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) > goto out_free_table; > } > > + if (of_property_read_bool(np, "needs-cooling")) > + cdev = cpufreq_cooling_register(cpu_present_mask); > + > of_node_put(np); > of_node_put(parent); > return 0; > @@ -283,6 +290,7 @@ out_put_parent: > > static int cpu0_cpufreq_remove(struct platform_device *pdev) > { > + cpufreq_cooling_unregister(cdev); > cpufreq_unregister_driver(&cpu0_cpufreq_driver); > opp_free_cpufreq_table(cpu_dev, &freq_table); > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Eduardo Valentin <eduardo.valentin@ti.com> Cc: devicetree-discuss@lists.ozlabs.org, wni@nvidia.com, l.stach@pengutronix.de, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, lm-sensors@lm-sensors.org, Viresh Kumar <viresh.kumar@linaro.org>, Grant Likely <grant.likely@linaro.org>, Rob Herring <rob.herring@calxeda.com>, cpufreq@vger.kernel.org Subject: Re: [lm-sensors] [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling Date: Thu, 25 Jul 2013 23:28:36 +0000 [thread overview] Message-ID: <36180776.zbN9qNcjis@vostro.rjw.lan> (raw) In-Reply-To: <1374074248-31690-2-git-send-email-eduardo.valentin@ti.com> On Wednesday, July 17, 2013 11:17:20 AM Eduardo Valentin wrote: > This patch changes the cpufreq-cpu0 driver to consider if > a cpu needs cooling (with cpufreq). In case the cooling is needed, > it can be flagged at the cpu0 device tree node, with the boolean > property 'needs-cooling'. > > In case this boolean is present, the driver will > load a cpufreq cooling device in the system. The cpufreq-cpu0 > driver is not interested in determining how the system should > be using the cooling device. The driver is responsible > only of loading the cooling device. > > Describing how the cooling device will be used can be > accomplished by setting up a thermal zone that references > and is composed by the cpufreq cooling device. > > Cc: "Rafael J. Wysocki" <rjw@sisk.pl> FWIW, this change is fine by me, but I guess it should be handled along with the entire series. > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Grant Likely <grant.likely@linaro.org> > Cc: Rob Herring <rob.herring@calxeda.com> > Cc: cpufreq@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: devicetree-discuss@lists.ozlabs.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 3 +++ > drivers/cpufreq/cpufreq-cpu0.c | 8 ++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt > index 051f764..e8ff916 100644 > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-cpu0.txt > @@ -15,6 +15,8 @@ Optional properties: > - clock-latency: Specify the possible maximum transition latency for clock, > in unit of nanoseconds. > - voltage-tolerance: Specify the CPU voltage tolerance in percentage. > +- needs-cooling: The generic cpu cooling (freq clipping) is loaded by the > +generic cpufreq-cpu0 driver in case the device tree node has this boolean. > > Examples: > > @@ -33,6 +35,7 @@ cpus { > 198000 850000 > >; > clock-latency = <61036>; /* two CLK32 periods */ > + needs-cooling; > }; > > cpu@1 { > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index ad1fde2..4a8747a 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -20,6 +20,9 @@ > #include <linux/platform_device.h> > #include <linux/regulator/consumer.h> > #include <linux/slab.h> > +#include <linux/thermal.h> > +#include <linux/cpu_cooling.h> > +#include <linux/cpumask.h> > > static unsigned int transition_latency; > static unsigned int voltage_tolerance; /* in percentage */ > @@ -28,6 +31,7 @@ static struct device *cpu_dev; > static struct clk *cpu_clk; > static struct regulator *cpu_reg; > static struct cpufreq_frequency_table *freq_table; > +static struct thermal_cooling_device *cdev; > > static int cpu0_verify_speed(struct cpufreq_policy *policy) > { > @@ -268,6 +272,9 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) > goto out_free_table; > } > > + if (of_property_read_bool(np, "needs-cooling")) > + cdev = cpufreq_cooling_register(cpu_present_mask); > + > of_node_put(np); > of_node_put(parent); > return 0; > @@ -283,6 +290,7 @@ out_put_parent: > > static int cpu0_cpufreq_remove(struct platform_device *pdev) > { > + cpufreq_cooling_unregister(cdev); > cpufreq_unregister_driver(&cpu0_cpufreq_driver); > opp_free_cpufreq_table(cpu_dev, &freq_table); > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-07-25 23:18 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-17 15:17 [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-25 23:28 ` Rafael J. Wysocki [this message] 2013-07-25 23:28 ` [lm-sensors] [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling Rafael J. Wysocki 2013-07-26 13:27 ` [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Eduardo Valentin 2013-07-26 13:27 ` [lm-sensors] [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling Eduardo Valentin 2013-07-26 13:27 ` [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 2/9] thermal: hwmon: move hwmon support to single file Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 16:29 ` [lm-sensors] " R, Durgadoss 2013-07-17 16:29 ` R, Durgadoss 2013-07-17 16:29 ` R, Durgadoss 2013-07-17 15:17 ` [RESEND PATCH V1 3/9] thermal: thermal_core: allow binding with limits on bind_params Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 16:25 ` [lm-sensors] " R, Durgadoss 2013-07-17 16:25 ` [lm-sensors] [RESEND PATCH V1 3/9] thermal: thermal_core: allow binding with limits on bind_para R, Durgadoss 2013-07-17 16:25 ` [lm-sensors] [RESEND PATCH V1 3/9] thermal: thermal_core: allow binding with limits on bind_params R, Durgadoss 2013-07-17 15:17 ` [RESEND PATCH V1 4/9] arm: dts: flag omap4430 with needs-cooling for cpu node Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 5/9] thermal: introduce device tree parser Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 6/9] thermal: ti-soc-thermal: use thermal DT infrastructure Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 7/9] arm: dts: add omap4430 thermal data Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 8/9] hwmon: lm75: expose to thermal fw via DT nodes Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-18 5:33 ` Wei Ni 2013-07-18 5:33 ` [lm-sensors] " Wei Ni 2013-07-18 5:33 ` Wei Ni 2013-07-18 13:12 ` Eduardo Valentin 2013-07-18 13:12 ` [lm-sensors] " Eduardo Valentin 2013-07-18 13:12 ` Eduardo Valentin 2013-07-19 7:43 ` Wei Ni 2013-07-19 7:43 ` [lm-sensors] " Wei Ni 2013-07-19 7:43 ` Wei Ni 2013-07-18 7:22 ` Guenter Roeck 2013-07-18 7:22 ` [lm-sensors] " Guenter Roeck 2013-07-17 15:17 ` [RESEND PATCH V1 9/9] hwmon: tmp102: " Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-18 7:23 ` Guenter Roeck 2013-07-18 7:23 ` [lm-sensors] " Guenter Roeck 2013-07-17 22:09 ` [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build Guenter Roeck 2013-07-17 22:09 ` Guenter Roeck 2013-07-18 13:53 ` Eduardo Valentin 2013-07-18 13:53 ` Eduardo Valentin 2013-07-18 13:53 ` Eduardo Valentin 2013-07-18 17:18 ` Stephen Warren 2013-07-18 17:18 ` Stephen Warren 2013-07-18 21:21 ` Guenter Roeck 2013-07-18 21:21 ` Guenter Roeck 2013-07-19 13:03 ` Eduardo Valentin 2013-07-19 13:03 ` Eduardo Valentin 2013-07-19 13:03 ` Eduardo Valentin 2013-07-19 18:48 ` Stephen Warren 2013-07-19 18:48 ` Stephen Warren 2013-07-21 11:08 ` Guenter Roeck 2013-07-21 11:08 ` Guenter Roeck 2013-07-21 11:08 ` Guenter Roeck 2013-07-22 19:43 ` Stephen Warren 2013-07-22 19:43 ` Stephen Warren 2013-07-22 21:46 ` Guenter Roeck 2013-07-22 21:46 ` Guenter Roeck 2013-07-18 21:11 ` Guenter Roeck 2013-07-18 21:11 ` Guenter Roeck 2013-07-18 21:11 ` Guenter Roeck 2013-07-19 13:38 ` Eduardo Valentin 2013-07-19 13:38 ` Eduardo Valentin 2013-07-19 13:38 ` Eduardo Valentin 2013-07-19 18:45 ` Stephen Warren 2013-07-19 18:45 ` Stephen Warren 2013-07-19 18:45 ` Stephen Warren 2013-07-19 18:56 ` Eduardo Valentin 2013-07-19 18:56 ` Eduardo Valentin 2013-07-19 18:56 ` Eduardo Valentin 2013-07-21 10:14 ` Guenter Roeck 2013-07-21 10:14 ` Guenter Roeck 2013-07-21 10:14 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=36180776.zbN9qNcjis@vostro.rjw.lan \ --to=rjw@sisk.pl \ --cc=cpufreq@vger.kernel.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=eduardo.valentin@ti.com \ --cc=grant.likely@linaro.org \ --cc=l.stach@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lm-sensors@lm-sensors.org \ --cc=rob.herring@calxeda.com \ --cc=viresh.kumar@linaro.org \ --cc=wni@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.