* [PATCH 0/1] Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures @ 2019-05-16 5:58 Harish Chegondi 2019-05-16 5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi ` (2 more replies) 0 siblings, 3 replies; 16+ messages in thread From: Harish Chegondi @ 2019-05-16 5:58 UTC (permalink / raw) To: intel-gfx; +Cc: Jani Nikula, Tomi Sarvela This patch fixes the igt@kms_pipe_crc_basic@* test failures due to CRC mismatch on CI BYT squawks chromebook as reported in: https://bugs.freedesktop.org/show_bug.cgi?id=103191 These CRC mismatch test failures happen consistently on BYT squawks chromebook These test failures happen very intermittently on shard-SKL and CML-U systems. This patch fixes these test failures on the BYT platform. The reason for these CRC test failures happening on SKL and CML-U platforms is still unknown and is being investigated. Thanks Harish. Harish Chegondi (1): drm/i915: skip the second CRC even for GEN 7 GPUs drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.21.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 5:58 [PATCH 0/1] Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Harish Chegondi @ 2019-05-16 5:58 ` Harish Chegondi 2019-05-16 8:30 ` Jani Nikula ` (2 more replies) 2019-05-16 6:33 ` ✓ Fi.CI.BAT: success for Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Patchwork 2019-05-16 7:51 ` ✓ Fi.CI.IGT: " Patchwork 2 siblings, 3 replies; 16+ messages in thread From: Harish Chegondi @ 2019-05-16 5:58 UTC (permalink / raw) To: intel-gfx; +Cc: Jani Nikula, Tomi Sarvela display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. Cc: Jani Nikula <jani.nikula@intel.com> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 233211fde0ea..3809e9f7fae2 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1775,11 +1775,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, * bonkers. So let's just wait for the next vblank and read * out the buggy result. * - * On GEN8+ sometimes the second CRC is bonkers as well, so + * On GEN7+ sometimes the second CRC is bonkers as well, so * don't trust that one either. */ if (pipe_crc->skipped <= 0 || - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { pipe_crc->skipped++; spin_unlock(&pipe_crc->lock); return; -- 2.21.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi @ 2019-05-16 8:30 ` Jani Nikula 2019-05-16 12:46 ` Maarten Lankhorst 2019-10-23 7:24 ` [PATCH v2 0/1] Invalid CRCs causing CRC mismatch test failures Harish Chegondi 2 siblings, 0 replies; 16+ messages in thread From: Jani Nikula @ 2019-05-16 8:30 UTC (permalink / raw) To: Harish Chegondi, intel-gfx; +Cc: Tomi Sarvela On Wed, 15 May 2019, Harish Chegondi <harish.chegondi@intel.com> wrote: > display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the > second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> > References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 s/References:/Bugzilla:/ Acked-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 233211fde0ea..3809e9f7fae2 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1775,11 +1775,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, > * bonkers. So let's just wait for the next vblank and read > * out the buggy result. > * > - * On GEN8+ sometimes the second CRC is bonkers as well, so > + * On GEN7+ sometimes the second CRC is bonkers as well, so > * don't trust that one either. > */ > if (pipe_crc->skipped <= 0 || > - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { > + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { > pipe_crc->skipped++; > spin_unlock(&pipe_crc->lock); > return; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi 2019-05-16 8:30 ` Jani Nikula @ 2019-05-16 12:46 ` Maarten Lankhorst 2019-05-16 12:55 ` Jani Nikula 2019-10-23 7:24 ` [PATCH v2 0/1] Invalid CRCs causing CRC mismatch test failures Harish Chegondi 2 siblings, 1 reply; 16+ messages in thread From: Maarten Lankhorst @ 2019-05-16 12:46 UTC (permalink / raw) To: Harish Chegondi, intel-gfx; +Cc: Jani Nikula, Tomi Sarvela Op 16-05-2019 om 07:58 schreef Harish Chegondi: > display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the > second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> > References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 233211fde0ea..3809e9f7fae2 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1775,11 +1775,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, > * bonkers. So let's just wait for the next vblank and read > * out the buggy result. > * > - * On GEN8+ sometimes the second CRC is bonkers as well, so > + * On GEN7+ sometimes the second CRC is bonkers as well, so > * don't trust that one either. > */ > if (pipe_crc->skipped <= 0 || > - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { > + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { > pipe_crc->skipped++; > spin_unlock(&pipe_crc->lock); > return; I would be interested in the results, haswell is different from VLV. Has it ever been observed on that platform? _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 12:46 ` Maarten Lankhorst @ 2019-05-16 12:55 ` Jani Nikula 2019-05-16 13:30 ` Ville Syrjälä 2019-05-16 20:52 ` Chegondi, Harish 0 siblings, 2 replies; 16+ messages in thread From: Jani Nikula @ 2019-05-16 12:55 UTC (permalink / raw) To: Maarten Lankhorst, Harish Chegondi, intel-gfx; +Cc: Tomi Sarvela On Thu, 16 May 2019, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: > Op 16-05-2019 om 07:58 schreef Harish Chegondi: >> display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the >> second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which >> is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. >> >> Cc: Jani Nikula <jani.nikula@intel.com> >> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> >> Cc: Petri Latvala <petri.latvala@intel.com> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> >> References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 >> --- >> drivers/gpu/drm/i915/i915_irq.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c >> index 233211fde0ea..3809e9f7fae2 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -1775,11 +1775,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, >> * bonkers. So let's just wait for the next vblank and read >> * out the buggy result. >> * >> - * On GEN8+ sometimes the second CRC is bonkers as well, so >> + * On GEN7+ sometimes the second CRC is bonkers as well, so >> * don't trust that one either. >> */ >> if (pipe_crc->skipped <= 0 || >> - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { >> + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { >> pipe_crc->skipped++; >> spin_unlock(&pipe_crc->lock); >> return; > > I would be interested in the results, haswell is different from > VLV. Has it ever been observed on that platform? Good point. I looked at [1] which I presumed was on VLV, but it says nothing about HSW. BR, Jani. [1] https://bugs.freedesktop.org/show_bug.cgi?id=103191#c34 > -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 12:55 ` Jani Nikula @ 2019-05-16 13:30 ` Ville Syrjälä 2019-05-16 15:46 ` Jani Nikula 2019-05-16 21:02 ` Chegondi, Harish 2019-05-16 20:52 ` Chegondi, Harish 1 sibling, 2 replies; 16+ messages in thread From: Ville Syrjälä @ 2019-05-16 13:30 UTC (permalink / raw) To: Jani Nikula; +Cc: Tomi Sarvela, intel-gfx On Thu, May 16, 2019 at 03:55:25PM +0300, Jani Nikula wrote: > On Thu, 16 May 2019, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: > > Op 16-05-2019 om 07:58 schreef Harish Chegondi: > >> display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the > >> second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which > >> is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > >> > >> Cc: Jani Nikula <jani.nikula@intel.com> > >> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > >> Cc: Petri Latvala <petri.latvala@intel.com> > >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > >> Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> > >> References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > >> --- > >> drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > >> index 233211fde0ea..3809e9f7fae2 100644 > >> --- a/drivers/gpu/drm/i915/i915_irq.c > >> +++ b/drivers/gpu/drm/i915/i915_irq.c > >> @@ -1775,11 +1775,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, > >> * bonkers. So let's just wait for the next vblank and read > >> * out the buggy result. > >> * > >> - * On GEN8+ sometimes the second CRC is bonkers as well, so > >> + * On GEN7+ sometimes the second CRC is bonkers as well, so > >> * don't trust that one either. > >> */ > >> if (pipe_crc->skipped <= 0 || > >> - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { > >> + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { > >> pipe_crc->skipped++; > >> spin_unlock(&pipe_crc->lock); > >> return; > > > > I would be interested in the results, haswell is different from > > VLV. Has it ever been observed on that platform? > > Good point. I looked at [1] which I presumed was on VLV, but it says > nothing about HSW. This whole thing is just a pile of duct tape anyway. The reason(s) for these funky crcs has never been properly analysed. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 13:30 ` Ville Syrjälä @ 2019-05-16 15:46 ` Jani Nikula 2019-05-16 21:02 ` Chegondi, Harish 1 sibling, 0 replies; 16+ messages in thread From: Jani Nikula @ 2019-05-16 15:46 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Tomi Sarvela, intel-gfx On Thu, 16 May 2019, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Thu, May 16, 2019 at 03:55:25PM +0300, Jani Nikula wrote: >> On Thu, 16 May 2019, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: >> > Op 16-05-2019 om 07:58 schreef Harish Chegondi: >> >> display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the >> >> second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which >> >> is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. >> >> >> >> Cc: Jani Nikula <jani.nikula@intel.com> >> >> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> >> >> Cc: Petri Latvala <petri.latvala@intel.com> >> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> >> >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> >> Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> >> >> References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 >> >> --- >> >> drivers/gpu/drm/i915/i915_irq.c | 4 ++-- >> >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c >> >> index 233211fde0ea..3809e9f7fae2 100644 >> >> --- a/drivers/gpu/drm/i915/i915_irq.c >> >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> >> @@ -1775,11 +1775,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, >> >> * bonkers. So let's just wait for the next vblank and read >> >> * out the buggy result. >> >> * >> >> - * On GEN8+ sometimes the second CRC is bonkers as well, so >> >> + * On GEN7+ sometimes the second CRC is bonkers as well, so >> >> * don't trust that one either. >> >> */ >> >> if (pipe_crc->skipped <= 0 || >> >> - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { >> >> + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { >> >> pipe_crc->skipped++; >> >> spin_unlock(&pipe_crc->lock); >> >> return; >> > >> > I would be interested in the results, haswell is different from >> > VLV. Has it ever been observed on that platform? >> >> Good point. I looked at [1] which I presumed was on VLV, but it says >> nothing about HSW. > > This whole thing is just a pile of duct tape anyway. The reason(s) > for these funky crcs has never been properly analysed. I don't disagree. And this is partially why I was so eager to ack the patch at hand. Another strip of duct tape does no harm when you already have so much, and we can't hold this particular issue hostage to root cause the issues. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 13:30 ` Ville Syrjälä 2019-05-16 15:46 ` Jani Nikula @ 2019-05-16 21:02 ` Chegondi, Harish 1 sibling, 0 replies; 16+ messages in thread From: Chegondi, Harish @ 2019-05-16 21:02 UTC (permalink / raw) To: ville.syrjala, Nikula, Jani; +Cc: Sarvela, Tomi P, intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2615 bytes --] On Thu, 2019-05-16 at 16:30 +0300, Ville Syrjälä wrote: > On Thu, May 16, 2019 at 03:55:25PM +0300, Jani Nikula wrote: > > On Thu, 16 May 2019, Maarten Lankhorst < > > maarten.lankhorst@linux.intel.com> wrote: > > > Op 16-05-2019 om 07:58 schreef Harish Chegondi: > > > > display_pipe_crc_irq_handler() skips the first CRC for all GPUs > > > > and the > > > > second CRC for GEN8+ GPUs. The second CRC is invalid even for > > > > BYT which > > > > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > > > > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > > > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > > > > Cc: Petri Latvala <petri.latvala@intel.com> > > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > > > > --- > > > > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/i915_irq.c > > > > b/drivers/gpu/drm/i915/i915_irq.c > > > > index 233211fde0ea..3809e9f7fae2 100644 > > > > --- a/drivers/gpu/drm/i915/i915_irq.c > > > > +++ b/drivers/gpu/drm/i915/i915_irq.c > > > > @@ -1775,11 +1775,11 @@ static void > > > > display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, > > > > * bonkers. So let's just wait for the next vblank and > > > > read > > > > * out the buggy result. > > > > * > > > > - * On GEN8+ sometimes the second CRC is bonkers as > > > > well, so > > > > + * On GEN7+ sometimes the second CRC is bonkers as > > > > well, so > > > > * don't trust that one either. > > > > */ > > > > if (pipe_crc->skipped <= 0 || > > > > - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == > > > > 1)) { > > > > + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == > > > > 1)) { > > > > pipe_crc->skipped++; > > > > spin_unlock(&pipe_crc->lock); > > > > return; > > > > > > I would be interested in the results, haswell is different from > > > VLV. Has it ever been observed on that platform? > > > > Good point. I looked at [1] which I presumed was on VLV, but it > > says > > nothing about HSW. > > This whole thing is just a pile of duct tape anyway. The reason(s) > for these funky crcs has never been properly analysed. Ville, Are the patches in your branch : git://github.com/vsyrjala/linux.git g4x_fixes_4 related to fixing these invalid CRCs ? Thanks! Harish [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3274 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-05-16 12:55 ` Jani Nikula 2019-05-16 13:30 ` Ville Syrjälä @ 2019-05-16 20:52 ` Chegondi, Harish 1 sibling, 0 replies; 16+ messages in thread From: Chegondi, Harish @ 2019-05-16 20:52 UTC (permalink / raw) To: Nikula, Jani, maarten.lankhorst, intel-gfx; +Cc: Sarvela, Tomi P [-- Attachment #1.1: Type: text/plain, Size: 2938 bytes --] On Thu, 2019-05-16 at 15:55 +0300, Jani Nikula wrote: > On Thu, 16 May 2019, Maarten Lankhorst < > maarten.lankhorst@linux.intel.com> wrote: > > Op 16-05-2019 om 07:58 schreef Harish Chegondi: > > > display_pipe_crc_irq_handler() skips the first CRC for all GPUs > > > and the > > > second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT > > > which > > > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > > > Cc: Petri Latvala <petri.latvala@intel.com> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > > > --- > > > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_irq.c > > > b/drivers/gpu/drm/i915/i915_irq.c > > > index 233211fde0ea..3809e9f7fae2 100644 > > > --- a/drivers/gpu/drm/i915/i915_irq.c > > > +++ b/drivers/gpu/drm/i915/i915_irq.c > > > @@ -1775,11 +1775,11 @@ static void > > > display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, > > > * bonkers. So let's just wait for the next vblank and read > > > * out the buggy result. > > > * > > > - * On GEN8+ sometimes the second CRC is bonkers as well, so > > > + * On GEN7+ sometimes the second CRC is bonkers as well, so > > > * don't trust that one either. > > > */ > > > if (pipe_crc->skipped <= 0 || > > > - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { > > > + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { > > > pipe_crc->skipped++; > > > spin_unlock(&pipe_crc->lock); > > > return; > > > > I would be interested in the results, haswell is different from > > VLV. Has it ever been observed on that platform? > > Good point. I looked at [1] which I presumed was on VLV, but it says > nothing about HSW. In fdo # 103191, CRC mismatch failures in igt@kms_pipe_crc_basic@* tests have not been observed on HSW. These tests have been very consistently failing on CI fi-byt-squawks system which is a chromebook, sporadically failing on CI fi-byt-clapper system which is also a chromebook. However the tests are passing on other CI BYT systems like fi-byt-n2820 and fi-byt-j1900 which are not chromebooks and the display is not eDP. I haven't seen these failures happening on other GEN7 GPUs. Instead of skipping the second CRC just for BYT, I thought it may be a better idea to skip the second CRC on all GEN7 GPUs as the current code is already skipping the second CRC on all GEN8+ GPUs. Thanks! Harish. > > BR, > Jani. > > > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=103191#c34 > > [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3274 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 0/1] Invalid CRCs causing CRC mismatch test failures 2019-05-16 5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi 2019-05-16 8:30 ` Jani Nikula 2019-05-16 12:46 ` Maarten Lankhorst @ 2019-10-23 7:24 ` Harish Chegondi 2019-10-23 7:24 ` [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi 2019-10-23 8:08 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork 2 siblings, 2 replies; 16+ messages in thread From: Harish Chegondi @ 2019-10-23 7:24 UTC (permalink / raw) To: intel-gfx Hello, The first version of this patch has been "Acked-by" but wasn't "Reviewed-by" as the patch adds another workaround on top of an already existing workaround. The patch doesn't fix the cause of invalid CRCs being generated which still needs to be investigated and fixed. I am rebasing and resending the patch to seek feedback on how to move further with this patch. Thank You Harish Chegondi (1): drm/i915: skip the second CRC even for GEN 7 GPUs drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.21.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-10-23 7:24 ` [PATCH v2 0/1] Invalid CRCs causing CRC mismatch test failures Harish Chegondi @ 2019-10-23 7:24 ` Harish Chegondi 2019-10-23 22:15 ` [Intel-gfx] " Chegondi, Harish 2019-10-23 8:08 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork 1 sibling, 1 reply; 16+ messages in thread From: Harish Chegondi @ 2019-10-23 7:24 UTC (permalink / raw) To: intel-gfx display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. v2: Rebase Cc: Jani Saarinen <jani.saarinen@intel.com> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Acked-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 572a5c37cc61..312ca9d5292a 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1565,11 +1565,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, * bonkers. So let's just wait for the next vblank and read * out the buggy result. * - * On GEN8+ sometimes the second CRC is bonkers as well, so + * On GEN7+ sometimes the second CRC is bonkers as well, so * don't trust that one either. */ if (pipe_crc->skipped <= 0 || - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { pipe_crc->skipped++; spin_unlock(&pipe_crc->lock); return; -- 2.21.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs @ 2019-10-23 22:15 ` Chegondi, Harish 0 siblings, 0 replies; 16+ messages in thread From: Chegondi, Harish @ 2019-10-23 22:15 UTC (permalink / raw) To: intel-gfx; +Cc: Sarvela, Tomi P, Nikula, Jani Hi, Even though I tried to link this patch with it's first version by specifying --in-reply-to=<message-id>, it wasn't successful. So here is the link to the first version of the patch and the discussion. https://patchwork.freedesktop.org/patch/305153/?series=60697&rev=1 The first version of this patch has been "Acked-by" but wasn't "Reviewed-by" as the patch adds another workaround on top of an already existing workaround. The patch doesn't fix the cause of invalid CRCs being generated which still needs to be investigated and fixed. I am rebasing and resending the patch to seek feedback on how to move further with this patch. Thank You Harish On Wed, 2019-10-23 at 00:24 -0700, Harish Chegondi wrote: > display_pipe_crc_irq_handler() skips the first CRC for all GPUs and > the > second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT > which > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > v2: Rebase > > Cc: Jani Saarinen <jani.saarinen@intel.com> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Acked-by: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> > References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c > b/drivers/gpu/drm/i915/i915_irq.c > index 572a5c37cc61..312ca9d5292a 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1565,11 +1565,11 @@ static void > display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, > * bonkers. So let's just wait for the next vblank and read > * out the buggy result. > * > - * On GEN8+ sometimes the second CRC is bonkers as well, so > + * On GEN7+ sometimes the second CRC is bonkers as well, so > * don't trust that one either. > */ > if (pipe_crc->skipped <= 0 || > - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { > + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { > pipe_crc->skipped++; > spin_unlock(&pipe_crc->lock); > return; _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs @ 2019-10-23 22:15 ` Chegondi, Harish 0 siblings, 0 replies; 16+ messages in thread From: Chegondi, Harish @ 2019-10-23 22:15 UTC (permalink / raw) To: intel-gfx; +Cc: Sarvela, Tomi P, Nikula, Jani Hi, Even though I tried to link this patch with it's first version by specifying --in-reply-to=<message-id>, it wasn't successful. So here is the link to the first version of the patch and the discussion. https://patchwork.freedesktop.org/patch/305153/?series=60697&rev=1 The first version of this patch has been "Acked-by" but wasn't "Reviewed-by" as the patch adds another workaround on top of an already existing workaround. The patch doesn't fix the cause of invalid CRCs being generated which still needs to be investigated and fixed. I am rebasing and resending the patch to seek feedback on how to move further with this patch. Thank You Harish On Wed, 2019-10-23 at 00:24 -0700, Harish Chegondi wrote: > display_pipe_crc_irq_handler() skips the first CRC for all GPUs and > the > second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT > which > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > v2: Rebase > > Cc: Jani Saarinen <jani.saarinen@intel.com> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Acked-by: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com> > References: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c > b/drivers/gpu/drm/i915/i915_irq.c > index 572a5c37cc61..312ca9d5292a 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1565,11 +1565,11 @@ static void > display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv, > * bonkers. So let's just wait for the next vblank and read > * out the buggy result. > * > - * On GEN8+ sometimes the second CRC is bonkers as well, so > + * On GEN7+ sometimes the second CRC is bonkers as well, so > * don't trust that one either. > */ > if (pipe_crc->skipped <= 0 || > - (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) { > + (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) { > pipe_crc->skipped++; > spin_unlock(&pipe_crc->lock); > return; _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v2,1/1] drm/i915: skip the second CRC even for GEN 7 GPUs 2019-10-23 7:24 ` [PATCH v2 0/1] Invalid CRCs causing CRC mismatch test failures Harish Chegondi 2019-10-23 7:24 ` [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi @ 2019-10-23 8:08 ` Patchwork 1 sibling, 0 replies; 16+ messages in thread From: Patchwork @ 2019-10-23 8:08 UTC (permalink / raw) To: Harish Chegondi; +Cc: intel-gfx == Series Details == Series: series starting with [v2,1/1] drm/i915: skip the second CRC even for GEN 7 GPUs URL : https://patchwork.freedesktop.org/series/68427/ State : success == Summary == CI Bug Log - changes from CI_DRM_7155 -> Patchwork_14938 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_14938: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@i915_selftest@live_gt_heartbeat}: - fi-whl-u: [PASS][1] -> [DMESG-FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-whl-u/igt@i915_selftest@live_gt_heartbeat.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-whl-u/igt@i915_selftest@live_gt_heartbeat.html Known issues ------------ Here are the changes found in Patchwork_14938 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_reloc@basic-cpu-read-noreloc: - fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@gem_exec_reloc@basic-cpu-read-noreloc.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-icl-u3/igt@gem_exec_reloc@basic-cpu-read-noreloc.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-hsw-4770: [PASS][5] -> [SKIP][6] ([fdo#109271]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html #### Possible fixes #### * igt@gem_sync@basic-many-each: - {fi-tgl-u}: [INCOMPLETE][7] ([fdo#111880]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-tgl-u/igt@gem_sync@basic-many-each.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-tgl-u/igt@gem_sync@basic-many-each.html * igt@i915_selftest@live_requests: - {fi-tgl-u2}: [INCOMPLETE][9] ([fdo#112057]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-tgl-u2/igt@i915_selftest@live_requests.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-tgl-u2/igt@i915_selftest@live_requests.html * igt@vgem_basic@setversion: - fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@vgem_basic@setversion.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-icl-u3/igt@vgem_basic@setversion.html #### Warnings #### * igt@i915_selftest@live_gem: - fi-snb-2600: [INCOMPLETE][13] ([fdo#105411]) -> [INCOMPLETE][14] ([fdo#105411] / [fdo#112107]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-snb-2600/igt@i915_selftest@live_gem.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-snb-2600/igt@i915_selftest@live_gem.html - fi-byt-j1900: [INCOMPLETE][15] ([fdo#102657]) -> [INCOMPLETE][16] ([fdo#102657] / [fdo#112107]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-byt-j1900/igt@i915_selftest@live_gem.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-byt-j1900/igt@i915_selftest@live_gem.html - fi-cml-u2: [INCOMPLETE][17] ([fdo#110566]) -> [INCOMPLETE][18] ([fdo#110566] / [fdo#112107]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-cml-u2/igt@i915_selftest@live_gem.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-cml-u2/igt@i915_selftest@live_gem.html - fi-icl-u3: [INCOMPLETE][19] ([fdo#107713]) -> [INCOMPLETE][20] ([fdo#107713] / [fdo#112107]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@i915_selftest@live_gem.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-icl-u3/igt@i915_selftest@live_gem.html - fi-gdg-551: [INCOMPLETE][21] ([fdo#108316]) -> [INCOMPLETE][22] ([fdo#108316] / [fdo#112107]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-gdg-551/igt@i915_selftest@live_gem.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-gdg-551/igt@i915_selftest@live_gem.html - fi-glk-dsi: [INCOMPLETE][23] ([fdo#103359] / [k.org#198133]) -> [INCOMPLETE][24] ([fdo#103359] / [fdo#112107] / [k.org#198133]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-glk-dsi/igt@i915_selftest@live_gem.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-glk-dsi/igt@i915_selftest@live_gem.html - fi-icl-u2: [INCOMPLETE][25] ([fdo#107713]) -> [INCOMPLETE][26] ([fdo#107713] / [fdo#112107]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u2/igt@i915_selftest@live_gem.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-icl-u2/igt@i915_selftest@live_gem.html - fi-byt-n2820: [INCOMPLETE][27] ([fdo#102657]) -> [INCOMPLETE][28] ([fdo#102657] / [fdo#112107]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-byt-n2820/igt@i915_selftest@live_gem.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/fi-byt-n2820/igt@i915_selftest@live_gem.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657 [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108316]: https://bugs.freedesktop.org/show_bug.cgi?id=108316 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566 [fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880 [fdo#112057]: https://bugs.freedesktop.org/show_bug.cgi?id=112057 [fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096 [fdo#112107]: https://bugs.freedesktop.org/show_bug.cgi?id=112107 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (52 -> 33) ------------------------------ Missing (19): fi-icl-u4 fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-apl-guc fi-snb-2520m fi-cfl-guc fi-byt-clapper fi-elk-e7500 fi-skl-iommu fi-pnv-d510 fi-icl-y fi-bdw-samus fi-bsw-kefka fi-skl-6700k2 fi-cml-u Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7155 -> Patchwork_14938 CI-20190529: 20190529 CI_DRM_7155: 87aff128f9bafd90854e4691c3afcdf7a0e61ce2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5235: da9abbab69be80dd00812a4607a4ea2dffcc4544 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14938: 964997fd484dbc1314b6f4abb13a8174d733d130 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 964997fd484d drm/i915: skip the second CRC even for GEN 7 GPUs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14938/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures 2019-05-16 5:58 [PATCH 0/1] Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Harish Chegondi 2019-05-16 5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi @ 2019-05-16 6:33 ` Patchwork 2019-05-16 7:51 ` ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 16+ messages in thread From: Patchwork @ 2019-05-16 6:33 UTC (permalink / raw) To: Harish Chegondi; +Cc: intel-gfx == Series Details == Series: Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures URL : https://patchwork.freedesktop.org/series/60697/ State : success == Summary == CI Bug Log - changes from CI_DRM_6089 -> Patchwork_13023 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/ Known issues ------------ Here are the changes found in Patchwork_13023 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html #### Possible fixes #### * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][3] ([fdo#109485]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Warnings #### * igt@i915_selftest@live_hangcheck: - fi-apl-guc: [DMESG-FAIL][5] ([fdo#110620]) -> [INCOMPLETE][6] ([fdo#103927] / [fdo#110624]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/fi-apl-guc/igt@i915_selftest@live_hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/fi-apl-guc/igt@i915_selftest@live_hangcheck.html * igt@runner@aborted: - fi-apl-guc: [FAIL][7] ([fdo#110622]) -> [FAIL][8] ([fdo#110624]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/fi-apl-guc/igt@runner@aborted.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/fi-apl-guc/igt@runner@aborted.html [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485 [fdo#110620]: https://bugs.freedesktop.org/show_bug.cgi?id=110620 [fdo#110622]: https://bugs.freedesktop.org/show_bug.cgi?id=110622 [fdo#110624]: https://bugs.freedesktop.org/show_bug.cgi?id=110624 Participating hosts (52 -> 45) ------------------------------ Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_6089 -> Patchwork_13023 CI_DRM_6089: c7a46913f77868d15ade90846526d7e4cb910637 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4991: 61dd8eec659062eac67823ccd9f2189c3aa36201 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13023: ea7bd1c53ffed5ca2cf77f2a236ff031fcd71ba7 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == ea7bd1c53ffe drm/i915: skip the second CRC even for GEN 7 GPUs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.IGT: success for Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures 2019-05-16 5:58 [PATCH 0/1] Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Harish Chegondi 2019-05-16 5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi 2019-05-16 6:33 ` ✓ Fi.CI.BAT: success for Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Patchwork @ 2019-05-16 7:51 ` Patchwork 2 siblings, 0 replies; 16+ messages in thread From: Patchwork @ 2019-05-16 7:51 UTC (permalink / raw) To: Harish Chegondi; +Cc: intel-gfx == Series Details == Series: Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures URL : https://patchwork.freedesktop.org/series/60697/ State : success == Summary == CI Bug Log - changes from CI_DRM_6089_full -> Patchwork_13023_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_13023_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_tiled_swapping@non-threaded: - shard-hsw: [PASS][1] -> [FAIL][2] ([fdo#108686]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-hsw7/igt@gem_tiled_swapping@non-threaded.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-hsw4/igt@gem_tiled_swapping@non-threaded.html * igt@i915_pm_rpm@debugfs-forcewake-user: - shard-skl: [PASS][3] -> [INCOMPLETE][4] ([fdo#107807]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl2/igt@i915_pm_rpm@debugfs-forcewake-user.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-skl4/igt@i915_pm_rpm@debugfs-forcewake-user.html * igt@i915_suspend@debugfs-reader: - shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-apl7/igt@i915_suspend@debugfs-reader.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-apl5/igt@i915_suspend@debugfs-reader.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic: - shard-hsw: [PASS][7] -> [FAIL][8] ([fdo#105767]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-hsw7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-skl: [PASS][9] -> [FAIL][10] ([fdo#100368]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +8 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [fdo#110403]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#108341]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb4/igt@kms_psr@no_drrs.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html * igt@perf@oa-exponents: - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105483]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-glk2/igt@perf@oa-exponents.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-glk8/igt@perf@oa-exponents.html * igt@perf_pmu@rc6: - shard-kbl: [PASS][21] -> [SKIP][22] ([fdo#109271]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-kbl6/igt@perf_pmu@rc6.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-kbl2/igt@perf_pmu@rc6.html #### Possible fixes #### * igt@i915_pm_rpm@gem-execbuf: - shard-apl: [INCOMPLETE][23] ([fdo#103927]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-apl6/igt@i915_pm_rpm@gem-execbuf.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-apl3/igt@i915_pm_rpm@gem-execbuf.html * igt@i915_pm_rpm@sysfs-read: - shard-skl: [INCOMPLETE][25] ([fdo#107807]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl7/igt@i915_pm_rpm@sysfs-read.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-skl5/igt@i915_pm_rpm@sysfs-read.html * {igt@kms_cursor_crc@pipe-b-cursor-suspend}: - shard-apl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt: - shard-iclb: [FAIL][29] ([fdo#103167]) -> [PASS][30] +5 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [FAIL][31] ([fdo#103166]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][33] ([fdo#109642]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb6/igt@kms_psr2_su@page_flip.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-iclb2/igt@kms_psr2_su@page_flip.html #### Warnings #### * igt@gem_mmap_gtt@forked-big-copy-odd: - shard-iclb: [INCOMPLETE][35] ([fdo#107713] / [fdo#109100]) -> [TIMEOUT][36] ([fdo#109673]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-iclb1/igt@gem_mmap_gtt@forked-big-copy-odd.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-iclb5/igt@gem_mmap_gtt@forked-big-copy-odd.html * igt@i915_pm_rpm@pc8-residency: - shard-skl: [SKIP][37] ([fdo#109271]) -> [INCOMPLETE][38] ([fdo#107807]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6089/shard-skl10/igt@i915_pm_rpm@pc8-residency.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/shard-skl7/igt@i915_pm_rpm@pc8-residency.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483 [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_6089 -> Patchwork_13023 CI_DRM_6089: c7a46913f77868d15ade90846526d7e4cb910637 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4991: 61dd8eec659062eac67823ccd9f2189c3aa36201 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13023: ea7bd1c53ffed5ca2cf77f2a236ff031fcd71ba7 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13023/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-10-23 22:15 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-05-16 5:58 [PATCH 0/1] Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Harish Chegondi 2019-05-16 5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi 2019-05-16 8:30 ` Jani Nikula 2019-05-16 12:46 ` Maarten Lankhorst 2019-05-16 12:55 ` Jani Nikula 2019-05-16 13:30 ` Ville Syrjälä 2019-05-16 15:46 ` Jani Nikula 2019-05-16 21:02 ` Chegondi, Harish 2019-05-16 20:52 ` Chegondi, Harish 2019-10-23 7:24 ` [PATCH v2 0/1] Invalid CRCs causing CRC mismatch test failures Harish Chegondi 2019-10-23 7:24 ` [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi 2019-10-23 22:15 ` Chegondi, Harish 2019-10-23 22:15 ` [Intel-gfx] " Chegondi, Harish 2019-10-23 8:08 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork 2019-05-16 6:33 ` ✓ Fi.CI.BAT: success for Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Patchwork 2019-05-16 7:51 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.