From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
peterz@infradead.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, tglx@linutronix.de, mingo@kernel.org
Subject: Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64
Date: Tue, 10 Nov 2015 13:29:35 +0100 [thread overview]
Message-ID: <4372800.FdTygmcuyo@wuerfel> (raw)
In-Reply-To: <1447156675-7418-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote:
> __current_kernel_time64 returns a struct timespec64, without taking the
> xtime lock. Mirrors __current_kernel_time/current_kernel_time.
>
Actually it doesn't mirror __current_kernel_time/current_kernel_time
> diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
> index ec89d84..b5802bf 100644
> --- a/include/linux/timekeeping.h
> +++ b/include/linux/timekeeping.h
> @@ -19,7 +19,8 @@ extern int do_sys_settimeofday(const struct timespec *tv,
> */
> unsigned long get_seconds(void);
> struct timespec64 current_kernel_time64(void);
> -/* does not take xtime_lock */
> +/* do not take xtime_lock */
> +struct timespec64 __current_kernel_time64(void);
> struct timespec __current_kernel_time(void);
Please change __current_kernel_time into a static inline function
while you are introducing the new one, to match the patch description ;-)
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64
Date: Tue, 10 Nov 2015 13:29:35 +0100 [thread overview]
Message-ID: <4372800.FdTygmcuyo@wuerfel> (raw)
In-Reply-To: <1447156675-7418-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote:
> __current_kernel_time64 returns a struct timespec64, without taking the
> xtime lock. Mirrors __current_kernel_time/current_kernel_time.
>
Actually it doesn't mirror __current_kernel_time/current_kernel_time
> diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
> index ec89d84..b5802bf 100644
> --- a/include/linux/timekeeping.h
> +++ b/include/linux/timekeeping.h
> @@ -19,7 +19,8 @@ extern int do_sys_settimeofday(const struct timespec *tv,
> */
> unsigned long get_seconds(void);
> struct timespec64 current_kernel_time64(void);
> -/* does not take xtime_lock */
> +/* do not take xtime_lock */
> +struct timespec64 __current_kernel_time64(void);
> struct timespec __current_kernel_time(void);
Please change __current_kernel_time into a static inline function
while you are introducing the new one, to match the patch description ;-)
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
peterz@infradead.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, tglx@linutronix.de, mingo@kernel.org
Subject: Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64
Date: Tue, 10 Nov 2015 13:29:35 +0100 [thread overview]
Message-ID: <4372800.FdTygmcuyo@wuerfel> (raw)
In-Reply-To: <1447156675-7418-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote:
> __current_kernel_time64 returns a struct timespec64, without taking the
> xtime lock. Mirrors __current_kernel_time/current_kernel_time.
>
Actually it doesn't mirror __current_kernel_time/current_kernel_time
> diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
> index ec89d84..b5802bf 100644
> --- a/include/linux/timekeeping.h
> +++ b/include/linux/timekeeping.h
> @@ -19,7 +19,8 @@ extern int do_sys_settimeofday(const struct timespec *tv,
> */
> unsigned long get_seconds(void);
> struct timespec64 current_kernel_time64(void);
> -/* does not take xtime_lock */
> +/* do not take xtime_lock */
> +struct timespec64 __current_kernel_time64(void);
> struct timespec __current_kernel_time(void);
Please change __current_kernel_time into a static inline function
while you are introducing the new one, to match the patch description ;-)
Arnd
next prev parent reply other threads:[~2015-11-10 12:30 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 11:56 [PATCH v2 0/7] Xen wallclock on arm and arm64 Stefano Stabellini
2015-11-10 11:56 ` Stefano Stabellini
2015-11-10 11:56 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:22 ` Peter Zijlstra
2015-11-10 12:22 ` Peter Zijlstra
2015-11-10 14:34 ` Stefano Stabellini
2015-11-10 14:34 ` Stefano Stabellini
2015-11-10 14:34 ` Stefano Stabellini
2015-11-10 12:29 ` Arnd Bergmann [this message]
2015-11-10 12:29 ` Arnd Bergmann
2015-11-10 12:29 ` Arnd Bergmann
2015-11-10 15:10 ` Stefano Stabellini
2015-11-10 15:10 ` Stefano Stabellini
2015-11-10 15:10 ` Stefano Stabellini
2015-11-10 15:26 ` John Stultz
2015-11-10 15:26 ` John Stultz
2015-11-10 15:26 ` John Stultz
2015-11-10 15:31 ` Thomas Gleixner
2015-11-10 15:31 ` Thomas Gleixner
2015-11-10 15:31 ` Thomas Gleixner
2015-11-10 15:41 ` John Stultz
2015-11-10 15:41 ` John Stultz
2015-11-10 15:41 ` John Stultz
2015-11-10 15:55 ` Thomas Gleixner
2015-11-10 15:55 ` Thomas Gleixner
2015-11-10 15:55 ` Thomas Gleixner
2015-11-11 11:51 ` Stefano Stabellini
2015-11-11 11:51 ` Stefano Stabellini
2015-11-11 11:51 ` Stefano Stabellini
2015-11-11 13:31 ` Arnd Bergmann
2015-11-11 13:31 ` Arnd Bergmann
2015-11-11 13:31 ` Arnd Bergmann
2015-11-10 11:57 ` [PATCH v2 2/7] xen: rename dom0_op to platform_op Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 3/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64 Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 4/7] xen: introduce XENPF_settime64 Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:32 ` Arnd Bergmann
2015-11-10 12:32 ` Arnd Bergmann
2015-11-10 14:43 ` Stefano Stabellini
2015-11-10 14:43 ` Stefano Stabellini
2015-11-10 14:43 ` Stefano Stabellini
2015-11-10 14:47 ` Arnd Bergmann
2015-11-10 14:47 ` Arnd Bergmann
2015-11-10 11:57 ` [PATCH v2 5/7] arm: extend pvclock_wall_clock with sec_hi Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:35 ` Arnd Bergmann
2015-11-10 12:35 ` Arnd Bergmann
2015-11-10 11:57 ` [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:39 ` Arnd Bergmann
2015-11-10 12:39 ` Arnd Bergmann
2015-11-10 15:58 ` Stefano Stabellini
2015-11-10 15:58 ` Stefano Stabellini
2015-11-10 15:58 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4372800.FdTygmcuyo@wuerfel \
--to=arnd@arndb.de \
--cc=Ian.Campbell@citrix.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.