From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
<xen-devel@lists.xensource.com>,
<linux-arm-kernel@lists.infradead.org>, <Ian.Campbell@citrix.com>,
<linux-kernel@vger.kernel.org>, <arnd@arndb.de>,
<john.stultz@linaro.org>, <tglx@linutronix.de>,
<mingo@kernel.org>
Subject: Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64
Date: Tue, 10 Nov 2015 14:34:13 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1511101429100.5676@kaball.uk.xensource.com> (raw)
In-Reply-To: <20151110122201.GB17308@twins.programming.kicks-ass.net>
On Tue, 10 Nov 2015, Peter Zijlstra wrote:
> On Tue, Nov 10, 2015 at 11:57:49AM +0000, Stefano Stabellini wrote:
> > __current_kernel_time64 returns a struct timespec64, without taking the
> > xtime lock. Mirrors __current_kernel_time/current_kernel_time.
>
> It always helps if you include a reason why you want a patch.
You are right, sorry.
I need to get the current_kernel_time from a pvclock_gtod callback
function, which cannot take the lock again.
On x86 we are just calling __current_kernel_time() (see
arch/x86/xen/time.c:xen_pvclock_gtod_notify). I was introducing the same
functionality on ARM, when the maintainers pointed out that it might be
better to use struct timespec64 and related functions for
future-proofness. To do that I need a version of __current_kernel_time
which returns a struct timespec64.
WARNING: multiple messages have this Message-ID (diff)
From: stefano.stabellini@eu.citrix.com (Stefano Stabellini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64
Date: Tue, 10 Nov 2015 14:34:13 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1511101429100.5676@kaball.uk.xensource.com> (raw)
In-Reply-To: <20151110122201.GB17308@twins.programming.kicks-ass.net>
On Tue, 10 Nov 2015, Peter Zijlstra wrote:
> On Tue, Nov 10, 2015 at 11:57:49AM +0000, Stefano Stabellini wrote:
> > __current_kernel_time64 returns a struct timespec64, without taking the
> > xtime lock. Mirrors __current_kernel_time/current_kernel_time.
>
> It always helps if you include a reason why you want a patch.
You are right, sorry.
I need to get the current_kernel_time from a pvclock_gtod callback
function, which cannot take the lock again.
On x86 we are just calling __current_kernel_time() (see
arch/x86/xen/time.c:xen_pvclock_gtod_notify). I was introducing the same
functionality on ARM, when the maintainers pointed out that it might be
better to use struct timespec64 and related functions for
future-proofness. To do that I need a version of __current_kernel_time
which returns a struct timespec64.
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com,
linux-arm-kernel@lists.infradead.org, Ian.Campbell@citrix.com,
linux-kernel@vger.kernel.org, arnd@arndb.de,
john.stultz@linaro.org, tglx@linutronix.de, mingo@kernel.org
Subject: Re: [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64
Date: Tue, 10 Nov 2015 14:34:13 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1511101429100.5676@kaball.uk.xensource.com> (raw)
In-Reply-To: <20151110122201.GB17308@twins.programming.kicks-ass.net>
On Tue, 10 Nov 2015, Peter Zijlstra wrote:
> On Tue, Nov 10, 2015 at 11:57:49AM +0000, Stefano Stabellini wrote:
> > __current_kernel_time64 returns a struct timespec64, without taking the
> > xtime lock. Mirrors __current_kernel_time/current_kernel_time.
>
> It always helps if you include a reason why you want a patch.
You are right, sorry.
I need to get the current_kernel_time from a pvclock_gtod callback
function, which cannot take the lock again.
On x86 we are just calling __current_kernel_time() (see
arch/x86/xen/time.c:xen_pvclock_gtod_notify). I was introducing the same
functionality on ARM, when the maintainers pointed out that it might be
better to use struct timespec64 and related functions for
future-proofness. To do that I need a version of __current_kernel_time
which returns a struct timespec64.
next prev parent reply other threads:[~2015-11-10 14:37 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 11:56 [PATCH v2 0/7] Xen wallclock on arm and arm64 Stefano Stabellini
2015-11-10 11:56 ` Stefano Stabellini
2015-11-10 11:56 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 1/7] timekeeping: introduce __current_kernel_time64 Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:22 ` Peter Zijlstra
2015-11-10 12:22 ` Peter Zijlstra
2015-11-10 14:34 ` Stefano Stabellini [this message]
2015-11-10 14:34 ` Stefano Stabellini
2015-11-10 14:34 ` Stefano Stabellini
2015-11-10 12:29 ` Arnd Bergmann
2015-11-10 12:29 ` Arnd Bergmann
2015-11-10 12:29 ` Arnd Bergmann
2015-11-10 15:10 ` Stefano Stabellini
2015-11-10 15:10 ` Stefano Stabellini
2015-11-10 15:10 ` Stefano Stabellini
2015-11-10 15:26 ` John Stultz
2015-11-10 15:26 ` John Stultz
2015-11-10 15:26 ` John Stultz
2015-11-10 15:31 ` Thomas Gleixner
2015-11-10 15:31 ` Thomas Gleixner
2015-11-10 15:31 ` Thomas Gleixner
2015-11-10 15:41 ` John Stultz
2015-11-10 15:41 ` John Stultz
2015-11-10 15:41 ` John Stultz
2015-11-10 15:55 ` Thomas Gleixner
2015-11-10 15:55 ` Thomas Gleixner
2015-11-10 15:55 ` Thomas Gleixner
2015-11-11 11:51 ` Stefano Stabellini
2015-11-11 11:51 ` Stefano Stabellini
2015-11-11 11:51 ` Stefano Stabellini
2015-11-11 13:31 ` Arnd Bergmann
2015-11-11 13:31 ` Arnd Bergmann
2015-11-11 13:31 ` Arnd Bergmann
2015-11-10 11:57 ` [PATCH v2 2/7] xen: rename dom0_op to platform_op Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 3/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64 Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 4/7] xen: introduce XENPF_settime64 Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:32 ` Arnd Bergmann
2015-11-10 12:32 ` Arnd Bergmann
2015-11-10 14:43 ` Stefano Stabellini
2015-11-10 14:43 ` Stefano Stabellini
2015-11-10 14:43 ` Stefano Stabellini
2015-11-10 14:47 ` Arnd Bergmann
2015-11-10 14:47 ` Arnd Bergmann
2015-11-10 11:57 ` [PATCH v2 5/7] arm: extend pvclock_wall_clock with sec_hi Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` [PATCH v2 6/7] xen/arm: introduce xen_read_wallclock Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:35 ` Arnd Bergmann
2015-11-10 12:35 ` Arnd Bergmann
2015-11-10 11:57 ` [PATCH v2 7/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 11:57 ` Stefano Stabellini
2015-11-10 12:39 ` Arnd Bergmann
2015-11-10 12:39 ` Arnd Bergmann
2015-11-10 15:58 ` Stefano Stabellini
2015-11-10 15:58 ` Stefano Stabellini
2015-11-10 15:58 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1511101429100.5676@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=arnd@arndb.de \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.