From: Avi Kivity <avi@redhat.com> To: Ian Molton <ian.molton@collabora.co.uk> Cc: linux-kernel@vger.kernel.org, QEMU Developers <qemu-devel@nongnu.org>, virtualization@lists.osdl.org Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport Date: Thu, 28 Oct 2010 11:27:31 +0200 [thread overview] Message-ID: <4CC94203.1080207@redhat.com> (raw) In-Reply-To: <4CC8226F.5080807@collabora.co.uk> On 10/27/2010 03:00 PM, Ian Molton wrote: > On 19/10/10 11:39, Avi Kivity wrote: >> On 10/19/2010 12:31 PM, Ian Molton wrote: > >>>> 2. should start with a patch to the virtio-pci spec to document what >>>> you're doing >>> >>> Where can I find that spec? >> >> http://ozlabs.org/~rusty/virtio-spec/ > > Ok, but I'm not patching that until theres been some review. Well, I like to review an implementation against a spec. > > There are links to the associated qemu and guest OS changes in my > original email. > >>> It doesnt, at present... It could be changed fairly easily ithout >>> breaking anything if that happens though. >> >> The hypervisor and the guest can be changed independently. The driver >> should be coded so that it doesn't depend on hypervisor implementation >> details. > > Fixed - updated patch tested and attached. > + > + /* Transfer data */ > + if (virtqueue_add_buf(vq, sg_list, o_page, i_page, gldata)>= 0) { > + virtqueue_kick(vq); > + /* Chill out until it's done with the buffer. */ > + wait_for_completion(&gldata->done); > + } > + Better, but still unsatisfying. If the server is busy, the caller would block. I guess it's expected since it's called from ->fsync(). I'm not sure whether that's the best interface, perhaps aio_writev is better. -- error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com> To: Ian Molton <ian.molton@collabora.co.uk> Cc: virtualization@lists.osdl.org, linux-kernel@vger.kernel.org, QEMU Developers <qemu-devel@nongnu.org> Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport Date: Thu, 28 Oct 2010 11:27:31 +0200 [thread overview] Message-ID: <4CC94203.1080207@redhat.com> (raw) In-Reply-To: <4CC8226F.5080807@collabora.co.uk> On 10/27/2010 03:00 PM, Ian Molton wrote: > On 19/10/10 11:39, Avi Kivity wrote: >> On 10/19/2010 12:31 PM, Ian Molton wrote: > >>>> 2. should start with a patch to the virtio-pci spec to document what >>>> you're doing >>> >>> Where can I find that spec? >> >> http://ozlabs.org/~rusty/virtio-spec/ > > Ok, but I'm not patching that until theres been some review. Well, I like to review an implementation against a spec. > > There are links to the associated qemu and guest OS changes in my > original email. > >>> It doesnt, at present... It could be changed fairly easily ithout >>> breaking anything if that happens though. >> >> The hypervisor and the guest can be changed independently. The driver >> should be coded so that it doesn't depend on hypervisor implementation >> details. > > Fixed - updated patch tested and attached. > + > + /* Transfer data */ > + if (virtqueue_add_buf(vq, sg_list, o_page, i_page, gldata)>= 0) { > + virtqueue_kick(vq); > + /* Chill out until it's done with the buffer. */ > + wait_for_completion(&gldata->done); > + } > + Better, but still unsatisfying. If the server is busy, the caller would block. I guess it's expected since it's called from ->fsync(). I'm not sure whether that's the best interface, perhaps aio_writev is better. -- error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-10-28 9:27 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-06 15:59 [PATCH] Implement a virtio GPU transport Ian Molton 2010-10-10 15:11 ` Avi Kivity 2010-10-19 10:31 ` Ian Molton 2010-10-19 10:31 ` [Qemu-devel] " Ian Molton 2010-10-19 10:39 ` Avi Kivity 2010-10-19 10:39 ` [Qemu-devel] " Avi Kivity 2010-10-27 13:00 ` Ian Molton 2010-10-27 13:00 ` Ian Molton 2010-10-28 9:27 ` Avi Kivity [this message] 2010-10-28 9:27 ` Avi Kivity 2010-10-28 11:54 ` Ian Molton 2010-10-28 11:54 ` Ian Molton 2010-10-28 14:24 ` Avi Kivity 2010-10-28 14:24 ` Avi Kivity 2010-10-28 14:43 ` Anthony Liguori 2010-10-28 14:43 ` Anthony Liguori 2010-10-28 19:50 ` Ian Molton 2010-10-28 19:50 ` Ian Molton 2010-10-28 20:14 ` Anthony Liguori 2010-10-28 20:14 ` Anthony Liguori 2010-10-28 21:41 ` Ian Molton 2010-10-28 21:41 ` Ian Molton 2010-10-28 19:52 ` Ian Molton 2010-11-01 10:42 ` Avi Kivity 2010-11-01 13:21 ` Anthony Liguori 2010-11-01 13:21 ` Anthony Liguori 2010-11-01 15:49 ` Ian Molton 2010-11-01 15:49 ` Ian Molton 2010-11-01 15:57 ` Anthony Liguori 2010-11-01 15:57 ` Anthony Liguori 2010-11-03 17:49 ` Ian Molton 2010-11-03 17:49 ` Ian Molton 2010-11-01 15:50 ` Ian Molton 2010-10-29 11:18 ` Rusty Russell 2010-10-29 11:18 ` Rusty Russell 2010-10-29 11:49 ` Ed Tomlinson 2010-10-29 11:49 ` Ed Tomlinson 2010-10-29 11:49 ` Ed Tomlinson 2010-10-29 13:05 ` Anthony Liguori 2010-10-29 13:05 ` Anthony Liguori 2010-11-01 11:53 ` Alon Levy 2010-11-01 11:53 ` Alon Levy 2010-11-01 13:28 ` Anthony Liguori 2010-11-01 13:28 ` Anthony Liguori 2010-11-03 18:03 ` Ian Molton 2010-11-03 18:03 ` Ian Molton 2010-11-03 18:17 ` Anthony Liguori 2010-11-03 18:17 ` Anthony Liguori 2010-11-05 18:05 ` Ian Molton 2010-11-05 18:05 ` Ian Molton 2010-11-10 17:22 ` Ian Molton 2010-11-10 17:22 ` Ian Molton 2010-11-10 17:47 ` Anthony Liguori 2010-11-10 17:47 ` Anthony Liguori 2010-11-12 12:14 ` Ian Molton 2010-11-12 12:14 ` Ian Molton 2010-11-12 13:21 ` Anthony Liguori 2010-11-12 13:21 ` Anthony Liguori 2010-11-04 9:13 ` Alon Levy 2010-11-04 9:13 ` Alon Levy 2010-11-05 17:57 ` Ian Molton 2010-11-05 17:57 ` Ian Molton 2010-11-03 17:50 ` Ian Molton 2010-11-03 17:50 ` Ian Molton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4CC94203.1080207@redhat.com \ --to=avi@redhat.com \ --cc=ian.molton@collabora.co.uk \ --cc=linux-kernel@vger.kernel.org \ --cc=qemu-devel@nongnu.org \ --cc=virtualization@lists.osdl.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.