From: Anthony Liguori <anthony@codemonkey.ws> To: Ian Molton <ian.molton@collabora.co.uk> Cc: QEMU Developers <qemu-devel@nongnu.org>, Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, virtualization@lists.osdl.org, Alon Levy <alevy@redhat.com>, Avi Kivity <avi@redhat.com> Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport Date: Fri, 12 Nov 2010 07:21:53 -0600 [thread overview] Message-ID: <4CDD3F71.5030908@codemonkey.ws> (raw) In-Reply-To: <4CDD2F9A.7000702@collabora.co.uk> On 11/12/2010 06:14 AM, Ian Molton wrote: > On 10/11/10 17:47, Anthony Liguori wrote: >> On 11/10/2010 11:22 AM, Ian Molton wrote: >>> Ping ? >> >> I think the best way forward is to post patches. > > I posted links to the git trees. I can post patches, but they are > *large*. Do you really want me to post them? Yes, and they have to be split up into something reviewable. > >> To summarize what I was trying to express in the thread, I think this is >> not the right long term architecture but am not opposed to it as a short >> term solution. I think having a new virtio device is a bad design choice >> but am not totally opposed to it. > > Ok! (I agree (that this should be a short term solution) :) ) > >> you want to go for the path of integration, you're going to have to fix >> all of the coding style issues and make the code fit into QEMU. Dropping >> a bunch of junk into target-i386/ is not making the code fit into QEMU. > > I agree. how about hw/gl for the renderer and hw/ for the virtio module? That would be fine. >> If you post just what you have now in patch form, I can try to provide >> more concrete advice ignoring the coding style problems. > > I can post patches, although I dont think LKML would appreciate the > volume! I can post them to the qemu list if you do. Yes, qemu is where I was suggesting you post them. Regards, Anthony Liguori > -Ian
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws> To: Ian Molton <ian.molton@collabora.co.uk> Cc: linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, QEMU Developers <qemu-devel@nongnu.org>, virtualization@lists.linux-foundation.org, virtualization@lists.osdl.org, Alon Levy <alevy@redhat.com>, Avi Kivity <avi@redhat.com> Subject: Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport Date: Fri, 12 Nov 2010 07:21:53 -0600 [thread overview] Message-ID: <4CDD3F71.5030908@codemonkey.ws> (raw) In-Reply-To: <4CDD2F9A.7000702@collabora.co.uk> On 11/12/2010 06:14 AM, Ian Molton wrote: > On 10/11/10 17:47, Anthony Liguori wrote: >> On 11/10/2010 11:22 AM, Ian Molton wrote: >>> Ping ? >> >> I think the best way forward is to post patches. > > I posted links to the git trees. I can post patches, but they are > *large*. Do you really want me to post them? Yes, and they have to be split up into something reviewable. > >> To summarize what I was trying to express in the thread, I think this is >> not the right long term architecture but am not opposed to it as a short >> term solution. I think having a new virtio device is a bad design choice >> but am not totally opposed to it. > > Ok! (I agree (that this should be a short term solution) :) ) > >> you want to go for the path of integration, you're going to have to fix >> all of the coding style issues and make the code fit into QEMU. Dropping >> a bunch of junk into target-i386/ is not making the code fit into QEMU. > > I agree. how about hw/gl for the renderer and hw/ for the virtio module? That would be fine. >> If you post just what you have now in patch form, I can try to provide >> more concrete advice ignoring the coding style problems. > > I can post patches, although I dont think LKML would appreciate the > volume! I can post them to the qemu list if you do. Yes, qemu is where I was suggesting you post them. Regards, Anthony Liguori > -Ian
next prev parent reply other threads:[~2010-11-12 13:21 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-06 15:59 [PATCH] Implement a virtio GPU transport Ian Molton 2010-10-10 15:11 ` Avi Kivity 2010-10-19 10:31 ` Ian Molton 2010-10-19 10:31 ` [Qemu-devel] " Ian Molton 2010-10-19 10:39 ` Avi Kivity 2010-10-19 10:39 ` [Qemu-devel] " Avi Kivity 2010-10-27 13:00 ` Ian Molton 2010-10-27 13:00 ` Ian Molton 2010-10-28 9:27 ` Avi Kivity 2010-10-28 9:27 ` Avi Kivity 2010-10-28 11:54 ` Ian Molton 2010-10-28 11:54 ` Ian Molton 2010-10-28 14:24 ` Avi Kivity 2010-10-28 14:24 ` Avi Kivity 2010-10-28 14:43 ` Anthony Liguori 2010-10-28 14:43 ` Anthony Liguori 2010-10-28 19:50 ` Ian Molton 2010-10-28 19:50 ` Ian Molton 2010-10-28 20:14 ` Anthony Liguori 2010-10-28 20:14 ` Anthony Liguori 2010-10-28 21:41 ` Ian Molton 2010-10-28 21:41 ` Ian Molton 2010-10-28 19:52 ` Ian Molton 2010-11-01 10:42 ` Avi Kivity 2010-11-01 13:21 ` Anthony Liguori 2010-11-01 13:21 ` Anthony Liguori 2010-11-01 15:49 ` Ian Molton 2010-11-01 15:49 ` Ian Molton 2010-11-01 15:57 ` Anthony Liguori 2010-11-01 15:57 ` Anthony Liguori 2010-11-03 17:49 ` Ian Molton 2010-11-03 17:49 ` Ian Molton 2010-11-01 15:50 ` Ian Molton 2010-10-29 11:18 ` Rusty Russell 2010-10-29 11:18 ` Rusty Russell 2010-10-29 11:49 ` Ed Tomlinson 2010-10-29 11:49 ` Ed Tomlinson 2010-10-29 11:49 ` Ed Tomlinson 2010-10-29 13:05 ` Anthony Liguori 2010-10-29 13:05 ` Anthony Liguori 2010-11-01 11:53 ` Alon Levy 2010-11-01 11:53 ` Alon Levy 2010-11-01 13:28 ` Anthony Liguori 2010-11-01 13:28 ` Anthony Liguori 2010-11-03 18:03 ` Ian Molton 2010-11-03 18:03 ` Ian Molton 2010-11-03 18:17 ` Anthony Liguori 2010-11-03 18:17 ` Anthony Liguori 2010-11-05 18:05 ` Ian Molton 2010-11-05 18:05 ` Ian Molton 2010-11-10 17:22 ` Ian Molton 2010-11-10 17:22 ` Ian Molton 2010-11-10 17:47 ` Anthony Liguori 2010-11-10 17:47 ` Anthony Liguori 2010-11-12 12:14 ` Ian Molton 2010-11-12 12:14 ` Ian Molton 2010-11-12 13:21 ` Anthony Liguori [this message] 2010-11-12 13:21 ` Anthony Liguori 2010-11-04 9:13 ` Alon Levy 2010-11-04 9:13 ` Alon Levy 2010-11-05 17:57 ` Ian Molton 2010-11-05 17:57 ` Ian Molton 2010-11-03 17:50 ` Ian Molton 2010-11-03 17:50 ` Ian Molton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4CDD3F71.5030908@codemonkey.ws \ --to=anthony@codemonkey.ws \ --cc=alevy@redhat.com \ --cc=avi@redhat.com \ --cc=ian.molton@collabora.co.uk \ --cc=linux-kernel@vger.kernel.org \ --cc=qemu-devel@nongnu.org \ --cc=rusty@rustcorp.com.au \ --cc=virtualization@lists.linux-foundation.org \ --cc=virtualization@lists.osdl.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.