From: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org> To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> Cc: "davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org" <davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>, "dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>, "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, "khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org" <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>, "broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>, "rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org" <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>, "alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org" <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>, "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" <spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>, "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, "lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" <lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org> Subject: Re: [PATCH v5 01/12] misc: add driver for sequencer serial port Date: Tue, 16 Nov 2010 11:15:56 -0500 [thread overview] Message-ID: <4CE2AE3C.4040805@ti.com> (raw) In-Reply-To: <20101116071047.GE4074-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> On 11/16/2010 02:10 AM, Grant Likely wrote: > On Mon, Nov 15, 2010 at 02:12:03PM -0500, Cyril Chemparathy wrote: >> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port >> device. It has a built-in programmable execution engine that can be programmed >> to operate as almost any serial bus (I2C, SPI, EasyScale, and others). >> >> This patch adds a driver for this controller device. The driver does not >> expose a user-land interface. Protocol drivers built on top of this layer are >> expected to remain in-kernel. >> [...] >> +static inline void ssp_write(struct ti_ssp *ssp, int reg, u32 val) >> +{ >> + __raw_writel(val, ssp->regs + reg); >> +} > > I'm pretty sure it was resolved that __raw_ versions should not be > used here. The endian-swap done by writel/readl are incorrect since these devices are meant to be accessed native-endian at all times. See [1] below for Russell King's earlier response on this. In this case, I don't think memory-device ordering matters, and therefore the __raw_ variants should be ok. Should I just insert barriers into the read/write wrappers here? [...] Regards Cyril. [1] http://kerneltrap.org/mailarchive/linux-kernel/2010/10/22/4636289 ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today http://p.sf.net/sfu/msIE9-sfdev2dev
WARNING: multiple messages have this Message-ID (diff)
From: cyril@ti.com (Cyril Chemparathy) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 01/12] misc: add driver for sequencer serial port Date: Tue, 16 Nov 2010 11:15:56 -0500 [thread overview] Message-ID: <4CE2AE3C.4040805@ti.com> (raw) In-Reply-To: <20101116071047.GE4074@angua.secretlab.ca> On 11/16/2010 02:10 AM, Grant Likely wrote: > On Mon, Nov 15, 2010 at 02:12:03PM -0500, Cyril Chemparathy wrote: >> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port >> device. It has a built-in programmable execution engine that can be programmed >> to operate as almost any serial bus (I2C, SPI, EasyScale, and others). >> >> This patch adds a driver for this controller device. The driver does not >> expose a user-land interface. Protocol drivers built on top of this layer are >> expected to remain in-kernel. >> [...] >> +static inline void ssp_write(struct ti_ssp *ssp, int reg, u32 val) >> +{ >> + __raw_writel(val, ssp->regs + reg); >> +} > > I'm pretty sure it was resolved that __raw_ versions should not be > used here. The endian-swap done by writel/readl are incorrect since these devices are meant to be accessed native-endian at all times. See [1] below for Russell King's earlier response on this. In this case, I don't think memory-device ordering matters, and therefore the __raw_ variants should be ok. Should I just insert barriers into the read/write wrappers here? [...] Regards Cyril. [1] http://kerneltrap.org/mailarchive/linux-kernel/2010/10/22/4636289
next prev parent reply other threads:[~2010-11-16 16:15 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-15 19:12 [PATCH v5 00/12] tnetv107x ssp drivers Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy [not found] ` <1289848334-8695-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org> 2010-11-15 19:12 ` [PATCH v5 01/12] misc: add driver for sequencer serial port Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy [not found] ` <1289848334-8695-2-git-send-email-cyril-l0cyMroinI0@public.gmane.org> 2010-11-16 7:10 ` Grant Likely 2010-11-16 7:10 ` Grant Likely [not found] ` <20101116071047.GE4074-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> 2010-11-16 16:15 ` Cyril Chemparathy [this message] 2010-11-16 16:15 ` Cyril Chemparathy [not found] ` <4CE2AE3C.4040805-l0cyMroinI0@public.gmane.org> 2010-11-16 20:35 ` Grant Likely 2010-11-16 20:35 ` Grant Likely [not found] ` <AANLkTik76EY8Xh01YP2Tep6k1ETPO+3idmNuk3pVikJG-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-11-16 21:19 ` Cyril Chemparathy 2010-11-16 21:19 ` Cyril Chemparathy 2010-11-16 22:23 ` Russell King - ARM Linux 2010-11-16 22:23 ` Russell King - ARM Linux [not found] ` <20101116222340.GF21926-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2010-11-16 23:57 ` Grant Likely 2010-11-16 23:57 ` Grant Likely 2010-11-15 19:12 ` [PATCH v5 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 21:59 ` Ryan Mallon 2010-11-15 21:59 ` Ryan Mallon [not found] ` <1289848334-8695-5-git-send-email-cyril-l0cyMroinI0@public.gmane.org> 2010-11-16 7:22 ` Grant Likely 2010-11-16 7:22 ` Grant Likely [not found] ` <20101116072225.GF4074-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> 2010-11-16 7:47 ` Grant Likely 2010-11-16 7:47 ` Grant Likely 2010-11-16 11:34 ` Mark Brown 2010-11-16 11:34 ` Mark Brown [not found] ` <20101116113409.GH3338-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2010-11-16 20:45 ` Grant Likely 2010-11-16 20:45 ` Grant Likely [not found] ` <20101116204554.GB5016-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> 2010-11-16 22:48 ` Mark Brown 2010-11-16 22:48 ` Mark Brown [not found] ` <AANLkTi=utWumLKo9QVWXpkC8WxpgaNJJs+dj=pa2eq-q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-11-17 0:17 ` Cyril Chemparathy 2010-11-17 0:17 ` Cyril Chemparathy 2010-11-17 13:31 ` Mark Brown 2010-11-17 13:31 ` Mark Brown [not found] ` <20101117133136.GA19488-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org> 2010-11-17 15:25 ` David Brownell 2010-11-17 15:25 ` David Brownell [not found] ` <781931.83221.qm-g47maUHHHF+ORdMXk8NaZPu2YVrzzGjVVpNB7YpNyf8@public.gmane.org> 2010-11-17 17:54 ` Cyril Chemparathy 2010-11-17 17:54 ` Cyril Chemparathy [not found] ` <4CE31F0E.7050103-l0cyMroinI0@public.gmane.org> 2010-11-17 16:11 ` Grant Likely 2010-11-17 16:11 ` Grant Likely [not found] ` <20101117161130.GC5757-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org> 2010-11-17 17:23 ` Mark Brown 2010-11-17 17:23 ` Mark Brown 2010-11-17 17:35 ` Cyril Chemparathy 2010-11-17 17:35 ` Cyril Chemparathy 2010-11-18 5:46 ` Greg KH 2010-11-18 5:46 ` Greg KH 2010-11-25 23:32 ` Rafael J. Wysocki 2010-11-25 23:32 ` Rafael J. Wysocki 2010-11-16 14:19 ` David Brownell 2010-11-16 14:19 ` David Brownell 2010-11-15 19:12 ` [PATCH v5 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 08/12] gpio: add ti-ssp gpio driver Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy [not found] ` <1289848334-8695-9-git-send-email-cyril-l0cyMroinI0@public.gmane.org> 2010-11-15 22:38 ` Ryan Mallon 2010-11-15 22:38 ` Ryan Mallon [not found] ` <4CE1B651.1060006-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org> 2010-11-16 19:38 ` Cyril Chemparathy 2010-11-16 19:38 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 10/12] backlight: add support for tps6116x controller Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy 2010-11-15 19:12 ` [PATCH v5 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy 2010-11-15 19:12 ` Cyril Chemparathy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4CE2AE3C.4040805@ti.com \ --to=cyril-l0cymroini0@public.gmane.org \ --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \ --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \ --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \ --cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \ --cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \ --cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \ --cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \ --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.