* [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
@ 2014-09-09 11:52 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-09 11:52 UTC (permalink / raw)
To: linux-mips
Cc: Markos Chandras, Ricardo Ribalda Delgado, linux-next,
linux-kernel, linux-serial
Commit e676253b19b2d269cccf67fdb1592120a0cd0676
(serial/8250: Add support for RS485 IOCTLs) added cases for the
TIOC{S,G}RS485 commands but this broke the build for MIPS:
drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
(first use in this function)
drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
(first use in this function)
This patch adds these missing definitions
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: <linux-next@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: <linux-serial@vger.kernel.org>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
arch/mips/include/uapi/asm/ioctls.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
index b1e637757fe3..34050cb6b631 100644
--- a/arch/mips/include/uapi/asm/ioctls.h
+++ b/arch/mips/include/uapi/asm/ioctls.h
@@ -76,6 +76,8 @@
#define TIOCSBRK 0x5427 /* BSD compatibility */
#define TIOCCBRK 0x5428 /* BSD compatibility */
+#define TIOCGRS485 0x542E
+#define TIOCSRS485 0x542F
#define TIOCGSID 0x7416 /* Return the session ID of FD */
#define TCGETS2 _IOR('T', 0x2A, struct termios2)
#define TCSETS2 _IOW('T', 0x2B, struct termios2)
--
2.1.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
@ 2014-09-09 11:52 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-09 11:52 UTC (permalink / raw)
To: linux-mips
Cc: Markos Chandras, Ricardo Ribalda Delgado, linux-next,
linux-kernel, linux-serial
Commit e676253b19b2d269cccf67fdb1592120a0cd0676
(serial/8250: Add support for RS485 IOCTLs) added cases for the
TIOC{S,G}RS485 commands but this broke the build for MIPS:
drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
(first use in this function)
drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
(first use in this function)
This patch adds these missing definitions
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: <linux-next@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: <linux-serial@vger.kernel.org>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
arch/mips/include/uapi/asm/ioctls.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
index b1e637757fe3..34050cb6b631 100644
--- a/arch/mips/include/uapi/asm/ioctls.h
+++ b/arch/mips/include/uapi/asm/ioctls.h
@@ -76,6 +76,8 @@
#define TIOCSBRK 0x5427 /* BSD compatibility */
#define TIOCCBRK 0x5428 /* BSD compatibility */
+#define TIOCGRS485 0x542E
+#define TIOCSRS485 0x542F
#define TIOCGSID 0x7416 /* Return the session ID of FD */
#define TCGETS2 _IOR('T', 0x2A, struct termios2)
#define TCSETS2 _IOW('T', 0x2B, struct termios2)
--
2.1.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
2014-09-09 11:52 ` Markos Chandras
(?)
@ 2014-09-09 19:17 ` Greg KH
2014-09-10 8:25 ` Markos Chandras
-1 siblings, 1 reply; 11+ messages in thread
From: Greg KH @ 2014-09-09 19:17 UTC (permalink / raw)
To: Markos Chandras
Cc: linux-mips, Ricardo Ribalda Delgado, linux-next, linux-kernel,
linux-serial
On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
> (serial/8250: Add support for RS485 IOCTLs) added cases for the
> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>
> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
> (first use in this function)
> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
> (first use in this function)
>
> This patch adds these missing definitions
>
> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Cc: <linux-next@vger.kernel.org>
> Cc: <linux-kernel@vger.kernel.org>
> Cc: <linux-serial@vger.kernel.org>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> arch/mips/include/uapi/asm/ioctls.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
> index b1e637757fe3..34050cb6b631 100644
> --- a/arch/mips/include/uapi/asm/ioctls.h
> +++ b/arch/mips/include/uapi/asm/ioctls.h
> @@ -76,6 +76,8 @@
>
> #define TIOCSBRK 0x5427 /* BSD compatibility */
> #define TIOCCBRK 0x5428 /* BSD compatibility */
> +#define TIOCGRS485 0x542E
> +#define TIOCSRS485 0x542F
Any reason you aren't using the _IOR() type macros here?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
2014-09-09 19:17 ` Greg KH
@ 2014-09-10 8:25 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-10 8:25 UTC (permalink / raw)
To: Greg KH
Cc: linux-mips, Ricardo Ribalda Delgado, linux-next, linux-kernel,
linux-serial
On 09/09/2014 08:17 PM, Greg KH wrote:
> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
>> (serial/8250: Add support for RS485 IOCTLs) added cases for the
>> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>>
>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
>> (first use in this function)
>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
>> (first use in this function)
>>
>> This patch adds these missing definitions
>>
>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> Cc: <linux-next@vger.kernel.org>
>> Cc: <linux-kernel@vger.kernel.org>
>> Cc: <linux-serial@vger.kernel.org>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> arch/mips/include/uapi/asm/ioctls.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
>> index b1e637757fe3..34050cb6b631 100644
>> --- a/arch/mips/include/uapi/asm/ioctls.h
>> +++ b/arch/mips/include/uapi/asm/ioctls.h
>> @@ -76,6 +76,8 @@
>>
>> #define TIOCSBRK 0x5427 /* BSD compatibility */
>> #define TIOCCBRK 0x5428 /* BSD compatibility */
>> +#define TIOCGRS485 0x542E
>> +#define TIOCSRS485 0x542F
>
> Any reason you aren't using the _IOR() type macros here?
>
> thanks,
>
> greg k-h
>
Hi Greg,
Not really. I am being consistent with what
include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch
that was posted yesterday
https://lkml.org/lkml/2014/9/9/27
--
markos
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
@ 2014-09-10 8:25 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-10 8:25 UTC (permalink / raw)
To: Greg KH
Cc: linux-mips, Ricardo Ribalda Delgado, linux-next, linux-kernel,
linux-serial
On 09/09/2014 08:17 PM, Greg KH wrote:
> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
>> (serial/8250: Add support for RS485 IOCTLs) added cases for the
>> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>>
>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
>> (first use in this function)
>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
>> (first use in this function)
>>
>> This patch adds these missing definitions
>>
>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> Cc: <linux-next@vger.kernel.org>
>> Cc: <linux-kernel@vger.kernel.org>
>> Cc: <linux-serial@vger.kernel.org>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>> arch/mips/include/uapi/asm/ioctls.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
>> index b1e637757fe3..34050cb6b631 100644
>> --- a/arch/mips/include/uapi/asm/ioctls.h
>> +++ b/arch/mips/include/uapi/asm/ioctls.h
>> @@ -76,6 +76,8 @@
>>
>> #define TIOCSBRK 0x5427 /* BSD compatibility */
>> #define TIOCCBRK 0x5428 /* BSD compatibility */
>> +#define TIOCGRS485 0x542E
>> +#define TIOCSRS485 0x542F
>
> Any reason you aren't using the _IOR() type macros here?
>
> thanks,
>
> greg k-h
>
Hi Greg,
Not really. I am being consistent with what
include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch
that was posted yesterday
https://lkml.org/lkml/2014/9/9/27
--
markos
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
2014-09-10 8:25 ` Markos Chandras
(?)
@ 2014-09-10 8:39 ` Ricardo Ribalda Delgado
2014-09-10 8:45 ` Markos Chandras
-1 siblings, 1 reply; 11+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-09-10 8:39 UTC (permalink / raw)
To: Markos Chandras; +Cc: Greg KH, linux-mips, linux-next, LKML, linux-serial
Hello Greg
Sorry, Probably my bad :). I did resend a new patch using the _IO*
macros, that has been now merged to tty-next
Regards!
On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> On 09/09/2014 08:17 PM, Greg KH wrote:
>> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
>>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
>>> (serial/8250: Add support for RS485 IOCTLs) added cases for the
>>> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>>>
>>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
>>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
>>> (first use in this function)
>>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
>>> (first use in this function)
>>>
>>> This patch adds these missing definitions
>>>
>>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>>> Cc: <linux-next@vger.kernel.org>
>>> Cc: <linux-kernel@vger.kernel.org>
>>> Cc: <linux-serial@vger.kernel.org>
>>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>>> ---
>>> arch/mips/include/uapi/asm/ioctls.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
>>> index b1e637757fe3..34050cb6b631 100644
>>> --- a/arch/mips/include/uapi/asm/ioctls.h
>>> +++ b/arch/mips/include/uapi/asm/ioctls.h
>>> @@ -76,6 +76,8 @@
>>>
>>> #define TIOCSBRK 0x5427 /* BSD compatibility */
>>> #define TIOCCBRK 0x5428 /* BSD compatibility */
>>> +#define TIOCGRS485 0x542E
>>> +#define TIOCSRS485 0x542F
>>
>> Any reason you aren't using the _IOR() type macros here?
>>
>> thanks,
>>
>> greg k-h
>>
> Hi Greg,
>
> Not really. I am being consistent with what
> include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch
> that was posted yesterday
>
> https://lkml.org/lkml/2014/9/9/27
>
> --
> markos
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
2014-09-10 8:39 ` Ricardo Ribalda Delgado
@ 2014-09-10 8:45 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-10 8:45 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Greg KH, linux-mips, linux-next, LKML, linux-serial
On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote:
> Hello Greg
>
> Sorry, Probably my bad :). I did resend a new patch using the _IO*
> macros, that has been now merged to tty-next
>
> Regards!
>
> On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras
> <Markos.Chandras@imgtec.com> wrote:
>> On 09/09/2014 08:17 PM, Greg KH wrote:
>>> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
>>>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
>>>> (serial/8250: Add support for RS485 IOCTLs) added cases for the
>>>> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>>>>
>>>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
>>>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
>>>> (first use in this function)
>>>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
>>>> (first use in this function)
>>>>
>>>> This patch adds these missing definitions
>>>>
>>>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>>>> Cc: <linux-next@vger.kernel.org>
>>>> Cc: <linux-kernel@vger.kernel.org>
>>>> Cc: <linux-serial@vger.kernel.org>
>>>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>>>> ---
>>>> arch/mips/include/uapi/asm/ioctls.h | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
>>>> index b1e637757fe3..34050cb6b631 100644
>>>> --- a/arch/mips/include/uapi/asm/ioctls.h
>>>> +++ b/arch/mips/include/uapi/asm/ioctls.h
>>>> @@ -76,6 +76,8 @@
>>>>
>>>> #define TIOCSBRK 0x5427 /* BSD compatibility */
>>>> #define TIOCCBRK 0x5428 /* BSD compatibility */
>>>> +#define TIOCGRS485 0x542E
>>>> +#define TIOCSRS485 0x542F
>>>
>>> Any reason you aren't using the _IOR() type macros here?
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>> Hi Greg,
>>
>> Not really. I am being consistent with what
>> include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch
>> that was posted yesterday
>>
>> https://lkml.org/lkml/2014/9/9/27
>>
>> --
>> markos
>
>
>
Hi Ricardo,
Since you are taking care of the same problem on the other
architectures, could you also make a similar patch for MIPS so they can
all get merged via the same tree? Because, right now, MIPS is still broken.
--
markos
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
@ 2014-09-10 8:45 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-10 8:45 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Greg KH, linux-mips, linux-next, LKML, linux-serial
On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote:
> Hello Greg
>
> Sorry, Probably my bad :). I did resend a new patch using the _IO*
> macros, that has been now merged to tty-next
>
> Regards!
>
> On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras
> <Markos.Chandras@imgtec.com> wrote:
>> On 09/09/2014 08:17 PM, Greg KH wrote:
>>> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
>>>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
>>>> (serial/8250: Add support for RS485 IOCTLs) added cases for the
>>>> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>>>>
>>>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
>>>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
>>>> (first use in this function)
>>>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
>>>> (first use in this function)
>>>>
>>>> This patch adds these missing definitions
>>>>
>>>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>>>> Cc: <linux-next@vger.kernel.org>
>>>> Cc: <linux-kernel@vger.kernel.org>
>>>> Cc: <linux-serial@vger.kernel.org>
>>>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>>>> ---
>>>> arch/mips/include/uapi/asm/ioctls.h | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
>>>> index b1e637757fe3..34050cb6b631 100644
>>>> --- a/arch/mips/include/uapi/asm/ioctls.h
>>>> +++ b/arch/mips/include/uapi/asm/ioctls.h
>>>> @@ -76,6 +76,8 @@
>>>>
>>>> #define TIOCSBRK 0x5427 /* BSD compatibility */
>>>> #define TIOCCBRK 0x5428 /* BSD compatibility */
>>>> +#define TIOCGRS485 0x542E
>>>> +#define TIOCSRS485 0x542F
>>>
>>> Any reason you aren't using the _IOR() type macros here?
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>> Hi Greg,
>>
>> Not really. I am being consistent with what
>> include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch
>> that was posted yesterday
>>
>> https://lkml.org/lkml/2014/9/9/27
>>
>> --
>> markos
>
>
>
Hi Ricardo,
Since you are taking care of the same problem on the other
architectures, could you also make a similar patch for MIPS so they can
all get merged via the same tree? Because, right now, MIPS is still broken.
--
markos
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
2014-09-10 8:45 ` Markos Chandras
(?)
@ 2014-09-10 9:05 ` Ricardo Ribalda Delgado
2014-09-10 9:14 ` Markos Chandras
-1 siblings, 1 reply; 11+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-09-10 9:05 UTC (permalink / raw)
To: Markos Chandras; +Cc: Greg KH, linux-mips, linux-next, LKML, linux-serial
Hello Markos
Sorry for the mess. I have already send a new patch for mips using the
_IO* macros
Just to put things a bit into context:
I did made the patch for serial and tested it only in x86. I wrongly
infer that the IOCTLS were defined for all the arches (sorry :S)
Then when the patch was applied on tty-next the build-bot throw some
errors for xtensa, that I fixed without using the IO_ macros
Then you came with your patch,
I realized that this could be wrong for mor arches, so I check the
rest and make patches for them.
Greg then pointed out that I should use _IO instead of numbers, so I
remade my patches using the _IO macros. I did not want to step into
your patch so I did not prepare a new one for mips
All the _IO patches (except mips) are now merged into tty-next.
Hopefully that one also get merged soon :)
Thanks for your help and sorry for any disturbance.
On Wed, Sep 10, 2014 at 10:45 AM, Markos Chandras
<Markos.Chandras@imgtec.com> wrote:
> On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote:
>> Hello Greg
>>
>> Sorry, Probably my bad :). I did resend a new patch using the _IO*
>> macros, that has been now merged to tty-next
>>
>> Regards!
>>
>> On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras
>> <Markos.Chandras@imgtec.com> wrote:
>>> On 09/09/2014 08:17 PM, Greg KH wrote:
>>>> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote:
>>>>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676
>>>>> (serial/8250: Add support for RS485 IOCTLs) added cases for the
>>>>> TIOC{S,G}RS485 commands but this broke the build for MIPS:
>>>>>
>>>>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl':
>>>>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared
>>>>> (first use in this function)
>>>>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared
>>>>> (first use in this function)
>>>>>
>>>>> This patch adds these missing definitions
>>>>>
>>>>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>>>>> Cc: <linux-next@vger.kernel.org>
>>>>> Cc: <linux-kernel@vger.kernel.org>
>>>>> Cc: <linux-serial@vger.kernel.org>
>>>>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>>>>> ---
>>>>> arch/mips/include/uapi/asm/ioctls.h | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h
>>>>> index b1e637757fe3..34050cb6b631 100644
>>>>> --- a/arch/mips/include/uapi/asm/ioctls.h
>>>>> +++ b/arch/mips/include/uapi/asm/ioctls.h
>>>>> @@ -76,6 +76,8 @@
>>>>>
>>>>> #define TIOCSBRK 0x5427 /* BSD compatibility */
>>>>> #define TIOCCBRK 0x5428 /* BSD compatibility */
>>>>> +#define TIOCGRS485 0x542E
>>>>> +#define TIOCSRS485 0x542F
>>>>
>>>> Any reason you aren't using the _IOR() type macros here?
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>>
>>> Hi Greg,
>>>
>>> Not really. I am being consistent with what
>>> include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch
>>> that was posted yesterday
>>>
>>> https://lkml.org/lkml/2014/9/9/27
>>>
>>> --
>>> markos
>>
>>
>>
> Hi Ricardo,
>
> Since you are taking care of the same problem on the other
> architectures, could you also make a similar patch for MIPS so they can
> all get merged via the same tree? Because, right now, MIPS is still broken.
>
> --
> markos
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
2014-09-10 9:05 ` Ricardo Ribalda Delgado
@ 2014-09-10 9:14 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-10 9:14 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Greg KH, linux-mips, linux-next, LKML, linux-serial
On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote:
> Hello Markos
>
> Sorry for the mess. I have already send a new patch for mips using the
> _IO* macros
>
> Just to put things a bit into context:
>
> I did made the patch for serial and tested it only in x86. I wrongly
> infer that the IOCTLS were defined for all the arches (sorry :S)
>
> Then when the patch was applied on tty-next the build-bot throw some
> errors for xtensa, that I fixed without using the IO_ macros
>
> Then you came with your patch,
>
> I realized that this could be wrong for mor arches, so I check the
> rest and make patches for them.
>
> Greg then pointed out that I should use _IO instead of numbers, so I
> remade my patches using the _IO macros. I did not want to step into
> your patch so I did not prepare a new one for mips
>
> All the _IO patches (except mips) are now merged into tty-next.
>
> Hopefully that one also get merged soon :)
>
>
> Thanks for your help and sorry for any disturbance.
>
>
Hi Ricardo,
No problem :) Thanks for taking care of that
--
markos
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions
@ 2014-09-10 9:14 ` Markos Chandras
0 siblings, 0 replies; 11+ messages in thread
From: Markos Chandras @ 2014-09-10 9:14 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Greg KH, linux-mips, linux-next, LKML, linux-serial
On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote:
> Hello Markos
>
> Sorry for the mess. I have already send a new patch for mips using the
> _IO* macros
>
> Just to put things a bit into context:
>
> I did made the patch for serial and tested it only in x86. I wrongly
> infer that the IOCTLS were defined for all the arches (sorry :S)
>
> Then when the patch was applied on tty-next the build-bot throw some
> errors for xtensa, that I fixed without using the IO_ macros
>
> Then you came with your patch,
>
> I realized that this could be wrong for mor arches, so I check the
> rest and make patches for them.
>
> Greg then pointed out that I should use _IO instead of numbers, so I
> remade my patches using the _IO macros. I did not want to step into
> your patch so I did not prepare a new one for mips
>
> All the _IO patches (except mips) are now merged into tty-next.
>
> Hopefully that one also get merged soon :)
>
>
> Thanks for your help and sorry for any disturbance.
>
>
Hi Ricardo,
No problem :) Thanks for taking care of that
--
markos
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-09-10 9:14 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-09 11:52 [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions Markos Chandras
2014-09-09 11:52 ` Markos Chandras
2014-09-09 19:17 ` Greg KH
2014-09-10 8:25 ` Markos Chandras
2014-09-10 8:25 ` Markos Chandras
2014-09-10 8:39 ` Ricardo Ribalda Delgado
2014-09-10 8:45 ` Markos Chandras
2014-09-10 8:45 ` Markos Chandras
2014-09-10 9:05 ` Ricardo Ribalda Delgado
2014-09-10 9:14 ` Markos Chandras
2014-09-10 9:14 ` Markos Chandras
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.