From: Stephen Warren <swarren@wwwdotorg.org> To: Simon Glass <sjg@chromium.org> Cc: devicetree@vger.kernel.org, Stephen Warren <swarren@nvidia.com>, Arnd Bergmann <arnd@arndb.de>, U-Boot Mailing List <u-boot@lists.denx.de>, Joe Hershberger <joe.hershberger@ni.com>, Geert Uytterhoeven <geert@linux-m68k.org> Subject: Re: [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART Date: Mon, 10 Aug 2015 21:57:46 -0600 [thread overview] Message-ID: <55C972BA.5050706@wwwdotorg.org> (raw) In-Reply-To: <1438954951-13329-2-git-send-email-sjg@chromium.org> On 08/07/2015 07:42 AM, Simon Glass wrote: > This binding differs from that of Linux. Update it and change existing > users. Is that meant to imply that this patch fixes the copy of the binding doc in U-Boot so it does match the kernel's copy? > Changes in v3: > - Rename binding file to pl01x.txt The file is named pl011.txt in the kernel. Shouldn't U-Boot's copy be named the same? > diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts > uart0: serial@0x80406000 { > compatible = "arm,pl011", "arm,primecell"; > reg = <0x80406000 0x1000>; > - clock = <2700000>; > + clock-frequency = <2700000>; I don't see either "clock" or "clock-frequency" mentioned in the Linux binding doc. > diff --git a/doc/device-tree-bindings/serial/pl01x.txt b/doc/device-tree-bindings/serial/pl01x.txt > Required properties: > -- compatible: must be "arm,primecell", "arm,pl011" or "arm,pl010" > +- compatible: must be "arm,primecell", "arm,pl011" It'd be worth mentioning which version of Linux this binding doc came from; that text has changed in linux-next since v4.1 which is what I assume you're importing. > diff --git a/drivers/serial/serial_pl01x.c b/drivers/serial/serial_pl01x.c > @@ -365,13 +365,15 @@ static int pl01x_serial_ofdata_to_platdata(struct udevice *dev) > struct pl01x_serial_platdata *plat = dev_get_platdata(dev); > fdt_addr_t addr; > > - addr = fdtdec_get_addr(gd->fdt_blob, dev->of_offset, "reg"); > + addr = dev_get_addr(dev); > if (addr == FDT_ADDR_T_NONE) > return -EINVAL; That looks like an unrelated change.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org> To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART Date: Mon, 10 Aug 2015 21:57:46 -0600 [thread overview] Message-ID: <55C972BA.5050706@wwwdotorg.org> (raw) In-Reply-To: <1438954951-13329-2-git-send-email-sjg@chromium.org> On 08/07/2015 07:42 AM, Simon Glass wrote: > This binding differs from that of Linux. Update it and change existing > users. Is that meant to imply that this patch fixes the copy of the binding doc in U-Boot so it does match the kernel's copy? > Changes in v3: > - Rename binding file to pl01x.txt The file is named pl011.txt in the kernel. Shouldn't U-Boot's copy be named the same? > diff --git a/arch/arm/dts/stv0991.dts b/arch/arm/dts/stv0991.dts > uart0: serial at 0x80406000 { > compatible = "arm,pl011", "arm,primecell"; > reg = <0x80406000 0x1000>; > - clock = <2700000>; > + clock-frequency = <2700000>; I don't see either "clock" or "clock-frequency" mentioned in the Linux binding doc. > diff --git a/doc/device-tree-bindings/serial/pl01x.txt b/doc/device-tree-bindings/serial/pl01x.txt > Required properties: > -- compatible: must be "arm,primecell", "arm,pl011" or "arm,pl010" > +- compatible: must be "arm,primecell", "arm,pl011" It'd be worth mentioning which version of Linux this binding doc came from; that text has changed in linux-next since v4.1 which is what I assume you're importing. > diff --git a/drivers/serial/serial_pl01x.c b/drivers/serial/serial_pl01x.c > @@ -365,13 +365,15 @@ static int pl01x_serial_ofdata_to_platdata(struct udevice *dev) > struct pl01x_serial_platdata *plat = dev_get_platdata(dev); > fdt_addr_t addr; > > - addr = fdtdec_get_addr(gd->fdt_blob, dev->of_offset, "reg"); > + addr = dev_get_addr(dev); > if (addr == FDT_ADDR_T_NONE) > return -EINVAL; That looks like an unrelated change.
next prev parent reply other threads:[~2015-08-11 3:57 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-07 13:42 [PATCH v3 00/11] arm: rpi: Enable USB and Ethernet driver model Raspberry Pi Simon Glass 2015-08-07 13:42 ` [U-Boot] " Simon Glass [not found] ` <1438954951-13329-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-07 13:42 ` [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART Simon Glass 2015-08-07 13:42 ` [U-Boot] " Simon Glass 2015-08-11 3:57 ` Stephen Warren [this message] 2015-08-11 3:57 ` Stephen Warren [not found] ` <55C972BA.5050706-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-08-11 4:11 ` Simon Glass 2015-08-11 4:11 ` [U-Boot] " Simon Glass [not found] ` <CAPnjgZ2XdOPGMfAPHGy4c7vuc+exrirXkZ5DF+wHKGmAPg8ZjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-11 4:24 ` Stephen Warren 2015-08-11 4:24 ` [U-Boot] " Stephen Warren [not found] ` <1438954951-13329-2-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-11 13:00 ` Linus Walleij 2015-08-11 13:00 ` [U-Boot] " Linus Walleij [not found] ` <CACRpkdZa2O1MqCVT8q2P0u0ciXK+6HFbQQGXB_-chimg=FbzQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-13 15:59 ` Simon Glass 2015-08-13 15:59 ` [U-Boot] " Simon Glass [not found] ` <CAPnjgZ3V1KS7POEhsvj63OSB29MUtyaZGBoFR8JGPnaN=-fXVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-13 16:02 ` Stephen Warren 2015-08-13 16:02 ` [U-Boot] " Stephen Warren 2015-08-13 18:13 ` Tom Rini 2015-08-13 18:13 ` [U-Boot] " Tom Rini 2015-08-13 19:04 ` Ian Lepore 2015-08-13 19:04 ` Ian Lepore [not found] ` <1439492679.242.35.camel-h+KGxgPPiopAfugRpC6u6w@public.gmane.org> 2015-08-13 19:37 ` Stephen Warren 2015-08-13 19:37 ` Stephen Warren [not found] ` <55CCF20C.9000104-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-08-14 7:43 ` Geert Uytterhoeven 2015-08-14 7:43 ` Geert Uytterhoeven 2015-08-14 10:22 ` Linus Walleij 2015-08-14 10:22 ` Linus Walleij 2015-08-14 14:27 ` Rob Herring 2015-08-14 14:27 ` Rob Herring [not found] ` <CAL_JsqL8tcECpdwCxatd6ULS8z0UU160OXr8S0ZGTTRRrUaeSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-14 17:45 ` Ian Lepore 2015-08-14 17:45 ` Ian Lepore [not found] ` <1439574356.242.60.camel-h+KGxgPPiopAfugRpC6u6w@public.gmane.org> 2015-08-14 18:42 ` Stephen Warren 2015-08-14 18:42 ` Stephen Warren 2015-08-17 7:46 ` Linus Walleij 2015-08-17 7:46 ` Linus Walleij 2015-08-14 19:32 ` Pantelis Antoniou 2015-08-14 19:32 ` [U-Boot] " Pantelis Antoniou 2015-08-13 22:24 ` Rob Herring 2015-08-13 22:24 ` [U-Boot] " Rob Herring 2015-08-07 13:42 ` [U-Boot] [PATCH v3 02/11] arm: rpi: Define CONFIG_TFTP_TSIZE to show tftp size info Simon Glass 2015-08-11 3:58 ` Stephen Warren 2016-05-23 15:39 ` Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 03/11] arm: rpi: Bring in kernel device tree files Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 04/11] arm: rpi: Device tree modifications for U-Boot Simon Glass 2015-08-11 4:00 ` Stephen Warren 2015-08-11 4:17 ` Simon Glass 2015-08-11 4:25 ` Stephen Warren 2015-08-12 13:28 ` Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 05/11] arm: rpi: Add device tree files for Raspberry Pi 2 Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 06/11] arm: rpi: Enable device tree control for Rasberry Pi Simon Glass 2015-08-11 3:47 ` Stephen Warren 2015-08-14 19:20 ` Simon Glass 2015-08-15 3:32 ` Stephen Warren 2015-08-15 13:59 ` Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 07/11] arm: rpi: Enable device tree control for Rasberry Pi 2 Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 08/11] arm: rpi: Drop the UART console platform data Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 09/11] arm: rpi: Drop the GPIO " Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 10/11] arm: rpi: Move to driver model for USB Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 11/11] arm: rpi: Use driver model for Ethernet Simon Glass
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55C972BA.5050706@wwwdotorg.org \ --to=swarren@wwwdotorg.org \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=joe.hershberger@ni.com \ --cc=sjg@chromium.org \ --cc=swarren@nvidia.com \ --cc=u-boot@lists.denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.