From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, U-Boot Mailing List <u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>, Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Joe Hershberger <joe.hershberger-acOepvfBmUk@public.gmane.org>, Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Pavel Herrmann <morpheus.ibis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Vikas Manocha <vikas.manocha-qxv4g6HH51o@public.gmane.org>, Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> Subject: Re: [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART Date: Thu, 13 Aug 2015 17:24:49 -0500 [thread overview] Message-ID: <CAL_JsqL2bn5Dop1oNsHNx6zgAohAfCS99BA4EiU16aG_c5AjsA@mail.gmail.com> (raw) In-Reply-To: <CAPnjgZ3V1KS7POEhsvj63OSB29MUtyaZGBoFR8JGPnaN=-fXVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Thu, Aug 13, 2015 at 10:59 AM, Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote: > Hi Linus, > > On 11 August 2015 at 07:00, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: >> On Fri, Aug 7, 2015 at 3:42 PM, Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote: >> >>> This binding differs from that of Linux. Update it and change existing >>> users. >>> >>> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> >> (...) >>> doc/device-tree-bindings/serial/pl01x.txt | 55 ++++++++++++++++++++++++++++--- >> >> So why does U-Boot have its own copy of any bindings at all? >> >> This is forking the ontology of who gets to define bindings I fear. >> It's a bit like have two bibles both claiming to be the word of god. >> (OK maybe a hyperbolic statement, but you see what I mean.) >> >> Can't we just have the bindings in the Linux kernel tree please? Yes, please! > Is there any plan to move them out of Linux and put them in a separate place? There is a tree generated from the kernel tree which is only bindings and dts files[1]. The path in for changes though is still thru the kernel. Actually splitting it out to an independent repo will require someone stepping up to do that. Perhaps as an intermediate step, we could take patches against the generated tree, apply path fixups, and merge thru the kernel tree. > We should make an effort to sync the device tree files with Linux periodically. > > I quite like having the bindings in U-Boot since it makes people think > about what they are adding. Are you worried that the bindings in > U-Boot might evolve separately? Certainly there has been some of that. Certainly, having driver binding related changes decoupled from binding documentation makes things harder to review. > However I recently sent a series to add a few things for Raspberry Pi > ("arm: rpi: Device tree modifications for U-Boot") and I don't yet see > a willingness to add what some see as 'U-Boot things' to the binding. > How do we address that? I went and looked at it. I don't have a big problem with "u-boot,?" in principle, but like any linux,? property they are a red flag and get extra scrutiny. You didn't explain what the binding was for, so I've got no idea on the one in question. Rob [1] http://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com> To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART Date: Thu, 13 Aug 2015 17:24:49 -0500 [thread overview] Message-ID: <CAL_JsqL2bn5Dop1oNsHNx6zgAohAfCS99BA4EiU16aG_c5AjsA@mail.gmail.com> (raw) In-Reply-To: <CAPnjgZ3V1KS7POEhsvj63OSB29MUtyaZGBoFR8JGPnaN=-fXVw@mail.gmail.com> On Thu, Aug 13, 2015 at 10:59 AM, Simon Glass <sjg@chromium.org> wrote: > Hi Linus, > > On 11 August 2015 at 07:00, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Fri, Aug 7, 2015 at 3:42 PM, Simon Glass <sjg@chromium.org> wrote: >> >>> This binding differs from that of Linux. Update it and change existing >>> users. >>> >>> Signed-off-by: Simon Glass <sjg@chromium.org> >> (...) >>> doc/device-tree-bindings/serial/pl01x.txt | 55 ++++++++++++++++++++++++++++--- >> >> So why does U-Boot have its own copy of any bindings at all? >> >> This is forking the ontology of who gets to define bindings I fear. >> It's a bit like have two bibles both claiming to be the word of god. >> (OK maybe a hyperbolic statement, but you see what I mean.) >> >> Can't we just have the bindings in the Linux kernel tree please? Yes, please! > Is there any plan to move them out of Linux and put them in a separate place? There is a tree generated from the kernel tree which is only bindings and dts files[1]. The path in for changes though is still thru the kernel. Actually splitting it out to an independent repo will require someone stepping up to do that. Perhaps as an intermediate step, we could take patches against the generated tree, apply path fixups, and merge thru the kernel tree. > We should make an effort to sync the device tree files with Linux periodically. > > I quite like having the bindings in U-Boot since it makes people think > about what they are adding. Are you worried that the bindings in > U-Boot might evolve separately? Certainly there has been some of that. Certainly, having driver binding related changes decoupled from binding documentation makes things harder to review. > However I recently sent a series to add a few things for Raspberry Pi > ("arm: rpi: Device tree modifications for U-Boot") and I don't yet see > a willingness to add what some see as 'U-Boot things' to the binding. > How do we address that? I went and looked at it. I don't have a big problem with "u-boot,?" in principle, but like any linux,? property they are a red flag and get extra scrutiny. You didn't explain what the binding was for, so I've got no idea on the one in question. Rob [1] http://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git
next prev parent reply other threads:[~2015-08-13 22:24 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-07 13:42 [PATCH v3 00/11] arm: rpi: Enable USB and Ethernet driver model Raspberry Pi Simon Glass 2015-08-07 13:42 ` [U-Boot] " Simon Glass [not found] ` <1438954951-13329-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-07 13:42 ` [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART Simon Glass 2015-08-07 13:42 ` [U-Boot] " Simon Glass 2015-08-11 3:57 ` Stephen Warren 2015-08-11 3:57 ` [U-Boot] " Stephen Warren [not found] ` <55C972BA.5050706-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-08-11 4:11 ` Simon Glass 2015-08-11 4:11 ` [U-Boot] " Simon Glass [not found] ` <CAPnjgZ2XdOPGMfAPHGy4c7vuc+exrirXkZ5DF+wHKGmAPg8ZjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-11 4:24 ` Stephen Warren 2015-08-11 4:24 ` [U-Boot] " Stephen Warren [not found] ` <1438954951-13329-2-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2015-08-11 13:00 ` Linus Walleij 2015-08-11 13:00 ` [U-Boot] " Linus Walleij [not found] ` <CACRpkdZa2O1MqCVT8q2P0u0ciXK+6HFbQQGXB_-chimg=FbzQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-13 15:59 ` Simon Glass 2015-08-13 15:59 ` [U-Boot] " Simon Glass [not found] ` <CAPnjgZ3V1KS7POEhsvj63OSB29MUtyaZGBoFR8JGPnaN=-fXVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-13 16:02 ` Stephen Warren 2015-08-13 16:02 ` [U-Boot] " Stephen Warren 2015-08-13 18:13 ` Tom Rini 2015-08-13 18:13 ` [U-Boot] " Tom Rini 2015-08-13 19:04 ` Ian Lepore 2015-08-13 19:04 ` Ian Lepore [not found] ` <1439492679.242.35.camel-h+KGxgPPiopAfugRpC6u6w@public.gmane.org> 2015-08-13 19:37 ` Stephen Warren 2015-08-13 19:37 ` Stephen Warren [not found] ` <55CCF20C.9000104-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2015-08-14 7:43 ` Geert Uytterhoeven 2015-08-14 7:43 ` Geert Uytterhoeven 2015-08-14 10:22 ` Linus Walleij 2015-08-14 10:22 ` Linus Walleij 2015-08-14 14:27 ` Rob Herring 2015-08-14 14:27 ` Rob Herring [not found] ` <CAL_JsqL8tcECpdwCxatd6ULS8z0UU160OXr8S0ZGTTRRrUaeSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-08-14 17:45 ` Ian Lepore 2015-08-14 17:45 ` Ian Lepore [not found] ` <1439574356.242.60.camel-h+KGxgPPiopAfugRpC6u6w@public.gmane.org> 2015-08-14 18:42 ` Stephen Warren 2015-08-14 18:42 ` Stephen Warren 2015-08-17 7:46 ` Linus Walleij 2015-08-17 7:46 ` Linus Walleij 2015-08-14 19:32 ` Pantelis Antoniou 2015-08-14 19:32 ` [U-Boot] " Pantelis Antoniou 2015-08-13 22:24 ` Rob Herring [this message] 2015-08-13 22:24 ` Rob Herring 2015-08-07 13:42 ` [U-Boot] [PATCH v3 02/11] arm: rpi: Define CONFIG_TFTP_TSIZE to show tftp size info Simon Glass 2015-08-11 3:58 ` Stephen Warren 2016-05-23 15:39 ` Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 03/11] arm: rpi: Bring in kernel device tree files Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 04/11] arm: rpi: Device tree modifications for U-Boot Simon Glass 2015-08-11 4:00 ` Stephen Warren 2015-08-11 4:17 ` Simon Glass 2015-08-11 4:25 ` Stephen Warren 2015-08-12 13:28 ` Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 05/11] arm: rpi: Add device tree files for Raspberry Pi 2 Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 06/11] arm: rpi: Enable device tree control for Rasberry Pi Simon Glass 2015-08-11 3:47 ` Stephen Warren 2015-08-14 19:20 ` Simon Glass 2015-08-15 3:32 ` Stephen Warren 2015-08-15 13:59 ` Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 07/11] arm: rpi: Enable device tree control for Rasberry Pi 2 Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 08/11] arm: rpi: Drop the UART console platform data Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 09/11] arm: rpi: Drop the GPIO " Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 10/11] arm: rpi: Move to driver model for USB Simon Glass 2015-08-07 13:42 ` [U-Boot] [PATCH v3 11/11] arm: rpi: Use driver model for Ethernet Simon Glass
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAL_JsqL2bn5Dop1oNsHNx6zgAohAfCS99BA4EiU16aG_c5AjsA@mail.gmail.com \ --to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=arnd-r2nGTMty4D4@public.gmane.org \ --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \ --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=joe.hershberger-acOepvfBmUk@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=morpheus.ibis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \ --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \ --cc=vikas.manocha-qxv4g6HH51o@public.gmane.org \ --cc=yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.