All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vz@mleia.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Russell King <linux@arm.linux.org.uk>,
	Roland Stigge <stigge@antcom.de>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/11] dt-bindings: clock: add NXP LPC32xx clock list for consumers
Date: Fri, 20 Nov 2015 19:58:06 +0200	[thread overview]
Message-ID: <564F5F2E.70607@mleia.com> (raw)
In-Reply-To: <4268221.QhjAE5RLYk@wuerfel>

On 20.11.2015 15:56, Arnd Bergmann wrote:
> On Friday 20 November 2015 03:05:03 Vladimir Zapolskiy wrote:
>> +
>> +/* LPC32XX System Control Block clocks */
>> +#define LPC32XX_CLK_RTC                0
>> +#define LPC32XX_CLK_DMA                1
>> +#define LPC32XX_CLK_MLC                2
>> +#define LPC32XX_CLK_SLC                3
>> +#define LPC32XX_CLK_LCD                4
>> +#define LPC32XX_CLK_MAC                5
>> +#define LPC32XX_CLK_SD         6
>> +#define LPC32XX_CLK_DDRAM      7
>> +#define LPC32XX_CLK_SSP0       8
>> +#define LPC32XX_CLK_SSP1       9
>> +#define LPC32XX_CLK_UART3      10
>> +#define LPC32XX_CLK_UART4      11
>> +#define LPC32XX_CLK_UART5      12
>> +#define LPC32XX_CLK_UART6      13
>> +#define LPC32XX_CLK_IRDA       14
>> +#define LPC32XX_CLK_I2C1       15
>>
> 
> Any chance we can avoid the include file? This is going to make it really
> hard to merge everything in one merge window with the dependencies between
> the driver, the bindings and the platform code.

I see only one option to avoid this commit, namely squash it with the
CCF driver and merge it before making changes in DTS.

However I suppose ARM trees won't be synced on clk tree, so probably it
won't simplify maintainer's work.

> If there is a way to describe the clocks based on numbers from the
> data sheet instead of making up your own, that makes life much
> easier for us.

There are no any clock numbers in the datasheet, unfortunately.

--
Vladimir

WARNING: multiple messages have this Message-ID (diff)
From: vz@mleia.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/11] dt-bindings: clock: add NXP LPC32xx clock list for consumers
Date: Fri, 20 Nov 2015 19:58:06 +0200	[thread overview]
Message-ID: <564F5F2E.70607@mleia.com> (raw)
In-Reply-To: <4268221.QhjAE5RLYk@wuerfel>

On 20.11.2015 15:56, Arnd Bergmann wrote:
> On Friday 20 November 2015 03:05:03 Vladimir Zapolskiy wrote:
>> +
>> +/* LPC32XX System Control Block clocks */
>> +#define LPC32XX_CLK_RTC                0
>> +#define LPC32XX_CLK_DMA                1
>> +#define LPC32XX_CLK_MLC                2
>> +#define LPC32XX_CLK_SLC                3
>> +#define LPC32XX_CLK_LCD                4
>> +#define LPC32XX_CLK_MAC                5
>> +#define LPC32XX_CLK_SD         6
>> +#define LPC32XX_CLK_DDRAM      7
>> +#define LPC32XX_CLK_SSP0       8
>> +#define LPC32XX_CLK_SSP1       9
>> +#define LPC32XX_CLK_UART3      10
>> +#define LPC32XX_CLK_UART4      11
>> +#define LPC32XX_CLK_UART5      12
>> +#define LPC32XX_CLK_UART6      13
>> +#define LPC32XX_CLK_IRDA       14
>> +#define LPC32XX_CLK_I2C1       15
>>
> 
> Any chance we can avoid the include file? This is going to make it really
> hard to merge everything in one merge window with the dependencies between
> the driver, the bindings and the platform code.

I see only one option to avoid this commit, namely squash it with the
CCF driver and merge it before making changes in DTS.

However I suppose ARM trees won't be synced on clk tree, so probably it
won't simplify maintainer's work.

> If there is a way to describe the clocks based on numbers from the
> data sheet instead of making up your own, that makes life much
> easier for us.

There are no any clock numbers in the datasheet, unfortunately.

--
Vladimir

  reply	other threads:[~2015-11-20 17:58 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  1:05 [PATCH 00/11] clk: lpc32xx: add clock support for NXP LPC32xx Vladimir Zapolskiy
2015-11-20  1:05 ` Vladimir Zapolskiy
2015-11-20  1:05 ` Vladimir Zapolskiy
2015-11-20  1:05 ` [PATCH 02/11] dt-bindings: clock: add description of LPC32xx USB clock controller Vladimir Zapolskiy
2015-11-20  1:05   ` Vladimir Zapolskiy
2015-11-20 16:41   ` Rob Herring
2015-11-20 16:41     ` Rob Herring
2015-11-20 18:14     ` Vladimir Zapolskiy
2015-11-20 18:14       ` Vladimir Zapolskiy
2015-11-20  1:05 ` [PATCH 03/11] dt-bindings: clock: add NXP LPC32xx clock list for consumers Vladimir Zapolskiy
2015-11-20  1:05   ` Vladimir Zapolskiy
2015-11-20 13:56   ` Arnd Bergmann
2015-11-20 13:56     ` Arnd Bergmann
2015-11-20 13:56     ` Arnd Bergmann
2015-11-20 17:58     ` Vladimir Zapolskiy [this message]
2015-11-20 17:58       ` Vladimir Zapolskiy
2015-11-20 21:07       ` Arnd Bergmann
2015-11-20 21:07         ` Arnd Bergmann
2015-11-21 18:53         ` Vladimir Zapolskiy
2015-11-21 18:53           ` Vladimir Zapolskiy
2015-11-20  1:05 ` [PATCH 04/11] arm: dts: lpc32xx: add device nodes for external oscillators Vladimir Zapolskiy
2015-11-20  1:05   ` Vladimir Zapolskiy
2015-11-20  1:05 ` [PATCH 05/11] arm: dts: lpc32xx: add clock controller device node Vladimir Zapolskiy
2015-11-20  1:05   ` Vladimir Zapolskiy
     [not found] ` <1447981511-29653-1-git-send-email-vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2015-11-20  1:05   ` [PATCH 01/11] dt-bindings: clock: add description of LPC32xx clock controller Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20 13:58     ` Arnd Bergmann
2015-11-20 13:58       ` Arnd Bergmann
2015-11-20 18:01       ` Vladimir Zapolskiy
2015-11-20 18:01         ` Vladimir Zapolskiy
2015-11-20 18:01         ` Vladimir Zapolskiy
2015-11-20 20:03         ` Arnd Bergmann
2015-11-20 20:03           ` Arnd Bergmann
2015-11-20  1:05   ` [PATCH 06/11] arm: dts: lpc32xx: add clock properties to device nodes Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05   ` [PATCH 07/11] arm: dts: lpc32xx: add USB clock controller Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05   ` [PATCH 08/11] clk: lpc18xx: add NXP specific common clock framework selection Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-22 20:38     ` Joachim Eastwood
2015-11-22 20:38       ` Joachim Eastwood
2015-11-22 20:38       ` Joachim Eastwood
2015-11-20  1:05   ` [PATCH 11/11] arm: dts: lpc32xx: remove clock frequency property from UART device nodes Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05     ` Vladimir Zapolskiy
2015-11-20  1:05 ` [PATCH 09/11] clk: lpc32xx: add common clock framework driver Vladimir Zapolskiy
2015-11-20  1:05   ` Vladimir Zapolskiy
2015-11-20 14:04   ` Arnd Bergmann
2015-11-20 14:04     ` Arnd Bergmann
2015-11-20 18:07     ` Vladimir Zapolskiy
2015-11-20 18:07       ` Vladimir Zapolskiy
2015-11-20 18:07       ` Vladimir Zapolskiy
2015-11-20 20:20       ` Arnd Bergmann
2015-11-20 20:20         ` Arnd Bergmann
2015-11-29 13:00         ` Vladimir Zapolskiy
2015-11-29 13:00           ` Vladimir Zapolskiy
2015-11-20  1:05 ` [PATCH 10/11] arm: lpc32xx: switch to common clock framework Vladimir Zapolskiy
2015-11-20  1:05   ` Vladimir Zapolskiy
2016-02-09 21:01 ` [PATCH 00/11] clk: lpc32xx: add clock support for NXP LPC32xx Sylvain Lemieux
     [not found]   ` <loom.20160209T215103-78-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2016-02-10  0:19     ` Vladimir Zapolskiy
2016-02-10  0:19       ` Vladimir Zapolskiy
     [not found]       ` <56BA81F7.4080006-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2016-02-10 14:25         ` Sylvain Lemieux
2016-02-10 14:25           ` Sylvain Lemieux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564F5F2E.70607@mleia.com \
    --to=vz@mleia.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=stigge@antcom.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.