Re: [PATCH 08/11] clk: lpc18xx: add NXP specific common clock framework selection

[Joachim Eastwood <manabian@gmail.com>]

Hi Vladimir,

On 20 November 2015 at 02:05, Vladimir Zapolskiy <vz@mleia.com> wrote:
> The change adds COMMON_CLK_NXP configuration symbol and enables it for
> NXP LPC18XX architecture, this is needed to reuse drivers/clk/nxp
> folder for NXP common clock framework drivers other than LPC18XX one.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Joachim Eastwood <manabian@gmail.com>
> ---
>  arch/arm/Kconfig     | 1 +
>  drivers/clk/Kconfig  | 5 +++++
>  drivers/clk/Makefile | 2 +-
>  3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 0365cbb..c318277 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -952,6 +952,7 @@ config ARCH_LPC18XX
>         select ARCH_HAS_RESET_CONTROLLER
>         select ARM_AMBA
>         select CLKSRC_LPC32XX
> +       select COMMON_CLK

COMMON_CLK is already selected by ARM_SINGLE_ARMV7M which ARCH_LPC18XX
depends on so this hunk should not be necessary.

>         select PINCTRL
>         help
>           Support for NXP's LPC18xx Cortex-M3 and LPC43xx Cortex-M4
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c3e3a02..7fc1eb9 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -175,6 +175,11 @@ config COMMON_CLK_PWM
>           Adapter driver so that any PWM output can be (mis)used as clock signal
>           at 50% duty cycle.
>
> +config COMMON_CLK_NXP
> +       def_bool COMMON_CLK && ARCH_LPC18XX
> +       ---help---
> +         Support for clock providers on NXP platforms.
> +
>  config COMMON_CLK_PXA
>         def_bool COMMON_CLK && ARCH_PXA
>         ---help---
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index 820714c..15603c1 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -62,8 +62,8 @@ endif
>  obj-$(CONFIG_PLAT_ORION)               += mvebu/
>  obj-$(CONFIG_ARCH_MESON)               += meson/
>  obj-$(CONFIG_ARCH_MXS)                 += mxs/
> -obj-$(CONFIG_ARCH_LPC18XX)             += nxp/
>  obj-$(CONFIG_MACH_PISTACHIO)           += pistachio/
> +obj-$(CONFIG_COMMON_CLK_NXP)           += nxp/
>  obj-$(CONFIG_COMMON_CLK_PXA)           += pxa/
>  obj-$(CONFIG_COMMON_CLK_QCOM)          += qcom/
>  obj-$(CONFIG_ARCH_ROCKCHIP)            += rockchip/
> --

Other than the one comment above it looks good to me:
Acked-by: Joachim Eastwood <manabian@gmail.com>

I'll try to find the time look through the other patches you have for
lpc32xx. I also have a EA LPC3250 dev kit v2
(http://embeddedartists.com/products/kits/lpc3250_kit_v2.php) in my
collection.

regards,
Joachim Eastwood