* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-12 21:03 ` Arnd Bergmann
0 siblings, 0 replies; 22+ messages in thread
From: Arnd Bergmann @ 2016-05-12 21:03 UTC (permalink / raw)
To: Jason Cooper
Cc: Noam Camus, Vineet Gupta, linux-snps-arc, Arnd Bergmann,
Thomas Gleixner, Marc Zyngier, linux-kernel
The newly added nps irqchip driver causes build warnings on ARM64.
include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
As the driver is only used on ARC, we don't need to see it without
COMPILE_TEST elsewhere, and we can avoid the warnings by only
building on 32-bit architectures even with CONFIG_COMPILE_TEST.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 83775f148158..37289cf6b449 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -253,6 +253,7 @@ config MVEBU_ODMI
config EZNPS_GIC
bool "NPS400 Global Interrupt Manager (GIM)"
+ depends on ARC || (COMPILE_TEST && !64BIT)
select IRQ_DOMAIN
help
Support the EZchip NPS400 global interrupt controller
--
2.7.0
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-12 21:03 ` Arnd Bergmann
0 siblings, 0 replies; 22+ messages in thread
From: Arnd Bergmann @ 2016-05-12 21:03 UTC (permalink / raw)
To: linux-snps-arc
The newly added nps irqchip driver causes build warnings on ARM64.
include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
As the driver is only used on ARC, we don't need to see it without
COMPILE_TEST elsewhere, and we can avoid the warnings by only
building on 32-bit architectures even with CONFIG_COMPILE_TEST.
Signed-off-by: Arnd Bergmann <arnd at arndb.de>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 83775f148158..37289cf6b449 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -253,6 +253,7 @@ config MVEBU_ODMI
config EZNPS_GIC
bool "NPS400 Global Interrupt Manager (GIM)"
+ depends on ARC || (COMPILE_TEST && !64BIT)
select IRQ_DOMAIN
help
Support the EZchip NPS400 global interrupt controller
--
2.7.0
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-12 21:03 ` Arnd Bergmann
@ 2016-05-13 8:24 ` Marc Zyngier
-1 siblings, 0 replies; 22+ messages in thread
From: Marc Zyngier @ 2016-05-13 8:24 UTC (permalink / raw)
To: Arnd Bergmann, Jason Cooper
Cc: Noam Camus, Vineet Gupta, linux-snps-arc, Thomas Gleixner, linux-kernel
On 12/05/16 22:03, Arnd Bergmann wrote:
> The newly added nps irqchip driver causes build warnings on ARM64.
>
> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> As the driver is only used on ARC, we don't need to see it without
> COMPILE_TEST elsewhere, and we can avoid the warnings by only
> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 83775f148158..37289cf6b449 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>
> config EZNPS_GIC
> bool "NPS400 Global Interrupt Manager (GIM)"
> + depends on ARC || (COMPILE_TEST && !64BIT)
> select IRQ_DOMAIN
> help
> Support the EZchip NPS400 global interrupt controller
>
Acked-by: Marc Zyngier <narc.zyngier@arm.com>
As I've already started collecting fixes that are aimed at -rc1 (mostly
to avoid dependencies), I can queue that as well.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-13 8:24 ` Marc Zyngier
0 siblings, 0 replies; 22+ messages in thread
From: Marc Zyngier @ 2016-05-13 8:24 UTC (permalink / raw)
To: linux-snps-arc
On 12/05/16 22:03, Arnd Bergmann wrote:
> The newly added nps irqchip driver causes build warnings on ARM64.
>
> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> As the driver is only used on ARC, we don't need to see it without
> COMPILE_TEST elsewhere, and we can avoid the warnings by only
> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
> drivers/irqchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 83775f148158..37289cf6b449 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>
> config EZNPS_GIC
> bool "NPS400 Global Interrupt Manager (GIM)"
> + depends on ARC || (COMPILE_TEST && !64BIT)
> select IRQ_DOMAIN
> help
> Support the EZchip NPS400 global interrupt controller
>
Acked-by: Marc Zyngier <narc.zyngier at arm.com>
As I've already started collecting fixes that are aimed at -rc1 (mostly
to avoid dependencies), I can queue that as well.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-13 8:24 ` Marc Zyngier
@ 2016-05-13 8:35 ` Vineet Gupta
-1 siblings, 0 replies; 22+ messages in thread
From: Vineet Gupta @ 2016-05-13 8:35 UTC (permalink / raw)
To: Marc Zyngier, Arnd Bergmann, Jason Cooper
Cc: Noam Camus, linux-snps-arc, Thomas Gleixner, linux-kernel
On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> On 12/05/16 22:03, Arnd Bergmann wrote:
...
>>
>> config EZNPS_GIC
>> bool "NPS400 Global Interrupt Manager (GIM)"
>> + depends on ARC || (COMPILE_TEST && !64BIT)
>> select IRQ_DOMAIN
>> help
>> Support the EZchip NPS400 global interrupt controller
>>
>
> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
>
> As I've already started collecting fixes that are aimed at -rc1 (mostly
> to avoid dependencies), I can queue that as well.
There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
towards the end of rc1 ?
Thx,
-Vineet
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-13 8:35 ` Vineet Gupta
0 siblings, 0 replies; 22+ messages in thread
From: Vineet Gupta @ 2016-05-13 8:35 UTC (permalink / raw)
To: linux-snps-arc
On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> On 12/05/16 22:03, Arnd Bergmann wrote:
...
>>
>> config EZNPS_GIC
>> bool "NPS400 Global Interrupt Manager (GIM)"
>> + depends on ARC || (COMPILE_TEST && !64BIT)
>> select IRQ_DOMAIN
>> help
>> Support the EZchip NPS400 global interrupt controller
>>
>
> Acked-by: Marc Zyngier <narc.zyngier at arm.com>
>
> As I've already started collecting fixes that are aimed at -rc1 (mostly
> to avoid dependencies), I can queue that as well.
There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
towards the end of rc1 ?
Thx,
-Vineet
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-13 8:35 ` Vineet Gupta
@ 2016-05-13 8:39 ` Marc Zyngier
-1 siblings, 0 replies; 22+ messages in thread
From: Marc Zyngier @ 2016-05-13 8:39 UTC (permalink / raw)
To: Vineet Gupta, Arnd Bergmann, Jason Cooper
Cc: Noam Camus, linux-snps-arc, Thomas Gleixner, linux-kernel
On 13/05/16 09:35, Vineet Gupta wrote:
> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>> On 12/05/16 22:03, Arnd Bergmann wrote:
> ...
>>>
>>> config EZNPS_GIC
>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>> select IRQ_DOMAIN
>>> help
>>> Support the EZchip NPS400 global interrupt controller
>>>
>>
>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
>>
>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>> to avoid dependencies), I can queue that as well.
>
> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> towards the end of rc1 ?
That'd be post -rc1.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-13 8:39 ` Marc Zyngier
0 siblings, 0 replies; 22+ messages in thread
From: Marc Zyngier @ 2016-05-13 8:39 UTC (permalink / raw)
To: linux-snps-arc
On 13/05/16 09:35, Vineet Gupta wrote:
> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>> On 12/05/16 22:03, Arnd Bergmann wrote:
> ...
>>>
>>> config EZNPS_GIC
>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>> select IRQ_DOMAIN
>>> help
>>> Support the EZchip NPS400 global interrupt controller
>>>
>>
>> Acked-by: Marc Zyngier <narc.zyngier at arm.com>
>>
>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>> to avoid dependencies), I can queue that as well.
>
> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> towards the end of rc1 ?
That'd be post -rc1.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-13 8:35 ` Vineet Gupta
@ 2016-05-13 9:51 ` Arnd Bergmann
-1 siblings, 0 replies; 22+ messages in thread
From: Arnd Bergmann @ 2016-05-13 9:51 UTC (permalink / raw)
To: Vineet Gupta
Cc: Marc Zyngier, Jason Cooper, Noam Camus, linux-snps-arc,
Thomas Gleixner, linux-kernel
On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> > On 12/05/16 22:03, Arnd Bergmann wrote:
> ...
> >>
> >> config EZNPS_GIC
> >> bool "NPS400 Global Interrupt Manager (GIM)"
> >> + depends on ARC || (COMPILE_TEST && !64BIT)
> >> select IRQ_DOMAIN
> >> help
> >> Support the EZchip NPS400 global interrupt controller
> >>
> >
> > Acked-by: Marc Zyngier <narc.zyngier@arm.com>
> >
> > As I've already started collecting fixes that are aimed at -rc1 (mostly
> > to avoid dependencies), I can queue that as well.
>
> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> towards the end of rc1 ?
>
I'd say the best option is to have you pick up the fix for the ARC tree,
but either way works.
Arnd
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-13 9:51 ` Arnd Bergmann
0 siblings, 0 replies; 22+ messages in thread
From: Arnd Bergmann @ 2016-05-13 9:51 UTC (permalink / raw)
To: linux-snps-arc
On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> > On 12/05/16 22:03, Arnd Bergmann wrote:
> ...
> >>
> >> config EZNPS_GIC
> >> bool "NPS400 Global Interrupt Manager (GIM)"
> >> + depends on ARC || (COMPILE_TEST && !64BIT)
> >> select IRQ_DOMAIN
> >> help
> >> Support the EZchip NPS400 global interrupt controller
> >>
> >
> > Acked-by: Marc Zyngier <narc.zyngier at arm.com>
> >
> > As I've already started collecting fixes that are aimed at -rc1 (mostly
> > to avoid dependencies), I can queue that as well.
>
> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> towards the end of rc1 ?
>
I'd say the best option is to have you pick up the fix for the ARC tree,
but either way works.
Arnd
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-13 9:51 ` Arnd Bergmann
@ 2016-05-13 10:25 ` Marc Zyngier
-1 siblings, 0 replies; 22+ messages in thread
From: Marc Zyngier @ 2016-05-13 10:25 UTC (permalink / raw)
To: Arnd Bergmann, Vineet Gupta
Cc: Jason Cooper, Noam Camus, linux-snps-arc, Thomas Gleixner, linux-kernel
On 13/05/16 10:51, Arnd Bergmann wrote:
> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>>> On 12/05/16 22:03, Arnd Bergmann wrote:
>> ...
>>>>
>>>> config EZNPS_GIC
>>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>>> select IRQ_DOMAIN
>>>> help
>>>> Support the EZchip NPS400 global interrupt controller
>>>>
>>>
>>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
>>>
>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>>> to avoid dependencies), I can queue that as well.
>>
>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
>> towards the end of rc1 ?
>>
>
> I'd say the best option is to have you pick up the fix for the ARC tree,
> but either way works.
That'd work for me too (I've acked it anyway). Just let me know what you
decide to do.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-13 10:25 ` Marc Zyngier
0 siblings, 0 replies; 22+ messages in thread
From: Marc Zyngier @ 2016-05-13 10:25 UTC (permalink / raw)
To: linux-snps-arc
On 13/05/16 10:51, Arnd Bergmann wrote:
> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>>> On 12/05/16 22:03, Arnd Bergmann wrote:
>> ...
>>>>
>>>> config EZNPS_GIC
>>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>>> select IRQ_DOMAIN
>>>> help
>>>> Support the EZchip NPS400 global interrupt controller
>>>>
>>>
>>> Acked-by: Marc Zyngier <narc.zyngier at arm.com>
>>>
>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>>> to avoid dependencies), I can queue that as well.
>>
>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
>> towards the end of rc1 ?
>>
>
> I'd say the best option is to have you pick up the fix for the ARC tree,
> but either way works.
That'd work for me too (I've acked it anyway). Just let me know what you
decide to do.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-13 10:25 ` Marc Zyngier
@ 2016-05-13 10:39 ` Vineet Gupta
-1 siblings, 0 replies; 22+ messages in thread
From: Vineet Gupta @ 2016-05-13 10:39 UTC (permalink / raw)
To: Marc Zyngier, Arnd Bergmann
Cc: Jason Cooper, Noam Camus, linux-snps-arc, Thomas Gleixner, linux-kernel
On Friday 13 May 2016 03:55 PM, Marc Zyngier wrote:
> On 13/05/16 10:51, Arnd Bergmann wrote:
>> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
>>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>>>> On 12/05/16 22:03, Arnd Bergmann wrote:
>>> ...
>>>>>
>>>>> config EZNPS_GIC
>>>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>>>> select IRQ_DOMAIN
>>>>> help
>>>>> Support the EZchip NPS400 global interrupt controller
>>>>>
>>>>
>>>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
>>>>
>>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>>>> to avoid dependencies), I can queue that as well.
>>>
>>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
>>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
>>> towards the end of rc1 ?
>>>
>>
>> I'd say the best option is to have you pick up the fix for the ARC tree,
>> but either way works.
>
> That'd work for me too (I've acked it anyway). Just let me know what you
> decide to do.
I'd prefer Marc takes it post rc1. The reason being chances of merge conflicts
between ARC and tip trees increase with ARC tree changing drivers/irqchip/*. We've
seen two of those already which Stephen fixed up in linux-next. Although
admittedly the conflicts are trivial and given the location of this diff hunk it
might not happen at all....
-Vineet
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-13 10:39 ` Vineet Gupta
0 siblings, 0 replies; 22+ messages in thread
From: Vineet Gupta @ 2016-05-13 10:39 UTC (permalink / raw)
To: linux-snps-arc
On Friday 13 May 2016 03:55 PM, Marc Zyngier wrote:
> On 13/05/16 10:51, Arnd Bergmann wrote:
>> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
>>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>>>> On 12/05/16 22:03, Arnd Bergmann wrote:
>>> ...
>>>>>
>>>>> config EZNPS_GIC
>>>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>>>> select IRQ_DOMAIN
>>>>> help
>>>>> Support the EZchip NPS400 global interrupt controller
>>>>>
>>>>
>>>> Acked-by: Marc Zyngier <narc.zyngier at arm.com>
>>>>
>>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>>>> to avoid dependencies), I can queue that as well.
>>>
>>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
>>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
>>> towards the end of rc1 ?
>>>
>>
>> I'd say the best option is to have you pick up the fix for the ARC tree,
>> but either way works.
>
> That'd work for me too (I've acked it anyway). Just let me know what you
> decide to do.
I'd prefer Marc takes it post rc1. The reason being chances of merge conflicts
between ARC and tip trees increase with ARC tree changing drivers/irqchip/*. We've
seen two of those already which Stephen fixed up in linux-next. Although
admittedly the conflicts are trivial and given the location of this diff hunk it
might not happen at all....
-Vineet
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-13 10:39 ` Vineet Gupta
@ 2016-05-17 19:39 ` Thomas Gleixner
-1 siblings, 0 replies; 22+ messages in thread
From: Thomas Gleixner @ 2016-05-17 19:39 UTC (permalink / raw)
To: Vineet Gupta
Cc: Marc Zyngier, Arnd Bergmann, Jason Cooper, Noam Camus,
linux-snps-arc, linux-kernel
On Fri, 13 May 2016, Vineet Gupta wrote:
> On Friday 13 May 2016 03:55 PM, Marc Zyngier wrote:
> > On 13/05/16 10:51, Arnd Bergmann wrote:
> >> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
> >>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> >>>> On 12/05/16 22:03, Arnd Bergmann wrote:
> >>> ...
> >>>>>
> >>>>> config EZNPS_GIC
> >>>>> bool "NPS400 Global Interrupt Manager (GIM)"
> >>>>> + depends on ARC || (COMPILE_TEST && !64BIT)
> >>>>> select IRQ_DOMAIN
> >>>>> help
> >>>>> Support the EZchip NPS400 global interrupt controller
> >>>>>
> >>>>
> >>>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
> >>>>
> >>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
> >>>> to avoid dependencies), I can queue that as well.
> >>>
> >>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> >>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> >>> towards the end of rc1 ?
> >>>
> >>
> >> I'd say the best option is to have you pick up the fix for the ARC tree,
> >> but either way works.
> >
> > That'd work for me too (I've acked it anyway). Just let me know what you
> > decide to do.
>
> I'd prefer Marc takes it post rc1. The reason being chances of merge conflicts
> between ARC and tip trees increase with ARC tree changing drivers/irqchip/*. We've
> seen two of those already which Stephen fixed up in linux-next. Although
> admittedly the conflicts are trivial and given the location of this diff hunk it
> might not happen at all....
If the driver is new and in ARC then the fix should go into ARC and shipped
with the pull request.
Thanks,
tglx
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-17 19:39 ` Thomas Gleixner
0 siblings, 0 replies; 22+ messages in thread
From: Thomas Gleixner @ 2016-05-17 19:39 UTC (permalink / raw)
To: linux-snps-arc
On Fri, 13 May 2016, Vineet Gupta wrote:
> On Friday 13 May 2016 03:55 PM, Marc Zyngier wrote:
> > On 13/05/16 10:51, Arnd Bergmann wrote:
> >> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
> >>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> >>>> On 12/05/16 22:03, Arnd Bergmann wrote:
> >>> ...
> >>>>>
> >>>>> config EZNPS_GIC
> >>>>> bool "NPS400 Global Interrupt Manager (GIM)"
> >>>>> + depends on ARC || (COMPILE_TEST && !64BIT)
> >>>>> select IRQ_DOMAIN
> >>>>> help
> >>>>> Support the EZchip NPS400 global interrupt controller
> >>>>>
> >>>>
> >>>> Acked-by: Marc Zyngier <narc.zyngier at arm.com>
> >>>>
> >>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
> >>>> to avoid dependencies), I can queue that as well.
> >>>
> >>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> >>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> >>> towards the end of rc1 ?
> >>>
> >>
> >> I'd say the best option is to have you pick up the fix for the ARC tree,
> >> but either way works.
> >
> > That'd work for me too (I've acked it anyway). Just let me know what you
> > decide to do.
>
> I'd prefer Marc takes it post rc1. The reason being chances of merge conflicts
> between ARC and tip trees increase with ARC tree changing drivers/irqchip/*. We've
> seen two of those already which Stephen fixed up in linux-next. Although
> admittedly the conflicts are trivial and given the location of this diff hunk it
> might not happen at all....
If the driver is new and in ARC then the fix should go into ARC and shipped
with the pull request.
Thanks,
tglx
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-12 21:03 ` Arnd Bergmann
@ 2016-05-20 7:34 ` Geert Uytterhoeven
-1 siblings, 0 replies; 22+ messages in thread
From: Geert Uytterhoeven @ 2016-05-20 7:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jason Cooper, Noam Camus, Vineet Gupta, arcml, Thomas Gleixner,
Marc Zyngier, linux-kernel
Hi Arnd,
On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added nps irqchip driver causes build warnings on ARM64.
>
> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> As the driver is only used on ARC, we don't need to see it without
> COMPILE_TEST elsewhere, and we can avoid the warnings by only
> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 83775f148158..37289cf6b449 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>
> config EZNPS_GIC
> bool "NPS400 Global Interrupt Manager (GIM)"
> + depends on ARC || (COMPILE_TEST && !64BIT)
> select IRQ_DOMAIN
> help
> Support the EZchip NPS400 global interrupt controller
As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
the slight simpler (whitespace-damaged):
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -255,7 +255,8 @@ config PARTITION_PERCPU
bool
config EZNPS_GIC
- bool "NPS400 Global Interrupt Manager (GIM)"
+ bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST
+ depends on !64BIT
select IRQ_DOMAIN
help
Support the EZchip NPS400 global interrupt controller
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-20 7:34 ` Geert Uytterhoeven
0 siblings, 0 replies; 22+ messages in thread
From: Geert Uytterhoeven @ 2016-05-20 7:34 UTC (permalink / raw)
To: linux-snps-arc
Hi Arnd,
On Thu, May 12, 2016@11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added nps irqchip driver causes build warnings on ARM64.
>
> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> As the driver is only used on ARC, we don't need to see it without
> COMPILE_TEST elsewhere, and we can avoid the warnings by only
> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
> drivers/irqchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 83775f148158..37289cf6b449 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>
> config EZNPS_GIC
> bool "NPS400 Global Interrupt Manager (GIM)"
> + depends on ARC || (COMPILE_TEST && !64BIT)
> select IRQ_DOMAIN
> help
> Support the EZchip NPS400 global interrupt controller
As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
the slight simpler (whitespace-damaged):
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -255,7 +255,8 @@ config PARTITION_PERCPU
bool
config EZNPS_GIC
- bool "NPS400 Global Interrupt Manager (GIM)"
+ bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST
+ depends on !64BIT
select IRQ_DOMAIN
help
Support the EZchip NPS400 global interrupt controller
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-20 7:34 ` Geert Uytterhoeven
@ 2016-05-20 8:22 ` Vineet Gupta
-1 siblings, 0 replies; 22+ messages in thread
From: Vineet Gupta @ 2016-05-20 8:22 UTC (permalink / raw)
To: Geert Uytterhoeven, Arnd Bergmann
Cc: Jason Cooper, Noam Camus, arcml, Thomas Gleixner, Marc Zyngier,
linux-kernel
On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
> Hi Arnd,
>
> On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added nps irqchip driver causes build warnings on ARM64.
>>
>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>
>> As the driver is only used on ARC, we don't need to see it without
>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/irqchip/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 83775f148158..37289cf6b449 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>
>> config EZNPS_GIC
>> bool "NPS400 Global Interrupt Manager (GIM)"
>> + depends on ARC || (COMPILE_TEST && !64BIT)
>> select IRQ_DOMAIN
>> help
>> Support the EZchip NPS400 global interrupt controller
>
> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
> the slight simpler (whitespace-damaged):
I'm afraid you are late to party - this has been sent Linus' way earlier today !
But it does look prettier so we can do this after rc1
>
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -255,7 +255,8 @@ config PARTITION_PERCPU
> bool
>
> config EZNPS_GIC
> - bool "NPS400 Global Interrupt Manager (GIM)"
> + bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST
> + depends on !64BIT
> select IRQ_DOMAIN
> help
> Support the EZchip NPS400 global interrupt controller
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-20 8:22 ` Vineet Gupta
0 siblings, 0 replies; 22+ messages in thread
From: Vineet Gupta @ 2016-05-20 8:22 UTC (permalink / raw)
To: linux-snps-arc
On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
> Hi Arnd,
>
> On Thu, May 12, 2016@11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added nps irqchip driver causes build warnings on ARM64.
>>
>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>
>> As the driver is only used on ARC, we don't need to see it without
>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>
>> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>> ---
>> drivers/irqchip/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 83775f148158..37289cf6b449 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>
>> config EZNPS_GIC
>> bool "NPS400 Global Interrupt Manager (GIM)"
>> + depends on ARC || (COMPILE_TEST && !64BIT)
>> select IRQ_DOMAIN
>> help
>> Support the EZchip NPS400 global interrupt controller
>
> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
> the slight simpler (whitespace-damaged):
I'm afraid you are late to party - this has been sent Linus' way earlier today !
But it does look prettier so we can do this after rc1
>
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -255,7 +255,8 @@ config PARTITION_PERCPU
> bool
>
> config EZNPS_GIC
> - bool "NPS400 Global Interrupt Manager (GIM)"
> + bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST
> + depends on !64BIT
> select IRQ_DOMAIN
> help
> Support the EZchip NPS400 global interrupt controller
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH] irqchip: nps: add 64BIT dependency
2016-05-20 8:22 ` Vineet Gupta
@ 2016-05-20 8:25 ` Geert Uytterhoeven
-1 siblings, 0 replies; 22+ messages in thread
From: Geert Uytterhoeven @ 2016-05-20 8:25 UTC (permalink / raw)
To: Vineet Gupta
Cc: Arnd Bergmann, Jason Cooper, Noam Camus, arcml, Thomas Gleixner,
Marc Zyngier, linux-kernel
Hi Vineet,
On Fri, May 20, 2016 at 10:22 AM, Vineet Gupta <vgupta@synopsys.com> wrote:
> On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
>> On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> The newly added nps irqchip driver causes build warnings on ARM64.
>>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>>
>>> As the driver is only used on ARC, we don't need to see it without
>>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>> drivers/irqchip/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>>> index 83775f148158..37289cf6b449 100644
>>> --- a/drivers/irqchip/Kconfig
>>> +++ b/drivers/irqchip/Kconfig
>>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>>
>>> config EZNPS_GIC
>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>> select IRQ_DOMAIN
>>> help
>>> Support the EZchip NPS400 global interrupt controller
>>
>> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
>> the slight simpler (whitespace-damaged):
>
> I'm afraid you are late to party - this has been sent Linus' way earlier today !
I am (my compilers are) celebrating Linus' current tree...
> But it does look prettier so we can do this after rc1
OK.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH] irqchip: nps: add 64BIT dependency
@ 2016-05-20 8:25 ` Geert Uytterhoeven
0 siblings, 0 replies; 22+ messages in thread
From: Geert Uytterhoeven @ 2016-05-20 8:25 UTC (permalink / raw)
To: linux-snps-arc
Hi Vineet,
On Fri, May 20, 2016@10:22 AM, Vineet Gupta <vgupta@synopsys.com> wrote:
> On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
>> On Thu, May 12, 2016@11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> The newly added nps irqchip driver causes build warnings on ARM64.
>>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>>
>>> As the driver is only used on ARC, we don't need to see it without
>>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>>> ---
>>> drivers/irqchip/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>>> index 83775f148158..37289cf6b449 100644
>>> --- a/drivers/irqchip/Kconfig
>>> +++ b/drivers/irqchip/Kconfig
>>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>>
>>> config EZNPS_GIC
>>> bool "NPS400 Global Interrupt Manager (GIM)"
>>> + depends on ARC || (COMPILE_TEST && !64BIT)
>>> select IRQ_DOMAIN
>>> help
>>> Support the EZchip NPS400 global interrupt controller
>>
>> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
>> the slight simpler (whitespace-damaged):
>
> I'm afraid you are late to party - this has been sent Linus' way earlier today !
I am (my compilers are) celebrating Linus' current tree...
> But it does look prettier so we can do this after rc1
OK.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2016-05-20 8:25 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-12 21:03 [PATCH] irqchip: nps: add 64BIT dependency Arnd Bergmann
2016-05-12 21:03 ` Arnd Bergmann
2016-05-13 8:24 ` Marc Zyngier
2016-05-13 8:24 ` Marc Zyngier
2016-05-13 8:35 ` Vineet Gupta
2016-05-13 8:35 ` Vineet Gupta
2016-05-13 8:39 ` Marc Zyngier
2016-05-13 8:39 ` Marc Zyngier
2016-05-13 9:51 ` Arnd Bergmann
2016-05-13 9:51 ` Arnd Bergmann
2016-05-13 10:25 ` Marc Zyngier
2016-05-13 10:25 ` Marc Zyngier
2016-05-13 10:39 ` Vineet Gupta
2016-05-13 10:39 ` Vineet Gupta
2016-05-17 19:39 ` Thomas Gleixner
2016-05-17 19:39 ` Thomas Gleixner
2016-05-20 7:34 ` Geert Uytterhoeven
2016-05-20 7:34 ` Geert Uytterhoeven
2016-05-20 8:22 ` Vineet Gupta
2016-05-20 8:22 ` Vineet Gupta
2016-05-20 8:25 ` Geert Uytterhoeven
2016-05-20 8:25 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.