All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys
Date: Thu, 21 Aug 2014 10:41:39 +0200	[thread overview]
Message-ID: <5a7b6f57-b6c0-4fb3-af0d-d403277c0207@BN1AFFO11FD045.protection.gbl> (raw)
In-Reply-To: <1408550219-19825-3-git-send-email-soren.brinkmann@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

On 08/20/2014 05:56 PM, Soren Brinkmann wrote:
> Add missing Ethernet phys to Zynq DTs.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
>  arch/arm/boot/dts/zynq-zc702.dts | 6 ++++++
>  arch/arm/boot/dts/zynq-zc706.dts | 6 ++++++
>  arch/arm/boot/dts/zynq-zed.dts   | 6 ++++++
>  3 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 30bcfe20f0bc..fa810505ab8f 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -36,6 +36,12 @@
>  &gem0 {
>  	status = "okay";
>  	phy-mode = "rgmii-id";
> +	phy-handle = <&ethernet_phy>;
> +
> +	ethernet_phy: ethernet-phy@7 {
> +		compatible = "marvell,88e1116r", "ethernet-phy-ieee802.3-c22";

c22 is completely unused by the kernel and also c22 is default option anyway.
Any advantage to have c22 specified here?

Thanks,
Michal


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys
Date: Thu, 21 Aug 2014 10:41:39 +0200	[thread overview]
Message-ID: <5a7b6f57-b6c0-4fb3-af0d-d403277c0207@BN1AFFO11FD045.protection.gbl> (raw)
In-Reply-To: <1408550219-19825-3-git-send-email-soren.brinkmann@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

On 08/20/2014 05:56 PM, Soren Brinkmann wrote:
> Add missing Ethernet phys to Zynq DTs.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
>  arch/arm/boot/dts/zynq-zc702.dts | 6 ++++++
>  arch/arm/boot/dts/zynq-zc706.dts | 6 ++++++
>  arch/arm/boot/dts/zynq-zed.dts   | 6 ++++++
>  3 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 30bcfe20f0bc..fa810505ab8f 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -36,6 +36,12 @@
>  &gem0 {
>  	status = "okay";
>  	phy-mode = "rgmii-id";
> +	phy-handle = <&ethernet_phy>;
> +
> +	ethernet_phy: ethernet-phy@7 {
> +		compatible = "marvell,88e1116r", "ethernet-phy-ieee802.3-c22";

c22 is completely unused by the kernel and also c22 is default option anyway.
Any advantage to have c22 specified here?

Thanks,
Michal


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys
Date: Thu, 21 Aug 2014 10:41:39 +0200	[thread overview]
Message-ID: <5a7b6f57-b6c0-4fb3-af0d-d403277c0207@BN1AFFO11FD045.protection.gbl> (raw)
In-Reply-To: <1408550219-19825-3-git-send-email-soren.brinkmann@xilinx.com>

On 08/20/2014 05:56 PM, Soren Brinkmann wrote:
> Add missing Ethernet phys to Zynq DTs.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
>  arch/arm/boot/dts/zynq-zc702.dts | 6 ++++++
>  arch/arm/boot/dts/zynq-zc706.dts | 6 ++++++
>  arch/arm/boot/dts/zynq-zed.dts   | 6 ++++++
>  3 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index 30bcfe20f0bc..fa810505ab8f 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -36,6 +36,12 @@
>  &gem0 {
>  	status = "okay";
>  	phy-mode = "rgmii-id";
> +	phy-handle = <&ethernet_phy>;
> +
> +	ethernet_phy: ethernet-phy at 7 {
> +		compatible = "marvell,88e1116r", "ethernet-phy-ieee802.3-c22";

c22 is completely unused by the kernel and also c22 is default option anyway.
Any advantage to have c22 specified here?

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140821/ab428838/attachment.sig>

  reply	other threads:[~2014-08-21  8:41 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20 15:56 [PATCH 1/3] ARM: zynq: DT: Fix Ethernet phy modes Soren Brinkmann
2014-08-20 15:56 ` Soren Brinkmann
2014-08-20 15:56 ` [PATCH 2/3] ARM: zynq: DT: Move size/address properties to dtsi Soren Brinkmann
2014-08-20 15:56   ` Soren Brinkmann
2014-08-20 16:00   ` Andreas Färber
2014-08-20 16:00     ` Andreas Färber
2014-08-21  8:42     ` Michal Simek
2014-08-21  8:42       ` Michal Simek
2014-08-21  8:42       ` Michal Simek
2014-08-20 15:56 ` [PATCH 3/3] ARM: zynq: DT: Add Ethernet phys Soren Brinkmann
2014-08-20 15:56   ` Soren Brinkmann
2014-08-21  8:41   ` Michal Simek [this message]
2014-08-21  8:41     ` Michal Simek
2014-08-21  8:41     ` Michal Simek
2014-08-21 11:32     ` Andreas Färber
2014-08-21 11:32       ` Andreas Färber
2014-08-21 15:49       ` Sören Brinkmann
2014-08-21 15:49         ` Sören Brinkmann
2014-08-21 15:49         ` Sören Brinkmann
2014-08-22 16:20         ` Jason Gunthorpe
2014-08-22 16:20           ` Jason Gunthorpe
2014-08-22 16:20           ` Jason Gunthorpe
2014-08-22 16:31           ` Sören Brinkmann
2014-08-22 16:31             ` Sören Brinkmann
2014-08-22 16:48             ` Jason Gunthorpe
2014-08-22 16:48               ` Jason Gunthorpe
2014-08-22 16:48               ` Jason Gunthorpe
2014-08-22 20:47         ` Florian Fainelli
2014-08-22 20:47           ` Florian Fainelli
2014-08-22 20:47           ` Florian Fainelli
2014-08-25 17:46           ` Jason Gunthorpe
2014-08-25 17:46             ` Jason Gunthorpe
2014-08-25 17:46             ` Jason Gunthorpe
2014-08-25 20:21             ` Florian Fainelli
2014-08-25 20:21               ` Florian Fainelli
2014-08-25 20:21               ` Florian Fainelli
2014-08-29 14:08               ` Michal Simek
2014-08-29 14:08                 ` Michal Simek
2014-08-29 14:08                 ` Michal Simek
2014-08-29 15:18                 ` Andreas Färber
2014-08-29 15:18                   ` Andreas Färber
2014-08-29 15:35                   ` Sören Brinkmann
2014-08-29 15:35                     ` Sören Brinkmann
2014-08-29 15:35                     ` Sören Brinkmann
2014-08-29 15:46                     ` Andreas Färber
2014-08-29 15:46                       ` Andreas Färber
2014-08-29 15:46                       ` Andreas Färber
2014-08-29 17:31                     ` Jason Gunthorpe
2014-08-29 17:31                       ` Jason Gunthorpe
2014-08-29 17:31                       ` Jason Gunthorpe
2014-08-29 18:23                       ` Florian Fainelli
2014-08-29 18:23                         ` Florian Fainelli
2014-08-29 18:23                         ` Florian Fainelli
2014-08-29 23:22                         ` Jason Gunthorpe
2014-08-29 23:22                           ` Jason Gunthorpe
2014-08-30  0:43                           ` Florian Fainelli
2014-08-30  0:43                             ` Florian Fainelli
2014-08-30  0:43                             ` Florian Fainelli
2014-09-01 11:26                             ` Michal Simek
2014-09-01 11:26                               ` Michal Simek
2014-09-01 11:26                               ` Michal Simek
2014-08-22 20:42     ` Florian Fainelli
2014-08-21  8:42 ` [PATCH 1/3] ARM: zynq: DT: Fix Ethernet phy modes Michal Simek
2014-08-21  8:42   ` Michal Simek
2014-08-21  8:42   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a7b6f57-b6c0-4fb3-af0d-d403277c0207@BN1AFFO11FD045.protection.gbl \
    --to=michal.simek@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.