From: John Hubbard <jhubbard@nvidia.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Joao Martins <joao.m.martins@oracle.com>
Cc: linux-mm@kvack.org, linux-nvdimm@lists.01.org,
Matthew Wilcox <willy@infradead.org>,
Muchun Song <songmuchun@bytedance.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
"Andrew Morton <akpm@linux-foundation.org>,
Daniel Jordan" <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH RFC 7/9] mm/gup: Decrement head page once for group of subpages
Date: Fri, 18 Dec 2020 18:06:28 -0800 [thread overview]
Message-ID: <604ac536-a829-4ae6-e0c8-291ab9e0138e@nvidia.com> (raw)
In-Reply-To: <20201217200530.GK5487@ziepe.ca>
On 12/17/20 12:05 PM, Jason Gunthorpe wrote:
> On Thu, Dec 17, 2020 at 07:05:37PM +0000, Joao Martins wrote:
>>> No reason not to fix set_page_dirty_lock() too while you are here.
>>
>> The wack of atomics you mentioned earlier you referred to, I suppose it
>> ends being account_page_dirtied(). See partial diff at the end.
>
> Well, even just eliminating the lock_page, page_mapping, PageDirty,
> etc is already a big win.
>
> If mapping->a_ops->set_page_dirty() needs to be called multiple times
> on the head page I'd probably just suggest:
>
> while (ntails--)
> rc |= (*spd)(head);
I think once should be enough. There is no counter for page dirtiness,
and this kind of accounting is always tracked in the head page, so there
is no reason to repeatedly call set_page_dirty() from the same
spot.
thanks,
--
John Hubbard
NVIDIA
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: John Hubbard <jhubbard@nvidia.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Joao Martins <joao.m.martins@oracle.com>
Cc: <linux-mm@kvack.org>, Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>, <linux-nvdimm@lists.01.org>,
Matthew Wilcox <willy@infradead.org>,
Jane Chu <jane.chu@oracle.com>,
Muchun Song <songmuchun@bytedance.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH RFC 7/9] mm/gup: Decrement head page once for group of subpages
Date: Fri, 18 Dec 2020 18:06:28 -0800 [thread overview]
Message-ID: <604ac536-a829-4ae6-e0c8-291ab9e0138e@nvidia.com> (raw)
In-Reply-To: <20201217200530.GK5487@ziepe.ca>
On 12/17/20 12:05 PM, Jason Gunthorpe wrote:
> On Thu, Dec 17, 2020 at 07:05:37PM +0000, Joao Martins wrote:
>>> No reason not to fix set_page_dirty_lock() too while you are here.
>>
>> The wack of atomics you mentioned earlier you referred to, I suppose it
>> ends being account_page_dirtied(). See partial diff at the end.
>
> Well, even just eliminating the lock_page, page_mapping, PageDirty,
> etc is already a big win.
>
> If mapping->a_ops->set_page_dirty() needs to be called multiple times
> on the head page I'd probably just suggest:
>
> while (ntails--)
> rc |= (*spd)(head);
I think once should be enough. There is no counter for page dirtiness,
and this kind of accounting is always tracked in the head page, so there
is no reason to repeatedly call set_page_dirty() from the same
spot.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2020-12-19 2:06 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 17:28 [PATCH RFC 0/9] mm, sparse-vmemmap: Introduce compound pagemaps Joao Martins
2020-12-08 17:28 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 1/9] memremap: add ZONE_DEVICE support for compound pages Joao Martins
2020-12-08 17:28 ` Joao Martins
2020-12-09 5:59 ` John Hubbard
2020-12-09 5:59 ` John Hubbard
2020-12-09 6:33 ` Matthew Wilcox
2020-12-09 6:33 ` Matthew Wilcox
2020-12-09 13:12 ` Joao Martins
2020-12-09 13:12 ` Joao Martins
2021-02-20 1:43 ` Dan Williams
2021-02-20 1:43 ` Dan Williams
2021-02-22 11:24 ` Joao Martins
2021-02-22 11:24 ` Joao Martins
2021-02-22 20:37 ` Dan Williams
2021-02-22 20:37 ` Dan Williams
2021-02-23 15:46 ` Joao Martins
2021-02-23 15:46 ` Joao Martins
2021-02-23 16:50 ` Dan Williams
2021-02-23 16:50 ` Dan Williams
2021-02-23 17:18 ` Joao Martins
2021-02-23 17:18 ` Joao Martins
2021-02-23 18:18 ` Dan Williams
2021-02-23 18:18 ` Dan Williams
2021-03-10 18:12 ` Joao Martins
2021-03-10 18:12 ` Joao Martins
2021-03-12 5:54 ` Dan Williams
2021-03-12 5:54 ` Dan Williams
2021-02-20 1:24 ` Dan Williams
2021-02-20 1:24 ` Dan Williams
2021-02-22 11:09 ` Joao Martins
2021-02-22 11:09 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 2/9] sparse-vmemmap: Consolidate arguments in vmemmap section populate Joao Martins
2020-12-08 17:28 ` Joao Martins
2020-12-09 6:16 ` John Hubbard
2020-12-09 6:16 ` John Hubbard
2020-12-09 13:51 ` Joao Martins
2020-12-09 13:51 ` Joao Martins
2021-02-20 1:49 ` Dan Williams
2021-02-20 1:49 ` Dan Williams
2021-02-22 11:26 ` Joao Martins
2021-02-22 11:26 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 3/9] sparse-vmemmap: Reuse vmemmap areas for a given mhp_params::align Joao Martins
2020-12-08 17:28 ` Joao Martins
2020-12-08 17:38 ` Joao Martins
2020-12-08 17:38 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 3/9] sparse-vmemmap: Reuse vmemmap areas for a given page size Joao Martins
2020-12-08 17:28 ` Joao Martins
2021-02-20 3:34 ` Dan Williams
2021-02-20 3:34 ` Dan Williams
2021-02-22 11:42 ` Joao Martins
2021-02-22 11:42 ` Joao Martins
2021-02-22 22:40 ` Dan Williams
2021-02-22 22:40 ` Dan Williams
2021-02-23 15:46 ` Joao Martins
2021-02-23 15:46 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 4/9] mm/page_alloc: Reuse tail struct pages for compound pagemaps Joao Martins
2020-12-08 17:28 ` Joao Martins
2021-02-20 6:17 ` Dan Williams
2021-02-20 6:17 ` Dan Williams
2021-02-22 12:01 ` Joao Martins
2021-02-22 12:01 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 5/9] device-dax: Compound pagemap support Joao Martins
2020-12-08 17:28 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 6/9] mm/gup: Grab head page refcount once for group of subpages Joao Martins
2020-12-08 17:28 ` Joao Martins
2020-12-08 19:49 ` Jason Gunthorpe
2020-12-09 11:05 ` Joao Martins
2020-12-09 11:05 ` Joao Martins
2020-12-09 15:15 ` Jason Gunthorpe
2020-12-09 16:02 ` Joao Martins
2020-12-09 16:02 ` Joao Martins
2020-12-09 16:24 ` Jason Gunthorpe
2020-12-09 17:27 ` Joao Martins
2020-12-09 17:27 ` Joao Martins
2020-12-09 18:14 ` Matthew Wilcox
2020-12-09 18:14 ` Matthew Wilcox
2020-12-09 19:08 ` Jason Gunthorpe
2020-12-10 15:43 ` Joao Martins
2020-12-10 15:43 ` Joao Martins
2020-12-09 4:40 ` John Hubbard
2020-12-09 4:40 ` John Hubbard
2020-12-09 13:44 ` Joao Martins
2020-12-09 13:44 ` Joao Martins
2020-12-08 17:28 ` [PATCH RFC 7/9] mm/gup: Decrement head page " Joao Martins
2020-12-08 17:28 ` Joao Martins
2020-12-08 19:34 ` Jason Gunthorpe
2020-12-09 5:06 ` John Hubbard
2020-12-09 5:06 ` John Hubbard
2020-12-09 13:43 ` Jason Gunthorpe
2020-12-09 12:17 ` Joao Martins
2020-12-09 12:17 ` Joao Martins
2020-12-17 19:05 ` Joao Martins
2020-12-17 19:05 ` Joao Martins
2020-12-17 20:05 ` Jason Gunthorpe
2020-12-17 22:34 ` Joao Martins
2020-12-17 22:34 ` Joao Martins
2020-12-18 14:25 ` Jason Gunthorpe
2020-12-19 2:06 ` John Hubbard [this message]
2020-12-19 2:06 ` John Hubbard
2020-12-19 13:10 ` Joao Martins
2020-12-19 13:10 ` Joao Martins
2020-12-08 17:29 ` [PATCH RFC 8/9] RDMA/umem: batch page unpin in __ib_mem_release() Joao Martins
2020-12-08 17:29 ` Joao Martins
2020-12-08 19:29 ` Jason Gunthorpe
2020-12-09 10:59 ` Joao Martins
2020-12-09 10:59 ` Joao Martins
2020-12-19 13:15 ` Joao Martins
2020-12-19 13:15 ` Joao Martins
2020-12-09 5:18 ` John Hubbard
2020-12-09 5:18 ` John Hubbard
2020-12-08 17:29 ` [PATCH RFC 9/9] mm: Add follow_devmap_page() for devdax vmas Joao Martins
2020-12-08 17:29 ` Joao Martins
2020-12-08 19:57 ` Jason Gunthorpe
2020-12-09 8:05 ` Christoph Hellwig
2020-12-09 8:05 ` Christoph Hellwig
2020-12-09 11:19 ` Joao Martins
2020-12-09 11:19 ` Joao Martins
2020-12-09 5:23 ` John Hubbard
2020-12-09 5:23 ` John Hubbard
2020-12-09 9:38 ` [PATCH RFC 0/9] mm, sparse-vmemmap: Introduce compound pagemaps David Hildenbrand
2020-12-09 9:38 ` David Hildenbrand
2020-12-09 9:52 ` [External] " Muchun Song
2020-12-09 9:52 ` Muchun Song
2021-02-20 1:18 ` Dan Williams
2021-02-20 1:18 ` Dan Williams
2021-02-22 11:06 ` Joao Martins
2021-02-22 11:06 ` Joao Martins
2021-02-22 14:32 ` Joao Martins
2021-02-22 14:32 ` Joao Martins
2021-02-23 16:28 ` Joao Martins
2021-02-23 16:28 ` Joao Martins
2021-02-23 16:44 ` Dan Williams
2021-02-23 16:44 ` Dan Williams
2021-02-23 17:15 ` Joao Martins
2021-02-23 17:15 ` Joao Martins
2021-02-23 18:15 ` Dan Williams
2021-02-23 18:15 ` Dan Williams
2021-02-23 18:54 ` Jason Gunthorpe
2021-02-23 22:48 ` Dan Williams
2021-02-23 22:48 ` Dan Williams
2021-02-23 23:07 ` Jason Gunthorpe
2021-02-24 0:14 ` Dan Williams
2021-02-24 0:14 ` Dan Williams
2021-02-24 1:00 ` Jason Gunthorpe
2021-02-24 1:32 ` Dan Williams
2021-02-24 1:32 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604ac536-a829-4ae6-e0c8-291ab9e0138e@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=daniel.m.jordan@oracle.com \
--cc=jgg@ziepe.ca \
--cc=joao.m.martins@oracle.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.