From: John Garry <john.garry@huawei.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Mark Brown <broonie@kernel.org>, <tudor.ambarus@microchip.com>, <linux-kernel@vger.kernel.org>, <chenxiang66@hisilicon.com>, <linuxarm@huawei.com>, <linux-spi@vger.kernel.org>, <marek.vasut@gmail.com>, <linux-mtd@lists.infradead.org>, <xuejiancheng@hisilicon.com>, <fengsheng5@huawei.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, wanghuiqiang <wanghuiqiang@huawei.com>, <liusimin4@huawei.com> Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver Date: Mon, 13 Jan 2020 10:09:27 +0000 [thread overview] Message-ID: <612a3c5d-69a4-af6b-5c79-c3fb853193ab@huawei.com> (raw) In-Reply-To: <20200110193119.GI32742@smile.fi.intel.com> On 10/01/2020 19:31, Andy Shevchenko wrote: > On Fri, Jan 10, 2020 at 02:58:54PM +0000, John Garry wrote: >> On 10/01/2020 14:07, Mark Brown wrote: >>> On Fri, Jan 10, 2020 at 11:55:37AM +0000, John Garry wrote: > > > ... > >>>> I will note that PRP0001+"jedec,spi-nor" compatible DSD seems to be the >>>> defacto method to describe the SPI NOR-compat part for ACPI - that's what >>>> I'm using. We could add properties there, but that seems improper. >>> >>> OK, so that's just reusing the DT binding in which case everything >>> that's valid for the DT binding should also be valid for ACPI - I >>> thought that actually worked automatically without you having to do >>> anything in the code but ICBW. >> >> I thought that it would be improper as we could be mixing ACPI methods to >> describe the serial bus (SPI Serial Bus Connection Resource Descriptor) and >> also DT properties which could conflict, like CS active high. >> >> However I do see extra properties than "compatible" being added in DSD for >> PRP0001: >> https://patchwork.ozlabs.org/patch/662813/ (see EEPROM part) > Hi Andy, > PRP method is only for vendors to *test* the hardware in ACPI environment. > The proper method is to allocate correct ACPI ID. Yes, that would seem the proper thing to do. So the SPI NOR driver is based on micron m25p80 and compatible string is "jedec,spi-nor", so I don't know who should or would do this registration. > > Properties (_DSD in ACPI) may be used in the same way as for DT if we have no > other means in ACPI specification for them. > >> And if we were to do this, I think that we would need to add some >> device_property_read_u32("spi-rx-bus-width", ...), etc calls in the SPI FW >> parsing for ACPI path - I couldn't see that. > > It's okay as long as you have ACPI ID. Well there is none AFAIK. > > P.S. Most of the sensor drivers were updated in order to support ACPI PRP > method due to DIY hobbyist on IoT sector and embedded devices. This should not > be an official way how we support hardware on ACPI-based platforms. Yeah, so we could do this. But, as I mentioned already, this could mean that we conflicting properties. For this the kernel driver prob should only pay attention to properties which ACPI cannot describe. Even better would be to update the ACPI spec, especially for something general like SPI bus width BTW, Do any of these sensors you mention have any ACPI standardization? Thanks, John
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: chenxiang66@hisilicon.com, linux-kernel@vger.kernel.org, tudor.ambarus@microchip.com, liusimin4@huawei.com, linuxarm@huawei.com, linux-spi@vger.kernel.org, marek.vasut@gmail.com, Mark Brown <broonie@kernel.org>, linux-mtd@lists.infradead.org, xuejiancheng@hisilicon.com, Mika Westerberg <mika.westerberg@linux.intel.com>, wanghuiqiang <wanghuiqiang@huawei.com>, fengsheng5@huawei.com Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver Date: Mon, 13 Jan 2020 10:09:27 +0000 [thread overview] Message-ID: <612a3c5d-69a4-af6b-5c79-c3fb853193ab@huawei.com> (raw) In-Reply-To: <20200110193119.GI32742@smile.fi.intel.com> On 10/01/2020 19:31, Andy Shevchenko wrote: > On Fri, Jan 10, 2020 at 02:58:54PM +0000, John Garry wrote: >> On 10/01/2020 14:07, Mark Brown wrote: >>> On Fri, Jan 10, 2020 at 11:55:37AM +0000, John Garry wrote: > > > ... > >>>> I will note that PRP0001+"jedec,spi-nor" compatible DSD seems to be the >>>> defacto method to describe the SPI NOR-compat part for ACPI - that's what >>>> I'm using. We could add properties there, but that seems improper. >>> >>> OK, so that's just reusing the DT binding in which case everything >>> that's valid for the DT binding should also be valid for ACPI - I >>> thought that actually worked automatically without you having to do >>> anything in the code but ICBW. >> >> I thought that it would be improper as we could be mixing ACPI methods to >> describe the serial bus (SPI Serial Bus Connection Resource Descriptor) and >> also DT properties which could conflict, like CS active high. >> >> However I do see extra properties than "compatible" being added in DSD for >> PRP0001: >> https://patchwork.ozlabs.org/patch/662813/ (see EEPROM part) > Hi Andy, > PRP method is only for vendors to *test* the hardware in ACPI environment. > The proper method is to allocate correct ACPI ID. Yes, that would seem the proper thing to do. So the SPI NOR driver is based on micron m25p80 and compatible string is "jedec,spi-nor", so I don't know who should or would do this registration. > > Properties (_DSD in ACPI) may be used in the same way as for DT if we have no > other means in ACPI specification for them. > >> And if we were to do this, I think that we would need to add some >> device_property_read_u32("spi-rx-bus-width", ...), etc calls in the SPI FW >> parsing for ACPI path - I couldn't see that. > > It's okay as long as you have ACPI ID. Well there is none AFAIK. > > P.S. Most of the sensor drivers were updated in order to support ACPI PRP > method due to DIY hobbyist on IoT sector and embedded devices. This should not > be an official way how we support hardware on ACPI-based platforms. Yeah, so we could do this. But, as I mentioned already, this could mean that we conflicting properties. For this the kernel driver prob should only pay attention to properties which ACPI cannot describe. Even better would be to update the ACPI spec, especially for something general like SPI bus width BTW, Do any of these sensors you mention have any ACPI standardization? Thanks, John ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-13 10:09 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-09 14:08 [PATCH v2 0/3] HiSilicon v3xx SFC driver John Garry 2019-12-09 14:08 ` John Garry 2019-12-09 14:08 ` [PATCH v2 1/3] mtd: spi-nor: hisi-sfc: Try to provide some clarity on which SFC we are John Garry 2019-12-09 14:08 ` John Garry 2020-01-16 11:03 ` Tudor.Ambarus 2020-01-16 11:03 ` Tudor.Ambarus 2019-12-09 14:08 ` [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver John Garry 2019-12-09 14:08 ` John Garry 2020-01-09 15:54 ` John Garry 2020-01-09 15:54 ` John Garry 2020-01-09 21:28 ` Mark Brown 2020-01-09 21:28 ` Mark Brown 2020-01-10 11:55 ` John Garry 2020-01-10 11:55 ` John Garry 2020-01-10 11:55 ` John Garry 2020-01-10 14:07 ` Mark Brown 2020-01-10 14:07 ` Mark Brown 2020-01-10 14:07 ` Mark Brown 2020-01-10 14:58 ` John Garry 2020-01-10 14:58 ` John Garry 2020-01-10 15:12 ` Mark Brown 2020-01-10 15:12 ` Mark Brown 2020-01-10 16:09 ` John Garry 2020-01-10 16:09 ` John Garry 2020-01-10 19:31 ` Andy Shevchenko 2020-01-10 19:31 ` Andy Shevchenko 2020-01-10 19:31 ` Andy Shevchenko 2020-01-13 10:09 ` John Garry [this message] 2020-01-13 10:09 ` John Garry 2020-01-13 11:42 ` Mark Brown 2020-01-13 11:42 ` Mark Brown 2020-01-13 13:01 ` John Garry 2020-01-13 13:01 ` John Garry 2020-01-13 14:06 ` Mark Brown 2020-01-13 14:06 ` Mark Brown 2020-01-13 14:17 ` Andy Shevchenko 2020-01-13 14:17 ` Andy Shevchenko 2020-01-13 14:17 ` Andy Shevchenko 2020-01-13 14:27 ` Mark Brown 2020-01-13 14:27 ` Mark Brown 2020-01-13 14:27 ` Mark Brown 2020-01-13 14:34 ` Andy Shevchenko 2020-01-13 14:34 ` Andy Shevchenko 2020-01-13 14:34 ` Andy Shevchenko 2020-01-31 10:08 ` John Garry 2020-01-31 10:08 ` John Garry 2020-01-31 11:39 ` Andy Shevchenko 2020-01-31 11:39 ` Andy Shevchenko 2020-01-31 11:39 ` Andy Shevchenko 2020-01-31 12:03 ` John Garry 2020-01-31 12:03 ` John Garry 2020-01-31 12:03 ` John Garry 2020-01-31 15:46 ` Andy Shevchenko 2020-01-31 15:46 ` Andy Shevchenko 2020-01-31 15:46 ` Andy Shevchenko 2020-01-31 16:26 ` John Garry 2020-01-31 16:26 ` John Garry 2020-01-31 16:26 ` John Garry 2020-02-01 11:34 ` Mark Brown 2020-02-01 11:34 ` Mark Brown 2020-02-01 11:32 ` Mark Brown 2020-02-01 11:32 ` Mark Brown 2020-01-10 19:59 ` Applied "spi: Add HiSilicon v3xx SPI NOR flash controller driver" to the spi tree Mark Brown 2020-01-10 19:59 ` Mark Brown 2020-01-10 19:59 ` Mark Brown 2019-12-09 14:08 ` [PATCH v2 3/3] MAINTAINERS: Add a maintainer for the HiSilicon v3xx SFC driver John Garry 2019-12-09 14:08 ` John Garry 2020-01-10 19:59 ` Applied "MAINTAINERS: Add a maintainer for the HiSilicon v3xx SFC driver" to the spi tree Mark Brown 2020-01-10 19:59 ` Mark Brown 2020-01-10 19:59 ` Mark Brown 2019-12-16 14:52 ` [PATCH v2 0/3] HiSilicon v3xx SFC driver John Garry 2019-12-16 14:52 ` John Garry 2019-12-16 14:56 ` Mark Brown 2019-12-16 14:56 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=612a3c5d-69a4-af6b-5c79-c3fb853193ab@huawei.com \ --to=john.garry@huawei.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=broonie@kernel.org \ --cc=chenxiang66@hisilicon.com \ --cc=fengsheng5@huawei.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=liusimin4@huawei.com \ --cc=marek.vasut@gmail.com \ --cc=mika.westerberg@linux.intel.com \ --cc=tudor.ambarus@microchip.com \ --cc=wanghuiqiang@huawei.com \ --cc=xuejiancheng@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.