From: Rasmus Villemoes <rasmus.villemoes@prevas.dk> To: Rob Herring <robh@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>, Mark Rutland <mark.rutland@arm.com>, Alexander Stein <alexander.stein@systec-electronic.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC] irqchip: add support for LS1021A external interrupt lines Date: Fri, 15 Dec 2017 23:55:34 +0100 [thread overview] Message-ID: <62c4af0c-ffe5-23c9-9ef6-2e4b8ab90050@prevas.dk> (raw) In-Reply-To: <20171212232839.yy3jtn6amktqjo4g@rob-hp-laptop> On 2017-12-13 00:28, Rob Herring wrote: > On Fri, Dec 08, 2017 at 03:33:00PM +0100, Rasmus Villemoes wrote: >> >> .../interrupt-controller/fsl,ls1021a-extirq.txt | 19 +++ > > Please split to separate patch. Will do. >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls1021a-extirq.txt >> @@ -0,0 +1,19 @@ >> +* Freescale LS1021A external IRQs >> + >> +The LS1021A supports inverting the polarity of six external interrupt lines. >> + >> +Required properties: >> +- compatible: should be "fsl,ls1021a-extirq" >> +- interrupt-controller: Identifies the node as an interrupt controller >> +- #interrupt-cells: Use the same format as specified by GIC in arm,gic.txt. >> +- interrupt-parent: phandle of GIC. >> +- syscon: phandle of Supplemental Configuration Unit (scfg). > > Can this be a child of that node instead? I suppose it could, but I don't think it would make much sense. In any case, I did it this way because that seemed to be the way the syscon driver is used in lots of other cases, cf. all the occurrences of syscon_regmap_lookup_by_phandle() and the corresponding bindings - I don't think I've seen any of those cases represent the syscon-using node as a child of the syscon node. >> + >> +Example: >> + extirq: interrupt-controller@15701ac { > > Unit-address without reg is not valid. Building with W=1 will tell you > this. Thanks, that was actually a leftover from an earlier version. Rasmus
WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <rasmus.villemoes-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [RFC] irqchip: add support for LS1021A external interrupt lines Date: Fri, 15 Dec 2017 23:55:34 +0100 [thread overview] Message-ID: <62c4af0c-ffe5-23c9-9ef6-2e4b8ab90050@prevas.dk> (raw) In-Reply-To: <20171212232839.yy3jtn6amktqjo4g@rob-hp-laptop> On 2017-12-13 00:28, Rob Herring wrote: > On Fri, Dec 08, 2017 at 03:33:00PM +0100, Rasmus Villemoes wrote: >> >> .../interrupt-controller/fsl,ls1021a-extirq.txt | 19 +++ > > Please split to separate patch. Will do. >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls1021a-extirq.txt >> @@ -0,0 +1,19 @@ >> +* Freescale LS1021A external IRQs >> + >> +The LS1021A supports inverting the polarity of six external interrupt lines. >> + >> +Required properties: >> +- compatible: should be "fsl,ls1021a-extirq" >> +- interrupt-controller: Identifies the node as an interrupt controller >> +- #interrupt-cells: Use the same format as specified by GIC in arm,gic.txt. >> +- interrupt-parent: phandle of GIC. >> +- syscon: phandle of Supplemental Configuration Unit (scfg). > > Can this be a child of that node instead? I suppose it could, but I don't think it would make much sense. In any case, I did it this way because that seemed to be the way the syscon driver is used in lots of other cases, cf. all the occurrences of syscon_regmap_lookup_by_phandle() and the corresponding bindings - I don't think I've seen any of those cases represent the syscon-using node as a child of the syscon node. >> + >> +Example: >> + extirq: interrupt-controller@15701ac { > > Unit-address without reg is not valid. Building with W=1 will tell you > this. Thanks, that was actually a leftover from an earlier version. Rasmus -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-15 22:56 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-04 15:11 polarity inversion on LS1021a Rasmus Villemoes 2017-12-04 15:23 ` Marc Zyngier 2017-12-08 14:33 ` [RFC] irqchip: add support for LS1021A external interrupt lines Rasmus Villemoes 2017-12-08 14:33 ` Rasmus Villemoes 2017-12-08 15:11 ` Alexander Stein 2017-12-08 15:11 ` Alexander Stein 2017-12-08 16:09 ` Marc Zyngier 2017-12-08 16:09 ` Marc Zyngier 2017-12-11 9:08 ` Rasmus Villemoes 2017-12-11 9:08 ` Rasmus Villemoes 2017-12-11 9:45 ` Alexander Stein 2017-12-11 9:45 ` Alexander Stein 2017-12-11 10:02 ` Alexander Stein 2017-12-11 10:02 ` Alexander Stein 2017-12-11 13:45 ` Rasmus Villemoes 2017-12-11 13:45 ` Rasmus Villemoes 2017-12-11 14:06 ` Rasmus Villemoes 2017-12-11 14:06 ` Rasmus Villemoes 2017-12-11 14:38 ` Alexander Stein 2017-12-11 14:38 ` Alexander Stein 2017-12-08 16:02 ` Marc Zyngier 2017-12-08 16:02 ` Marc Zyngier 2017-12-11 9:30 ` Rasmus Villemoes 2017-12-11 9:30 ` Rasmus Villemoes 2017-12-11 18:29 ` Marc Zyngier 2017-12-11 18:29 ` Marc Zyngier 2017-12-12 23:28 ` Rob Herring 2017-12-12 23:28 ` Rob Herring 2017-12-15 22:55 ` Rasmus Villemoes [this message] 2017-12-15 22:55 ` Rasmus Villemoes 2017-12-21 22:45 ` Rob Herring 2017-12-21 22:45 ` Rob Herring 2017-12-20 8:30 ` [PATCH v2 1/2] irqchip: add support for Layerscape " Rasmus Villemoes 2017-12-20 8:30 ` [PATCH v2 2/2] dt/bindings: Add bindings for Layerscape external irqs Rasmus Villemoes 2017-12-20 8:30 ` Rasmus Villemoes 2017-12-21 22:44 ` Rob Herring 2017-12-21 22:44 ` Rob Herring 2018-01-22 9:21 ` [PATCH v3 1/2] irqchip: add support for Layerscape external interrupt lines Rasmus Villemoes 2018-01-22 9:21 ` [PATCH v3 2/2] dt/bindings: Add bindings for Layerscape external irqs Rasmus Villemoes 2018-01-22 9:21 ` Rasmus Villemoes 2018-01-24 15:28 ` Marc Zyngier 2018-01-25 15:02 ` [PATCH v4 1/2] irqchip: add support for Layerscape external interrupt lines Rasmus Villemoes 2018-01-25 15:02 ` [PATCH v4 2/2] dt/bindings: Add bindings for Layerscape external irqs Rasmus Villemoes 2018-01-25 15:02 ` Rasmus Villemoes 2018-02-05 6:07 ` Rob Herring 2018-02-05 6:07 ` Rob Herring 2018-02-08 15:08 ` Rasmus Villemoes 2018-02-09 9:47 ` Marc Zyngier 2018-02-09 9:47 ` Marc Zyngier 2018-02-23 21:08 ` [PATCH v5 0/2] irqchip: add support for Layerscape external interrupt lines Rasmus Villemoes 2018-02-23 21:08 ` [PATCH v5 1/2] " Rasmus Villemoes 2018-03-01 12:16 ` Thomas Gleixner 2018-05-04 7:44 ` Rasmus Villemoes 2019-09-17 9:39 ` Kurt Kanzenbach 2018-02-23 21:09 ` [PATCH v5 2/2] dt/bindings: Add bindings for Layerscape external irqs Rasmus Villemoes 2018-03-02 19:49 ` Rob Herring 2018-05-04 8:07 ` Rasmus Villemoes 2017-12-04 15:31 ` polarity inversion on LS1021a Alexander Stein 2017-12-04 15:37 ` Marc Zyngier 2017-12-04 16:04 ` Alexander Stein
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=62c4af0c-ffe5-23c9-9ef6-2e4b8ab90050@prevas.dk \ --to=rasmus.villemoes@prevas.dk \ --cc=alexander.stein@systec-electronic.com \ --cc=devicetree@vger.kernel.org \ --cc=jason@lakedaemon.net \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=robh@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.