[PATCH] musl: Set UPSTREAM_CHECK_COMMITS

[PATCH] musl: Set UPSTREAM_CHECK_COMMITS

[Khem Raj]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/musl/musl_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb
index 6569d1b37b..bd9d5f1d4b 100644
--- a/meta/recipes-core/musl/musl_git.bb
+++ b/meta/recipes-core/musl/musl_git.bb
@@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
 LEAD_SONAME = "libc.so"
 INSANE_SKIP_${PN}-dev = "staticdev"
 INSANE_SKIP_${PN} = "libdir"
+
+UPSTREAM_CHECK_COMMITS = "1"
-- 
2.32.0

Re: [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS

[Michael Opdenacker]

Hi Khem

On 6/13/21 12:10 AM, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-core/musl/musl_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb
> index 6569d1b37b..bd9d5f1d4b 100644
> --- a/meta/recipes-core/musl/musl_git.bb
> +++ b/meta/recipes-core/musl/musl_git.bb
> @@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
>  LEAD_SONAME = "libc.so"
>  INSANE_SKIP_${PN}-dev = "staticdev"
>  INSANE_SKIP_${PN} = "libdir"
> +
> +UPSTREAM_CHECK_COMMITS = "1"


Thanks for the patch.
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the
documentation, and it's in relatively frequent use.

Would it make sense to propose to add a description based on the initial
commit
(https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb)?

Thanks in advance,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [docs] [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

That would be very useful, but you should check if the entire nomenclature
of UPSTREAM_CHECK_* variables is documented as well
(_COMMITS, _REGEX, _URI, _GITTAGREGEX).

Alex

On Mon, 14 Jun 2021 at 15:12, Michael Opdenacker <
michael.opdenacker@bootlin.com> wrote:

> Hi Khem
>
> On 6/13/21 12:10 AM, Khem Raj wrote:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-core/musl/musl_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/recipes-core/musl/musl_git.bb
> b/meta/recipes-core/musl/musl_git.bb
> > index 6569d1b37b..bd9d5f1d4b 100644
> > --- a/meta/recipes-core/musl/musl_git.bb
> > +++ b/meta/recipes-core/musl/musl_git.bb
> > @@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
> >  LEAD_SONAME = "libc.so"
> >  INSANE_SKIP_${PN}-dev = "staticdev"
> >  INSANE_SKIP_${PN} = "libdir"
> > +
> > +UPSTREAM_CHECK_COMMITS = "1"
>
>
> Thanks for the patch.
> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>
> I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the
> documentation, and it's in relatively frequent use.
>
> Would it make sense to propose to add a description based on the initial
> commit
> (
> https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb
> )?
>
> Thanks in advance,
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2715 bytes --]

Re: [docs] [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS

[Michael Opdenacker]

Hi Alex,

On 6/14/21 3:17 PM, Alexander Kanavin wrote:
> That would be very useful, but you should check if the entire
> nomenclature of UPSTREAM_CHECK_* variables is documented as well
> (_COMMITS, _REGEX, _URI, _GITTAGREGEX).


Great, many thanks for the advise!
I filed a bug to keep track of this need:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14431

Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com