From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer()
Date: Fri, 8 Nov 2019 08:20:20 +0100 [thread overview]
Message-ID: <80bfc0e8-860d-3c11-07f4-08b7dd7fada4@suse.de> (raw)
In-Reply-To: <20191108015702.233102-9-damien.lemoal@wdc.com>
On 11/8/19 2:57 AM, Damien Le Moal wrote:
> There is no need to arbitrarily limit the size of a report zone to the
> number of zones defined by SD_ZBC_REPORT_MAX_ZONES. Rather, simply
> calculate the report buffer size needed for the requested number of
> zones without exceeding the device total number of zones. This buffer
> size limitation to the hardware maximum transfer size and page mapping
> capabilities is kept unchanged. Starting with this initial buffer size,
> the allocation is optimized by iterating over decreasing buffer size
> until the allocation succeeds. This ensures forward progress for zone
> reports and avoids failures of zones revalidation under memory pressure.
>
> While at it, also replace the hard coded 512 B sector size with the
> SECTOR_SIZE macro.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> drivers/scsi/sd_zbc.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [f2fs-dev] [PATCH 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer()
Date: Fri, 8 Nov 2019 08:20:20 +0100 [thread overview]
Message-ID: <80bfc0e8-860d-3c11-07f4-08b7dd7fada4@suse.de> (raw)
In-Reply-To: <20191108015702.233102-9-damien.lemoal@wdc.com>
On 11/8/19 2:57 AM, Damien Le Moal wrote:
> There is no need to arbitrarily limit the size of a report zone to the
> number of zones defined by SD_ZBC_REPORT_MAX_ZONES. Rather, simply
> calculate the report buffer size needed for the requested number of
> zones without exceeding the device total number of zones. This buffer
> size limitation to the hardware maximum transfer size and page mapping
> capabilities is kept unchanged. Starting with this initial buffer size,
> the allocation is optimized by iterating over decreasing buffer size
> until the allocation succeeds. This ensures forward progress for zone
> reports and avoids failures of zones revalidation under memory pressure.
>
> While at it, also replace the hard coded 512 B sector size with the
> SECTOR_SIZE macro.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> drivers/scsi/sd_zbc.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer()
Date: Fri, 8 Nov 2019 08:20:20 +0100 [thread overview]
Message-ID: <80bfc0e8-860d-3c11-07f4-08b7dd7fada4@suse.de> (raw)
In-Reply-To: <20191108015702.233102-9-damien.lemoal@wdc.com>
On 11/8/19 2:57 AM, Damien Le Moal wrote:
> There is no need to arbitrarily limit the size of a report zone to the
> number of zones defined by SD_ZBC_REPORT_MAX_ZONES. Rather, simply
> calculate the report buffer size needed for the requested number of
> zones without exceeding the device total number of zones. This buffer
> size limitation to the hardware maximum transfer size and page mapping
> capabilities is kept unchanged. Starting with this initial buffer size,
> the allocation is optimized by iterating over decreasing buffer size
> until the allocation succeeds. This ensures forward progress for zone
> reports and avoids failures of zones revalidation under memory pressure.
>
> While at it, also replace the hard coded 512 B sector size with the
> SECTOR_SIZE macro.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> drivers/scsi/sd_zbc.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-08 7:20 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 1:56 [PATCH 0/9] Zoned block device enhancements and zone report rework Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] " Damien Le Moal
2019-11-08 1:56 ` [PATCH 1/9] block: Enhance blk_revalidate_disk_zones() Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] " Damien Le Moal
2019-11-08 6:28 ` [dm-devel] " Christoph Hellwig
2019-11-08 6:28 ` Christoph Hellwig
2019-11-08 6:28 ` [f2fs-dev] " Christoph Hellwig
2019-11-08 7:10 ` Hannes Reinecke
2019-11-08 7:10 ` Hannes Reinecke
2019-11-08 7:10 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 1:56 ` [PATCH 2/9] block: cleanup the !zoned case in blk_revalidate_disk_zones Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] " Damien Le Moal
2019-11-08 7:11 ` Hannes Reinecke
2019-11-08 7:11 ` Hannes Reinecke
2019-11-08 7:11 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 18:50 ` Chaitanya Kulkarni
2019-11-08 18:50 ` Chaitanya Kulkarni
2019-11-08 18:50 ` [f2fs-dev] " Chaitanya Kulkarni
2019-11-08 1:56 ` [PATCH 3/9] block: Simplify report zones execution Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] " Damien Le Moal
2019-11-08 7:12 ` Hannes Reinecke
2019-11-08 7:12 ` Hannes Reinecke
2019-11-08 7:12 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 1:56 ` [PATCH 4/9] block: Remove partition support for zoned block devices Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] " Damien Le Moal
2019-11-08 6:30 ` [dm-devel] " Christoph Hellwig
2019-11-08 6:30 ` Christoph Hellwig
2019-11-08 6:30 ` [f2fs-dev] " Christoph Hellwig
2019-11-08 7:17 ` Hannes Reinecke
2019-11-08 7:17 ` Hannes Reinecke
2019-11-08 7:17 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 7:28 ` Damien Le Moal
2019-11-08 7:28 ` Damien Le Moal
2019-11-08 7:28 ` [f2fs-dev] " Damien Le Moal
2019-11-08 1:56 ` [PATCH 5/9] null_blk: clean up the block device operations Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] " Damien Le Moal
2019-11-08 7:17 ` Hannes Reinecke
2019-11-08 7:17 ` Hannes Reinecke
2019-11-08 7:17 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 18:47 ` Chaitanya Kulkarni
2019-11-08 18:47 ` Chaitanya Kulkarni
2019-11-08 18:47 ` [f2fs-dev] " Chaitanya Kulkarni
2019-11-08 1:56 ` [PATCH 6/9] null_blk: clean up report zones Damien Le Moal
2019-11-08 1:56 ` [f2fs-dev] " Damien Le Moal
2019-11-08 7:18 ` Hannes Reinecke
2019-11-08 7:18 ` Hannes Reinecke
2019-11-08 7:18 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 18:47 ` Chaitanya Kulkarni
2019-11-08 18:47 ` Chaitanya Kulkarni
2019-11-08 18:47 ` [f2fs-dev] " Chaitanya Kulkarni
2019-11-08 1:57 ` [PATCH 7/9] null_blk: Add zone_nr_conv to features Damien Le Moal
2019-11-08 1:57 ` [f2fs-dev] " Damien Le Moal
2019-11-08 7:18 ` Hannes Reinecke
2019-11-08 7:18 ` Hannes Reinecke
2019-11-08 7:18 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 18:48 ` Chaitanya Kulkarni
2019-11-08 18:48 ` Chaitanya Kulkarni
2019-11-08 18:48 ` [f2fs-dev] " Chaitanya Kulkarni
2019-11-08 1:57 ` [PATCH 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer() Damien Le Moal
2019-11-08 1:57 ` [f2fs-dev] " Damien Le Moal
2019-11-08 6:31 ` [dm-devel] " Christoph Hellwig
2019-11-08 6:31 ` Christoph Hellwig
2019-11-08 6:31 ` [f2fs-dev] " Christoph Hellwig
2019-11-08 7:20 ` Hannes Reinecke [this message]
2019-11-08 7:20 ` Hannes Reinecke
2019-11-08 7:20 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 19:06 ` [dm-devel] " Bart Van Assche
2019-11-08 19:06 ` [f2fs-dev] " Bart Van Assche
2019-11-09 2:54 ` Damien Le Moal
2019-11-09 2:54 ` Damien Le Moal
2019-11-09 2:54 ` [f2fs-dev] " Damien Le Moal
2019-11-09 3:02 ` Bart Van Assche
2019-11-09 3:02 ` Bart Van Assche
2019-11-09 3:02 ` [f2fs-dev] " Bart Van Assche
2019-11-08 1:57 ` [PATCH 9/9] block: rework zone reporting Damien Le Moal
2019-11-08 1:57 ` [f2fs-dev] " Damien Le Moal
2019-11-08 7:23 ` Hannes Reinecke
2019-11-08 7:23 ` Hannes Reinecke
2019-11-08 7:23 ` [f2fs-dev] " Hannes Reinecke
2019-11-08 15:16 ` Mike Snitzer
2019-11-08 15:16 ` Mike Snitzer
2019-11-08 15:16 ` [f2fs-dev] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80bfc0e8-860d-3c11-07f4-08b7dd7fada4@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.