Re: [PATCH 3/9] block: Simplify report zones execution

[Hannes Reinecke <hare@suse.de>]

On 11/8/19 2:56 AM, Damien Le Moal wrote:
> All kernel users of blkdev_report_zones() as well as applications use
> through ioctl(BLKZONEREPORT) expect to potentially get less zone
> descriptors than requested. As such, the use of the internal report
> zones command execution loop implemented by blk_report_zones() is
> not necessary and can even be harmful to performance by causing the
> execution of inefficient small zones report command to service the
> reminder of a requested zone array.
> 
> This patch removes blk_report_zones(), simplifying the code. Also
> remove a now incorrect comment in dm_blk_report_zones().
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Javier Gonzalez <javier@javigon.com>
> ---
>  block/blk-zoned.c | 34 +++++-----------------------------
>  drivers/md/dm.c   |  6 ------
>  2 files changed, 5 insertions(+), 35 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      Teamlead Storage & Networking
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer