All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hal Feng <hal.feng@starfivetech.com>, Rob Herring <robh@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Ben Dooks <ben.dooks@sifive.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-riscv@lists.infradead.org, Conor Dooley <conor@kernel.org>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	linux-clk@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH v5 11/21] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator
Date: Mon, 13 Mar 2023 08:51:20 +0100	[thread overview]
Message-ID: <834fb899-7a03-ba0a-8302-f64ea58c60dd@linaro.org> (raw)
In-Reply-To: <80549148-1bad-9190-c4ea-a9555d15ca38@starfivetech.com>

On 13/03/2023 03:47, Hal Feng wrote:
> On Sat, 11 Mar 2023 08:17:00 -0600, Rob Herring wrote:
>> On Sat, 11 Mar 2023 17:07:23 +0800, Hal Feng wrote:
>>> From: Emil Renner Berthing <kernel@esmil.dk>
>>>
>>> Add bindings for the system clock and reset generator (SYSCRG) on the
>>> JH7110 RISC-V SoC by StarFive Ltd.
>>>
>>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>>> ---
>>>  .../clock/starfive,jh7110-syscrg.yaml         | 104 +++++++++
>>>  MAINTAINERS                                   |   8 +-
>>>  .../dt-bindings/clock/starfive,jh7110-crg.h   | 203 ++++++++++++++++++
>>>  .../dt-bindings/reset/starfive,jh7110-crg.h   | 142 ++++++++++++
>>>  4 files changed, 454 insertions(+), 3 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml
>>>  create mode 100644 include/dt-bindings/clock/starfive,jh7110-crg.h
>>>  create mode 100644 include/dt-bindings/reset/starfive,jh7110-crg.h
>>>
>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
>>
>> Missing tags:
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> This patch has been changed a lot and I am not sure whether it's still
> the one you want. So I removed the Reviewed-by tag.

Then mention it in changelog, just like Rob asked:
"If a tag was not added on purpose, please state why and what changed."
I don't see any explanation in the changelog about it.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hal Feng <hal.feng@starfivetech.com>, Rob Herring <robh@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Ben Dooks <ben.dooks@sifive.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-riscv@lists.infradead.org, Conor Dooley <conor@kernel.org>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	linux-clk@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH v5 11/21] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator
Date: Mon, 13 Mar 2023 08:51:20 +0100	[thread overview]
Message-ID: <834fb899-7a03-ba0a-8302-f64ea58c60dd@linaro.org> (raw)
In-Reply-To: <80549148-1bad-9190-c4ea-a9555d15ca38@starfivetech.com>

On 13/03/2023 03:47, Hal Feng wrote:
> On Sat, 11 Mar 2023 08:17:00 -0600, Rob Herring wrote:
>> On Sat, 11 Mar 2023 17:07:23 +0800, Hal Feng wrote:
>>> From: Emil Renner Berthing <kernel@esmil.dk>
>>>
>>> Add bindings for the system clock and reset generator (SYSCRG) on the
>>> JH7110 RISC-V SoC by StarFive Ltd.
>>>
>>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>>> ---
>>>  .../clock/starfive,jh7110-syscrg.yaml         | 104 +++++++++
>>>  MAINTAINERS                                   |   8 +-
>>>  .../dt-bindings/clock/starfive,jh7110-crg.h   | 203 ++++++++++++++++++
>>>  .../dt-bindings/reset/starfive,jh7110-crg.h   | 142 ++++++++++++
>>>  4 files changed, 454 insertions(+), 3 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml
>>>  create mode 100644 include/dt-bindings/clock/starfive,jh7110-crg.h
>>>  create mode 100644 include/dt-bindings/reset/starfive,jh7110-crg.h
>>>
>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
>>
>> Missing tags:
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> This patch has been changed a lot and I am not sure whether it's still
> the one you want. So I removed the Reviewed-by tag.

Then mention it in changelog, just like Rob asked:
"If a tag was not added on purpose, please state why and what changed."
I don't see any explanation in the changelog about it.

Best regards,
Krzysztof


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-03-13  7:51 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11  9:07 [PATCH v5 00/21] Basic clock, reset & device tree support for StarFive JH7110 RISC-V SoC Hal Feng
2023-03-11  9:07 ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 01/21] clk: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11 12:56   ` Conor Dooley
2023-03-11 12:56     ` Conor Dooley
2023-03-11  9:07 ` [PATCH v5 02/21] clk: starfive: Factor out common JH7100 and JH7110 code Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 03/21] clk: starfive: Rename clk-starfive-jh7100.h to clk-starfive-jh71x0.h Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-12 14:00   ` Conor Dooley
2023-03-12 14:00     ` Conor Dooley
2023-03-13  2:37     ` Hal Feng
2023-03-13  2:37       ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 04/21] clk: starfive: Rename "jh7100" to "jh71x0" for the common code Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-16 19:05   ` Tommaso Merciai
2023-03-16 19:05     ` Tommaso Merciai
2023-03-18  4:19     ` Hal Feng
2023-03-18  4:19       ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 05/21] reset: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11 12:56   ` Conor Dooley
2023-03-11 12:56     ` Conor Dooley
2023-03-14 14:34   ` Philipp Zabel
2023-03-14 14:34     ` Philipp Zabel
2023-03-20 11:51   ` Emil Renner Berthing
2023-03-20 11:51     ` Emil Renner Berthing
2023-03-11  9:07 ` [PATCH v5 06/21] reset: Create subdirectory for StarFive drivers Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-14 14:34   ` Philipp Zabel
2023-03-14 14:34     ` Philipp Zabel
2023-03-17  8:17     ` Hal Feng
2023-03-17  8:17       ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 07/21] reset: starfive: Factor out common JH71X0 reset code Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 08/21] reset: starfive: Extract the " Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 09/21] reset: starfive: Rename "jh7100" to "jh71x0" for the common code Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 10/21] reset: starfive: jh71x0: Use 32bit I/O on 32bit registers Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 11/21] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11 13:11   ` Conor Dooley
2023-03-11 13:11     ` Conor Dooley
2023-03-13  3:22     ` Hal Feng
2023-03-13  3:22       ` Hal Feng
2023-03-13  8:53       ` Emil Renner Berthing
2023-03-13  8:53         ` Emil Renner Berthing
2023-03-14 14:09         ` Hal Feng
2023-03-14 14:09           ` Hal Feng
2023-03-11 14:17   ` Rob Herring
2023-03-11 14:17     ` Rob Herring
2023-03-13  2:47     ` Hal Feng
2023-03-13  2:47       ` Hal Feng
2023-03-13  7:51       ` Krzysztof Kozlowski [this message]
2023-03-13  7:51         ` Krzysztof Kozlowski
2023-03-14 14:18         ` Hal Feng
2023-03-14 14:18           ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 12/21] dt-bindings: clock: Add StarFive JH7110 always-on " Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11 13:14   ` Conor Dooley
2023-03-11 13:14     ` Conor Dooley
2023-03-19 13:28     ` Hal Feng
2023-03-19 13:28       ` Hal Feng
2023-03-11 14:18   ` Rob Herring
2023-03-11 14:18     ` Rob Herring
2023-03-13  2:49     ` Hal Feng
2023-03-13  2:49       ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 13/21] clk: starfive: Add StarFive JH7110 system clock driver Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 14/21] clk: starfive: Add StarFive JH7110 always-on " Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 15/21] reset: starfive: Add StarFive JH7110 reset driver Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 16/21] dt-bindings: timer: Add StarFive JH7110 clint Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 17/21] dt-bindings: interrupt-controller: Add StarFive JH7110 plic Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 18/21] dt-bindings: riscv: Add SiFive S7 compatible Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 19/21] riscv: dts: starfive: Add initial StarFive JH7110 device tree Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 20/21] riscv: dts: starfive: Add StarFive JH7110 pin function definitions Hal Feng
2023-03-11  9:07   ` Hal Feng
2023-03-11  9:07 ` [PATCH v5 21/21] riscv: dts: starfive: Add StarFive JH7110 VisionFive 2 board device tree Hal Feng
2023-03-11  9:07   ` Hal Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834fb899-7a03-ba0a-8302-f64ea58c60dd@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=ben.dooks@sifive.com \
    --cc=conor@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=hal.feng@starfivetech.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.