* [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-28 14:05 ` [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Victor Toso
` (14 subsequent siblings)
15 siblings, 0 replies; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
@hide and @soft are potential additions which fits the TODO section
perfectly.
The main motivation is to avoid this whole block of comment entering
the wrong section in the python parser.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/block-export.json | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qapi/block-export.json b/qapi/block-export.json
index f183522d0d..1e34927f85 100644
--- a/qapi/block-export.json
+++ b/qapi/block-export.json
@@ -219,13 +219,13 @@
#
# @hard: Drop all connections immediately and remove export.
#
-# Potential additional modes to be added in the future:
+# TODO: Potential additional modes to be added in the future:
#
-# hide: Just hide export from new clients, leave existing connections as is.
-# Remove export after all clients are disconnected.
+# hide: Just hide export from new clients, leave existing connections as is.
+# Remove export after all clients are disconnected.
#
-# soft: Hide export from new clients, answer with ESHUTDOWN for all further
-# requests from existing clients.
+# soft: Hide export from new clients, answer with ESHUTDOWN for all further
+# requests from existing clients.
#
# Since: 2.12
##
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
2022-03-28 14:05 ` [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-29 15:34 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event Victor Toso
` (13 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @fatal. Provide it.
Example output shows a value of @msg no version of the code
produces. No big deal, but replace it anyway by one that
today's code does produce.
Signed-off-by: Victor Toso <victortoso@redhat.com>
---
qapi/block-core.json | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index e89f2dfb5b..63c30a5378 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -5006,10 +5006,9 @@
# Example:
#
# <- { "event": "BLOCK_IMAGE_CORRUPTED",
-# "data": { "device": "ide0-hd0", "node-name": "node0",
-# "msg": "Prevented active L1 table overwrite", "offset": 196608,
-# "size": 65536 },
-# "timestamp": { "seconds": 1378126126, "microseconds": 966463 } }
+# "data": { "device": "", "node-name": "drive", "fatal": false,
+# "msg": "L2 table offset 0x2a2a2a00 unaligned (L1 index: 0)" },
+# "timestamp": { "seconds": 1648243240, "microseconds": 906060 } }
#
# Since: 1.7
##
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event
2022-03-28 14:05 ` [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Victor Toso
@ 2022-03-29 15:34 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:34 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @fatal. Provide it.
>
> Example output shows a value of @msg no version of the code
> produces. No big deal, but replace it anyway by one that
> today's code does produce.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/block-core.json | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e89f2dfb5b..63c30a5378 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -5006,10 +5006,9 @@
> # Example:
> #
> # <- { "event": "BLOCK_IMAGE_CORRUPTED",
> -# "data": { "device": "ide0-hd0", "node-name": "node0",
> -# "msg": "Prevented active L1 table overwrite", "offset": 196608,
> -# "size": 65536 },
> -# "timestamp": { "seconds": 1378126126, "microseconds": 966463 } }
> +# "data": { "device": "", "node-name": "drive", "fatal": false,
> +# "msg": "L2 table offset 0x2a2a2a00 unaligned (L1 index: 0)" },
> +# "timestamp": { "seconds": 1648243240, "microseconds": 906060 } }
> #
> # Since: 1.7
> ##
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
2022-03-28 14:05 ` [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO Victor Toso
2022-03-28 14:05 ` [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-29 15:39 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event Victor Toso
` (12 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @reason. Provide it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
---
qapi/block-core.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 63c30a5378..46580ac551 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -5058,7 +5058,8 @@
# "data": { "device": "ide0-hd1",
# "node-name": "#block212",
# "operation": "write",
-# "action": "stop" },
+# "action": "stop",
+# "reason": "No space left on device" },
# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
#
##
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event
2022-03-28 14:05 ` [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event Victor Toso
@ 2022-03-29 15:39 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:39 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @reason. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/block-core.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 63c30a5378..46580ac551 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -5058,7 +5058,8 @@
> # "data": { "device": "ide0-hd1",
> # "node-name": "#block212",
> # "operation": "write",
> -# "action": "stop" },
> +# "action": "stop",
> +# "reason": "No space left on device" },
> # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> #
> ##
I briefly wondered whether "reason": "No space left on device" implies
"nospace: true, but it looks like it doesn't.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (2 preceding siblings ...)
2022-03-28 14:05 ` [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-28 14:05 ` [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event Victor Toso
` (11 subsequent siblings)
15 siblings, 0 replies; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output has the wrong event's name in it. Fix it.
Example output shows incorrect member @device. Fix it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
qapi/block-core.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 46580ac551..4a7a6940a3 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -5225,8 +5225,8 @@
#
# Example:
#
-# <- { "event": "BLOCK_JOB_WAITING",
-# "data": { "device": "drive0", "type": "mirror" },
+# <- { "event": "BLOCK_JOB_PENDING",
+# "data": { "type": "mirror", "id": "backup_1" },
# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
#
##
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (3 preceding siblings ...)
2022-03-28 14:05 ` [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-28 14:05 ` [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Victor Toso
` (10 subsequent siblings)
15 siblings, 0 replies; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @timestamp. Provide it.
Example output is not properly formatted. Fixing it by:
- Adding '<-' to signalize it is receiving the data;
- Adding extra spaces around members @result, @total and @completed
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/dump.json | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/qapi/dump.json b/qapi/dump.json
index f7c4267e3f..9119c82b14 100644
--- a/qapi/dump.json
+++ b/qapi/dump.json
@@ -161,9 +161,10 @@
#
# Example:
#
-# { "event": "DUMP_COMPLETED",
-# "data": {"result": {"total": 1090650112, "status": "completed",
-# "completed": 1090650112} } }
+# <- { "event": "DUMP_COMPLETED",
+# "data": { "result": { "total": 1090650112, "status": "completed",
+# "completed": 1090650112 } },
+# "timestamp": { "seconds": 1648244171, "microseconds": 950316 } }
#
##
{ 'event': 'DUMP_COMPLETED' ,
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (4 preceding siblings ...)
2022-03-28 14:05 ` [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-28 14:05 ` [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event Victor Toso
` (9 subsequent siblings)
15 siblings, 0 replies; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @qom-path. Provide it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
qapi/machine.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 42fc68403d..9c460ec450 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1356,7 +1356,8 @@
# Example:
#
# <- { "event": "MEMORY_DEVICE_SIZE_CHANGE",
-# "data": { "id": "vm0", "size": 1073741824},
+# "data": { "id": "vm0", "size": 1073741824,
+# "qom-path": "/machine/unattached/device[2]" },
# "timestamp": { "seconds": 1588168529, "microseconds": 201316 } }
#
##
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (5 preceding siblings ...)
2022-03-28 14:05 ` [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-29 15:40 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Victor Toso
` (8 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @timestamp. Provide it.
Example output is not properly formatted. Fixing it by:
- Adding '<-' to signalize it is receiving the data;
- Breaking lines similar to the other examples.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/migration.json | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 18e2610e88..092a63354b 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1736,7 +1736,9 @@
# Since: 4.2
#
# Example:
-# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} }
+# <- { "event": "UNPLUG_PRIMARY",
+# "data": { "device-id": "hostdev0" },
+# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
#
##
{ 'event': 'UNPLUG_PRIMARY',
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event
2022-03-28 14:05 ` [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event Victor Toso
@ 2022-03-29 15:40 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:40 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @timestamp. Provide it.
>
> Example output is not properly formatted. Fixing it by:
> - Adding '<-' to signalize it is receiving the data;
> - Breaking lines similar to the other examples.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/migration.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 18e2610e88..092a63354b 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1736,7 +1736,9 @@
> # Since: 4.2
> #
> # Example:
> -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} }
> +# <- { "event": "UNPLUG_PRIMARY",
> +# "data": { "device-id": "hostdev0" },
> +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> #
> ##
> { 'event': 'UNPLUG_PRIMARY',
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (6 preceding siblings ...)
2022-03-28 14:05 ` [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-29 15:41 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events Victor Toso
` (7 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @timestamp. Provide it.
Event's documentation is not properly formatted. Fix it by:
- Adding @ to "device-id"
- Adding extra line for "Since" section
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/net.json | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qapi/net.json b/qapi/net.json
index 7fab2e7cd8..0d4578bd07 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -685,13 +685,15 @@
# Failover primary devices which were hidden (not hotplugged when requested)
# before will now be hotplugged by the virtio-net standby device.
#
-# device-id: QEMU device id of the unplugged device
+# @device-id: QEMU device id of the unplugged device
+#
# Since: 4.2
#
# Example:
#
# <- { "event": "FAILOVER_NEGOTIATED",
-# "data": "net1" }
+# "data": { "device-id": "net1" },
+# "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
#
##
{ 'event': 'FAILOVER_NEGOTIATED',
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event
2022-03-28 14:05 ` [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Victor Toso
@ 2022-03-29 15:41 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:41 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel, Markus Armbruster
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @timestamp. Provide it.
>
> Event's documentation is not properly formatted. Fix it by:
> - Adding @ to "device-id"
> - Adding extra line for "Since" section
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/net.json | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/net.json b/qapi/net.json
> index 7fab2e7cd8..0d4578bd07 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -685,13 +685,15 @@
> # Failover primary devices which were hidden (not hotplugged when requested)
> # before will now be hotplugged by the virtio-net standby device.
> #
> -# device-id: QEMU device id of the unplugged device
> +# @device-id: QEMU device id of the unplugged device
> +#
> # Since: 4.2
> #
> # Example:
> #
> # <- { "event": "FAILOVER_NEGOTIATED",
> -# "data": "net1" }
> +# "data": { "device-id": "net1" },
> +# "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
> #
> ##
> { 'event': 'FAILOVER_NEGOTIATED',
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (7 preceding siblings ...)
2022-03-28 14:05 ` [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Victor Toso
@ 2022-03-28 14:05 ` Victor Toso
2022-03-29 15:45 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp Victor Toso
` (6 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @reason. Provide it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/run-state.json | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qapi/run-state.json b/qapi/run-state.json
index 43d66d700f..1b9f64c9cd 100644
--- a/qapi/run-state.json
+++ b/qapi/run-state.json
@@ -150,7 +150,8 @@
#
# Example:
#
-# <- { "event": "SHUTDOWN", "data": { "guest": true },
+# <- { "event": "SHUTDOWN",
+# "data": { "guest": true, "reason": "guest-shutdown" },
# "timestamp": { "seconds": 1267040730, "microseconds": 682951 } }
#
##
@@ -188,7 +189,8 @@
#
# Example:
#
-# <- { "event": "RESET", "data": { "guest": false },
+# <- { "event": "RESET",
+# "data": { "guest": false, "reason": "guest-reset" },
# "timestamp": { "seconds": 1267041653, "microseconds": 9518 } }
#
##
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events
2022-03-28 14:05 ` [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events Victor Toso
@ 2022-03-29 15:45 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:45 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel, Markus Armbruster
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @reason. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/run-state.json | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 43d66d700f..1b9f64c9cd 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -150,7 +150,8 @@
> #
> # Example:
> #
> -# <- { "event": "SHUTDOWN", "data": { "guest": true },
> +# <- { "event": "SHUTDOWN",
> +# "data": { "guest": true, "reason": "guest-shutdown" },
> # "timestamp": { "seconds": 1267040730, "microseconds": 682951 } }
> #
> ##
> @@ -188,7 +189,8 @@
> #
> # Example:
> #
> -# <- { "event": "RESET", "data": { "guest": false },
> +# <- { "event": "RESET",
> +# "data": { "guest": false, "reason": "guest-reset" },
> # "timestamp": { "seconds": 1267041653, "microseconds": 9518 } }
> #
> ##
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (8 preceding siblings ...)
2022-03-28 14:05 ` [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events Victor Toso
@ 2022-03-28 14:06 ` Victor Toso
2022-03-29 15:46 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE Victor Toso
` (5 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
The changed examples were lacking mandatory member @timestamp.
Provide it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/run-state.json | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qapi/run-state.json b/qapi/run-state.json
index 1b9f64c9cd..7f1c788c4e 100644
--- a/qapi/run-state.json
+++ b/qapi/run-state.json
@@ -426,7 +426,8 @@
# Example:
#
# <- { "event": "GUEST_PANICKED",
-# "data": { "action": "pause" } }
+# "data": { "action": "pause" },
+# "timestamp": { "seconds": 1648245231, "microseconds": 900001 } }
#
##
{ 'event': 'GUEST_PANICKED',
@@ -446,7 +447,8 @@
# Example:
#
# <- { "event": "GUEST_CRASHLOADED",
-# "data": { "action": "run" } }
+# "data": { "action": "run" },
+# "timestamp": { "seconds": 1648245259, "microseconds": 893771 } }
#
##
{ 'event': 'GUEST_CRASHLOADED',
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp
2022-03-28 14:06 ` [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp Victor Toso
@ 2022-03-29 15:46 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:46 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel, Markus Armbruster
Victor Toso <victortoso@redhat.com> writes:
> The changed examples were lacking mandatory member @timestamp.
> Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/run-state.json | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 1b9f64c9cd..7f1c788c4e 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -426,7 +426,8 @@
> # Example:
> #
> # <- { "event": "GUEST_PANICKED",
> -# "data": { "action": "pause" } }
> +# "data": { "action": "pause" },
> +# "timestamp": { "seconds": 1648245231, "microseconds": 900001 } }
> #
> ##
> { 'event': 'GUEST_PANICKED',
> @@ -446,7 +447,8 @@
> # Example:
> #
> # <- { "event": "GUEST_CRASHLOADED",
> -# "data": { "action": "run" } }
> +# "data": { "action": "run" },
> +# "timestamp": { "seconds": 1648245259, "microseconds": 893771 } }
> #
> ##
> { 'event': 'GUEST_CRASHLOADED',
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (9 preceding siblings ...)
2022-03-28 14:06 ` [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp Victor Toso
@ 2022-03-28 14:06 ` Victor Toso
2022-03-29 15:52 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 12/14] qapi: ui examples: add missing @websocket member Victor Toso
` (4 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @timestamp. Provide it.
While @flags is an optional member, if it is defined then all its
members should be include. For that reason, we add @recursive member.
Minor: Change quotes from '' to "" in @action-required member.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/run-state.json | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/run-state.json b/qapi/run-state.json
index 7f1c788c4e..8124220bd9 100644
--- a/qapi/run-state.json
+++ b/qapi/run-state.json
@@ -571,7 +571,9 @@
# <- { "event": "MEMORY_FAILURE",
# "data": { "recipient": "hypervisor",
# "action": "fatal",
-# "flags": { 'action-required': false } }
+# "flags": { "action-required": false,
+# "recursive": false } },
+# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } }
#
##
{ 'event': 'MEMORY_FAILURE',
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE
2022-03-28 14:06 ` [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE Victor Toso
@ 2022-03-29 15:52 ` Markus Armbruster
2022-03-30 10:15 ` Victor Toso
0 siblings, 1 reply; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:52 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @timestamp. Provide it.
>
> While @flags is an optional member,
Uh, it isn't.
> if it is defined then all its
> members should be include. For that reason, we add @recursive member.
Perhaps:
Example output lacks mandatory member flags.recursive. Provide it.
Happy to make such a change in my tree.
> Minor: Change quotes from '' to "" in @action-required member.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/run-state.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 7f1c788c4e..8124220bd9 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -571,7 +571,9 @@
> # <- { "event": "MEMORY_FAILURE",
> # "data": { "recipient": "hypervisor",
> # "action": "fatal",
> -# "flags": { 'action-required': false } }
> +# "flags": { "action-required": false,
> +# "recursive": false } },
> +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } }
> #
> ##
> { 'event': 'MEMORY_FAILURE',
With the commit message fixed:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE
2022-03-29 15:52 ` Markus Armbruster
@ 2022-03-30 10:15 ` Victor Toso
0 siblings, 0 replies; 29+ messages in thread
From: Victor Toso @ 2022-03-30 10:15 UTC (permalink / raw)
To: Markus Armbruster; +Cc: John Snow, Eric Blake, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]
Hi,
On Tue, Mar 29, 2022 at 05:52:47PM +0200, Markus Armbruster wrote:
> Victor Toso <victortoso@redhat.com> writes:
>
> > Example output lacks mandatory member @timestamp. Provide it.
> >
> > While @flags is an optional member,
>
> Uh, it isn't.
Wow! I was so sure I saw "*flags" before. Nice catch.
> > if it is defined then all its
> > members should be include. For that reason, we add @recursive member.
>
> Perhaps:
>
> Example output lacks mandatory member flags.recursive. Provide it.
>
> Happy to make such a change in my tree.
Yes, many thanks!
> > Minor: Change quotes from '' to "" in @action-required member.
> >
> > Signed-off-by: Victor Toso <victortoso@redhat.com>
> > Reviewed-by: John Snow <jsnow@redhat.com>
> > ---
> > qapi/run-state.json | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi/run-state.json b/qapi/run-state.json
> > index 7f1c788c4e..8124220bd9 100644
> > --- a/qapi/run-state.json
> > +++ b/qapi/run-state.json
> > @@ -571,7 +571,9 @@
> > # <- { "event": "MEMORY_FAILURE",
> > # "data": { "recipient": "hypervisor",
> > # "action": "fatal",
> > -# "flags": { 'action-required': false } }
> > +# "flags": { "action-required": false,
> > +# "recursive": false } },
> > +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } }
> > #
> > ##
> > { 'event': 'MEMORY_FAILURE',
>
> With the commit message fixed:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Cheers,
Victor
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 12/14] qapi: ui examples: add missing @websocket member
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (10 preceding siblings ...)
2022-03-28 14:06 ` [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE Victor Toso
@ 2022-03-28 14:06 ` Victor Toso
2022-03-29 15:55 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event Victor Toso
` (3 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
The examples were missing mandatory member @websocket. Provide it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/ui.json | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index 664da9e462..a810ed680c 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -710,10 +710,10 @@
#
# <- { "event": "VNC_CONNECTED",
# "data": {
-# "server": { "auth": "sasl", "family": "ipv4",
+# "server": { "auth": "sasl", "family": "ipv4", "websocket": false,
# "service": "5901", "host": "0.0.0.0" },
# "client": { "family": "ipv4", "service": "58425",
-# "host": "127.0.0.1" } },
+# "host": "127.0.0.1", "websocket": false } },
# "timestamp": { "seconds": 1262976601, "microseconds": 975795 } }
#
##
@@ -738,9 +738,9 @@
#
# <- { "event": "VNC_INITIALIZED",
# "data": {
-# "server": { "auth": "sasl", "family": "ipv4",
+# "server": { "auth": "sasl", "family": "ipv4", "websocket": false,
# "service": "5901", "host": "0.0.0.0"},
-# "client": { "family": "ipv4", "service": "46089",
+# "client": { "family": "ipv4", "service": "46089", "websocket": false,
# "host": "127.0.0.1", "sasl_username": "luiz" } },
# "timestamp": { "seconds": 1263475302, "microseconds": 150772 } }
#
@@ -765,9 +765,9 @@
#
# <- { "event": "VNC_DISCONNECTED",
# "data": {
-# "server": { "auth": "sasl", "family": "ipv4",
+# "server": { "auth": "sasl", "family": "ipv4", "websocket": false,
# "service": "5901", "host": "0.0.0.0" },
-# "client": { "family": "ipv4", "service": "58425",
+# "client": { "family": "ipv4", "service": "58425", "websocket": false,
# "host": "127.0.0.1", "sasl_username": "luiz" } },
# "timestamp": { "seconds": 1262976601, "microseconds": 975795 } }
#
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 12/14] qapi: ui examples: add missing @websocket member
2022-03-28 14:06 ` [PATCH v3 12/14] qapi: ui examples: add missing @websocket member Victor Toso
@ 2022-03-29 15:55 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:55 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> The examples were missing mandatory member @websocket. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/ui.json | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 664da9e462..a810ed680c 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -710,10 +710,10 @@
> #
> # <- { "event": "VNC_CONNECTED",
> # "data": {
> -# "server": { "auth": "sasl", "family": "ipv4",
> +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false,
> # "service": "5901", "host": "0.0.0.0" },
> # "client": { "family": "ipv4", "service": "58425",
> -# "host": "127.0.0.1" } },
> +# "host": "127.0.0.1", "websocket": false } },
> # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } }
> #
> ##
> @@ -738,9 +738,9 @@
> #
> # <- { "event": "VNC_INITIALIZED",
> # "data": {
> -# "server": { "auth": "sasl", "family": "ipv4",
> +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false,
> # "service": "5901", "host": "0.0.0.0"},
> -# "client": { "family": "ipv4", "service": "46089",
> +# "client": { "family": "ipv4", "service": "46089", "websocket": false,
> # "host": "127.0.0.1", "sasl_username": "luiz" } },
> # "timestamp": { "seconds": 1263475302, "microseconds": 150772 } }
> #
> @@ -765,9 +765,9 @@
> #
> # <- { "event": "VNC_DISCONNECTED",
> # "data": {
> -# "server": { "auth": "sasl", "family": "ipv4",
> +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false,
> # "service": "5901", "host": "0.0.0.0" },
> -# "client": { "family": "ipv4", "service": "58425",
> +# "client": { "family": "ipv4", "service": "58425", "websocket": false,
> # "host": "127.0.0.1", "sasl_username": "luiz" } },
> # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } }
> #
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (11 preceding siblings ...)
2022-03-28 14:06 ` [PATCH v3 12/14] qapi: ui examples: add missing @websocket member Victor Toso
@ 2022-03-28 14:06 ` Victor Toso
2022-03-29 15:55 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 14/14] qapi: fix example of dump-guest-memory Victor Toso
` (2 subsequent siblings)
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @timestamp. Provide it.
Event's @data member is missing @info object. Provide it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/acpi.json | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qapi/acpi.json b/qapi/acpi.json
index 51f0d55db7..d148f6db9f 100644
--- a/qapi/acpi.json
+++ b/qapi/acpi.json
@@ -133,8 +133,9 @@
# Example:
#
# <- { "event": "ACPI_DEVICE_OST",
-# "data": { "device": "d1", "slot": "0",
-# "slot-type": "DIMM", "source": 1, "status": 0 } }
+# "data": { "info": { "device": "d1", "slot": "0",
+# "slot-type": "DIMM", "source": 1, "status": 0 } },
+# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
#
##
{ 'event': 'ACPI_DEVICE_OST',
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event
2022-03-28 14:06 ` [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event Victor Toso
@ 2022-03-29 15:55 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:55 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel, Markus Armbruster
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @timestamp. Provide it.
>
> Event's @data member is missing @info object. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/acpi.json | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/acpi.json b/qapi/acpi.json
> index 51f0d55db7..d148f6db9f 100644
> --- a/qapi/acpi.json
> +++ b/qapi/acpi.json
> @@ -133,8 +133,9 @@
> # Example:
> #
> # <- { "event": "ACPI_DEVICE_OST",
> -# "data": { "device": "d1", "slot": "0",
> -# "slot-type": "DIMM", "source": 1, "status": 0 } }
> +# "data": { "info": { "device": "d1", "slot": "0",
> +# "slot-type": "DIMM", "source": 1, "status": 0 } },
> +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> #
> ##
> { 'event': 'ACPI_DEVICE_OST',
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v3 14/14] qapi: fix example of dump-guest-memory
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (12 preceding siblings ...)
2022-03-28 14:06 ` [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event Victor Toso
@ 2022-03-28 14:06 ` Victor Toso
2022-03-29 15:56 ` Markus Armbruster
2022-03-29 16:00 ` [PATCH v3 00/14] Fix some qapi examples and a TODO section Markus Armbruster
2022-03-31 10:44 ` Markus Armbruster
15 siblings, 1 reply; 29+ messages in thread
From: Victor Toso @ 2022-03-28 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Eric Blake, Markus Armbruster
Example output lacks mandatory member @paging. Provide it.
Signed-off-by: Victor Toso <victortoso@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/dump.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/dump.json b/qapi/dump.json
index 9119c82b14..29441af9d8 100644
--- a/qapi/dump.json
+++ b/qapi/dump.json
@@ -83,7 +83,7 @@
# Example:
#
# -> { "execute": "dump-guest-memory",
-# "arguments": { "protocol": "fd:dump" } }
+# "arguments": { "paging": false, "protocol": "fd:dump" } }
# <- { "return": {} }
#
##
--
2.35.1
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v3 14/14] qapi: fix example of dump-guest-memory
2022-03-28 14:06 ` [PATCH v3 14/14] qapi: fix example of dump-guest-memory Victor Toso
@ 2022-03-29 15:56 ` Markus Armbruster
0 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 15:56 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @paging. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/dump.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/dump.json b/qapi/dump.json
> index 9119c82b14..29441af9d8 100644
> --- a/qapi/dump.json
> +++ b/qapi/dump.json
> @@ -83,7 +83,7 @@
> # Example:
> #
> # -> { "execute": "dump-guest-memory",
> -# "arguments": { "protocol": "fd:dump" } }
> +# "arguments": { "paging": false, "protocol": "fd:dump" } }
> # <- { "return": {} }
> #
> ##
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (13 preceding siblings ...)
2022-03-28 14:06 ` [PATCH v3 14/14] qapi: fix example of dump-guest-memory Victor Toso
@ 2022-03-29 16:00 ` Markus Armbruster
2022-03-29 16:14 ` John Snow
2022-03-31 10:44 ` Markus Armbruster
15 siblings, 1 reply; 29+ messages in thread
From: Markus Armbruster @ 2022-03-29 16:00 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> Hi,
>
> I've being using the examples as unit tests and found a few that
> doesn't work out-of-the-box, might be inteded in order to be less
> verbose in the qapi documentation but nevertheless I'm sending this
> out in case you want to cherry-pick them.
Lovely doc fixes. I want them all. Thanks!
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section
2022-03-29 16:00 ` [PATCH v3 00/14] Fix some qapi examples and a TODO section Markus Armbruster
@ 2022-03-29 16:14 ` John Snow
0 siblings, 0 replies; 29+ messages in thread
From: John Snow @ 2022-03-29 16:14 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Eric Blake, Victor Toso, qemu-devel
On Tue, Mar 29, 2022 at 12:00 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> Victor Toso <victortoso@redhat.com> writes:
>
> > Hi,
> >
> > I've being using the examples as unit tests and found a few that
> > doesn't work out-of-the-box, might be inteded in order to be less
> > verbose in the qapi documentation but nevertheless I'm sending this
> > out in case you want to cherry-pick them.
>
> Lovely doc fixes. I want them all. Thanks!
>
Seconded.
Reviewed-by: John Snow <jsnow@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
` (14 preceding siblings ...)
2022-03-29 16:00 ` [PATCH v3 00/14] Fix some qapi examples and a TODO section Markus Armbruster
@ 2022-03-31 10:44 ` Markus Armbruster
15 siblings, 0 replies; 29+ messages in thread
From: Markus Armbruster @ 2022-03-31 10:44 UTC (permalink / raw)
To: Victor Toso; +Cc: John Snow, Eric Blake, qemu-devel
Victor Toso <victortoso@redhat.com> writes:
> Hi,
>
> I've being using the examples as unit tests and found a few that
> doesn't work out-of-the-box, might be inteded in order to be less
> verbose in the qapi documentation but nevertheless I'm sending this
> out in case you want to cherry-pick them.
All queued, thanks!
^ permalink raw reply [flat|nested] 29+ messages in thread