From: Juan Quintela <quintela@redhat.com> To: Paolo Bonzini <pbonzini@redhat.com> Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Radim Krcmar <rkrcmar@redhat.com>, Eduardo Habkost <ehabkost@redhat.com> Subject: Re: [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration Date: Mon, 14 Nov 2016 15:11:44 +0100 [thread overview] Message-ID: <87zil2ducf.fsf@emacs.mitica> (raw) In-Reply-To: <a3e00c38-4d4d-d353-231d-9eb0233139e2@redhat.com> (Paolo Bonzini's message of "Mon, 14 Nov 2016 14:54:38 +0100") Paolo Bonzini <pbonzini@redhat.com> wrote: > On 14/11/2016 13:36, Marcelo Tosatti wrote: >> + /* local (running VM) restore */ >> + if (s->clock_valid) { >> + /* >> + * if host does not support reliable KVM_GET_CLOCK, >> + * read kvmclock value from memory >> + */ >> + if (!kvm_has_adjust_clock_stable()) { >> + time_at_migration = kvmclock_current_nsec(s); > > Just assign to s->clock here... Agreed, I just wanted to make so many changes. > Also, just another small nit: please make your scripts use the "-p" > option on diff. :) YESSSS I was searching what functions the code belonged for :p Thanks, Juan.
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com> To: Paolo Bonzini <pbonzini@redhat.com> Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Radim Krcmar <rkrcmar@redhat.com>, Eduardo Habkost <ehabkost@redhat.com> Subject: Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration Date: Mon, 14 Nov 2016 15:11:44 +0100 [thread overview] Message-ID: <87zil2ducf.fsf@emacs.mitica> (raw) In-Reply-To: <a3e00c38-4d4d-d353-231d-9eb0233139e2@redhat.com> (Paolo Bonzini's message of "Mon, 14 Nov 2016 14:54:38 +0100") Paolo Bonzini <pbonzini@redhat.com> wrote: > On 14/11/2016 13:36, Marcelo Tosatti wrote: >> + /* local (running VM) restore */ >> + if (s->clock_valid) { >> + /* >> + * if host does not support reliable KVM_GET_CLOCK, >> + * read kvmclock value from memory >> + */ >> + if (!kvm_has_adjust_clock_stable()) { >> + time_at_migration = kvmclock_current_nsec(s); > > Just assign to s->clock here... Agreed, I just wanted to make so many changes. > Also, just another small nit: please make your scripts use the "-p" > option on diff. :) YESSSS I was searching what functions the code belonged for :p Thanks, Juan.
next prev parent reply other threads:[~2016-11-14 14:11 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-14 12:36 [qemu patch 0/2] improve kvmclock difference on migration Marcelo Tosatti 2016-11-14 12:36 ` [Qemu-devel] " Marcelo Tosatti 2016-11-14 12:36 ` [qemu patch 1/2] kvm: sync linux headers Marcelo Tosatti 2016-11-14 12:36 ` [Qemu-devel] " Marcelo Tosatti 2016-11-14 12:36 ` [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration Marcelo Tosatti 2016-11-14 12:36 ` [Qemu-devel] " Marcelo Tosatti 2016-11-14 13:54 ` Paolo Bonzini 2016-11-14 13:54 ` [Qemu-devel] " Paolo Bonzini 2016-11-14 14:00 ` Marcelo Tosatti 2016-11-14 14:00 ` [Qemu-devel] " Marcelo Tosatti 2016-11-14 14:22 ` Paolo Bonzini 2016-11-14 14:22 ` [Qemu-devel] " Paolo Bonzini 2016-11-14 14:50 ` Marcelo Tosatti 2016-11-14 14:50 ` [Qemu-devel] " Marcelo Tosatti 2016-11-14 15:00 ` Paolo Bonzini 2016-11-14 15:00 ` [Qemu-devel] " Paolo Bonzini 2016-11-14 15:40 ` Marcelo Tosatti 2016-11-14 15:40 ` [Qemu-devel] " Marcelo Tosatti 2016-11-14 16:43 ` Paolo Bonzini 2016-11-14 16:43 ` [Qemu-devel] " Paolo Bonzini 2016-11-14 17:13 ` Marcelo Tosatti 2016-11-14 17:13 ` [Qemu-devel] " Marcelo Tosatti 2016-11-14 17:20 ` Paolo Bonzini 2016-11-14 17:20 ` [Qemu-devel] " Paolo Bonzini 2016-11-14 18:15 ` Marcelo Tosatti 2016-11-14 18:15 ` [Qemu-devel] " Marcelo Tosatti 2016-11-17 12:16 ` Marcelo Tosatti 2016-11-17 12:16 ` [Qemu-devel] " Marcelo Tosatti 2016-11-17 13:03 ` Paolo Bonzini 2016-11-17 13:03 ` [Qemu-devel] " Paolo Bonzini 2016-11-28 13:47 ` Paolo Bonzini 2016-11-28 13:47 ` [Qemu-devel] " Paolo Bonzini 2016-11-28 14:28 ` Eduardo Habkost 2016-11-28 14:28 ` [Qemu-devel] " Eduardo Habkost 2016-11-28 15:12 ` Paolo Bonzini 2016-11-28 15:12 ` [Qemu-devel] " Paolo Bonzini 2016-11-28 16:36 ` Marcelo Tosatti 2016-11-28 16:36 ` [Qemu-devel] " Marcelo Tosatti 2016-11-28 17:30 ` Paolo Bonzini 2016-11-28 17:30 ` [Qemu-devel] " Paolo Bonzini 2016-11-14 14:11 ` Juan Quintela [this message] 2016-11-14 14:11 ` Juan Quintela 2016-11-14 14:09 ` Juan Quintela 2016-11-14 14:09 ` [Qemu-devel] " Juan Quintela 2016-11-14 15:37 ` Marcelo Tosatti 2016-11-14 15:37 ` [Qemu-devel] " Marcelo Tosatti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87zil2ducf.fsf@emacs.mitica \ --to=quintela@redhat.com \ --cc=dgilbert@redhat.com \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rkrcmar@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.