All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sebastian Döring" <moralapostel+linuxkernel@gmail.com>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: Ivan Babrou <ivan@ivan.computer>,
	sashal@kernel.org, alexandre.torgue@foss.st.com,
	davem@davemloft.net, joabreu@synopsys.com, kuba@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
	peppe.cavallaro@st.com, wens@kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Tue, 14 Sep 2021 15:39:39 +0200	[thread overview]
Message-ID: <CADkZQakh49i-M_1NgsENkqBnacVo6J3Rj8D2NFijvyBts9Pneg@mail.gmail.com> (raw)
In-Reply-To: <2ada6f05-fc3a-a301-a008-594f7665a514@wolfvision.net>

Hi Michael,

I guess looking for a better or more ideal solution sounds good, but
sorry if this is impertinent, as it's coming from a mostly uninvolved
3rd party: This is affects a kernel that is labeled as "stable". It
seems extremely unacceptable to break ethernet support for boards like
the rockpro64, which are used largely in a headless fashion, when the
offending commit has already been identified.

I don't expect a stable kernel release to completely break my hardware
and then see people not immediately applying a workaround patch. It
seems strange. I'm not fond of having to fix things through serial
console and hunting through mailing lists to figure out what's going
on. I'd only expect this for -rc kernels.

Just my two cents.

Best regards,
Sebastian

Am Di., 14. Sept. 2021 um 12:09 Uhr schrieb Michael Riesch
<michael.riesch@wolfvision.net>:
>
> Hello Ivan,
>
> On 9/14/21 3:10 AM, Ivan Babrou wrote:
> > Is it possible to revert the patch from the 5.14 and 5.15 as well?
> > I've tried upgrading my rockpro64 board from 5.13 to 5.15-rc1 and
> > ended up bisecting the issue to this commit like the others. It would
> > be nice to spare others from this exercise.
>
> For what it is worth we believe that there is a different issue with the
> dwmac-rk driver that was obscured by calling pm_runtime_get_sync()
> early. Investigation in progress -- I hope that we can achieve a proper
> solution before we have to revert the revert.
>
> Best regards,
> Michael

WARNING: multiple messages have this Message-ID (diff)
From: "Sebastian Döring" <moralapostel+linuxkernel@gmail.com>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: Ivan Babrou <ivan@ivan.computer>,
	sashal@kernel.org, alexandre.torgue@foss.st.com,
	 davem@davemloft.net, joabreu@synopsys.com, kuba@kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	 mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
	peppe.cavallaro@st.com,  wens@kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Tue, 14 Sep 2021 15:39:39 +0200	[thread overview]
Message-ID: <CADkZQakh49i-M_1NgsENkqBnacVo6J3Rj8D2NFijvyBts9Pneg@mail.gmail.com> (raw)
In-Reply-To: <2ada6f05-fc3a-a301-a008-594f7665a514@wolfvision.net>

Hi Michael,

I guess looking for a better or more ideal solution sounds good, but
sorry if this is impertinent, as it's coming from a mostly uninvolved
3rd party: This is affects a kernel that is labeled as "stable". It
seems extremely unacceptable to break ethernet support for boards like
the rockpro64, which are used largely in a headless fashion, when the
offending commit has already been identified.

I don't expect a stable kernel release to completely break my hardware
and then see people not immediately applying a workaround patch. It
seems strange. I'm not fond of having to fix things through serial
console and hunting through mailing lists to figure out what's going
on. I'd only expect this for -rc kernels.

Just my two cents.

Best regards,
Sebastian

Am Di., 14. Sept. 2021 um 12:09 Uhr schrieb Michael Riesch
<michael.riesch@wolfvision.net>:
>
> Hello Ivan,
>
> On 9/14/21 3:10 AM, Ivan Babrou wrote:
> > Is it possible to revert the patch from the 5.14 and 5.15 as well?
> > I've tried upgrading my rockpro64 board from 5.13 to 5.15-rc1 and
> > ended up bisecting the issue to this commit like the others. It would
> > be nice to spare others from this exercise.
>
> For what it is worth we believe that there is a different issue with the
> dwmac-rk driver that was obscured by calling pm_runtime_get_sync()
> early. Investigation in progress -- I hope that we can achieve a proper
> solution before we have to revert the revert.
>
> Best regards,
> Michael

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Sebastian Döring" <moralapostel+linuxkernel@gmail.com>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: Ivan Babrou <ivan@ivan.computer>,
	sashal@kernel.org, alexandre.torgue@foss.st.com,
	 davem@davemloft.net, joabreu@synopsys.com, kuba@kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	 mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
	peppe.cavallaro@st.com,  wens@kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Tue, 14 Sep 2021 15:39:39 +0200	[thread overview]
Message-ID: <CADkZQakh49i-M_1NgsENkqBnacVo6J3Rj8D2NFijvyBts9Pneg@mail.gmail.com> (raw)
In-Reply-To: <2ada6f05-fc3a-a301-a008-594f7665a514@wolfvision.net>

Hi Michael,

I guess looking for a better or more ideal solution sounds good, but
sorry if this is impertinent, as it's coming from a mostly uninvolved
3rd party: This is affects a kernel that is labeled as "stable". It
seems extremely unacceptable to break ethernet support for boards like
the rockpro64, which are used largely in a headless fashion, when the
offending commit has already been identified.

I don't expect a stable kernel release to completely break my hardware
and then see people not immediately applying a workaround patch. It
seems strange. I'm not fond of having to fix things through serial
console and hunting through mailing lists to figure out what's going
on. I'd only expect this for -rc kernels.

Just my two cents.

Best regards,
Sebastian

Am Di., 14. Sept. 2021 um 12:09 Uhr schrieb Michael Riesch
<michael.riesch@wolfvision.net>:
>
> Hello Ivan,
>
> On 9/14/21 3:10 AM, Ivan Babrou wrote:
> > Is it possible to revert the patch from the 5.14 and 5.15 as well?
> > I've tried upgrading my rockpro64 board from 5.13 to 5.15-rc1 and
> > ended up bisecting the issue to this commit like the others. It would
> > be nice to spare others from this exercise.
>
> For what it is worth we believe that there is a different issue with the
> dwmac-rk driver that was obscured by calling pm_runtime_get_sync()
> early. Investigation in progress -- I hope that we can achieve a proper
> solution before we have to revert the revert.
>
> Best regards,
> Michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-14 13:42 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  1:10 [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings Ivan Babrou
2021-09-14 10:06 ` Michael Riesch
2021-09-14 10:06   ` Michael Riesch
2021-09-14 10:06   ` Michael Riesch
2021-09-14 13:39   ` Sebastian Döring [this message]
2021-09-14 13:39     ` Sebastian Döring
2021-09-14 13:39     ` Sebastian Döring
  -- strict thread matches above, loose matches on Subject: below --
2021-08-23 14:37 Michael Riesch
2021-08-23 14:37 ` Michael Riesch
2021-08-23 14:37 ` Michael Riesch
2021-08-23 16:44 ` Jakub Kicinski
2021-08-23 16:44   ` Jakub Kicinski
2021-08-23 16:44   ` Jakub Kicinski
2021-08-25  8:07   ` Michael Riesch
2021-08-25  8:07     ` Michael Riesch
2021-08-25  8:07     ` Michael Riesch
2021-08-25  9:50 ` patchwork-bot+netdevbpf
2021-08-25  9:50   ` patchwork-bot+netdevbpf
2021-08-25  9:50   ` patchwork-bot+netdevbpf
2021-08-29 17:48 ` Chen-Yu Tsai
2021-08-29 17:48   ` Chen-Yu Tsai
2021-08-29 17:48   ` Chen-Yu Tsai
2021-08-30  7:57   ` Michael Riesch
2021-08-30  7:57     ` Michael Riesch
2021-08-30  7:57     ` Michael Riesch
2021-08-30 13:49     ` Punit Agrawal
2021-08-30 13:49       ` Punit Agrawal
2021-08-30 13:49       ` Punit Agrawal
2021-08-30 14:10       ` Michael Riesch
2021-08-30 14:10         ` Michael Riesch
2021-08-30 14:10         ` Michael Riesch
2021-09-17  2:22         ` Qu Wenruo
2021-09-17  2:22           ` Qu Wenruo
2021-09-17  2:22           ` Qu Wenruo
2021-09-17  7:18           ` Punit Agrawal
2021-09-17  7:18             ` Punit Agrawal
2021-09-17  7:18             ` Punit Agrawal
2021-09-17  8:02             ` Qu Wenruo
2021-09-17  8:02               ` Qu Wenruo
2021-09-17  8:02               ` Qu Wenruo
2021-09-17 15:11               ` Punit Agrawal
2021-09-17 15:11                 ` Punit Agrawal
2021-09-17 15:11                 ` Punit Agrawal
2021-08-30 16:03     ` Chen-Yu Tsai
2021-08-30 16:03       ` Chen-Yu Tsai
2021-08-30 16:03       ` Chen-Yu Tsai
2021-08-30 19:22     ` Sasha Levin
2021-08-30 19:22       ` Sasha Levin
2021-08-30 19:22       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADkZQakh49i-M_1NgsENkqBnacVo6J3Rj8D2NFijvyBts9Pneg@mail.gmail.com \
    --to=moralapostel+linuxkernel@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=ivan@ivan.computer \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michael.riesch@wolfvision.net \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=sashal@kernel.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.