All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-11 11:51 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2017-11-11 11:51 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David Airlie, Monk Liu,
	Xiangliang Yu, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and
hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored
to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf =
 			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-11 11:51 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2017-11-11 11:51 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David Airlie, Monk Liu,
	Xiangliang Yu, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and
hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored
to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf  			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-11 11:51 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2017-11-11 11:51 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David Airlie, Monk Liu,
	Xiangliang Yu, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and
hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored
to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf =
 			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
-- 
2.14.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13  3:43   ` Liu, Monk
  0 siblings, 0 replies; 12+ messages in thread
From: Liu, Monk @ 2017-11-13  3:43 UTC (permalink / raw)
  To: Chen, Horace, Colin King, Deucher, Alexander, Koenig, Christian,
	David Airlie, Yu, Xiangliang, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

+ Horace

-----Original Message-----
From: Colin King [mailto:colin.king@canonical.com] 
Sent: 2017年11月11日 19:51
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)  {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf =
 			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
--
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13  3:43   ` Liu, Monk
  0 siblings, 0 replies; 12+ messages in thread
From: Liu, Monk @ 2017-11-13  3:43 UTC (permalink / raw)
  To: Chen, Horace, Colin King, Deucher, Alexander, Koenig, Christian,
	David Airlie, Yu, Xiangliang,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

KyBIb3JhY2UNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IENvbGluIEtpbmcg
W21haWx0bzpjb2xpbi5raW5nQGNhbm9uaWNhbC5jb21dIA0KU2VudDogMjAxN+W5tDEx5pyIMTHm
l6UgMTk6NTENClRvOiBEZXVjaGVyLCBBbGV4YW5kZXIgPEFsZXhhbmRlci5EZXVjaGVyQGFtZC5j
b20+OyBLb2VuaWcsIENocmlzdGlhbiA8Q2hyaXN0aWFuLktvZW5pZ0BhbWQuY29tPjsgRGF2aWQg
QWlybGllIDxhaXJsaWVkQGxpbnV4LmllPjsgTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsg
WXUsIFhpYW5nbGlhbmcgPFhpYW5nbGlhbmcuWXVAYW1kLmNvbT47IGFtZC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnOyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQpDYzoga2VybmVs
LWphbml0b3JzQHZnZXIua2VybmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0K
U3ViamVjdDogW1BBVENIXSBkcm0vYW1kZ3B1L3ZpcnQ6IHJlbW92ZSByZWR1bmRhbnQgdmFyaWFi
bGUgcGYydmZfdmVyDQoNCkZyb206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNh
bC5jb20+DQoNClZhcmlhYmxlIHBmMnZmX3ZlciBpcyBhc3NpZ25lZCBidXQgbmV2ZXIgcmVhZCwg
aXQgaXMgcmVkdW5kYW50IGFuZCBoZW5jZSBjYW4gYmUgcmVtb3ZlZC4NCg0KQ2xlYW5zIHVwIGNs
YW5nIHdhcm5pbmc6DQpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdmlydC5jOjMx
MDozOiB3YXJuaW5nOiBWYWx1ZSBzdG9yZWQgdG8gJ3BmMnZmX3ZlcicgaXMgbmV2ZXIgcmVhZA0K
DQpTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29t
Pg0KLS0tDQogZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZpcnQuYyB8IDIgLS0N
CiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft
ZGdwdS9hbWRncHVfdmlydC5jDQppbmRleCA2NzM4ZGY4MzZhNzAuLmIxY2MxNzk1MTJmYSAxMDA2
NDQNCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMNCisrKyBi
L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMNCkBAIC0yOTYsNyArMjk2
LDYgQEAgaW50IGFtZGdwdV92aXJ0X2Z3X3Jlc2VydmVfZ2V0X2NoZWNrc3VtKHZvaWQgKm9iaiwN
CiANCiB2b2lkIGFtZGdwdV92aXJ0X2luaXRfZGF0YV9leGNoYW5nZShzdHJ1Y3QgYW1kZ3B1X2Rl
dmljZSAqYWRldikgIHsNCi0JdWludDMyX3QgcGYydmZfdmVyID0gMDsNCiAJdWludDMyX3QgcGYy
dmZfc2l6ZSA9IDA7DQogCXVpbnQzMl90IGNoZWNrc3VtID0gMDsNCiAJdWludDMyX3QgY2hlY2t2
YWw7DQpAQCAtMzA5LDcgKzMwOCw2IEBAIHZvaWQgYW1kZ3B1X3ZpcnRfaW5pdF9kYXRhX2V4Y2hh
bmdlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQ0KIAkJYWRldi0+dmlydC5md19yZXNlcnZl
LnBfcGYydmYgPQ0KIAkJCShzdHJ1Y3QgYW1kZ2ltX3BmMnZmX2luZm9faGVhZGVyICopKA0KIAkJ
CWFkZXYtPmZ3X3ZyYW1fdXNhZ2UudmEgKyBBTURHSU1fREFUQUVYQ0hBTkdFX09GRlNFVCk7DQot
CQlwZjJ2Zl92ZXIgPSBhZGV2LT52aXJ0LmZ3X3Jlc2VydmUucF9wZjJ2Zi0+dmVyc2lvbjsNCiAJ
CUFNREdQVV9GV19WUkFNX1BGMlZGX1JFQUQoYWRldiwgaGVhZGVyLnNpemUsICZwZjJ2Zl9zaXpl
KTsNCiAJCUFNREdQVV9GV19WUkFNX1BGMlZGX1JFQUQoYWRldiwgY2hlY2tzdW0sICZjaGVja3N1
bSk7DQogDQotLQ0KMi4xNC4xDQoNCg=

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13  3:43   ` Liu, Monk
  0 siblings, 0 replies; 12+ messages in thread
From: Liu, Monk @ 2017-11-13  3:43 UTC (permalink / raw)
  To: Chen, Horace, Colin King, Deucher, Alexander, Koenig, Christian,
	David Airlie, Yu, Xiangliang,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

+ Horace

-----Original Message-----
From: Colin King [mailto:colin.king@canonical.com] 
Sent: 2017年11月11日 19:51
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)  {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf =
 			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
--
2.14.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13 14:40     ` Chen, Horace
  0 siblings, 0 replies; 12+ messages in thread
From: Chen, Horace @ 2017-11-13 14:40 UTC (permalink / raw)
  To: Liu, Monk, Colin King, Deucher, Alexander, Koenig, Christian,
	David Airlie, Yu, Xiangliang, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

Reivewed-by: Horace Chen <horace.chen@amd.com>

-----Original Message-----
From: Liu, Monk 
Sent: Monday, November 13, 2017 11:43 AM
To: Chen, Horace <Horace.Chen@amd.com>; Colin King <colin.king@canonical.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
Importance: High

+ Horace

-----Original Message-----
From: Colin King [mailto:colin.king@canonical.com] 
Sent: 2017年11月11日 19:51
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)  {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf =
 			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
--
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13 14:40     ` Chen, Horace
  0 siblings, 0 replies; 12+ messages in thread
From: Chen, Horace @ 2017-11-13 14:40 UTC (permalink / raw)
  To: Liu, Monk, Colin King, Deucher, Alexander, Koenig, Christian,
	David Airlie, Yu, Xiangliang,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

UmVpdmV3ZWQtYnk6IEhvcmFjZSBDaGVuIDxob3JhY2UuY2hlbkBhbWQuY29tPg0KDQotLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogTGl1LCBNb25rIA0KU2VudDogTW9uZGF5LCBOb3Zl
bWJlciAxMywgMjAxNyAxMTo0MyBBTQ0KVG86IENoZW4sIEhvcmFjZSA8SG9yYWNlLkNoZW5AYW1k
LmNvbT47IENvbGluIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT47IERldWNoZXIsIEFs
ZXhhbmRlciA8QWxleGFuZGVyLkRldWNoZXJAYW1kLmNvbT47IEtvZW5pZywgQ2hyaXN0aWFuIDxD
aHJpc3RpYW4uS29lbmlnQGFtZC5jb20+OyBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+
OyBZdSwgWGlhbmdsaWFuZyA8WGlhbmdsaWFuZy5ZdUBhbWQuY29tPjsgYW1kLWdmeEBsaXN0cy5m
cmVlZGVza3RvcC5vcmc7IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCkNjOiBrZXJu
ZWwtamFuaXRvcnNAdmdlci5rZXJuZWwub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3Jn
DQpTdWJqZWN0OiBSRTogW1BBVENIXSBkcm0vYW1kZ3B1L3ZpcnQ6IHJlbW92ZSByZWR1bmRhbnQg
dmFyaWFibGUgcGYydmZfdmVyDQpJbXBvcnRhbmNlOiBIaWdoDQoNCisgSG9yYWNlDQoNCi0tLS0t
T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBDb2xpbiBLaW5nIFttYWlsdG86Y29saW4ua2lu
Z0BjYW5vbmljYWwuY29tXSANClNlbnQ6IDIwMTflubQxMeaciDEx5pelIDE5OjUxDQpUbzogRGV1
Y2hlciwgQWxleGFuZGVyIDxBbGV4YW5kZXIuRGV1Y2hlckBhbWQuY29tPjsgS29lbmlnLCBDaHJp
c3RpYW4gPENocmlzdGlhbi5Lb2VuaWdAYW1kLmNvbT47IERhdmlkIEFpcmxpZSA8YWlybGllZEBs
aW51eC5pZT47IExpdSwgTW9uayA8TW9uay5MaXVAYW1kLmNvbT47IFl1LCBYaWFuZ2xpYW5nIDxY
aWFuZ2xpYW5nLll1QGFtZC5jb20+OyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgZHJp
LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KQ2M6IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtl
cm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNClN1YmplY3Q6IFtQQVRDSF0g
ZHJtL2FtZGdwdS92aXJ0OiByZW1vdmUgcmVkdW5kYW50IHZhcmlhYmxlIHBmMnZmX3Zlcg0KDQpG
cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KDQpWYXJpYWJs
ZSBwZjJ2Zl92ZXIgaXMgYXNzaWduZWQgYnV0IG5ldmVyIHJlYWQsIGl0IGlzIHJlZHVuZGFudCBh
bmQgaGVuY2UgY2FuIGJlIHJlbW92ZWQuDQoNCkNsZWFucyB1cCBjbGFuZyB3YXJuaW5nOg0KZHJp
dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZpcnQuYzozMTA6Mzogd2FybmluZzogVmFs
dWUgc3RvcmVkIHRvICdwZjJ2Zl92ZXInIGlzIG5ldmVyIHJlYWQNCg0KU2lnbmVkLW9mZi1ieTog
Q29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCi0tLQ0KIGRyaXZlcnMv
Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92aXJ0LmMgfCAyIC0tDQogMSBmaWxlIGNoYW5nZWQs
IDIgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw
dS9hbWRncHVfdmlydC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZpcnQu
Yw0KaW5kZXggNjczOGRmODM2YTcwLi5iMWNjMTc5NTEyZmEgMTAwNjQ0DQotLS0gYS9kcml2ZXJz
L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdmlydC5jDQorKysgYi9kcml2ZXJzL2dwdS9kcm0v
YW1kL2FtZGdwdS9hbWRncHVfdmlydC5jDQpAQCAtMjk2LDcgKzI5Niw2IEBAIGludCBhbWRncHVf
dmlydF9md19yZXNlcnZlX2dldF9jaGVja3N1bSh2b2lkICpvYmosDQogDQogdm9pZCBhbWRncHVf
dmlydF9pbml0X2RhdGFfZXhjaGFuZ2Uoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpICB7DQot
CXVpbnQzMl90IHBmMnZmX3ZlciA9IDA7DQogCXVpbnQzMl90IHBmMnZmX3NpemUgPSAwOw0KIAl1
aW50MzJfdCBjaGVja3N1bSA9IDA7DQogCXVpbnQzMl90IGNoZWNrdmFsOw0KQEAgLTMwOSw3ICsz
MDgsNiBAQCB2b2lkIGFtZGdwdV92aXJ0X2luaXRfZGF0YV9leGNoYW5nZShzdHJ1Y3QgYW1kZ3B1
X2RldmljZSAqYWRldikNCiAJCWFkZXYtPnZpcnQuZndfcmVzZXJ2ZS5wX3BmMnZmID0NCiAJCQko
c3RydWN0IGFtZGdpbV9wZjJ2Zl9pbmZvX2hlYWRlciAqKSgNCiAJCQlhZGV2LT5md192cmFtX3Vz
YWdlLnZhICsgQU1ER0lNX0RBVEFFWENIQU5HRV9PRkZTRVQpOw0KLQkJcGYydmZfdmVyID0gYWRl
di0+dmlydC5md19yZXNlcnZlLnBfcGYydmYtPnZlcnNpb247DQogCQlBTURHUFVfRldfVlJBTV9Q
RjJWRl9SRUFEKGFkZXYsIGhlYWRlci5zaXplLCAmcGYydmZfc2l6ZSk7DQogCQlBTURHUFVfRldf
VlJBTV9QRjJWRl9SRUFEKGFkZXYsIGNoZWNrc3VtLCAmY2hlY2tzdW0pOw0KIA0KLS0NCjIuMTQu
MQ0KDQo

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13 14:40     ` Chen, Horace
  0 siblings, 0 replies; 12+ messages in thread
From: Chen, Horace @ 2017-11-13 14:40 UTC (permalink / raw)
  To: Liu, Monk, Colin King, Deucher, Alexander, Koenig, Christian,
	David Airlie, Yu, Xiangliang,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Reivewed-by: Horace Chen <horace.chen@amd.com>

-----Original Message-----
From: Liu, Monk 
Sent: Monday, November 13, 2017 11:43 AM
To: Chen, Horace <Horace.Chen@amd.com>; Colin King <colin.king@canonical.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
Importance: High

+ Horace

-----Original Message-----
From: Colin King [mailto:colin.king@canonical.com] 
Sent: 2017年11月11日 19:51
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)  {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf =
 			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
--
2.14.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
  2017-11-13 14:40     ` Chen, Horace
  (?)
@ 2017-11-13 19:21       ` Alex Deucher
  -1 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2017-11-13 19:21 UTC (permalink / raw)
  To: Chen, Horace
  Cc: Liu, Monk, Colin King, Deucher, Alexander, Koenig, Christian,
	David Airlie, Yu, Xiangliang, amd-gfx, dri-devel,
	kernel-janitors, linux-kernel

On Mon, Nov 13, 2017 at 9:40 AM, Chen, Horace <Horace.Chen@amd.com> wrote:
> Reivewed-by: Horace Chen <horace.chen@amd.com>

Applied.  thanks!

Alex

>
> -----Original Message-----
> From: Liu, Monk
> Sent: Monday, November 13, 2017 11:43 AM
> To: Chen, Horace <Horace.Chen@amd.com>; Colin King <colin.king@canonical.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
> Importance: High
>
> + Horace
>
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: 2017年11月11日 19:51
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.
>
> Cleans up clang warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 6738df836a70..b1cc179512fa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
>
>  void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)  {
> -       uint32_t pf2vf_ver = 0;
>         uint32_t pf2vf_size = 0;
>         uint32_t checksum = 0;
>         uint32_t checkval;
> @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
>                 adev->virt.fw_reserve.p_pf2vf =
>                         (struct amdgim_pf2vf_info_header *)(
>                         adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
> -               pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
>                 AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
>                 AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
>
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13 19:21       ` Alex Deucher
  0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2017-11-13 19:21 UTC (permalink / raw)
  To: Chen, Horace
  Cc: David Airlie, kernel-janitors, linux-kernel, amd-gfx, Yu,
	Xiangliang, dri-devel, Deucher, Alexander, Colin King, Koenig,
	Christian, Liu, Monk

On Mon, Nov 13, 2017 at 9:40 AM, Chen, Horace <Horace.Chen@amd.com> wrote:
> Reivewed-by: Horace Chen <horace.chen@amd.com>

Applied.  thanks!

Alex

>
> -----Original Message-----
> From: Liu, Monk
> Sent: Monday, November 13, 2017 11:43 AM
> To: Chen, Horace <Horace.Chen@amd.com>; Colin King <colin.king@canonical.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
> Importance: High
>
> + Horace
>
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: 2017年11月11日 19:51
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.
>
> Cleans up clang warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 6738df836a70..b1cc179512fa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
>
>  void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)  {
> -       uint32_t pf2vf_ver = 0;
>         uint32_t pf2vf_size = 0;
>         uint32_t checksum = 0;
>         uint32_t checkval;
> @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
>                 adev->virt.fw_reserve.p_pf2vf =
>                         (struct amdgim_pf2vf_info_header *)(
>                         adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
> -               pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
>                 AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
>                 AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
>
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-13 19:21       ` Alex Deucher
  0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2017-11-13 19:21 UTC (permalink / raw)
  To: Chen, Horace
  Cc: David Airlie, kernel-janitors, linux-kernel, amd-gfx, Yu,
	Xiangliang, dri-devel, Deucher, Alexander, Colin King, Koenig,
	Christian, Liu, Monk

On Mon, Nov 13, 2017 at 9:40 AM, Chen, Horace <Horace.Chen@amd.com> wrote:
> Reivewed-by: Horace Chen <horace.chen@amd.com>

Applied.  thanks!

Alex

>
> -----Original Message-----
> From: Liu, Monk
> Sent: Monday, November 13, 2017 11:43 AM
> To: Chen, Horace <Horace.Chen@amd.com>; Colin King <colin.king@canonical.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
> Importance: High
>
> + Horace
>
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: 2017年11月11日 19:51
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.
>
> Cleans up clang warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 6738df836a70..b1cc179512fa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
>
>  void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)  {
> -       uint32_t pf2vf_ver = 0;
>         uint32_t pf2vf_size = 0;
>         uint32_t checksum = 0;
>         uint32_t checkval;
> @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
>                 adev->virt.fw_reserve.p_pf2vf =
>                         (struct amdgim_pf2vf_info_header *)(
>                         adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
> -               pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
>                 AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
>                 AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
>
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-11-13 19:21 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-11 11:51 [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Colin King
2017-11-11 11:51 ` Colin King
2017-11-11 11:51 ` Colin King
2017-11-13  3:43 ` Liu, Monk
2017-11-13  3:43   ` Liu, Monk
2017-11-13  3:43   ` Liu, Monk
2017-11-13 14:40   ` Chen, Horace
2017-11-13 14:40     ` Chen, Horace
2017-11-13 14:40     ` Chen, Horace
2017-11-13 19:21     ` Alex Deucher
2017-11-13 19:21       ` Alex Deucher
2017-11-13 19:21       ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.