All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
@ 2017-11-11 11:51 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2017-11-11 11:51 UTC (permalink / raw)
  To: Alex Deucher, Christian König, David Airlie, Monk Liu,
	Xiangliang Yu, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable pf2vf_ver is assigned but never read, it is redundant and
hence can be removed.

Cleans up clang warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored
to 'pf2vf_ver' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 6738df836a70..b1cc179512fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
 
 void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 {
-	uint32_t pf2vf_ver = 0;
 	uint32_t pf2vf_size = 0;
 	uint32_t checksum = 0;
 	uint32_t checkval;
@@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
 		adev->virt.fw_reserve.p_pf2vf =
 			(struct amdgim_pf2vf_info_header *)(
 			adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
-		pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
 		AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2017-11-13 19:21 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-11 11:51 [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Colin King
2017-11-11 11:51 ` Colin King
2017-11-11 11:51 ` Colin King
2017-11-13  3:43 ` Liu, Monk
2017-11-13  3:43   ` Liu, Monk
2017-11-13  3:43   ` Liu, Monk
2017-11-13 14:40   ` Chen, Horace
2017-11-13 14:40     ` Chen, Horace
2017-11-13 14:40     ` Chen, Horace
2017-11-13 19:21     ` Alex Deucher
2017-11-13 19:21       ` Alex Deucher
2017-11-13 19:21       ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.