Re: [Qemu-devel] [PATCH target-arm v4 02/16] target-arm: cpu64: Factor out ARM cortex init

From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar Iglesias" <edgar.iglesias@xilinx.com>,
	zach.pfeffer@xilinx.com, "Ryota Ozaki" <ozaki.ryota@gmail.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"michals@xilinx.com" <michals@xilinx.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH target-arm v4 02/16] target-arm: cpu64: Factor out ARM cortex init
Date: Fri, 24 Apr 2015 09:39:01 -0700	[thread overview]
Message-ID: <CAEgOgz7tLGvA7p_=3fCwFNPTtYYoa2u+hzSW1pWpfUCjd6cpQQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8GouReo4z32xg5T9Bo=dDr2qp4WbPnkpT+QR9y+1EQQQ@mail.gmail.com>

On Thu, Apr 23, 2015 at 10:35 AM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 23 March 2015 at 11:05, Peter Crosthwaite
> <peter.crosthwaite@xilinx.com> wrote:
>> In preparation for support for Cortex a53. Use "axx" to describe the
>> shareable features. Some of the CP15 registers (such as ACTLR) are
>> specific to implementation, but we currently just RAZ them so continue
>> with that as the policy for all cortex A processors under a shared
>> definition.
>>
>> The cache sizes and geometeries, the L1 I-cache policy and the physical
>> address range differ between A53 and A57 so those particulars are left
>> as A57 specific. The rest are moved to the generalisation.
>
> I'm not a huge fan of this as it seems unlikely that every CPU
> with a "Cortex-Axx" is going to look so similar to the A57.
>
> Call the reginfo table cortex_a53_a57_cp_reginfo if you want
> to share it, but I would leave the initfns completely separate
> personally.
>

Both fixed.

Regards,
Peter

> -- PMM
>