* [PATCH] simplebench: Fix Python syntax error (reported by LGTM) @ 2022-01-07 15:30 Stefan Weil 2022-01-07 18:23 ` Philippe Mathieu-Daudé 2022-01-10 17:08 ` John Snow 0 siblings, 2 replies; 7+ messages in thread From: Stefan Weil @ 2022-01-07 15:30 UTC (permalink / raw) To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Weil <sw@weilnetz.de> --- scripts/simplebench/bench-example.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/simplebench/bench-example.py b/scripts/simplebench/bench-example.py index 4864435f39..fc370691e0 100644 --- a/scripts/simplebench/bench-example.py +++ b/scripts/simplebench/bench-example.py @@ -25,7 +25,7 @@ def bench_func(env, case): """ Handle one "cell" of benchmarking table. """ - return bench_block_copy(env['qemu_binary'], env['cmd'], {} + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, case['source'], case['target']) -- 2.30.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM) 2022-01-07 15:30 [PATCH] simplebench: Fix Python syntax error (reported by LGTM) Stefan Weil @ 2022-01-07 18:23 ` Philippe Mathieu-Daudé 2022-01-10 17:08 ` John Snow 1 sibling, 0 replies; 7+ messages in thread From: Philippe Mathieu-Daudé @ 2022-01-07 18:23 UTC (permalink / raw) To: Stefan Weil, qemu-devel Cc: qemu-trivial, Vladimir Sementsov-Ogievskiy, John Snow On 1/7/22 16:30, Stefan Weil wrote: > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > scripts/simplebench/bench-example.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/simplebench/bench-example.py b/scripts/simplebench/bench-example.py > index 4864435f39..fc370691e0 100644 > --- a/scripts/simplebench/bench-example.py > +++ b/scripts/simplebench/bench-example.py > @@ -25,7 +25,7 @@ > > def bench_func(env, case): > """ Handle one "cell" of benchmarking table. """ > - return bench_block_copy(env['qemu_binary'], env['cmd'], {} > + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, > case['source'], case['target']) > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM) 2022-01-07 15:30 [PATCH] simplebench: Fix Python syntax error (reported by LGTM) Stefan Weil 2022-01-07 18:23 ` Philippe Mathieu-Daudé @ 2022-01-10 17:08 ` John Snow 2022-01-10 17:56 ` Stefan Weil 1 sibling, 1 reply; 7+ messages in thread From: John Snow @ 2022-01-10 17:08 UTC (permalink / raw) To: Stefan Weil; +Cc: qemu-trivial, Vladimir Sementsov-Ogievskiy, qemu-devel [-- Attachment #1: Type: text/plain, Size: 932 bytes --] On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de> wrote: > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > scripts/simplebench/bench-example.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/simplebench/bench-example.py > b/scripts/simplebench/bench-example.py > index 4864435f39..fc370691e0 100644 > --- a/scripts/simplebench/bench-example.py > +++ b/scripts/simplebench/bench-example.py > @@ -25,7 +25,7 @@ > > def bench_func(env, case): > """ Handle one "cell" of benchmarking table. """ > - return bench_block_copy(env['qemu_binary'], env['cmd'], {} > + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, > case['source'], case['target']) > > > -- > 2.30.2 > Good spot. If it's not too late and not a hassle, can you add a fixes: commit-id in the commit message? No big deal if not. Reviewed-by: John Snow <jsnow@redhat.com> [-- Attachment #2: Type: text/html, Size: 1563 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM) 2022-01-10 17:08 ` John Snow @ 2022-01-10 17:56 ` Stefan Weil 2022-01-10 18:09 ` John Snow 0 siblings, 1 reply; 7+ messages in thread From: Stefan Weil @ 2022-01-10 17:56 UTC (permalink / raw) To: John Snow; +Cc: qemu-trivial, Vladimir Sementsov-Ogievskiy, qemu-devel [-- Attachment #1: Type: text/plain, Size: 1214 bytes --] Am 10.01.22 um 18:08 schrieb John Snow: > On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de> wrote: > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > scripts/simplebench/bench-example.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/simplebench/bench-example.py > b/scripts/simplebench/bench-example.py > index 4864435f39..fc370691e0 100644 > --- a/scripts/simplebench/bench-example.py > +++ b/scripts/simplebench/bench-example.py > @@ -25,7 +25,7 @@ > > def bench_func(env, case): > """ Handle one "cell" of benchmarking table. """ > - return bench_block_copy(env['qemu_binary'], env['cmd'], {} > + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, > case['source'], case['target']) > > > -- > 2.30.2 > > > Good spot. If it's not too late and not a hassle, can you add a fixes: > commit-id in the commit message? No big deal if not. > > Reviewed-by: John Snow <jsnow@redhat.com> Maybe that can be added locally to avoid a V2 patch. Here it is: Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd Thanks, Stefan [-- Attachment #2: Type: text/html, Size: 2498 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM) 2022-01-10 17:56 ` Stefan Weil @ 2022-01-10 18:09 ` John Snow 2022-01-17 8:02 ` Vladimir Sementsov-Ogievskiy 0 siblings, 1 reply; 7+ messages in thread From: John Snow @ 2022-01-10 18:09 UTC (permalink / raw) To: Stefan Weil; +Cc: qemu-trivial, Vladimir Sementsov-Ogievskiy, qemu-devel [-- Attachment #1: Type: text/plain, Size: 1418 bytes --] On Mon, Jan 10, 2022 at 12:57 PM Stefan Weil <sw@weilnetz.de> wrote: > Am 10.01.22 um 18:08 schrieb John Snow: > > On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de> wrote: > >> Signed-off-by: Stefan Weil <sw@weilnetz.de> >> --- >> scripts/simplebench/bench-example.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/simplebench/bench-example.py >> b/scripts/simplebench/bench-example.py >> index 4864435f39..fc370691e0 100644 >> --- a/scripts/simplebench/bench-example.py >> +++ b/scripts/simplebench/bench-example.py >> @@ -25,7 +25,7 @@ >> >> def bench_func(env, case): >> """ Handle one "cell" of benchmarking table. """ >> - return bench_block_copy(env['qemu_binary'], env['cmd'], {} >> + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, >> case['source'], case['target']) >> >> >> -- >> 2.30.2 >> > > Good spot. If it's not too late and not a hassle, can you add a fixes: > commit-id in the commit message? No big deal if not. > > Reviewed-by: John Snow <jsnow@redhat.com> > > > Maybe that can be added locally to avoid a V2 patch. Here it is: > > Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd > > Thanks, > > Stefan > > > Got it. I just got back from holiday today, so there's still lots of mail to catch up on. If nobody else has staged this, I will do so as part of my python fixes this week. Thanks! --js [-- Attachment #2: Type: text/html, Size: 2851 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM) 2022-01-10 18:09 ` John Snow @ 2022-01-17 8:02 ` Vladimir Sementsov-Ogievskiy 2022-01-17 19:26 ` John Snow 0 siblings, 1 reply; 7+ messages in thread From: Vladimir Sementsov-Ogievskiy @ 2022-01-17 8:02 UTC (permalink / raw) To: John Snow, Stefan Weil; +Cc: qemu-devel, qemu-trivial 10.01.2022 21:09, John Snow wrote: > > > On Mon, Jan 10, 2022 at 12:57 PM Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>> wrote: > > Am 10.01.22 um 18:08 schrieb John Snow: > >> On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>> wrote: >> >> Signed-off-by: Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>> >> --- >> scripts/simplebench/bench-example.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/simplebench/bench-example.py b/scripts/simplebench/bench-example.py >> index 4864435f39..fc370691e0 100644 >> --- a/scripts/simplebench/bench-example.py >> +++ b/scripts/simplebench/bench-example.py >> @@ -25,7 +25,7 @@ >> >> def bench_func(env, case): >> """ Handle one "cell" of benchmarking table. """ >> - return bench_block_copy(env['qemu_binary'], env['cmd'], {} >> + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, >> case['source'], case['target']) >> >> >> -- >> 2.30.2 >> >> >> Good spot. If it's not too late and not a hassle, can you add a fixes: commit-id in the commit message? No big deal if not. >> >> Reviewed-by: John Snow <jsnow@redhat.com <mailto:jsnow@redhat.com>> > > > Maybe that can be added locally to avoid a V2 patch. Here it is: > > Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd > > Thanks, > > Stefan > > > Got it. I just got back from holiday today, so there's still lots of mail to catch up on. If nobody else has staged this, I will do so as part of my python fixes this week. Thanks! > It would be nice, thanks! -- Best regards, Vladimir ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] simplebench: Fix Python syntax error (reported by LGTM) 2022-01-17 8:02 ` Vladimir Sementsov-Ogievskiy @ 2022-01-17 19:26 ` John Snow 0 siblings, 0 replies; 7+ messages in thread From: John Snow @ 2022-01-17 19:26 UTC (permalink / raw) To: Vladimir Sementsov-Ogievskiy; +Cc: qemu-trivial, Stefan Weil, qemu-devel On Mon, Jan 17, 2022 at 3:02 AM Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote: > > 10.01.2022 21:09, John Snow wrote: > > > > > > On Mon, Jan 10, 2022 at 12:57 PM Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>> wrote: > > > > Am 10.01.22 um 18:08 schrieb John Snow: > > > >> On Fri, Jan 7, 2022 at 10:32 AM Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>> wrote: > >> > >> Signed-off-by: Stefan Weil <sw@weilnetz.de <mailto:sw@weilnetz.de>> > >> --- > >> scripts/simplebench/bench-example.py | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/scripts/simplebench/bench-example.py b/scripts/simplebench/bench-example.py > >> index 4864435f39..fc370691e0 100644 > >> --- a/scripts/simplebench/bench-example.py > >> +++ b/scripts/simplebench/bench-example.py > >> @@ -25,7 +25,7 @@ > >> > >> def bench_func(env, case): > >> """ Handle one "cell" of benchmarking table. """ > >> - return bench_block_copy(env['qemu_binary'], env['cmd'], {} > >> + return bench_block_copy(env['qemu_binary'], env['cmd'], {}, > >> case['source'], case['target']) > >> > >> > >> -- > >> 2.30.2 > >> > >> > >> Good spot. If it's not too late and not a hassle, can you add a fixes: commit-id in the commit message? No big deal if not. > >> > >> Reviewed-by: John Snow <jsnow@redhat.com <mailto:jsnow@redhat.com>> > > > > > > Maybe that can be added locally to avoid a V2 patch. Here it is: > > > > Fixes: b2fcb0c5754c2554b8406376e99a75e9e0a6b7bd > > > > Thanks, > > > > Stefan > > > > > > Got it. I just got back from holiday today, so there's still lots of mail to catch up on. If nobody else has staged this, I will do so as part of my python fixes this week. Thanks! > > > > It would be nice, thanks! > Should be in origin/master by now, I forgot to update this thread. --js ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-17 19:38 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-01-07 15:30 [PATCH] simplebench: Fix Python syntax error (reported by LGTM) Stefan Weil 2022-01-07 18:23 ` Philippe Mathieu-Daudé 2022-01-10 17:08 ` John Snow 2022-01-10 17:56 ` Stefan Weil 2022-01-10 18:09 ` John Snow 2022-01-17 8:02 ` Vladimir Sementsov-Ogievskiy 2022-01-17 19:26 ` John Snow
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.