From: Arnd Bergmann <arnd@arndb.de>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Christoph Hellwig <hch@infradead.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap()
Date: Tue, 24 May 2022 16:47:16 +0200 [thread overview]
Message-ID: <CAK8P3a19S8CFxJKQo_8UXSKA0L8J40DsjL+u649oDhqUPHSW7A@mail.gmail.com> (raw)
In-Reply-To: <4c848b48-6ddf-664a-6296-d85ab49a694d@huawei.com>
On Tue, May 24, 2022 at 4:32 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> On 2022/5/24 20:37, Arnd Bergmann wrote:
> > On Thu, May 19, 2022 at 10:25 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> >> Add special hook for architecture to verify or setup addr, size
> >> or prot when ioremap() or iounmap(), which will make the generic
> >> ioremap more useful.
> >>
> >> arch_ioremap() return a pointer,
> >> - IS_ERR means return an error
> >> - NULL means continue to remap
> >> - a non-NULL, non-IS_ERR pointer is directly returned
> >> arch_iounmap() return a int value,
> >> - 0 means continue to vunmap
> >> - error code means skip vunmap and return directly
> >>
> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > I don't really like interfaces that mix error pointers and NULL pointer
> > returns.
> >
> > Would it be possible to have a special error code other than NULL
> > for the fallback case?
>
> I don't find a good error code, maybe ENOTSUPP, any better suggestion?
I had another look at the resulting arm64 function, and it appears that
you never actually return a non-error pointer here. If I didn't miss anything,
I think the best way would be to change the return type to just indicate
success or an error code, and drop the case of returning the actual result,
and changing the function name accordingly.
Would that work, or do you actually require returning an __iomem
token from somewhere else?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Christoph Hellwig <hch@infradead.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap()
Date: Tue, 24 May 2022 16:47:16 +0200 [thread overview]
Message-ID: <CAK8P3a19S8CFxJKQo_8UXSKA0L8J40DsjL+u649oDhqUPHSW7A@mail.gmail.com> (raw)
In-Reply-To: <4c848b48-6ddf-664a-6296-d85ab49a694d@huawei.com>
On Tue, May 24, 2022 at 4:32 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> On 2022/5/24 20:37, Arnd Bergmann wrote:
> > On Thu, May 19, 2022 at 10:25 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> >> Add special hook for architecture to verify or setup addr, size
> >> or prot when ioremap() or iounmap(), which will make the generic
> >> ioremap more useful.
> >>
> >> arch_ioremap() return a pointer,
> >> - IS_ERR means return an error
> >> - NULL means continue to remap
> >> - a non-NULL, non-IS_ERR pointer is directly returned
> >> arch_iounmap() return a int value,
> >> - 0 means continue to vunmap
> >> - error code means skip vunmap and return directly
> >>
> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > I don't really like interfaces that mix error pointers and NULL pointer
> > returns.
> >
> > Would it be possible to have a special error code other than NULL
> > for the fallback case?
>
> I don't find a good error code, maybe ENOTSUPP, any better suggestion?
I had another look at the resulting arm64 function, and it appears that
you never actually return a non-error pointer here. If I didn't miss anything,
I think the best way would be to change the return type to just indicate
success or an error code, and drop the case of returning the actual result,
and changing the function name accordingly.
Would that work, or do you actually require returning an __iomem
token from somewhere else?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-24 14:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 8:25 [PATCH v3 0/6] arm64: Cleanup ioremap() and support ioremap_prot() Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 1/6] ARM: mm: kill unused runtime hook arch_iounmap() Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang
2022-05-19 8:51 ` Anshuman Khandual
2022-05-19 8:51 ` Anshuman Khandual
2022-05-20 15:28 ` Catalin Marinas
2022-05-20 15:28 ` Catalin Marinas
2022-05-24 2:03 ` Kefeng Wang
2022-05-24 2:03 ` Kefeng Wang
2022-05-21 20:30 ` Arnd Bergmann
2022-05-21 20:30 ` Arnd Bergmann
2022-05-19 8:25 ` [PATCH v3 2/6] mm: ioremap: Use more sensibly name in ioremap_prot() Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 3/6] mm: ioremap: Setup phys_addr of struct vm_struct Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang
2022-05-19 18:52 ` Andrew Morton
2022-05-19 18:52 ` Andrew Morton
2022-05-20 1:22 ` Kefeng Wang
2022-05-20 1:22 ` Kefeng Wang
2022-05-23 3:57 ` Anshuman Khandual
2022-05-23 3:57 ` Anshuman Khandual
2022-05-23 22:17 ` kernel test robot
2022-05-23 22:17 ` kernel test robot
2022-05-24 9:48 ` Kefeng Wang
2022-05-24 9:48 ` Kefeng Wang
2022-05-24 9:48 ` Kefeng Wang
2022-05-24 12:35 ` Arnd Bergmann
2022-05-24 12:35 ` Arnd Bergmann
2022-05-24 12:35 ` Arnd Bergmann
2022-05-24 14:31 ` Kefeng Wang
2022-05-24 14:31 ` Kefeng Wang
2022-05-24 14:31 ` Kefeng Wang
2022-05-24 12:37 ` Arnd Bergmann
2022-05-24 12:37 ` Arnd Bergmann
2022-05-24 14:32 ` Kefeng Wang
2022-05-24 14:32 ` Kefeng Wang
2022-05-24 14:47 ` Arnd Bergmann [this message]
2022-05-24 14:47 ` Arnd Bergmann
2022-05-24 14:53 ` Kefeng Wang
2022-05-24 14:53 ` Kefeng Wang
2022-05-31 6:13 ` Christoph Hellwig
2022-05-31 6:13 ` Christoph Hellwig
2022-06-01 1:05 ` Kefeng Wang
2022-06-01 1:05 ` Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 5/6] arm64: mm: Convert to GENERIC_IOREMAP Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang
2022-05-19 8:25 ` [PATCH v3 6/6] arm64: Add HAVE_IOREMAP_PROT support Kefeng Wang
2022-05-19 8:25 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a19S8CFxJKQo_8UXSKA0L8J40DsjL+u649oDhqUPHSW7A@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.