From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: <catalin.marinas@arm.com>, <will@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>, <hch@infradead.org>, <arnd@arndb.de>, <anshuman.khandual@arm.com> Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Date: Fri, 20 May 2022 09:22:24 +0800 [thread overview] Message-ID: <c647a1b0-5cd8-0a61-10de-f95ff2820f60@huawei.com> (raw) In-Reply-To: <20220519115210.a6e41d5a997921354400557e@linux-foundation.org> On 2022/5/20 2:52, Andrew Morton wrote: > On Thu, 19 May 2022 16:25:50 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > >> Add special hook for architecture to verify or setup addr, size >> or prot when ioremap() or iounmap(), which will make the generic >> ioremap more useful. >> >> arch_ioremap() return a pointer, >> - IS_ERR means return an error >> - NULL means continue to remap >> - a non-NULL, non-IS_ERR pointer is directly returned >> arch_iounmap() return a int value, >> - 0 means continue to vunmap >> - error code means skip vunmap and return directly >> >> ... >> >> --- a/include/asm-generic/io.h >> +++ b/include/asm-generic/io.h >> @@ -964,6 +964,30 @@ static inline void iounmap(volatile void __iomem *addr) >> #elif defined(CONFIG_GENERIC_IOREMAP) >> #include <linux/pgtable.h> >> >> +/* >> + * Arch code can implement the following two special hooks when using GENERIC_IOREMAP >> + * arch_ioremap() return a pointer, >> + * - IS_ERR means return an error >> + * - NULL means continue to remap >> + * - a non-NULL, non-IS_ERR pointer is returned directly >> + * arch_iounmap() return a int, >> + * - 0 means continue to vunmap >> + * - error code means skip vunmap and return directly >> + */ >> +#ifndef arch_ioremap >> +static inline void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot) >> +{ >> + return NULL; >> +} > Maybe should do > > #define arch_ioremap arch_ioremap > > here > >> +#endif >> + >> +#ifndef arch_iounmap >> +static inline int arch_iounmap(void __iomem *addr) >> +{ >> + return 0; >> +} > and here. > > It shouldn't matter a lot because this file has inclusion guards. > However it seems tidier and perhaps other code will want to know > whether this was defined. Dunno. > Oh, forget to add the define part, thanks Andrew. Hi Catalin, could you help to involve them when taking them, many thanks. > Otherwise, > > Acked-by: Andrew Morton <akpm@linux-foundation.org> > > Please take this patch and [2/6] and [3/6] via the appropriate arm tree. > > .
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: <catalin.marinas@arm.com>, <will@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>, <hch@infradead.org>, <arnd@arndb.de>, <anshuman.khandual@arm.com> Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Date: Fri, 20 May 2022 09:22:24 +0800 [thread overview] Message-ID: <c647a1b0-5cd8-0a61-10de-f95ff2820f60@huawei.com> (raw) In-Reply-To: <20220519115210.a6e41d5a997921354400557e@linux-foundation.org> On 2022/5/20 2:52, Andrew Morton wrote: > On Thu, 19 May 2022 16:25:50 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > >> Add special hook for architecture to verify or setup addr, size >> or prot when ioremap() or iounmap(), which will make the generic >> ioremap more useful. >> >> arch_ioremap() return a pointer, >> - IS_ERR means return an error >> - NULL means continue to remap >> - a non-NULL, non-IS_ERR pointer is directly returned >> arch_iounmap() return a int value, >> - 0 means continue to vunmap >> - error code means skip vunmap and return directly >> >> ... >> >> --- a/include/asm-generic/io.h >> +++ b/include/asm-generic/io.h >> @@ -964,6 +964,30 @@ static inline void iounmap(volatile void __iomem *addr) >> #elif defined(CONFIG_GENERIC_IOREMAP) >> #include <linux/pgtable.h> >> >> +/* >> + * Arch code can implement the following two special hooks when using GENERIC_IOREMAP >> + * arch_ioremap() return a pointer, >> + * - IS_ERR means return an error >> + * - NULL means continue to remap >> + * - a non-NULL, non-IS_ERR pointer is returned directly >> + * arch_iounmap() return a int, >> + * - 0 means continue to vunmap >> + * - error code means skip vunmap and return directly >> + */ >> +#ifndef arch_ioremap >> +static inline void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot) >> +{ >> + return NULL; >> +} > Maybe should do > > #define arch_ioremap arch_ioremap > > here > >> +#endif >> + >> +#ifndef arch_iounmap >> +static inline int arch_iounmap(void __iomem *addr) >> +{ >> + return 0; >> +} > and here. > > It shouldn't matter a lot because this file has inclusion guards. > However it seems tidier and perhaps other code will want to know > whether this was defined. Dunno. > Oh, forget to add the define part, thanks Andrew. Hi Catalin, could you help to involve them when taking them, many thanks. > Otherwise, > > Acked-by: Andrew Morton <akpm@linux-foundation.org> > > Please take this patch and [2/6] and [3/6] via the appropriate arm tree. > > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-20 1:23 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 8:25 [PATCH v3 0/6] arm64: Cleanup ioremap() and support ioremap_prot() Kefeng Wang 2022-05-19 8:25 ` Kefeng Wang 2022-05-19 8:25 ` [PATCH v3 1/6] ARM: mm: kill unused runtime hook arch_iounmap() Kefeng Wang 2022-05-19 8:25 ` Kefeng Wang 2022-05-19 8:51 ` Anshuman Khandual 2022-05-19 8:51 ` Anshuman Khandual 2022-05-20 15:28 ` Catalin Marinas 2022-05-20 15:28 ` Catalin Marinas 2022-05-24 2:03 ` Kefeng Wang 2022-05-24 2:03 ` Kefeng Wang 2022-05-21 20:30 ` Arnd Bergmann 2022-05-21 20:30 ` Arnd Bergmann 2022-05-19 8:25 ` [PATCH v3 2/6] mm: ioremap: Use more sensibly name in ioremap_prot() Kefeng Wang 2022-05-19 8:25 ` Kefeng Wang 2022-05-19 8:25 ` [PATCH v3 3/6] mm: ioremap: Setup phys_addr of struct vm_struct Kefeng Wang 2022-05-19 8:25 ` Kefeng Wang 2022-05-19 8:25 ` [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Kefeng Wang 2022-05-19 8:25 ` Kefeng Wang 2022-05-19 18:52 ` Andrew Morton 2022-05-19 18:52 ` Andrew Morton 2022-05-20 1:22 ` Kefeng Wang [this message] 2022-05-20 1:22 ` Kefeng Wang 2022-05-23 3:57 ` Anshuman Khandual 2022-05-23 3:57 ` Anshuman Khandual 2022-05-23 22:17 ` kernel test robot 2022-05-23 22:17 ` kernel test robot 2022-05-24 9:48 ` Kefeng Wang 2022-05-24 9:48 ` Kefeng Wang 2022-05-24 9:48 ` Kefeng Wang 2022-05-24 12:35 ` Arnd Bergmann 2022-05-24 12:35 ` Arnd Bergmann 2022-05-24 12:35 ` Arnd Bergmann 2022-05-24 14:31 ` Kefeng Wang 2022-05-24 14:31 ` Kefeng Wang 2022-05-24 14:31 ` Kefeng Wang 2022-05-24 12:37 ` Arnd Bergmann 2022-05-24 12:37 ` Arnd Bergmann 2022-05-24 14:32 ` Kefeng Wang 2022-05-24 14:32 ` Kefeng Wang 2022-05-24 14:47 ` Arnd Bergmann 2022-05-24 14:47 ` Arnd Bergmann 2022-05-24 14:53 ` Kefeng Wang 2022-05-24 14:53 ` Kefeng Wang 2022-05-31 6:13 ` Christoph Hellwig 2022-05-31 6:13 ` Christoph Hellwig 2022-06-01 1:05 ` Kefeng Wang 2022-06-01 1:05 ` Kefeng Wang 2022-05-19 8:25 ` [PATCH v3 5/6] arm64: mm: Convert to GENERIC_IOREMAP Kefeng Wang 2022-05-19 8:25 ` Kefeng Wang 2022-05-19 8:25 ` [PATCH v3 6/6] arm64: Add HAVE_IOREMAP_PROT support Kefeng Wang 2022-05-19 8:25 ` Kefeng Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c647a1b0-5cd8-0a61-10de-f95ff2820f60@huawei.com \ --to=wangkefeng.wang@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=anshuman.khandual@arm.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=hch@infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.