All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	Christoph Hellwig <hch@infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v3 1/6] ARM: mm: kill unused runtime hook arch_iounmap()
Date: Sat, 21 May 2022 22:30:01 +0200	[thread overview]
Message-ID: <CAK8P3a3AaYovsu+aOmi62y-2i+0tmHHqpGN_PdToGt_UnGw=Ag@mail.gmail.com> (raw)
In-Reply-To: <20220519082552.117736-2-wangkefeng.wang@huawei.com>

On Thu, May 19, 2022 at 10:25 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> Since the following commits,
>
> v5.4
>   commit 59d3ae9a5bf6 ("ARM: remove Intel iop33x and iop13xx support")
> v5.11
>   commit 3e3f354bc383 ("ARM: remove ebsa110 platform")
>
> The runtime hook arch_iounmap() on ARM is useless, kill arch_iounmap()
> and __iounmap(), and the naming of arch_iounmap will be used in
> GENERIC_IOREMAP with the later patch.
>
> Cc: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

I had a very similar patch prototyped recently,

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

It would be nice to do the same for arch_ioremap_caller(), which now
has two implementations left for mvebu and imx3, previously we had
more for iop13xx, ebsa110, ixp4xx and msm.

For both armada37x/380 and imx3, the only purpose is to override
the mtype argument, and it feels like there should be a better way
to do this, though I'm not sure what that is. Having an overridable
mtype value per 256MB section of physical address space would
be sufficient for both, but I don't know if that's any better than what
we have.

        Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	 Christoph Hellwig <hch@infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	 Anshuman Khandual <anshuman.khandual@arm.com>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v3 1/6] ARM: mm: kill unused runtime hook arch_iounmap()
Date: Sat, 21 May 2022 22:30:01 +0200	[thread overview]
Message-ID: <CAK8P3a3AaYovsu+aOmi62y-2i+0tmHHqpGN_PdToGt_UnGw=Ag@mail.gmail.com> (raw)
In-Reply-To: <20220519082552.117736-2-wangkefeng.wang@huawei.com>

On Thu, May 19, 2022 at 10:25 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> Since the following commits,
>
> v5.4
>   commit 59d3ae9a5bf6 ("ARM: remove Intel iop33x and iop13xx support")
> v5.11
>   commit 3e3f354bc383 ("ARM: remove ebsa110 platform")
>
> The runtime hook arch_iounmap() on ARM is useless, kill arch_iounmap()
> and __iounmap(), and the naming of arch_iounmap will be used in
> GENERIC_IOREMAP with the later patch.
>
> Cc: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

I had a very similar patch prototyped recently,

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

It would be nice to do the same for arch_ioremap_caller(), which now
has two implementations left for mvebu and imx3, previously we had
more for iop13xx, ebsa110, ixp4xx and msm.

For both armada37x/380 and imx3, the only purpose is to override
the mtype argument, and it feels like there should be a better way
to do this, though I'm not sure what that is. Having an overridable
mtype value per 256MB section of physical address space would
be sufficient for both, but I don't know if that's any better than what
we have.

        Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-21 20:30 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  8:25 [PATCH v3 0/6] arm64: Cleanup ioremap() and support ioremap_prot() Kefeng Wang
2022-05-19  8:25 ` Kefeng Wang
2022-05-19  8:25 ` [PATCH v3 1/6] ARM: mm: kill unused runtime hook arch_iounmap() Kefeng Wang
2022-05-19  8:25   ` Kefeng Wang
2022-05-19  8:51   ` Anshuman Khandual
2022-05-19  8:51     ` Anshuman Khandual
2022-05-20 15:28   ` Catalin Marinas
2022-05-20 15:28     ` Catalin Marinas
2022-05-24  2:03     ` Kefeng Wang
2022-05-24  2:03       ` Kefeng Wang
2022-05-21 20:30   ` Arnd Bergmann [this message]
2022-05-21 20:30     ` Arnd Bergmann
2022-05-19  8:25 ` [PATCH v3 2/6] mm: ioremap: Use more sensibly name in ioremap_prot() Kefeng Wang
2022-05-19  8:25   ` Kefeng Wang
2022-05-19  8:25 ` [PATCH v3 3/6] mm: ioremap: Setup phys_addr of struct vm_struct Kefeng Wang
2022-05-19  8:25   ` Kefeng Wang
2022-05-19  8:25 ` [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Kefeng Wang
2022-05-19  8:25   ` Kefeng Wang
2022-05-19 18:52   ` Andrew Morton
2022-05-19 18:52     ` Andrew Morton
2022-05-20  1:22     ` Kefeng Wang
2022-05-20  1:22       ` Kefeng Wang
2022-05-23  3:57     ` Anshuman Khandual
2022-05-23  3:57       ` Anshuman Khandual
2022-05-23 22:17   ` kernel test robot
2022-05-23 22:17     ` kernel test robot
2022-05-24  9:48     ` Kefeng Wang
2022-05-24  9:48       ` Kefeng Wang
2022-05-24  9:48       ` Kefeng Wang
2022-05-24 12:35       ` Arnd Bergmann
2022-05-24 12:35         ` Arnd Bergmann
2022-05-24 12:35         ` Arnd Bergmann
2022-05-24 14:31         ` Kefeng Wang
2022-05-24 14:31           ` Kefeng Wang
2022-05-24 14:31           ` Kefeng Wang
2022-05-24 12:37   ` Arnd Bergmann
2022-05-24 12:37     ` Arnd Bergmann
2022-05-24 14:32     ` Kefeng Wang
2022-05-24 14:32       ` Kefeng Wang
2022-05-24 14:47       ` Arnd Bergmann
2022-05-24 14:47         ` Arnd Bergmann
2022-05-24 14:53         ` Kefeng Wang
2022-05-24 14:53           ` Kefeng Wang
2022-05-31  6:13           ` Christoph Hellwig
2022-05-31  6:13             ` Christoph Hellwig
2022-06-01  1:05             ` Kefeng Wang
2022-06-01  1:05               ` Kefeng Wang
2022-05-19  8:25 ` [PATCH v3 5/6] arm64: mm: Convert to GENERIC_IOREMAP Kefeng Wang
2022-05-19  8:25   ` Kefeng Wang
2022-05-19  8:25 ` [PATCH v3 6/6] arm64: Add HAVE_IOREMAP_PROT support Kefeng Wang
2022-05-19  8:25   ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a3AaYovsu+aOmi62y-2i+0tmHHqpGN_PdToGt_UnGw=Ag@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=hch@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.