From: Rob Herring <robh@kernel.org> To: Kishon Vijay Abraham I <kishon@ti.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Alan Stern <stern@rowland.harvard.edu>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux USB List <linux-usb@vger.kernel.org> Subject: Re: [PATCH 4/5] phy: add Marvell HSIC 28nm PHY Date: Fri, 22 May 2015 14:54:12 -0500 [thread overview] Message-ID: <CAL_JsqJxkOXNJ1wkoKAdFpGeaKcjCN2k0vBFWsY=wcuMEDVUOg@mail.gmail.com> (raw) In-Reply-To: <555DD4C2.80406@ti.com> On Thu, May 21, 2015 at 7:51 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote: > On Thursday 21 May 2015 06:15 PM, Kishon Vijay Abraham I wrote: >> >> Hi, >> >> On Thursday 14 May 2015 04:18 AM, Rob Herring wrote: >>> >>> Add PHY driver for the Marvell HSIC 28nm PHY. This PHY is found in >>> PXA1928 >>> SOC. [...] >>> + writel(readl(base + PHY_28NM_HSIC_CTRL) & >>> ~PHY_28NM_HSIC_S2H_HSIC_EN, >>> + base + PHY_28NM_HSIC_CTRL); >>> + >>> + clk_disable_unprepare(mv_phy->clk); >>> + return 0; >>> +} >>> + >>> +static const struct phy_ops hsic_ops = { >>> + .init = mv_hsic_phy_init, >>> + .power_on = mv_hsic_phy_power_on, >>> + .power_off = mv_hsic_phy_power_off, >> >> >> exit callback is missing? Shouldn't we turn off the PLLs in exit callback? I really don't understand the division of the ops functions. It seems backwards to me. Don't you need to power on the phy before you can initialize it? Or init is supposed to be s/w init of some kind. AFAICT, all the drivers just call init and power_on back to back. > > Also add the .owner member since this driver can be used as module. Strange. Generally an ops struct just has ops. Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org> Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux USB List <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 4/5] phy: add Marvell HSIC 28nm PHY Date: Fri, 22 May 2015 14:54:12 -0500 [thread overview] Message-ID: <CAL_JsqJxkOXNJ1wkoKAdFpGeaKcjCN2k0vBFWsY=wcuMEDVUOg@mail.gmail.com> (raw) In-Reply-To: <555DD4C2.80406-l0cyMroinI0@public.gmane.org> On Thu, May 21, 2015 at 7:51 AM, Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org> wrote: > On Thursday 21 May 2015 06:15 PM, Kishon Vijay Abraham I wrote: >> >> Hi, >> >> On Thursday 14 May 2015 04:18 AM, Rob Herring wrote: >>> >>> Add PHY driver for the Marvell HSIC 28nm PHY. This PHY is found in >>> PXA1928 >>> SOC. [...] >>> + writel(readl(base + PHY_28NM_HSIC_CTRL) & >>> ~PHY_28NM_HSIC_S2H_HSIC_EN, >>> + base + PHY_28NM_HSIC_CTRL); >>> + >>> + clk_disable_unprepare(mv_phy->clk); >>> + return 0; >>> +} >>> + >>> +static const struct phy_ops hsic_ops = { >>> + .init = mv_hsic_phy_init, >>> + .power_on = mv_hsic_phy_power_on, >>> + .power_off = mv_hsic_phy_power_off, >> >> >> exit callback is missing? Shouldn't we turn off the PLLs in exit callback? I really don't understand the division of the ops functions. It seems backwards to me. Don't you need to power on the phy before you can initialize it? Or init is supposed to be s/w init of some kind. AFAICT, all the drivers just call init and power_on back to back. > > Also add the .owner member since this driver can be used as module. Strange. Generally an ops struct just has ops. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-22 19:54 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-13 22:48 [PATCH 0/5] Marvell PXA1928 USB support Rob Herring 2015-05-13 22:48 ` Rob Herring 2015-05-13 22:48 ` [PATCH 1/5] dt-bindings: Add Marvell PXA1928 USB and HSIC PHY bindings Rob Herring 2015-05-13 22:48 ` Rob Herring 2015-05-13 22:48 ` [PATCH 2/5] dt-bindings: Add Marvell PXA1928 USB EHCI controller binding Rob Herring 2015-05-13 22:48 ` [PATCH 3/5] phy: Add Marvell USB 2.0 OTG 28nm PHY Rob Herring 2015-05-13 22:48 ` Rob Herring 2015-05-21 12:33 ` Kishon Vijay Abraham I 2015-05-21 12:33 ` Kishon Vijay Abraham I 2015-05-13 22:48 ` [PATCH 4/5] phy: add Marvell HSIC " Rob Herring 2015-05-21 12:45 ` Kishon Vijay Abraham I 2015-05-21 12:45 ` Kishon Vijay Abraham I 2015-05-21 12:51 ` Kishon Vijay Abraham I 2015-05-21 12:51 ` Kishon Vijay Abraham I 2015-05-22 19:54 ` Rob Herring [this message] 2015-05-22 19:54 ` Rob Herring 2015-05-26 6:06 ` Kishon Vijay Abraham I 2015-05-13 22:49 ` [PATCH 5/5] usb: add pxa1928 ehci support Rob Herring 2015-05-14 8:24 ` Paul Bolle 2015-05-14 10:42 ` Arnd Bergmann 2015-05-14 13:25 ` Rob Herring 2015-05-14 13:25 ` Rob Herring 2015-05-14 10:43 ` Arnd Bergmann 2015-05-14 14:56 ` Alan Stern 2015-05-14 14:56 ` Alan Stern 2015-05-14 16:36 ` Rob Herring 2015-05-14 16:36 ` Rob Herring 2015-05-14 17:06 ` Alan Stern 2015-05-14 17:06 ` Alan Stern 2015-05-14 15:55 ` Alan Stern 2015-05-14 15:55 ` Alan Stern 2015-05-15 9:32 ` Arnd Bergmann 2015-05-15 9:55 ` [PATCH 0/5] Marvell PXA1928 USB support Sebastian Hesselbarth 2015-05-15 9:55 ` Sebastian Hesselbarth 2015-05-15 12:48 ` Rob Herring 2015-05-15 12:48 ` Rob Herring 2015-05-15 14:11 ` Arnd Bergmann 2015-05-15 16:04 ` Rob Herring 2015-05-15 16:04 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqJxkOXNJ1wkoKAdFpGeaKcjCN2k0vBFWsY=wcuMEDVUOg@mail.gmail.com' \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.