[PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

When PHY reset pin is connected to a GPIO on external GPIO chip
(e.g. I2C), we should not call the gpio_set_value() function, but
gpio_set_value_cansleep().

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
This patch depends on the patch from Keshava [1]:
ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

[1] http://www.spinics.net/lists/linux-omap/msg66774.html

 drivers/usb/host/ehci-omap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 5c78f9e..26e9241 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 		udelay(10);
 
 		if (gpio_is_valid(pdata->reset_gpio_port[0]))
-			gpio_set_value(pdata->reset_gpio_port[0], 1);
+			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
 
 		if (gpio_is_valid(pdata->reset_gpio_port[1]))
-			gpio_set_value(pdata->reset_gpio_port[1], 1);
+			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
 	}
 
 	return 0;
-- 
1.7.3.4

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote:
> When PHY reset pin is connected to a GPIO on external GPIO chip
> (e.g. I2C), we should not call the gpio_set_value() function, but
> gpio_set_value_cansleep().
> 
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>

Acked-by: Felipe Balbi <balbi@ti.com>

Keshava, please give us your tested-by. Patch looks fine to me.

> ---
> This patch depends on the patch from Keshava [1]:
> ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
> 
> [1] http://www.spinics.net/lists/linux-omap/msg66774.html
> 
>  drivers/usb/host/ehci-omap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 5c78f9e..26e9241 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
>  		udelay(10);
>  
>  		if (gpio_is_valid(pdata->reset_gpio_port[0]))
> -			gpio_set_value(pdata->reset_gpio_port[0], 1);
> +			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
>  
>  		if (gpio_is_valid(pdata->reset_gpio_port[1]))
> -			gpio_set_value(pdata->reset_gpio_port[1], 1);
> +			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
>  	}
>  
>  	return 0;
> -- 
> 1.7.3.4
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Raja, Govindraj]

On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote:
>> When PHY reset pin is connected to a GPIO on external GPIO chip
>> (e.g. I2C), we should not call the gpio_set_value() function, but
>> gpio_set_value_cansleep().
>>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>
> Acked-by: Felipe Balbi <balbi@ti.com>
>
> Keshava, please give us your tested-by. Patch looks fine to me.

Tried on beagle-xm where the smsc hub + smsc95xx ethernet controller
relies gpio nreset sequence for initialization.

Both hub + Ethernet controller get enumerated even after this patch.

Tested-by: Govindraj.R <govindraj.raja@ti.com>

>
>> ---
>> This patch depends on the patch from Keshava [1]:
>> ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
>>
>> [1] http://www.spinics.net/lists/linux-omap/msg66774.html
>>
>>  drivers/usb/host/ehci-omap.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
>> index 5c78f9e..26e9241 100644
>> --- a/drivers/usb/host/ehci-omap.c
>> +++ b/drivers/usb/host/ehci-omap.c
>> @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
>>               udelay(10);
>>
>>               if (gpio_is_valid(pdata->reset_gpio_port[0]))
>> -                     gpio_set_value(pdata->reset_gpio_port[0], 1);
>> +                     gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
>>
>>               if (gpio_is_valid(pdata->reset_gpio_port[1]))
>> -                     gpio_set_value(pdata->reset_gpio_port[1], 1);
>> +                     gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
>>       }
>>
>>       return 0;
>> --
>> 1.7.3.4
>>
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

On 03/28/12 12:53, Raja, Govindraj wrote:
> On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
>> On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote:
>>> When PHY reset pin is connected to a GPIO on external GPIO chip
>>> (e.g. I2C), we should not call the gpio_set_value() function, but
>>> gpio_set_value_cansleep().
>>>
>>> Signed-off-by: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>>
>> Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>>
>> Keshava, please give us your tested-by. Patch looks fine to me.
> 
> Tried on beagle-xm where the smsc hub + smsc95xx ethernet controller
> relies gpio nreset sequence for initialization.
> 
> Both hub + Ethernet controller get enumerated even after this patch.
> 
> Tested-by: Govindraj.R <govindraj.raja-l0cyMroinI0@public.gmane.org>

Thanks Raja.


-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Munegowda, Keshava]

On Wed, Mar 28, 2012 at 4:23 PM, Raja, Govindraj <govindraj.raja@ti.com> wrote:
> On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi <balbi@ti.com> wrote:
>> On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote:
>>> When PHY reset pin is connected to a GPIO on external GPIO chip
>>> (e.g. I2C), we should not call the gpio_set_value() function, but
>>> gpio_set_value_cansleep().
>>>
>>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>>
>> Acked-by: Felipe Balbi <balbi@ti.com>
>>
>> Keshava, please give us your tested-by. Patch looks fine to me.
>
> Tried on beagle-xm where the smsc hub + smsc95xx ethernet controller
> relies gpio nreset sequence for initialization.
>
> Both hub + Ethernet controller get enumerated even after this patch.
>
> Tested-by: Govindraj.R <govindraj.raja@ti.com>
>
>>

Thanks govind.



>>> ---
>>> This patch depends on the patch from Keshava [1]:
>>> ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
>>>
>>> [1] http://www.spinics.net/lists/linux-omap/msg66774.html
>>>
>>>  drivers/usb/host/ehci-omap.c |    4 ++--
>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
>>> index 5c78f9e..26e9241 100644
>>> --- a/drivers/usb/host/ehci-omap.c
>>> +++ b/drivers/usb/host/ehci-omap.c
>>> @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
>>>               udelay(10);
>>>
>>>               if (gpio_is_valid(pdata->reset_gpio_port[0]))
>>> -                     gpio_set_value(pdata->reset_gpio_port[0], 1);
>>> +                     gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
>>>
>>>               if (gpio_is_valid(pdata->reset_gpio_port[1]))
>>> -                     gpio_set_value(pdata->reset_gpio_port[1], 1);
>>> +                     gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
>>>       }
>>>
>>>       return 0;
>>> --
>>> 1.7.3.4
>>>
>>
>> --
>> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

Hi Shubhrajyoti,

On 03/28/12 12:03, Shubhrajyoti wrote:
> On Tuesday 27 March 2012 07:38 PM, Igor Grinberg wrote:
>> When PHY reset pin is connected to a GPIO on external GPIO chip
>> (e.g. I2C), we should not call the gpio_set_value() function, but
>> gpio_set_value_cansleep().
> Why so ? Whats the error otherwise ?

Otherwise, we get a very confusing warnings:
WARNING: at /home/grinberg/git-repo/linux-omap/drivers/gpio/gpiolib.c:1584 __gpio_set_value+0x5c/0x64()
Modules linked in:
[<c001ae6c>] (unwind_backtrace+0x0/0xfc) from [<c003ba10>] (warn_slowpath_common+0x54/0x64)
[<c003ba10>] (warn_slowpath_common+0x54/0x64) from [<c003ba3c>] (warn_slowpath_null+0x1c/0x24)
[<c003ba3c>] (warn_slowpath_null+0x1c/0x24) from [<c0260860>] (__gpio_set_value+0x5c/0x64)
[<c0260860>] (__gpio_set_value+0x5c/0x64) from [<c035fde8>] (ehci_hcd_omap_probe+0x390/0x6c0)
[<c035fde8>] (ehci_hcd_omap_probe+0x390/0x6c0) from [<c02d59dc>] (platform_drv_probe+0x18/0x1c)
[<c02d59dc>] (platform_drv_probe+0x18/0x1c) from [<c02d44d0>] (really_probe+0x64/0x160)
[<c02d44d0>] (really_probe+0x64/0x160) from [<c02d4614>] (driver_probe_device+0x48/0x60)
[<c02d4614>] (driver_probe_device+0x48/0x60) from [<c02d46c0>] (__driver_attach+0x94/0x98)
[<c02d46c0>] (__driver_attach+0x94/0x98) from [<c02d2f4c>] (bus_for_each_dev+0x54/0x80)
[<c02d2f4c>] (bus_for_each_dev+0x54/0x80) from [<c02d3680>] (bus_add_driver+0xa8/0x2a4)
[<c02d3680>] (bus_add_driver+0xa8/0x2a4) from [<c02d4cbc>] (driver_register+0x78/0x184)
[<c02d4cbc>] (driver_register+0x78/0x184) from [<c062e744>] (ehci_hcd_init+0xd8/0x114)
[<c062e744>] (ehci_hcd_init+0xd8/0x114) from [<c0008758>] (do_one_initcall+0x34/0x184)
[<c0008758>] (do_one_initcall+0x34/0x184) from [<c0612248>] (do_basic_setup+0x34/0x40)
[<c0612248>] (do_basic_setup+0x34/0x40) from [<c06122b8>] (kernel_init+0x64/0xec)
[<c06122b8>] (kernel_init+0x64/0xec) from [<c00154cc>] (kernel_thread_exit+0x0/0x8)
---[ end trace 1b75b31a2719ed1e ]---

Because GPIOs can be used from atomic context, there are two versions
of GPIO control functions: gpio_<set|get>_value() and
gpio_<set|get>_value_cansleep().
The warning above means that the atomic context safe function
has been called, but the GPIO chip is not atomic safe - requires an I2C
transaction which may sleep and therefore a warning.

Now, for all on SoC GPIOs, the time for the gpio_set_value_cansleep()
call should not be different then the one for the gpio_set_value().
After my patch, the behavior should not change, but eliminate the warning
for external GPIO chip users.

>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>> This patch depends on the patch from Keshava [1]:
>> ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
>>
>> [1] http://www.spinics.net/lists/linux-omap/msg66774.html
>>
>>  drivers/usb/host/ehci-omap.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
>> index 5c78f9e..26e9241 100644
>> --- a/drivers/usb/host/ehci-omap.c
>> +++ b/drivers/usb/host/ehci-omap.c
>> @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
>>  		udelay(10);
>>  
>>  		if (gpio_is_valid(pdata->reset_gpio_port[0]))
>> -			gpio_set_value(pdata->reset_gpio_port[0], 1);
>> +			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
>>  
>>  		if (gpio_is_valid(pdata->reset_gpio_port[1]))
>> -			gpio_set_value(pdata->reset_gpio_port[1], 1);
>> +			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
>>  	}
>>  
>>  	return 0;
> 
> 

-- 
Regards,
Igor.

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Shubhrajyoti Datta]

Hi Igor,

On Wed, Mar 28, 2012 at 4:43 PM, Igor Grinberg <grinberg@compulab.co.il> wrote:
> Hi Shubhrajyoti,
>
> On 03/28/12 12:03, Shubhrajyoti wrote:
>> On Tuesday 27 March 2012 07:38 PM, Igor Grinberg wrote:
>>> When PHY reset pin is connected to a GPIO on external GPIO chip
>>> (e.g. I2C), we should not call the gpio_set_value() function, but
>>> gpio_set_value_cansleep().
>> Why so ? Whats the error otherwise ?
>
> Otherwise, we get a very confusing warnings:

Yes I guessed so thanks for the patch.

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

ping

Alan, Felipe,
Can this go into 3.5?

The dependency patch has already reached Samuel's tree,
what would be the best way to apply this one?
Should I ask Samuel to apply this one also (after having your acks)
via his tree, to reduce possible merge failures/conflicts?

On 03/27/12 16:08, Igor Grinberg wrote:
> When PHY reset pin is connected to a GPIO on external GPIO chip
> (e.g. I2C), we should not call the gpio_set_value() function, but
> gpio_set_value_cansleep().
> 
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> This patch depends on the patch from Keshava [1]:
> ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
> 
> [1] http://www.spinics.net/lists/linux-omap/msg66774.html
> 
>  drivers/usb/host/ehci-omap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 5c78f9e..26e9241 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
>  		udelay(10);
>  
>  		if (gpio_is_valid(pdata->reset_gpio_port[0]))
> -			gpio_set_value(pdata->reset_gpio_port[0], 1);
> +			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
>  
>  		if (gpio_is_valid(pdata->reset_gpio_port[1]))
> -			gpio_set_value(pdata->reset_gpio_port[1], 1);
> +			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
>  	}
>  
>  	return 0;

-- 
Regards,
Igor.

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Alan Stern]

On Thu, 19 Apr 2012, Igor Grinberg wrote:

> ping
> 
> Alan, Felipe,
> Can this go into 3.5?

It's okay with me.

Acked-by: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>

> The dependency patch has already reached Samuel's tree,
> what would be the best way to apply this one?
> Should I ask Samuel to apply this one also (after having your acks)
> via his tree, to reduce possible merge failures/conflicts?

Sure, go ahead.

> On 03/27/12 16:08, Igor Grinberg wrote:
> > When PHY reset pin is connected to a GPIO on external GPIO chip
> > (e.g. I2C), we should not call the gpio_set_value() function, but
> > gpio_set_value_cansleep().
> > 
> > Signed-off-by: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> > ---
> > This patch depends on the patch from Keshava [1]:
> > ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
> > 
> > [1] http://www.spinics.net/lists/linux-omap/msg66774.html
> > 
> >  drivers/usb/host/ehci-omap.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> > index 5c78f9e..26e9241 100644
> > --- a/drivers/usb/host/ehci-omap.c
> > +++ b/drivers/usb/host/ehci-omap.c
> > @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
> >  		udelay(10);
> >  
> >  		if (gpio_is_valid(pdata->reset_gpio_port[0]))
> > -			gpio_set_value(pdata->reset_gpio_port[0], 1);
> > +			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
> >  
> >  		if (gpio_is_valid(pdata->reset_gpio_port[1]))
> > -			gpio_set_value(pdata->reset_gpio_port[1], 1);
> > +			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
> >  	}
> >  
> >  	return 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1960 bytes --]

On Thu, Apr 19, 2012 at 11:01:16AM -0400, Alan Stern wrote:
> On Thu, 19 Apr 2012, Igor Grinberg wrote:
> 
> > ping
> > 
> > Alan, Felipe,
> > Can this go into 3.5?
> 
> It's okay with me.
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Also fine from my side:

Acked-by: Felipe Balbi <balbi@ti.com>

> > The dependency patch has already reached Samuel's tree,
> > what would be the best way to apply this one?
> > Should I ask Samuel to apply this one also (after having your acks)
> > via his tree, to reduce possible merge failures/conflicts?
> 
> Sure, go ahead.
> 
> > On 03/27/12 16:08, Igor Grinberg wrote:
> > > When PHY reset pin is connected to a GPIO on external GPIO chip
> > > (e.g. I2C), we should not call the gpio_set_value() function, but
> > > gpio_set_value_cansleep().
> > > 
> > > Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> > > ---
> > > This patch depends on the patch from Keshava [1]:
> > > ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
> > > 
> > > [1] http://www.spinics.net/lists/linux-omap/msg66774.html
> > > 
> > >  drivers/usb/host/ehci-omap.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> > > index 5c78f9e..26e9241 100644
> > > --- a/drivers/usb/host/ehci-omap.c
> > > +++ b/drivers/usb/host/ehci-omap.c
> > > @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
> > >  		udelay(10);
> > >  
> > >  		if (gpio_is_valid(pdata->reset_gpio_port[0]))
> > > -			gpio_set_value(pdata->reset_gpio_port[0], 1);
> > > +			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
> > >  
> > >  		if (gpio_is_valid(pdata->reset_gpio_port[1]))
> > > -			gpio_set_value(pdata->reset_gpio_port[1], 1);
> > > +			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
> > >  	}
> > >  
> > >  	return 0;
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Alan,


On 04/20/12 14:57, Felipe Balbi wrote:
> On Thu, Apr 19, 2012 at 11:01:16AM -0400, Alan Stern wrote:
>> On Thu, 19 Apr 2012, Igor Grinberg wrote:
>>
>>> ping
>>>
>>> Alan, Felipe,
>>> Can this go into 3.5?
>>
>> It's okay with me.
>>
>> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> 
> Also fine from my side:
> 
> Acked-by: Felipe Balbi <balbi@ti.com>
> 
>>> The dependency patch has already reached Samuel's tree,
>>> what would be the best way to apply this one?
>>> Should I ask Samuel to apply this one also (after having your acks)
>>> via his tree, to reduce possible merge failures/conflicts?
>>
>> Sure, go ahead.

Sorry, for being jumpy...
Samuel has not answered yet (it has been more then two weeks already)
and I'd like this to go into 3.5.
Also, the dependency patch is already in Linus' tree. It has been merged with
fixes (I thought it will happen only during the merge window...).

Can you, please take this one?

Thanks

>>
>>> On 03/27/12 16:08, Igor Grinberg wrote:
>>>> When PHY reset pin is connected to a GPIO on external GPIO chip
>>>> (e.g. I2C), we should not call the gpio_set_value() function, but
>>>> gpio_set_value_cansleep().
>>>>
>>>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>>>> ---
>>>> This patch depends on the patch from Keshava [1]:
>>>> ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue
>>>>
>>>> [1] http://www.spinics.net/lists/linux-omap/msg66774.html
>>>>
>>>>  drivers/usb/host/ehci-omap.c |    4 ++--
>>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
>>>> index 5c78f9e..26e9241 100644
>>>> --- a/drivers/usb/host/ehci-omap.c
>>>> +++ b/drivers/usb/host/ehci-omap.c
>>>> @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
>>>>  		udelay(10);
>>>>  
>>>>  		if (gpio_is_valid(pdata->reset_gpio_port[0]))
>>>> -			gpio_set_value(pdata->reset_gpio_port[0], 1);
>>>> +			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
>>>>  
>>>>  		if (gpio_is_valid(pdata->reset_gpio_port[1]))
>>>> -			gpio_set_value(pdata->reset_gpio_port[1], 1);
>>>> +			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
>>>>  	}
>>>>  
>>>>  	return 0;
>>
> 

- -- 
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPphlAAAoJEBDE8YO64EfaejYP/0cjyLNgGzxeWJy9X5Q34C8S
UIvAb6bHQrYxIqpdZ8vctPI1vnXgHvaWAdUg24Y5IWY+TPCvr6NWv5PGfMe7zAD6
YHF6T7Yakn1C9geuPMCUNR0KRdd4EEN5YSXEu+ILr/xa7Bp2IzFvtThD8rqLeLWi
8z411WT/eCpGdk2Y6WPw41AWW1YyfEaFwPz49w6siypyw032tB32zIghaYzy2C8W
QtAUAbpBSw627tHRVPeVAqfQIK6plLoyCP9ql1FtaDbx/BwYlgALJv/1NrAgqtCe
8Kd6vfkEfZiUhsG2uO4cx9QwY2gKTu285mpMQe0824rWUSFd8s/JS3HdYhPxIZOb
HKjcYT4T9N0ZSJyPx0SqCOvP5wLPySSc2g37PdOis7+awH2a0HGIsoZJgXTkWbR/
giLmvaOvKoTjsSsPRCUBKuU4eRPlK2k7tm4eobo/7VAJnhrD0IGAWn4vH981PE1h
eM4b9TwAxC4s2xUdxe/v5e+zF0wqtBvfWjultQw9OvKskZfroPspdzhuzhrt86P6
Ecedu+moMNG00zFuoEgPZYY7h/de+8gPFp+jZfuWNDQSLwDmRpZINLcAB2VEnY8G
YrTN6lmaH00Fy8EVAqOhh7wnIB192myVo6axiGKwSbus3E91YboKYoTLEjArJEF7
DE5AB9sKxnZQpzihpwAt
=OFXi
-----END PGP SIGNATURE-----

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Samuel Ortiz]

Hi Igor,

On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote:
> Sorry, for being jumpy...
> Samuel has not answered yet (it has been more then two weeks already)
Sorry about that.

> and I'd like this to go into 3.5.
Then you may need a better changelog explaining how this fixes a regression,
runtime crash or build failure.


> Also, the dependency patch is already in Linus' tree. It has been merged with
> fixes (I thought it will happen only during the merge window...).
> 
> Can you, please take this one?
At that point, it definitely makes more sense for Alan to push it.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

Hi Samuel,

On 05/07/12 11:09, Samuel Ortiz wrote:
> Hi Igor,
> 
> On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote:
>> Sorry, for being jumpy...
>> Samuel has not answered yet (it has been more then two weeks already)
> Sorry about that.
> 
>> and I'd like this to go into 3.5.
> Then you may need a better changelog explaining how this fixes a regression,
> runtime crash or build failure.

Well, I did not say it is a regression. In fact it is not.
I just finally sent a fix to eliminate a runtime warning which was there
for a long time and can be seen on specific configurations.
That is why, I want it into 3.5 during the merge window
(not 3.4 although I won't object it to go in earlier ;-) ).

> 
> 
>> Also, the dependency patch is already in Linus' tree. It has been merged with
>> fixes (I thought it will happen only during the merge window...).
>>
>> Can you, please take this one?
> At that point, it definitely makes more sense for Alan to push it.

Yep, makes sense to me.

Alan?

-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Samuel Ortiz]

Hi Igor,

On Mon, May 07, 2012 at 02:46:35PM +0300, Igor Grinberg wrote:
> Hi Samuel,
> 
> On 05/07/12 11:09, Samuel Ortiz wrote:
> > Hi Igor,
> > 
> > On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote:
> >> Sorry, for being jumpy...
> >> Samuel has not answered yet (it has been more then two weeks already)
> > Sorry about that.
> > 
> >> and I'd like this to go into 3.5.
> > Then you may need a better changelog explaining how this fixes a regression,
> > runtime crash or build failure.
> 
> Well, I did not say it is a regression. In fact it is not.
> I just finally sent a fix to eliminate a runtime warning which was there
> for a long time and can be seen on specific configurations.
> That is why, I want it into 3.5 during the merge window
Sorry, I misread that part. Getting that one for the next merge window is just
fine.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Alan Stern]

On Sun, 6 May 2012, Igor Grinberg wrote:

> Hi Alan,

...

> Sorry, for being jumpy...
> Samuel has not answered yet (it has been more then two weeks already)
> and I'd like this to go into 3.5.
> Also, the dependency patch is already in Linus' tree. It has been merged with
> fixes (I thought it will happen only during the merge window...).
> 
> Can you, please take this one?

No, I can't, sorry.  It has to be accepted by Greg KH.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

On 05/07/12 17:04, Alan Stern wrote:
> On Sun, 6 May 2012, Igor Grinberg wrote:
> 
>> Hi Alan,
> 
> ...
> 
>> Sorry, for being jumpy...
>> Samuel has not answered yet (it has been more then two weeks already)
>> and I'd like this to go into 3.5.
>> Also, the dependency patch is already in Linus' tree. It has been merged with
>> fixes (I thought it will happen only during the merge window...).
>>
>> Can you, please take this one?
> 
> No, I can't, sorry.  It has to be accepted by Greg KH.

Hmm... I don't mind it be that way, but I'd like to understand:

# scripts/get_maintainer.pl -f drivers/usb/host/ehci-omap.c
Alan Stern <stern@rowland.harvard.edu> (maintainer:USB EHCI DRIVER)
Felipe Balbi <balbi@ti.com> (maintainer:OMAP USB SUPPORT)
Greg Kroah-Hartman <gregkh@suse.de> (supporter:USB SUBSYSTEM)
linux-usb@vger.kernel.org (open list:USB EHCI DRIVER)
linux-omap@vger.kernel.org (open list:OMAP USB SUPPORT)
linux-kernel@vger.kernel.org (open list)

This makes you the USB EHCI maintainer, right?
I just want to understand...
Do you need also ack from Greg to take something to your tree
for being applied in the next merge window?


-- 
Regards,
Igor.

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Alan Stern]

On Mon, 7 May 2012, Igor Grinberg wrote:

> On 05/07/12 17:04, Alan Stern wrote:
> > On Sun, 6 May 2012, Igor Grinberg wrote:
> > 
> >> Hi Alan,
> > 
> > ...
> > 
> >> Sorry, for being jumpy...
> >> Samuel has not answered yet (it has been more then two weeks already)
> >> and I'd like this to go into 3.5.
> >> Also, the dependency patch is already in Linus' tree. It has been merged with
> >> fixes (I thought it will happen only during the merge window...).
> >>
> >> Can you, please take this one?
> > 
> > No, I can't, sorry.  It has to be accepted by Greg KH.
> 
> Hmm... I don't mind it be that way, but I'd like to understand:
> 
> # scripts/get_maintainer.pl -f drivers/usb/host/ehci-omap.c
> Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> (maintainer:USB EHCI DRIVER)
> Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> (maintainer:OMAP USB SUPPORT)
> Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org> (supporter:USB SUBSYSTEM)
> linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:USB EHCI DRIVER)
> linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:OMAP USB SUPPORT)
> linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
> 
> This makes you the USB EHCI maintainer, right?

Right.

> I just want to understand...
> Do you need also ack from Greg to take something to your tree
> for being applied in the next merge window?

No.  I don't takes patches at all, and in fact I don't even have a git
directory or a login account at kernel.org.  All my work goes through
Greg; I submit or acknowledge patches and he merges them.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

On 05/07/12 17:48, Alan Stern wrote:
> On Mon, 7 May 2012, Igor Grinberg wrote:
> 
>> On 05/07/12 17:04, Alan Stern wrote:
>>> On Sun, 6 May 2012, Igor Grinberg wrote:
>>>
>>>> Hi Alan,
>>>
>>> ...
>>>
>>>> Sorry, for being jumpy...
>>>> Samuel has not answered yet (it has been more then two weeks already)
>>>> and I'd like this to go into 3.5.
>>>> Also, the dependency patch is already in Linus' tree. It has been merged with
>>>> fixes (I thought it will happen only during the merge window...).
>>>>
>>>> Can you, please take this one?
>>>
>>> No, I can't, sorry.  It has to be accepted by Greg KH.
>>
>> Hmm... I don't mind it be that way, but I'd like to understand:
>>
>> # scripts/get_maintainer.pl -f drivers/usb/host/ehci-omap.c
>> Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> (maintainer:USB EHCI DRIVER)
>> Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> (maintainer:OMAP USB SUPPORT)
>> Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org> (supporter:USB SUBSYSTEM)
>> linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:USB EHCI DRIVER)
>> linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:OMAP USB SUPPORT)
>> linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
>>
>> This makes you the USB EHCI maintainer, right?
> 
> Right.
> 
>> I just want to understand...
>> Do you need also ack from Greg to take something to your tree
>> for being applied in the next merge window?
> 
> No.  I don't takes patches at all, and in fact I don't even have a git
> directory or a login account at kernel.org.  All my work goes through
> Greg; I submit or acknowledge patches and he merges them.

Ah, I see. Thanks for the explanation.
So currently, I need to do something like this:

Greg,

This patch has been acked by Alan and Felipe, can you please apply it
for the merge window (which is close as I understand from Linus':
"We've never been closer to a 3.4 release").

Thanks

-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Greg Kroah-Hartman]

On Tue, May 08, 2012 at 10:53:44AM +0300, Igor Grinberg wrote:
> On 05/07/12 17:48, Alan Stern wrote:
> > On Mon, 7 May 2012, Igor Grinberg wrote:
> > 
> >> On 05/07/12 17:04, Alan Stern wrote:
> >>> On Sun, 6 May 2012, Igor Grinberg wrote:
> >>>
> >>>> Hi Alan,
> >>>
> >>> ...
> >>>
> >>>> Sorry, for being jumpy...
> >>>> Samuel has not answered yet (it has been more then two weeks already)
> >>>> and I'd like this to go into 3.5.
> >>>> Also, the dependency patch is already in Linus' tree. It has been merged with
> >>>> fixes (I thought it will happen only during the merge window...).
> >>>>
> >>>> Can you, please take this one?
> >>>
> >>> No, I can't, sorry.  It has to be accepted by Greg KH.
> >>
> >> Hmm... I don't mind it be that way, but I'd like to understand:
> >>
> >> # scripts/get_maintainer.pl -f drivers/usb/host/ehci-omap.c
> >> Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> (maintainer:USB EHCI DRIVER)
> >> Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> (maintainer:OMAP USB SUPPORT)
> >> Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org> (supporter:USB SUBSYSTEM)
> >> linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:USB EHCI DRIVER)
> >> linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:OMAP USB SUPPORT)
> >> linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
> >>
> >> This makes you the USB EHCI maintainer, right?
> > 
> > Right.
> > 
> >> I just want to understand...
> >> Do you need also ack from Greg to take something to your tree
> >> for being applied in the next merge window?
> > 
> > No.  I don't takes patches at all, and in fact I don't even have a git
> > directory or a login account at kernel.org.  All my work goes through
> > Greg; I submit or acknowledge patches and he merges them.
> 
> Ah, I see. Thanks for the explanation.
> So currently, I need to do something like this:
> 
> Greg,
> 
> This patch has been acked by Alan and Felipe, can you please apply it
> for the merge window (which is close as I understand from Linus':
> "We've never been closer to a 3.4 release").

Ok, but it's fallen out of my email archive (I only keep the past month
around), so can you please resend it, with Alan and Felipe's acks, so I
can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

On 05/08/12 19:24, Greg Kroah-Hartman wrote:
> On Tue, May 08, 2012 at 10:53:44AM +0300, Igor Grinberg wrote:
>> On 05/07/12 17:48, Alan Stern wrote:
>>> On Mon, 7 May 2012, Igor Grinberg wrote:
>>>
>>>> On 05/07/12 17:04, Alan Stern wrote:
>>>>> On Sun, 6 May 2012, Igor Grinberg wrote:
>>>>>
>>>>>> Hi Alan,
>>>>>
>>>>> ...
>>>>>
>>>>>> Sorry, for being jumpy...
>>>>>> Samuel has not answered yet (it has been more then two weeks already)
>>>>>> and I'd like this to go into 3.5.
>>>>>> Also, the dependency patch is already in Linus' tree. It has been merged with
>>>>>> fixes (I thought it will happen only during the merge window...).
>>>>>>
>>>>>> Can you, please take this one?
>>>>>
>>>>> No, I can't, sorry.  It has to be accepted by Greg KH.
>>>>
>>>> Hmm... I don't mind it be that way, but I'd like to understand:
>>>>
>>>> # scripts/get_maintainer.pl -f drivers/usb/host/ehci-omap.c
>>>> Alan Stern <stern@rowland.harvard.edu> (maintainer:USB EHCI DRIVER)
>>>> Felipe Balbi <balbi@ti.com> (maintainer:OMAP USB SUPPORT)
>>>> Greg Kroah-Hartman <gregkh@suse.de> (supporter:USB SUBSYSTEM)
>>>> linux-usb@vger.kernel.org (open list:USB EHCI DRIVER)
>>>> linux-omap@vger.kernel.org (open list:OMAP USB SUPPORT)
>>>> linux-kernel@vger.kernel.org (open list)
>>>>
>>>> This makes you the USB EHCI maintainer, right?
>>>
>>> Right.
>>>
>>>> I just want to understand...
>>>> Do you need also ack from Greg to take something to your tree
>>>> for being applied in the next merge window?
>>>
>>> No.  I don't takes patches at all, and in fact I don't even have a git
>>> directory or a login account at kernel.org.  All my work goes through
>>> Greg; I submit or acknowledge patches and he merges them.
>>
>> Ah, I see. Thanks for the explanation.
>> So currently, I need to do something like this:
>>
>> Greg,
>>
>> This patch has been acked by Alan and Felipe, can you please apply it
>> for the merge window (which is close as I understand from Linus':
>> "We've never been closer to a 3.4 release").
> 
> Ok, but it's fallen out of my email archive (I only keep the past month
> around), so can you please resend it, with Alan and Felipe's acks, so I
> can apply it?

Yep, will shortly do.

Thanks


-- 
Regards,
Igor.

[PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

[Igor Grinberg]

When PHY reset pin is connected to a GPIO on external GPIO chip
(e.g. I2C), we should not call the gpio_set_value() function, but
gpio_set_value_cansleep().

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Acked-by: Felipe Balbi <balbi@ti.com>
Tested-by: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
 drivers/usb/host/ehci-omap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 5c78f9e..26e9241 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 		udelay(10);
 
 		if (gpio_is_valid(pdata->reset_gpio_port[0]))
-			gpio_set_value(pdata->reset_gpio_port[0], 1);
+			gpio_set_value_cansleep(pdata->reset_gpio_port[0], 1);
 
 		if (gpio_is_valid(pdata->reset_gpio_port[1]))
-			gpio_set_value(pdata->reset_gpio_port[1], 1);
+			gpio_set_value_cansleep(pdata->reset_gpio_port[1], 1);
 	}
 
 	return 0;
-- 
1.7.3.4