All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	DEVICETREE <devicetree@vger.kernel.org>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Dialog Opensource Support <support.opensource@diasemi.com>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Wed, 20 Mar 2019 09:16:49 -0300	[thread overview]
Message-ID: <CAOMZO5AHzQJzz3vd5MzYgSSxzPjU9xan1dFh9473BXeiRCOzzg@mail.gmail.com> (raw)
In-Reply-To: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com>

Hi Steve,

On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss
<stwiss.opensource@diasemi.com> wrote:
>
> The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
> 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were

This patch declares it as 'rgmii-id', which contradicts the commit log.

> previously added by the MAC when required, but are now provided
> internally by the PHY (and the MAC should no longer add the RX or TX
> delays in this case).
>
> This patch fixes the network problems seen on the Freescale i.MX6Q/DL

Please provide a Fixes tag. It would be good to know if this fix needs
to be applied to older kernels.

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	DEVICETREE <devicetree@vger.kernel.org>,
	Dialog Opensource Support <support.opensource@diasemi.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
Date: Wed, 20 Mar 2019 09:16:49 -0300	[thread overview]
Message-ID: <CAOMZO5AHzQJzz3vd5MzYgSSxzPjU9xan1dFh9473BXeiRCOzzg@mail.gmail.com> (raw)
In-Reply-To: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com>

Hi Steve,

On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss
<stwiss.opensource@diasemi.com> wrote:
>
> The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
> 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were

This patch declares it as 'rgmii-id', which contradicts the commit log.

> previously added by the MAC when required, but are now provided
> internally by the PHY (and the MAC should no longer add the RX or TX
> delays in this case).
>
> This patch fixes the network problems seen on the Freescale i.MX6Q/DL

Please provide a Fixes tag. It would be good to know if this fix needs
to be applied to older kernels.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-20 12:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 11:03 [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Steve Twiss
2019-03-20 11:03 ` Steve Twiss
2019-03-20 12:16 ` Fabio Estevam [this message]
2019-03-20 12:16   ` Fabio Estevam
2019-03-20 16:03   ` Steve Twiss
2019-03-20 16:03     ` Steve Twiss
2019-03-20 17:04     ` Fabio Estevam
2019-03-20 17:04       ` Fabio Estevam
2019-03-21  8:42       ` Abel Vesa
2019-03-21  8:42         ` Abel Vesa
2019-03-21 11:17         ` Fabio Estevam
2019-03-21 11:17           ` Fabio Estevam
2019-03-21 11:32           ` Steve Twiss
2019-03-21 11:32             ` Steve Twiss
2019-03-21 11:50             ` Andrew Lunn
2019-03-21 11:50               ` Andrew Lunn
2019-03-21 11:45           ` Andrew Lunn
2019-03-21 11:45             ` Andrew Lunn
2019-03-21 12:43           ` Lucas Stach
2019-03-21 12:43             ` Lucas Stach
2019-03-22  1:11           ` Shawn Guo
2019-03-22  1:11             ` Shawn Guo
2019-03-22  2:00             ` Fabio Estevam
2019-03-22  2:00               ` Fabio Estevam
2019-03-22  2:15               ` Shawn Guo
2019-03-22  2:15                 ` Shawn Guo
2019-03-22  2:24                 ` Fabio Estevam
2019-03-22  2:24                   ` Fabio Estevam
2019-03-22 10:20                   ` Michal Vokáč
2019-03-22 10:20                     ` Michal Vokáč
2019-03-22 10:50                     ` Steve Twiss
2019-03-22 10:50                       ` Steve Twiss
2019-03-22 10:50                       ` Steve Twiss
2019-03-22 10:59                       ` Andrew Lunn
2019-03-22 10:59                         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AHzQJzz3vd5MzYgSSxzPjU9xan1dFh9473BXeiRCOzzg@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stwiss.opensource@diasemi.com \
    --cc=support.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.